From e3d0dc0a96ee11f4a1943a3de33207e2ab050487 Mon Sep 17 00:00:00 2001 From: Justin Kotalik Date: Fri, 8 Feb 2019 10:10:38 -0800 Subject: [PATCH] Try re-enabling CancellationToken tests for StreamAdapters (#6755) --- src/Http/Http/test/StreamPipeReaderTests.cs | 4 ++-- src/Http/Http/test/StreamPipeWriterTests.cs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Http/Http/test/StreamPipeReaderTests.cs b/src/Http/Http/test/StreamPipeReaderTests.cs index 8d777110f1..f549adcb5c 100644 --- a/src/Http/Http/test/StreamPipeReaderTests.cs +++ b/src/Http/Http/test/StreamPipeReaderTests.cs @@ -148,7 +148,7 @@ namespace System.IO.Pipelines.Tests Assert.NotEqual(readResult, readResult2); } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] + [Fact] public async Task ReadCanBeCancelledViaProvidedCancellationToken() { var pipeReader = new StreamPipeReader(new HangingStream()); @@ -157,7 +157,7 @@ namespace System.IO.Pipelines.Tests await Assert.ThrowsAsync(async () => await pipeReader.ReadAsync(cts.Token)); } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] + [Fact] public async Task ReadCanBeCanceledViaCancelPendingReadWhenReadIsAsync() { var pipeReader = new StreamPipeReader(new HangingStream()); diff --git a/src/Http/Http/test/StreamPipeWriterTests.cs b/src/Http/Http/test/StreamPipeWriterTests.cs index c2bfce4d1a..4a773cc972 100644 --- a/src/Http/Http/test/StreamPipeWriterTests.cs +++ b/src/Http/Http/test/StreamPipeWriterTests.cs @@ -133,7 +133,7 @@ namespace System.IO.Pipelines.Tests } } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] + [Fact] public async Task CancelPendingFlushBetweenWritesAllDataIsPreserved() { Stream = new SingleWriteStream(); @@ -206,7 +206,7 @@ namespace System.IO.Pipelines.Tests Assert.True(flushResult.IsCanceled); } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/4621")] + [Fact] public async Task CancelPendingFlushLostOfCancellationsNoDataLost() { var writeSize = 16;