huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Break fix: Undo part of 141b637 

- affected test using a test factory for `HttpResponseStreamWriter`s
This commit is contained in:
Doug Bunting 2017-04-23 21:47:30 -07:00
parent 141b637d20
commit cacee2a837
1 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/ViewFeatures/ViewExecutorTest.cs
View File

@ -9,7 +9,6 @@ using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;
using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Abstractions; using Microsoft.AspNetCore.Mvc.Abstractions;
using Microsoft.AspNetCore.Mvc.Internal;
using Microsoft.AspNetCore.Mvc.ModelBinding; using Microsoft.AspNetCore.Mvc.ModelBinding;
using Microsoft.AspNetCore.Mvc.Rendering; using Microsoft.AspNetCore.Mvc.Rendering;
using Microsoft.AspNetCore.Mvc.TestCommon; using Microsoft.AspNetCore.Mvc.TestCommon;
@ -298,21 +297,10 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures
Assert.Equal(expectedLength, memoryStream.Length); Assert.Equal(expectedLength, memoryStream.Length);
} }
public static TheoryData<int> WriteLengthData
{
get
{
return new TheoryData<int>
{
MemoryPoolHttpResponseStreamWriterFactory.DefaultBufferSize - 1,
MemoryPoolHttpResponseStreamWriterFactory.DefaultBufferSize + 1,
2 * MemoryPoolHttpResponseStreamWriterFactory.DefaultBufferSize + 4,
};
}
}
[Theory] [Theory]
[MemberData(nameof(WriteLengthData))] [InlineData(HttpResponseStreamWriter.DefaultBufferSize - 1)]
[InlineData(HttpResponseStreamWriter.DefaultBufferSize + 1)]
[InlineData(2 * HttpResponseStreamWriter.DefaultBufferSize + 4)]
public async Task ExecuteAsync_AsynchronouslyFlushesToTheResponseStream_PriorToDispose(int writeLength) public async Task ExecuteAsync_AsynchronouslyFlushesToTheResponseStream_PriorToDispose(int writeLength)
{ {
// Arrange // Arrange
@ -322,8 +310,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures
await v.Writer.WriteAsync(text); await v.Writer.WriteAsync(text);
}); });
var expectedWriteCallCount = var expectedWriteCallCount = Math.Ceiling((double)writeLength / HttpResponseStreamWriter.DefaultBufferSize);
Math.Ceiling((double)writeLength / MemoryPoolHttpResponseStreamWriterFactory.DefaultBufferSize);
var context = new DefaultHttpContext(); var context = new DefaultHttpContext();
var stream = new Mock<Stream>(); var stream = new Mock<Stream>();