From cacee2a8374def9383130431747abee6565081a3 Mon Sep 17 00:00:00 2001 From: Doug Bunting Date: Sun, 23 Apr 2017 21:47:30 -0700 Subject: [PATCH] Break fix: Undo part of 141b637 - affected test using a test factory for `HttpResponseStreamWriter`s --- .../ViewFeatures/ViewExecutorTest.cs | 21 ++++--------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/ViewFeatures/ViewExecutorTest.cs b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/ViewFeatures/ViewExecutorTest.cs index 88ce632162..e607623625 100644 --- a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/ViewFeatures/ViewExecutorTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/ViewFeatures/ViewExecutorTest.cs @@ -9,7 +9,6 @@ using System.Threading; using System.Threading.Tasks; using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Mvc.Abstractions; -using Microsoft.AspNetCore.Mvc.Internal; using Microsoft.AspNetCore.Mvc.ModelBinding; using Microsoft.AspNetCore.Mvc.Rendering; using Microsoft.AspNetCore.Mvc.TestCommon; @@ -298,21 +297,10 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures Assert.Equal(expectedLength, memoryStream.Length); } - public static TheoryData WriteLengthData - { - get - { - return new TheoryData - { - MemoryPoolHttpResponseStreamWriterFactory.DefaultBufferSize - 1, - MemoryPoolHttpResponseStreamWriterFactory.DefaultBufferSize + 1, - 2 * MemoryPoolHttpResponseStreamWriterFactory.DefaultBufferSize + 4, - }; - } - } - [Theory] - [MemberData(nameof(WriteLengthData))] + [InlineData(HttpResponseStreamWriter.DefaultBufferSize - 1)] + [InlineData(HttpResponseStreamWriter.DefaultBufferSize + 1)] + [InlineData(2 * HttpResponseStreamWriter.DefaultBufferSize + 4)] public async Task ExecuteAsync_AsynchronouslyFlushesToTheResponseStream_PriorToDispose(int writeLength) { // Arrange @@ -322,8 +310,7 @@ namespace Microsoft.AspNetCore.Mvc.ViewFeatures await v.Writer.WriteAsync(text); }); - var expectedWriteCallCount = - Math.Ceiling((double)writeLength / MemoryPoolHttpResponseStreamWriterFactory.DefaultBufferSize); + var expectedWriteCallCount = Math.Ceiling((double)writeLength / HttpResponseStreamWriter.DefaultBufferSize); var context = new DefaultHttpContext(); var stream = new Mock();