huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

React to security API changes

This commit is contained in:
Hao Kung 2015-05-12 15:12:06 -07:00
parent caa8ea44fb
commit b2318bc471
4 changed files with 4 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ActionModelTest.cs
View File

@ -51,7 +51,7 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels
action.Controller = new ControllerModel(typeof(TestController).GetTypeInfo(), action.Controller = new ControllerModel(typeof(TestController).GetTypeInfo(),
new List<object>()); new List<object>());
action.Filters.Add(new AuthorizeFilter(new AuthorizationPolicyBuilder().Build())); action.Filters.Add(new AuthorizeFilter(new AuthorizationPolicyBuilder().RequireClaim("whatever").Build()));
action.HttpMethods.Add("GET"); action.HttpMethods.Add("GET");
action.RouteConstraints.Add(new AreaAttribute("Admin")); action.RouteConstraints.Add(new AreaAttribute("Admin"));
action.Properties.Add(new KeyValuePair<object, object>("test key", "test value")); action.Properties.Add(new KeyValuePair<object, object>("test key", "test value"));

2
test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ControllerModelTest.cs
View File

@ -55,7 +55,7 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels
controller.ActionConstraints.Add(new HttpMethodConstraint(new string[] { "GET" })); controller.ActionConstraints.Add(new HttpMethodConstraint(new string[] { "GET" }));
controller.Application = new ApplicationModel(); controller.Application = new ApplicationModel();
controller.ControllerName = "cool"; controller.ControllerName = "cool";
controller.Filters.Add(new AuthorizeFilter(new AuthorizationPolicyBuilder().Build())); controller.Filters.Add(new AuthorizeFilter(new AuthorizationPolicyBuilder().RequireClaim("whatever").Build()));
controller.RouteConstraints.Add(new AreaAttribute("Admin")); controller.RouteConstraints.Add(new AreaAttribute("Admin"));
controller.Properties.Add(new KeyValuePair<object, object>("test key", "test value")); controller.Properties.Add(new KeyValuePair<object, object>("test key", "test value"));
controller.ControllerProperties.Add( controller.ControllerProperties.Add(

14
test/Microsoft.AspNet.Mvc.Core.Test/Filters/AuthorizeFilterTest.cs
View File

@ -258,20 +258,6 @@ namespace Microsoft.AspNet.Mvc.Test
Assert.NotNull(authorizationContext.Result); Assert.NotNull(authorizationContext.Result);
} }
[Fact]
public async Task Invoke_EmptyPolicyWillFail()
{
// Arrange
var authorizeFilter = new AuthorizeFilter(new AuthorizationPolicyBuilder().Build());
var authorizationContext = GetAuthorizationContext(services => services.AddAuthorization());
// Act
await authorizeFilter.OnAuthorizationAsync(authorizationContext);
// Assert
Assert.NotNull(authorizationContext.Result);
}
private AuthorizationContext GetAuthorizationContext(Action<ServiceCollection> registerServices, bool anonymous = false) private AuthorizationContext GetAuthorizationContext(Action<ServiceCollection> registerServices, bool anonymous = false)
{ {
var basicPrincipal = new ClaimsPrincipal( var basicPrincipal = new ClaimsPrincipal(

4
test/WebSites/FiltersWebSite/Startup.cs
View File

@ -17,8 +17,8 @@ namespace FiltersWebSite
services.AddMvc(); services.AddMvc();
services.ConfigureAuthorization(options => services.ConfigureAuthorization(options =>
{ {
// This policy cannot succeed since it has no requirements // This policy cannot succeed since the claim is never added
options.AddPolicy("Impossible", policy => { }); options.AddPolicy("Impossible", policy => policy.RequireClaim("Never"));
options.AddPolicy("Api", policy => options.AddPolicy("Api", policy =>
{ {
policy.ActiveAuthenticationSchemes.Add("Api"); policy.ActiveAuthenticationSchemes.Add("Api");