diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ActionModelTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ActionModelTest.cs index 5992ac6492..b169eaaba6 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ActionModelTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ActionModelTest.cs @@ -51,7 +51,7 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels action.Controller = new ControllerModel(typeof(TestController).GetTypeInfo(), new List()); - action.Filters.Add(new AuthorizeFilter(new AuthorizationPolicyBuilder().Build())); + action.Filters.Add(new AuthorizeFilter(new AuthorizationPolicyBuilder().RequireClaim("whatever").Build())); action.HttpMethods.Add("GET"); action.RouteConstraints.Add(new AreaAttribute("Admin")); action.Properties.Add(new KeyValuePair("test key", "test value")); diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ControllerModelTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ControllerModelTest.cs index 9b49ab5248..89266a874b 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ControllerModelTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/ApplicationModel/ControllerModelTest.cs @@ -55,7 +55,7 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels controller.ActionConstraints.Add(new HttpMethodConstraint(new string[] { "GET" })); controller.Application = new ApplicationModel(); controller.ControllerName = "cool"; - controller.Filters.Add(new AuthorizeFilter(new AuthorizationPolicyBuilder().Build())); + controller.Filters.Add(new AuthorizeFilter(new AuthorizationPolicyBuilder().RequireClaim("whatever").Build())); controller.RouteConstraints.Add(new AreaAttribute("Admin")); controller.Properties.Add(new KeyValuePair("test key", "test value")); controller.ControllerProperties.Add( diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/Filters/AuthorizeFilterTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/Filters/AuthorizeFilterTest.cs index 5d2d0edc04..f715905576 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/Filters/AuthorizeFilterTest.cs +++ b/test/Microsoft.AspNet.Mvc.Core.Test/Filters/AuthorizeFilterTest.cs @@ -258,20 +258,6 @@ namespace Microsoft.AspNet.Mvc.Test Assert.NotNull(authorizationContext.Result); } - [Fact] - public async Task Invoke_EmptyPolicyWillFail() - { - // Arrange - var authorizeFilter = new AuthorizeFilter(new AuthorizationPolicyBuilder().Build()); - var authorizationContext = GetAuthorizationContext(services => services.AddAuthorization()); - - // Act - await authorizeFilter.OnAuthorizationAsync(authorizationContext); - - // Assert - Assert.NotNull(authorizationContext.Result); - } - private AuthorizationContext GetAuthorizationContext(Action registerServices, bool anonymous = false) { var basicPrincipal = new ClaimsPrincipal( diff --git a/test/WebSites/FiltersWebSite/Startup.cs b/test/WebSites/FiltersWebSite/Startup.cs index d5b8c371fc..c425ecbfa7 100644 --- a/test/WebSites/FiltersWebSite/Startup.cs +++ b/test/WebSites/FiltersWebSite/Startup.cs @@ -17,8 +17,8 @@ namespace FiltersWebSite services.AddMvc(); services.ConfigureAuthorization(options => { - // This policy cannot succeed since it has no requirements - options.AddPolicy("Impossible", policy => { }); + // This policy cannot succeed since the claim is never added + options.AddPolicy("Impossible", policy => policy.RequireClaim("Never")); options.AddPolicy("Api", policy => { policy.ActiveAuthenticationSchemes.Add("Api");