huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix #602 - improve the error message when a shipping package has an undefined external dependency

This commit is contained in:
Nate McMaster 2017-11-03 15:43:10 -07:00
parent 3728bb27e6
commit a64b36c484
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
build/tasks/VerifyCoherentVersions.cs
View File

@ -113,7 +113,9 @@ namespace RepoTasks
} }
else if (!packageLookup.TryGetValue(dependency.Id, out dependencyPackageInfo)) else if (!packageLookup.TryGetValue(dependency.Id, out dependencyPackageInfo))
{ {
Log.LogError($"Package {packageInfo.Id} has an undefined external dependency on {dependency.Id}/{depVersion}"); Log.LogError($"Package {packageInfo.Id} has an undefined external dependency on {dependency.Id}/{depVersion}. " +
"If the package is built in aspnet/Universe, make sure it is also marked as 'ship'. " +
"If it is an external dependency, add it as a new ExternalDependency.");
continue; continue;
} }
@ -123,7 +125,7 @@ namespace RepoTasks
// Add a mismatch if the min version doesn't work out // Add a mismatch if the min version doesn't work out
// (we only really care about >= minVersion) // (we only really care about >= minVersion)
Log.LogError($"{packageInfo.Id} depends on {dependency.Id} " + Log.LogError($"{packageInfo.Id} depends on {dependency.Id} " +
$"{dependency.VersionRange} ({dependencySet.TargetFramework}) when the latest build is {depVersion}."); $"{dependency.VersionRange} ({dependencySet.TargetFramework}) when the latest build is {dependencyPackageInfo.Version}.");
} }
} }
} }