From a64b36c484c3066b9bca1d50393915cede63c33f Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Fri, 3 Nov 2017 15:43:10 -0700 Subject: [PATCH] Fix #602 - improve the error message when a shipping package has an undefined external dependency --- build/tasks/VerifyCoherentVersions.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/build/tasks/VerifyCoherentVersions.cs b/build/tasks/VerifyCoherentVersions.cs index f0e92a7d47..e6800f03c8 100644 --- a/build/tasks/VerifyCoherentVersions.cs +++ b/build/tasks/VerifyCoherentVersions.cs @@ -113,7 +113,9 @@ namespace RepoTasks } else if (!packageLookup.TryGetValue(dependency.Id, out dependencyPackageInfo)) { - Log.LogError($"Package {packageInfo.Id} has an undefined external dependency on {dependency.Id}/{depVersion}"); + Log.LogError($"Package {packageInfo.Id} has an undefined external dependency on {dependency.Id}/{depVersion}. " + + "If the package is built in aspnet/Universe, make sure it is also marked as 'ship'. " + + "If it is an external dependency, add it as a new ExternalDependency."); continue; } @@ -123,7 +125,7 @@ namespace RepoTasks // Add a mismatch if the min version doesn't work out // (we only really care about >= minVersion) Log.LogError($"{packageInfo.Id} depends on {dependency.Id} " + - $"{dependency.VersionRange} ({dependencySet.TargetFramework}) when the latest build is {depVersion}."); + $"{dependency.VersionRange} ({dependencySet.TargetFramework}) when the latest build is {dependencyPackageInfo.Version}."); } } }