huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Skip flaky Components test on Helix (#7488)

This commit is contained in:
Hao Kung 2019-02-12 21:15:28 -08:00 committed by GitHub
parent 1c6651a1ae
commit 9ab72f6202
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Components/Components/test/Microsoft.AspNetCore.Components.Tests.csproj
View File

@ -12,6 +12,7 @@
<ItemGroup> <ItemGroup>
<Compile Include="$(ComponentsSharedSourceRoot)test\**\*.cs" LinkBase="Helpers" /> <Compile Include="$(ComponentsSharedSourceRoot)test\**\*.cs" LinkBase="Helpers" />
<Compile Include="$(SharedSourceRoot)test\SkipOnHelixAttribute.cs" />
</ItemGroup> </ItemGroup>
</Project> </Project>

4
src/Components/Components/test/RendererTest.cs
View File

@ -10,6 +10,7 @@ using System.Threading.Tasks;
using Microsoft.AspNetCore.Components.Rendering; using Microsoft.AspNetCore.Components.Rendering;
using Microsoft.AspNetCore.Components.RenderTree; using Microsoft.AspNetCore.Components.RenderTree;
using Microsoft.AspNetCore.Components.Test.Helpers; using Microsoft.AspNetCore.Components.Test.Helpers;
using Microsoft.AspNetCore.Testing.xunit;
using Xunit; using Xunit;
namespace Microsoft.AspNetCore.Components.Test namespace Microsoft.AspNetCore.Components.Test
@ -1301,7 +1302,8 @@ namespace Microsoft.AspNetCore.Components.Test
Assert.Equal(1, childComponents[2].OnAfterRenderCallCount); // Disposed Assert.Equal(1, childComponents[2].OnAfterRenderCallCount); // Disposed
} }
[Fact] [ConditionalFact]
[SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7487
public async Task CanTriggerEventHandlerDisposedInEarlierPendingBatchAsync() public async Task CanTriggerEventHandlerDisposedInEarlierPendingBatchAsync()
{ {
// This represents the scenario where the same event handler is being triggered // This represents the scenario where the same event handler is being triggered