From 9ab72f6202335ed513e0cbe84a968907e29aca99 Mon Sep 17 00:00:00 2001 From: Hao Kung Date: Tue, 12 Feb 2019 21:15:28 -0800 Subject: [PATCH] Skip flaky Components test on Helix (#7488) --- .../test/Microsoft.AspNetCore.Components.Tests.csproj | 1 + src/Components/Components/test/RendererTest.cs | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Components/Components/test/Microsoft.AspNetCore.Components.Tests.csproj b/src/Components/Components/test/Microsoft.AspNetCore.Components.Tests.csproj index 66cea32194..a18f393d83 100644 --- a/src/Components/Components/test/Microsoft.AspNetCore.Components.Tests.csproj +++ b/src/Components/Components/test/Microsoft.AspNetCore.Components.Tests.csproj @@ -12,6 +12,7 @@ + diff --git a/src/Components/Components/test/RendererTest.cs b/src/Components/Components/test/RendererTest.cs index f63600ad27..8e51132278 100644 --- a/src/Components/Components/test/RendererTest.cs +++ b/src/Components/Components/test/RendererTest.cs @@ -10,6 +10,7 @@ using System.Threading.Tasks; using Microsoft.AspNetCore.Components.Rendering; using Microsoft.AspNetCore.Components.RenderTree; using Microsoft.AspNetCore.Components.Test.Helpers; +using Microsoft.AspNetCore.Testing.xunit; using Xunit; namespace Microsoft.AspNetCore.Components.Test @@ -1301,7 +1302,8 @@ namespace Microsoft.AspNetCore.Components.Test Assert.Equal(1, childComponents[2].OnAfterRenderCallCount); // Disposed } - [Fact] + [ConditionalFact] + [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/7487 public async Task CanTriggerEventHandlerDisposedInEarlierPendingBatchAsync() { // This represents the scenario where the same event handler is being triggered