Handle line ending differences in a few tests
- #6205 - combine `TagHelpers_SupportsPathNavigation()` and `TagHelpers_SupportsRelativeNavigation()` into one nit: remove a few unnecessary `.Trim()` calls
This commit is contained in:
parent
e6c716444d
commit
6b2a702ff4
|
|
@ -40,8 +40,6 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
|
||||||
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
|
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
|
||||||
Assert.Equal(expectedMediaType, response.Content.Headers.ContentType);
|
Assert.Equal(expectedMediaType, response.Content.Headers.ContentType);
|
||||||
|
|
||||||
responseContent = responseContent.Trim();
|
|
||||||
|
|
||||||
var forgeryToken = AntiforgeryTestHelper.RetrieveAntiforgeryToken(responseContent, "SimpleForms");
|
var forgeryToken = AntiforgeryTestHelper.RetrieveAntiforgeryToken(responseContent, "SimpleForms");
|
||||||
#if GENERATE_BASELINES
|
#if GENERATE_BASELINES
|
||||||
// Reverse usual substitution and insert a format item into the new file content.
|
// Reverse usual substitution and insert a format item into the new file content.
|
||||||
|
|
@ -49,7 +47,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
|
||||||
ResourceFile.UpdateFile(_resourcesAssembly, outputFile, expectedContent, responseContent);
|
ResourceFile.UpdateFile(_resourcesAssembly, outputFile, expectedContent, responseContent);
|
||||||
#else
|
#else
|
||||||
expectedContent = string.Format(expectedContent, forgeryToken);
|
expectedContent = string.Format(expectedContent, forgeryToken);
|
||||||
Assert.Equal(expectedContent.Trim(), responseContent, ignoreLineEndingDifferences: true);
|
Assert.Equal(expectedContent, responseContent.Trim(), ignoreLineEndingDifferences: true);
|
||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -577,13 +575,14 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
|
||||||
{
|
{
|
||||||
// Test for https://github.com/aspnet/Mvc/issues/5915
|
// Test for https://github.com/aspnet/Mvc/issues/5915
|
||||||
//Arrange
|
//Arrange
|
||||||
var expected = $"Hello from _ViewStart{Environment.NewLine}Hello from /Pages/WithViewStart/Index.cshtml!";
|
var expected = @"Hello from _ViewStart
|
||||||
|
Hello from /Pages/WithViewStart/Index.cshtml!";
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
var response = await Client.GetStringAsync("/Pages/WithViewStart");
|
var response = await Client.GetStringAsync("/Pages/WithViewStart");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.Equal(expected, response.Trim());
|
Assert.Equal(expected, response, ignoreLineEndingDifferences: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
|
|
@ -791,7 +790,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP
|
||||||
var response = await Client.GetStringAsync("InjectedPageProperties");
|
var response = await Client.GetStringAsync("InjectedPageProperties");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.Equal(expected, response.Trim());
|
Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
|
|
@ -968,7 +967,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP
|
||||||
{
|
{
|
||||||
// Arrange
|
// Arrange
|
||||||
var expected =
|
var expected =
|
||||||
@"<form method=""post"" action=""/Pages/TagHelper/CrossPost""></form>
|
@"<form method=""post"" action=""/Pages/TagHelper/CrossPost""></form>
|
||||||
<a href=""/Pages/TagHelper/SelfPost/12"" />
|
<a href=""/Pages/TagHelper/SelfPost/12"" />
|
||||||
<input type=""image"" formaction=""/Pages/TagHelper/CrossPost#my-fragment"" />";
|
<input type=""image"" formaction=""/Pages/TagHelper/CrossPost#my-fragment"" />";
|
||||||
|
|
||||||
|
|
@ -976,7 +975,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP
|
||||||
var response = await Client.GetStringAsync("/Pages/TagHelper/SiblingLinks");
|
var response = await Client.GetStringAsync("/Pages/TagHelper/SiblingLinks");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.Equal(expected, response.Trim());
|
Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
|
|
@ -984,7 +983,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP
|
||||||
{
|
{
|
||||||
// Arrange
|
// Arrange
|
||||||
var expected =
|
var expected =
|
||||||
@"<form method=""post"" action=""/Pages/TagHelper/SubDir/SubDirPage""></form>
|
@"<form method=""post"" action=""/Pages/TagHelper/SubDir/SubDirPage""></form>
|
||||||
<a href=""/Pages/TagHelper/SubDir/SubDirPage/12"" />
|
<a href=""/Pages/TagHelper/SubDir/SubDirPage/12"" />
|
||||||
<input type=""image"" formaction=""/Pages/TagHelper/SubDir/SubDirPage#my-fragment"" />";
|
<input type=""image"" formaction=""/Pages/TagHelper/SubDir/SubDirPage#my-fragment"" />";
|
||||||
|
|
||||||
|
|
@ -992,7 +991,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP
|
||||||
var response = await Client.GetStringAsync("/Pages/TagHelper/SubDirectoryLinks");
|
var response = await Client.GetStringAsync("/Pages/TagHelper/SubDirectoryLinks");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.Equal(expected, response.Trim());
|
Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
|
|
@ -1000,7 +999,8 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP
|
||||||
{
|
{
|
||||||
// Arrange
|
// Arrange
|
||||||
var expected =
|
var expected =
|
||||||
@"<form method=""post"" action=""/HelloWorld""></form>
|
@"<form method=""post"" action=""/Pages/TagHelper/SubDirectoryLinks""></form>
|
||||||
|
<form method=""post"" action=""/HelloWorld""></form>
|
||||||
<a href=""/Pages/Redirects/RedirectToIndex"" />
|
<a href=""/Pages/Redirects/RedirectToIndex"" />
|
||||||
<input type=""image"" formaction=""/Pages/Admin#my-fragment"" />";
|
<input type=""image"" formaction=""/Pages/Admin#my-fragment"" />";
|
||||||
|
|
||||||
|
|
@ -1008,20 +1008,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP
|
||||||
var response = await Client.GetStringAsync("/Pages/TagHelper/PathTraversalLinks");
|
var response = await Client.GetStringAsync("/Pages/TagHelper/PathTraversalLinks");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.EndsWith(expected, response.Trim());
|
Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true);
|
||||||
}
|
|
||||||
|
|
||||||
[Fact]
|
|
||||||
public async Task TagHelpers_SupportsRelativeNavigation()
|
|
||||||
{
|
|
||||||
// Arrange
|
|
||||||
var expected = @"<form method=""post"" action=""/Pages/TagHelper/SubDirectoryLinks""></form>";
|
|
||||||
|
|
||||||
// Act
|
|
||||||
var response = await Client.GetStringAsync("/Pages/TagHelper/PathTraversalLinks");
|
|
||||||
|
|
||||||
// Assert
|
|
||||||
Assert.StartsWith(expected, response.Trim());
|
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
|
|
|
||||||
|
|
@ -1,7 +1,6 @@
|
||||||
// Copyright (c) .NET Foundation. All rights reserved.
|
// Copyright (c) .NET Foundation. All rights reserved.
|
||||||
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
|
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
|
||||||
|
|
||||||
using System;
|
|
||||||
using System.Net;
|
using System.Net;
|
||||||
using System.Net.Http;
|
using System.Net.Http;
|
||||||
using System.Threading.Tasks;
|
using System.Threading.Tasks;
|
||||||
|
|
@ -130,27 +129,29 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
|
||||||
{
|
{
|
||||||
// Test for https://github.com/aspnet/Mvc/issues/5915
|
// Test for https://github.com/aspnet/Mvc/issues/5915
|
||||||
//Arrange
|
//Arrange
|
||||||
var expected = $"Hello from _ViewStart{Environment.NewLine}Hello from /Pages/WithViewStart/Index.cshtml!";
|
var expected = @"Hello from _ViewStart
|
||||||
|
Hello from /Pages/WithViewStart/Index.cshtml!";
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
var response = await Client.GetStringAsync("/WithViewStart");
|
var response = await Client.GetStringAsync("/WithViewStart");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.Equal(expected, response.Trim());
|
Assert.Equal(expected, response, ignoreLineEndingDifferences: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public async Task ViewStart_IsDiscoveredForFilesOutsidePageRoot()
|
public async Task ViewStart_IsDiscoveredForFilesOutsidePageRoot()
|
||||||
{
|
{
|
||||||
//Arrange
|
//Arrange
|
||||||
var newLine = Environment.NewLine;
|
var expected = @"Hello from _ViewStart at root
|
||||||
var expected = $"Hello from _ViewStart at root{newLine}Hello from _ViewStart{newLine}Hello from page";
|
Hello from _ViewStart
|
||||||
|
Hello from page";
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
var response = await Client.GetStringAsync("/WithViewStart/ViewStartAtRoot");
|
var response = await Client.GetStringAsync("/WithViewStart/ViewStartAtRoot");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.Equal(expected, response.Trim());
|
Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
|
|
@ -212,14 +213,14 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
|
||||||
var response = await Client.GetStringAsync("/TagHelper/CrossPost");
|
var response = await Client.GetStringAsync("/TagHelper/CrossPost");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.Equal(expected, response.Trim());
|
Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public async Task FormActionTagHelper_WithPage_AllowsPostingToAnotherPage()
|
public async Task FormActionTagHelper_WithPage_AllowsPostingToAnotherPage()
|
||||||
{
|
{
|
||||||
//Arrange
|
//Arrange
|
||||||
var expected =
|
var expected =
|
||||||
@"<button formaction=""/TagHelper/CrossPost/10"" />
|
@"<button formaction=""/TagHelper/CrossPost/10"" />
|
||||||
<input type=""submit"" formaction=""/TagHelper/CrossPost/10"" />
|
<input type=""submit"" formaction=""/TagHelper/CrossPost/10"" />
|
||||||
<input type=""image"" formaction=""/TagHelper/CrossPost/10"" />
|
<input type=""image"" formaction=""/TagHelper/CrossPost/10"" />
|
||||||
|
|
@ -231,7 +232,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
|
||||||
var response = await Client.GetStringAsync("/TagHelper/FormAction");
|
var response = await Client.GetStringAsync("/TagHelper/FormAction");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.Equal(expected, response.Trim());
|
Assert.Equal(expected, response, ignoreLineEndingDifferences: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
|
|
|
||||||
|
|
@ -489,7 +489,7 @@ Partial that does not specify Layout
|
||||||
public async Task ViewEngine_NormalizesPathsReturnedByViewLocationExpanders()
|
public async Task ViewEngine_NormalizesPathsReturnedByViewLocationExpanders()
|
||||||
{
|
{
|
||||||
// Arrange
|
// Arrange
|
||||||
var expected =
|
var expected =
|
||||||
@"Layout
|
@"Layout
|
||||||
Page
|
Page
|
||||||
Partial";
|
Partial";
|
||||||
|
|
@ -498,7 +498,7 @@ Partial";
|
||||||
var responseContent = await Client.GetStringAsync("/BackSlash");
|
var responseContent = await Client.GetStringAsync("/BackSlash");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.Equal(expected, responseContent.Trim());
|
Assert.Equal(expected, responseContent, ignoreLineEndingDifferences: true);
|
||||||
}
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue