diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RazorPagesTest.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RazorPagesTest.cs index eac69b9e36..4731e2a323 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RazorPagesTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RazorPagesTest.cs @@ -40,8 +40,6 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests Assert.Equal(HttpStatusCode.OK, response.StatusCode); Assert.Equal(expectedMediaType, response.Content.Headers.ContentType); - responseContent = responseContent.Trim(); - var forgeryToken = AntiforgeryTestHelper.RetrieveAntiforgeryToken(responseContent, "SimpleForms"); #if GENERATE_BASELINES // Reverse usual substitution and insert a format item into the new file content. @@ -49,7 +47,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests ResourceFile.UpdateFile(_resourcesAssembly, outputFile, expectedContent, responseContent); #else expectedContent = string.Format(expectedContent, forgeryToken); - Assert.Equal(expectedContent.Trim(), responseContent, ignoreLineEndingDifferences: true); + Assert.Equal(expectedContent, responseContent.Trim(), ignoreLineEndingDifferences: true); #endif } @@ -577,13 +575,14 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests { // Test for https://github.com/aspnet/Mvc/issues/5915 //Arrange - var expected = $"Hello from _ViewStart{Environment.NewLine}Hello from /Pages/WithViewStart/Index.cshtml!"; + var expected = @"Hello from _ViewStart +Hello from /Pages/WithViewStart/Index.cshtml!"; // Act var response = await Client.GetStringAsync("/Pages/WithViewStart"); // Assert - Assert.Equal(expected, response.Trim()); + Assert.Equal(expected, response, ignoreLineEndingDifferences: true); } [Fact] @@ -791,7 +790,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP var response = await Client.GetStringAsync("InjectedPageProperties"); // Assert - Assert.Equal(expected, response.Trim()); + Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true); } [Fact] @@ -968,7 +967,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP { // Arrange var expected = - @"
+@" "; @@ -976,7 +975,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP var response = await Client.GetStringAsync("/Pages/TagHelper/SiblingLinks"); // Assert - Assert.Equal(expected, response.Trim()); + Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true); } [Fact] @@ -984,7 +983,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP { // Arrange var expected = - @" +@" "; @@ -992,7 +991,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP var response = await Client.GetStringAsync("/Pages/TagHelper/SubDirectoryLinks"); // Assert - Assert.Equal(expected, response.Trim()); + Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true); } [Fact] @@ -1000,7 +999,8 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP { // Arrange var expected = - @" +@" + "; @@ -1008,20 +1008,7 @@ Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary`1[AspNetCore._InjectedP var response = await Client.GetStringAsync("/Pages/TagHelper/PathTraversalLinks"); // Assert - Assert.EndsWith(expected, response.Trim()); - } - - [Fact] - public async Task TagHelpers_SupportsRelativeNavigation() - { - // Arrange - var expected = @""; - - // Act - var response = await Client.GetStringAsync("/Pages/TagHelper/PathTraversalLinks"); - - // Assert - Assert.StartsWith(expected, response.Trim()); + Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true); } [Fact] diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RazorPagesWithBasePathTest.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RazorPagesWithBasePathTest.cs index cc17c5d784..8af3c4c609 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RazorPagesWithBasePathTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RazorPagesWithBasePathTest.cs @@ -1,7 +1,6 @@ // Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. -using System; using System.Net; using System.Net.Http; using System.Threading.Tasks; @@ -130,27 +129,29 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests { // Test for https://github.com/aspnet/Mvc/issues/5915 //Arrange - var expected = $"Hello from _ViewStart{Environment.NewLine}Hello from /Pages/WithViewStart/Index.cshtml!"; + var expected = @"Hello from _ViewStart +Hello from /Pages/WithViewStart/Index.cshtml!"; // Act var response = await Client.GetStringAsync("/WithViewStart"); // Assert - Assert.Equal(expected, response.Trim()); + Assert.Equal(expected, response, ignoreLineEndingDifferences: true); } [Fact] public async Task ViewStart_IsDiscoveredForFilesOutsidePageRoot() { //Arrange - var newLine = Environment.NewLine; - var expected = $"Hello from _ViewStart at root{newLine}Hello from _ViewStart{newLine}Hello from page"; + var expected = @"Hello from _ViewStart at root +Hello from _ViewStart +Hello from page"; // Act var response = await Client.GetStringAsync("/WithViewStart/ViewStartAtRoot"); // Assert - Assert.Equal(expected, response.Trim()); + Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true); } [Fact] @@ -212,14 +213,14 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests var response = await Client.GetStringAsync("/TagHelper/CrossPost"); // Assert - Assert.Equal(expected, response.Trim()); + Assert.Equal(expected, response.Trim(), ignoreLineEndingDifferences: true); } [Fact] public async Task FormActionTagHelper_WithPage_AllowsPostingToAnotherPage() { //Arrange - var expected = + var expected = @" @@ -231,7 +232,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests var response = await Client.GetStringAsync("/TagHelper/FormAction"); // Assert - Assert.Equal(expected, response.Trim()); + Assert.Equal(expected, response, ignoreLineEndingDifferences: true); } [Fact] diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ViewEngineTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ViewEngineTests.cs index 8149c3bd12..ab6c1f9620 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ViewEngineTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ViewEngineTests.cs @@ -489,7 +489,7 @@ Partial that does not specify Layout public async Task ViewEngine_NormalizesPathsReturnedByViewLocationExpanders() { // Arrange - var expected = + var expected = @"Layout Page Partial"; @@ -498,7 +498,7 @@ Partial"; var responseContent = await Client.GetStringAsync("/BackSlash"); // Assert - Assert.Equal(expected, responseContent.Trim()); + Assert.Equal(expected, responseContent, ignoreLineEndingDifferences: true); } [Fact]