huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Lift local function to class function to workaround issue in xunit.analyzers and roslyn

This commit is contained in:
Nate McMaster 2017-08-31 13:42:44 -07:00
parent 7dcbf25069
commit 5b767e05b4
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs
View File

@ -97,12 +97,9 @@ namespace Microsoft.AspNetCore.SignalR.Tests
} }
} }
// Suppress this warning to workaround https://github.com/xunit/xunit/issues/1424
#pragma warning disable xUnit1026
[Theory] [Theory]
[MemberData(nameof(TransportTypesAndTransferModes))] [MemberData(nameof(TransportTypesAndTransferModes))]
public async Task ConnectionCanSendAndReceiveMessages(TransportType transportType, TransferMode requestedTransferMode) public async Task ConnectionCanSendAndReceiveMessages(TransportType transportType, TransferMode requestedTransferMode)
#pragma warning restore xUnit1026
{ {
using (StartLog(out var loggerFactory, testName: $"ConnectionCanSendAndReceiveMessages_{transportType.ToString()}")) using (StartLog(out var loggerFactory, testName: $"ConnectionCanSendAndReceiveMessages_{transportType.ToString()}"))
{ {
@ -182,11 +179,12 @@ namespace Microsoft.AspNetCore.SignalR.Tests
} }
} }
bool IsBase64Encoded(TransferMode transferMode, IConnection connection) }
{
return requestedTransferMode == TransferMode.Binary && private bool IsBase64Encoded(TransferMode transferMode, IConnection connection)
connection.Features.Get<ITransferModeFeature>().TransferMode == TransferMode.Text; {
} return transferMode == TransferMode.Binary &&
connection.Features.Get<ITransferModeFeature>().TransferMode == TransferMode.Text;
} }
public static IEnumerable<object[]> MessageSizesData public static IEnumerable<object[]> MessageSizesData