From 5b767e05b4caf8bee96d11b51ef7b68bdd71a697 Mon Sep 17 00:00:00 2001
From: Nate McMaster <nate.mcmaster@microsoft.com>
Date: Thu, 31 Aug 2017 13:42:44 -0700
Subject: [PATCH] Lift local function to class function to workaround issue in
 xunit.analyzers and roslyn

---
 .../EndToEndTests.cs                               | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs b/test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs
index 4779eb3d0f..2024780854 100644
--- a/test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs
+++ b/test/Microsoft.AspNetCore.SignalR.Tests/EndToEndTests.cs
@@ -97,12 +97,9 @@ namespace Microsoft.AspNetCore.SignalR.Tests
             }
         }
 
-// Suppress this warning to workaround https://github.com/xunit/xunit/issues/1424
-#pragma warning disable xUnit1026
         [Theory]
         [MemberData(nameof(TransportTypesAndTransferModes))]
         public async Task ConnectionCanSendAndReceiveMessages(TransportType transportType, TransferMode requestedTransferMode)
-#pragma warning restore xUnit1026
         {
             using (StartLog(out var loggerFactory, testName: $"ConnectionCanSendAndReceiveMessages_{transportType.ToString()}"))
             {
@@ -182,11 +179,12 @@ namespace Microsoft.AspNetCore.SignalR.Tests
                 }
             }
 
-            bool IsBase64Encoded(TransferMode transferMode, IConnection connection)
-            {
-                return requestedTransferMode == TransferMode.Binary &&
-                    connection.Features.Get<ITransferModeFeature>().TransferMode == TransferMode.Text;
-            }
+        }
+
+        private bool IsBase64Encoded(TransferMode transferMode, IConnection connection)
+        {
+            return transferMode == TransferMode.Binary &&
+                connection.Features.Get<ITransferModeFeature>().TransferMode == TransferMode.Text;
         }
 
         public static IEnumerable<object[]> MessageSizesData