huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Change Hub and friends to abstract (#2108)

This commit is contained in:
James Newton-King 2018-04-20 20:53:01 +12:00 committed by GitHub
parent 21b41a8376
commit 5516a969e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Microsoft.AspNetCore.SignalR.Core/DynamicHub.cs
View File

@ -3,7 +3,7 @@
namespace Microsoft.AspNetCore.SignalR namespace Microsoft.AspNetCore.SignalR
{ {
public class DynamicHub : Hub public abstract class DynamicHub : Hub
{ {
private DynamicHubClients _clients; private DynamicHubClients _clients;

2
src/Microsoft.AspNetCore.SignalR.Core/Hub.cs
View File

@ -6,7 +6,7 @@ using System.Threading.Tasks;
namespace Microsoft.AspNetCore.SignalR namespace Microsoft.AspNetCore.SignalR
{ {
public class Hub : IDisposable public abstract class Hub : IDisposable
{ {
private bool _disposed; private bool _disposed;
private IHubCallerClients _clients; private IHubCallerClients _clients;

2
src/Microsoft.AspNetCore.SignalR.Core/Hub`T.cs
View File

@ -5,7 +5,7 @@ using Microsoft.AspNetCore.SignalR.Internal;
namespace Microsoft.AspNetCore.SignalR namespace Microsoft.AspNetCore.SignalR
{ {
public class Hub<T> : Hub where T : class public abstract class Hub<T> : Hub where T : class
{ {
private IHubCallerClients<T> _clients; private IHubCallerClients<T> _clients;

6
test/Microsoft.AspNetCore.SignalR.Tests/DefaultHubActivatorTests.cs
View File

@ -11,11 +11,15 @@ namespace Microsoft.AspNetCore.SignalR.Tests
{ {
public class DefaultHubActivatorTests public class DefaultHubActivatorTests
{ {
public class CreatableHub : Hub
{
}
[Fact] [Fact]
public void HubCreatedIfNotResolvedFromServiceProvider() public void HubCreatedIfNotResolvedFromServiceProvider()
{ {
Assert.NotNull( Assert.NotNull(
new DefaultHubActivator<Hub>(Mock.Of<IServiceProvider>()).Create()); new DefaultHubActivator<CreatableHub>(Mock.Of<IServiceProvider>()).Create());
} }
[Fact] [Fact]