diff --git a/src/Microsoft.AspNetCore.SignalR.Core/DynamicHub.cs b/src/Microsoft.AspNetCore.SignalR.Core/DynamicHub.cs index 8571b1f3ad..f37460cacd 100644 --- a/src/Microsoft.AspNetCore.SignalR.Core/DynamicHub.cs +++ b/src/Microsoft.AspNetCore.SignalR.Core/DynamicHub.cs @@ -3,7 +3,7 @@ namespace Microsoft.AspNetCore.SignalR { - public class DynamicHub : Hub + public abstract class DynamicHub : Hub { private DynamicHubClients _clients; diff --git a/src/Microsoft.AspNetCore.SignalR.Core/Hub.cs b/src/Microsoft.AspNetCore.SignalR.Core/Hub.cs index 7075660886..63a36fe92a 100644 --- a/src/Microsoft.AspNetCore.SignalR.Core/Hub.cs +++ b/src/Microsoft.AspNetCore.SignalR.Core/Hub.cs @@ -6,7 +6,7 @@ using System.Threading.Tasks; namespace Microsoft.AspNetCore.SignalR { - public class Hub : IDisposable + public abstract class Hub : IDisposable { private bool _disposed; private IHubCallerClients _clients; diff --git a/src/Microsoft.AspNetCore.SignalR.Core/Hub`T.cs b/src/Microsoft.AspNetCore.SignalR.Core/Hub`T.cs index 8bce9b3507..5463b7c35e 100644 --- a/src/Microsoft.AspNetCore.SignalR.Core/Hub`T.cs +++ b/src/Microsoft.AspNetCore.SignalR.Core/Hub`T.cs @@ -5,7 +5,7 @@ using Microsoft.AspNetCore.SignalR.Internal; namespace Microsoft.AspNetCore.SignalR { - public class Hub : Hub where T : class + public abstract class Hub : Hub where T : class { private IHubCallerClients _clients; diff --git a/test/Microsoft.AspNetCore.SignalR.Tests/DefaultHubActivatorTests.cs b/test/Microsoft.AspNetCore.SignalR.Tests/DefaultHubActivatorTests.cs index dd75dd3d51..5584031e35 100644 --- a/test/Microsoft.AspNetCore.SignalR.Tests/DefaultHubActivatorTests.cs +++ b/test/Microsoft.AspNetCore.SignalR.Tests/DefaultHubActivatorTests.cs @@ -11,11 +11,15 @@ namespace Microsoft.AspNetCore.SignalR.Tests { public class DefaultHubActivatorTests { + public class CreatableHub : Hub + { + } + [Fact] public void HubCreatedIfNotResolvedFromServiceProvider() { Assert.NotNull( - new DefaultHubActivator(Mock.Of()).Create()); + new DefaultHubActivator(Mock.Of()).Create()); } [Fact]