huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Rename TagHelperContent.Append(IHtmlContent` overload to be `TagHelperContent.AppendHtml(IHtmlContent)` 

Fixes #634
This commit is contained in:
Pranav K 2015-12-31 11:26:21 -08:00
parent e1aa888165
commit 37eca627dd
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Microsoft.AspNet.Razor.Runtime/TagHelpers/DefaultTagHelperContent.cs
View File

@ -142,7 +142,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers
} }
/// <inheritdoc /> /// <inheritdoc />
public override TagHelperContent Append(IHtmlContent htmlContent) public override TagHelperContent AppendHtml(IHtmlContent htmlContent)
{ {
Buffer.Add(htmlContent); Buffer.Add(htmlContent);
return this; return this;

6
src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperContent.cs
View File

@ -79,7 +79,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers
/// </summary> /// </summary>
/// <param name="htmlContent">The <see cref="IHtmlContent"/> to be appended.</param> /// <param name="htmlContent">The <see cref="IHtmlContent"/> to be appended.</param>
/// <returns>A reference to this instance after the append operation has completed.</returns> /// <returns>A reference to this instance after the append operation has completed.</returns>
public abstract TagHelperContent Append(IHtmlContent htmlContent); public abstract TagHelperContent AppendHtml(IHtmlContent htmlContent);
/// <summary> /// <summary>
/// Appends <paramref name="encoded"/> to the existing content. <paramref name="encoded"/> is assumed /// Appends <paramref name="encoded"/> to the existing content. <paramref name="encoded"/> is assumed
@ -145,9 +145,9 @@ namespace Microsoft.AspNet.Razor.TagHelpers
public abstract void WriteTo(TextWriter writer, HtmlEncoder encoder); public abstract void WriteTo(TextWriter writer, HtmlEncoder encoder);
/// <inheritdoc /> /// <inheritdoc />
IHtmlContentBuilder IHtmlContentBuilder.Append(IHtmlContent content) IHtmlContentBuilder IHtmlContentBuilder.AppendHtml(IHtmlContent content)
{ {
return Append(content); return AppendHtml(content);
} }
/// <inheritdoc /> /// <inheritdoc />

8
test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/DefaultTagHelperContentTest.cs
View File

@ -179,7 +179,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers
tagHelperContent.Append(text2); tagHelperContent.Append(text2);
// Act // Act
copiedTagHelperContent.Append(tagHelperContent); copiedTagHelperContent.AppendHtml(tagHelperContent);
// Assert // Assert
Assert.Equal(expected, copiedTagHelperContent.GetContent(new HtmlTestEncoder())); Assert.Equal(expected, copiedTagHelperContent.GetContent(new HtmlTestEncoder()));
@ -233,7 +233,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers
TagHelperContent NullContent = null; TagHelperContent NullContent = null;
// Act // Act
tagHelperContent.Append(NullContent); tagHelperContent.AppendHtml(NullContent);
// Assert // Assert
Assert.True(tagHelperContent.IsModified); Assert.True(tagHelperContent.IsModified);
@ -317,7 +317,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers
var copiedTagHelperContent = new DefaultTagHelperContent(); var copiedTagHelperContent = new DefaultTagHelperContent();
// Act // Act
tagHelperContent.Append(copiedTagHelperContent); tagHelperContent.AppendHtml(copiedTagHelperContent);
tagHelperContent.Append(string.Empty); tagHelperContent.Append(string.Empty);
// Assert // Assert
@ -372,7 +372,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers
copiedTagHelperContent.SetContent("Hello"); copiedTagHelperContent.SetContent("Hello");
// Act // Act
tagHelperContent.Append(copiedTagHelperContent); tagHelperContent.AppendHtml(copiedTagHelperContent);
// Assert // Assert
Assert.False(tagHelperContent.IsEmpty); Assert.False(tagHelperContent.IsEmpty);