From 37eca627dd59604cfb68a19ddf10e96e1ab20ece Mon Sep 17 00:00:00 2001 From: Pranav K Date: Thu, 31 Dec 2015 11:26:21 -0800 Subject: [PATCH] Rename TagHelperContent.Append(IHtmlContent` overload to be `TagHelperContent.AppendHtml(IHtmlContent)` Fixes #634 --- .../TagHelpers/DefaultTagHelperContent.cs | 2 +- .../TagHelpers/TagHelperContent.cs | 6 +++--- .../TagHelpers/DefaultTagHelperContentTest.cs | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/DefaultTagHelperContent.cs b/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/DefaultTagHelperContent.cs index 9846df23c0..e1e0936f61 100644 --- a/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/DefaultTagHelperContent.cs +++ b/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/DefaultTagHelperContent.cs @@ -142,7 +142,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers } /// - public override TagHelperContent Append(IHtmlContent htmlContent) + public override TagHelperContent AppendHtml(IHtmlContent htmlContent) { Buffer.Add(htmlContent); return this; diff --git a/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperContent.cs b/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperContent.cs index 8b30491073..75e83ad7bd 100644 --- a/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperContent.cs +++ b/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperContent.cs @@ -79,7 +79,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers /// /// The to be appended. /// A reference to this instance after the append operation has completed. - public abstract TagHelperContent Append(IHtmlContent htmlContent); + public abstract TagHelperContent AppendHtml(IHtmlContent htmlContent); /// /// Appends to the existing content. is assumed @@ -145,9 +145,9 @@ namespace Microsoft.AspNet.Razor.TagHelpers public abstract void WriteTo(TextWriter writer, HtmlEncoder encoder); /// - IHtmlContentBuilder IHtmlContentBuilder.Append(IHtmlContent content) + IHtmlContentBuilder IHtmlContentBuilder.AppendHtml(IHtmlContent content) { - return Append(content); + return AppendHtml(content); } /// diff --git a/test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/DefaultTagHelperContentTest.cs b/test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/DefaultTagHelperContentTest.cs index 8ec73d26e3..d8e7986138 100644 --- a/test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/DefaultTagHelperContentTest.cs +++ b/test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/DefaultTagHelperContentTest.cs @@ -179,7 +179,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers tagHelperContent.Append(text2); // Act - copiedTagHelperContent.Append(tagHelperContent); + copiedTagHelperContent.AppendHtml(tagHelperContent); // Assert Assert.Equal(expected, copiedTagHelperContent.GetContent(new HtmlTestEncoder())); @@ -233,7 +233,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers TagHelperContent NullContent = null; // Act - tagHelperContent.Append(NullContent); + tagHelperContent.AppendHtml(NullContent); // Assert Assert.True(tagHelperContent.IsModified); @@ -317,7 +317,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers var copiedTagHelperContent = new DefaultTagHelperContent(); // Act - tagHelperContent.Append(copiedTagHelperContent); + tagHelperContent.AppendHtml(copiedTagHelperContent); tagHelperContent.Append(string.Empty); // Assert @@ -372,7 +372,7 @@ namespace Microsoft.AspNet.Razor.TagHelpers copiedTagHelperContent.SetContent("Hello"); // Act - tagHelperContent.Append(copiedTagHelperContent); + tagHelperContent.AppendHtml(copiedTagHelperContent); // Assert Assert.False(tagHelperContent.IsEmpty);