Review feedback.

This commit is contained in:
Chris Ross 2014-03-14 10:17:46 -07:00
parent 6a5cb913c8
commit 2b7272fe07
2 changed files with 4 additions and 13 deletions

View File

@ -47,7 +47,7 @@ namespace Microsoft.AspNet.Hosting.Startup
if (type == null)
{
// Full scan
var typeInfo = assembly.DefinedTypes.FirstOrDefault(aType => aType.Name.Equals(typeName));
var typeInfo = assembly.DefinedTypes.FirstOrDefault(aType => aType.Name.Equals(typeName, StringComparison.OrdinalIgnoreCase));
if (typeInfo != null)
{
type = typeInfo.AsType();

View File

@ -6,23 +6,14 @@ namespace Microsoft.AspNet.Hosting
{
internal static Tuple<string, string> SplitTypeName(string identifier)
{
string typeName;
string assemblyName;
string typeName = null;
string assemblyName = identifier.Trim();
var parts = identifier.Split(new[] { ',' }, 2);
if (parts.Length == 1)
{
typeName = null;
assemblyName = identifier.Trim();
}
else if (parts.Length == 2)
if (parts.Length == 2)
{
typeName = parts[0].Trim();
assemblyName = parts[1].Trim();
}
else
{
throw new ArgumentException("TODO: Unrecognized format", "identifier");
}
return new Tuple<string, string>(typeName, assemblyName);
}
}