Review feedback.
This commit is contained in:
parent
6a5cb913c8
commit
2b7272fe07
|
|
@ -47,7 +47,7 @@ namespace Microsoft.AspNet.Hosting.Startup
|
|||
if (type == null)
|
||||
{
|
||||
// Full scan
|
||||
var typeInfo = assembly.DefinedTypes.FirstOrDefault(aType => aType.Name.Equals(typeName));
|
||||
var typeInfo = assembly.DefinedTypes.FirstOrDefault(aType => aType.Name.Equals(typeName, StringComparison.OrdinalIgnoreCase));
|
||||
if (typeInfo != null)
|
||||
{
|
||||
type = typeInfo.AsType();
|
||||
|
|
|
|||
|
|
@ -6,23 +6,14 @@ namespace Microsoft.AspNet.Hosting
|
|||
{
|
||||
internal static Tuple<string, string> SplitTypeName(string identifier)
|
||||
{
|
||||
string typeName;
|
||||
string assemblyName;
|
||||
string typeName = null;
|
||||
string assemblyName = identifier.Trim();
|
||||
var parts = identifier.Split(new[] { ',' }, 2);
|
||||
if (parts.Length == 1)
|
||||
{
|
||||
typeName = null;
|
||||
assemblyName = identifier.Trim();
|
||||
}
|
||||
else if (parts.Length == 2)
|
||||
if (parts.Length == 2)
|
||||
{
|
||||
typeName = parts[0].Trim();
|
||||
assemblyName = parts[1].Trim();
|
||||
}
|
||||
else
|
||||
{
|
||||
throw new ArgumentException("TODO: Unrecognized format", "identifier");
|
||||
}
|
||||
return new Tuple<string, string>(typeName, assemblyName);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue