From 2b7272fe07ea9cfd6d28ca74348bde12a3949d0e Mon Sep 17 00:00:00 2001 From: Chris Ross Date: Fri, 14 Mar 2014 10:17:46 -0700 Subject: [PATCH] Review feedback. --- .../Startup/StartupLoader.cs | 2 +- src/Microsoft.AspNet.Hosting/Utilities.cs | 15 +++------------ 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs b/src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs index f49dd7a3c8..7b1362e90f 100644 --- a/src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs +++ b/src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs @@ -47,7 +47,7 @@ namespace Microsoft.AspNet.Hosting.Startup if (type == null) { // Full scan - var typeInfo = assembly.DefinedTypes.FirstOrDefault(aType => aType.Name.Equals(typeName)); + var typeInfo = assembly.DefinedTypes.FirstOrDefault(aType => aType.Name.Equals(typeName, StringComparison.OrdinalIgnoreCase)); if (typeInfo != null) { type = typeInfo.AsType(); diff --git a/src/Microsoft.AspNet.Hosting/Utilities.cs b/src/Microsoft.AspNet.Hosting/Utilities.cs index 21ec780149..ae98ea538f 100644 --- a/src/Microsoft.AspNet.Hosting/Utilities.cs +++ b/src/Microsoft.AspNet.Hosting/Utilities.cs @@ -6,23 +6,14 @@ namespace Microsoft.AspNet.Hosting { internal static Tuple SplitTypeName(string identifier) { - string typeName; - string assemblyName; + string typeName = null; + string assemblyName = identifier.Trim(); var parts = identifier.Split(new[] { ',' }, 2); - if (parts.Length == 1) - { - typeName = null; - assemblyName = identifier.Trim(); - } - else if (parts.Length == 2) + if (parts.Length == 2) { typeName = parts[0].Trim(); assemblyName = parts[1].Trim(); } - else - { - throw new ArgumentException("TODO: Unrecognized format", "identifier"); - } return new Tuple(typeName, assemblyName); } }