huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Change unsupported culture log level (#12153) 

* Change unsupported culture log level to Debug

* Fix unit tests
This commit is contained in:
Hisham Bin Ateya 2019-07-24 06:05:10 +03:00 committed by Artak
parent fad6a1867c
commit 28678ee430
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Middleware/Localization/src/RequestCultureProviderLoggerExtensions.cs
View File

@ -16,11 +16,11 @@ namespace Microsoft.AspNetCore.Localization
static RequestCultureProviderLoggerExtensions() static RequestCultureProviderLoggerExtensions()
{ {
_unsupportedCulture = LoggerMessage.Define<string, IList<StringSegment>>( _unsupportedCulture = LoggerMessage.Define<string, IList<StringSegment>>(
LogLevel.Warning, LogLevel.Debug,
new EventId (1, "UnsupportedCulture"), new EventId (1, "UnsupportedCulture"),
"{requestCultureProvider} returned the following unsupported cultures '{cultures}'."); "{requestCultureProvider} returned the following unsupported cultures '{cultures}'.");
_unsupportedUICulture = LoggerMessage.Define<string, IList<StringSegment>>( _unsupportedUICulture = LoggerMessage.Define<string, IList<StringSegment>>(
LogLevel.Warning, LogLevel.Debug,
new EventId(2, "UnsupportedUICulture"), new EventId(2, "UnsupportedUICulture"),
"{requestCultureProvider} returned the following unsupported UI Cultures '{uiCultures}'."); "{requestCultureProvider} returned the following unsupported UI Cultures '{uiCultures}'.");
} }

8
src/Middleware/Localization/test/UnitTests/CookieRequestCultureProviderTest.cs
View File

@ -147,7 +147,7 @@ namespace Microsoft.Extensions.Localization
} }
[Fact] [Fact]
public async Task RequestLocalizationMiddleware_LogsWarningsForUnsupportedCultures() public async Task RequestLocalizationMiddleware_LogsDebugForUnsupportedCultures()
{ {
var sink = new TestSink( var sink = new TestSink(
TestSink.EnableWithTypeName<RequestLocalizationMiddleware>, TestSink.EnableWithTypeName<RequestLocalizationMiddleware>,
@ -195,12 +195,12 @@ namespace Microsoft.Extensions.Localization
var expectedMessage = $"{nameof(CookieRequestCultureProvider)} returned the following unsupported cultures '??'."; var expectedMessage = $"{nameof(CookieRequestCultureProvider)} returned the following unsupported cultures '??'.";
var write = Assert.Single(sink.Writes); var write = Assert.Single(sink.Writes);
Assert.Equal(LogLevel.Warning, write.LogLevel); Assert.Equal(LogLevel.Debug, write.LogLevel);
Assert.Equal(expectedMessage, write.State.ToString()); Assert.Equal(expectedMessage, write.State.ToString());
} }
[Fact] [Fact]
public async Task RequestLocalizationMiddleware_LogsWarningsForUnsupportedUICultures() public async Task RequestLocalizationMiddleware_LogsDebugForUnsupportedUICultures()
{ {
var sink = new TestSink( var sink = new TestSink(
TestSink.EnableWithTypeName<RequestLocalizationMiddleware>, TestSink.EnableWithTypeName<RequestLocalizationMiddleware>,
@ -247,7 +247,7 @@ namespace Microsoft.Extensions.Localization
var expectedMessage = $"{nameof(CookieRequestCultureProvider)} returned the following unsupported UI Cultures '??'."; var expectedMessage = $"{nameof(CookieRequestCultureProvider)} returned the following unsupported UI Cultures '??'.";
var write = Assert.Single(sink.Writes); var write = Assert.Single(sink.Writes);
Assert.Equal(LogLevel.Warning, write.LogLevel); Assert.Equal(LogLevel.Debug, write.LogLevel);
Assert.Equal(expectedMessage, write.State.ToString()); Assert.Equal(expectedMessage, write.State.ToString());
} }
} }