From 28678ee430e9f9a8407e846441ab98692b9f9507 Mon Sep 17 00:00:00 2001 From: Hisham Bin Ateya Date: Wed, 24 Jul 2019 06:05:10 +0300 Subject: [PATCH] Change unsupported culture log level (#12153) * Change unsupported culture log level to Debug * Fix unit tests --- .../src/RequestCultureProviderLoggerExtensions.cs | 4 ++-- .../test/UnitTests/CookieRequestCultureProviderTest.cs | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Middleware/Localization/src/RequestCultureProviderLoggerExtensions.cs b/src/Middleware/Localization/src/RequestCultureProviderLoggerExtensions.cs index a35d8ede63..27d2bdb2d3 100644 --- a/src/Middleware/Localization/src/RequestCultureProviderLoggerExtensions.cs +++ b/src/Middleware/Localization/src/RequestCultureProviderLoggerExtensions.cs @@ -16,11 +16,11 @@ namespace Microsoft.AspNetCore.Localization static RequestCultureProviderLoggerExtensions() { _unsupportedCulture = LoggerMessage.Define>( - LogLevel.Warning, + LogLevel.Debug, new EventId (1, "UnsupportedCulture"), "{requestCultureProvider} returned the following unsupported cultures '{cultures}'."); _unsupportedUICulture = LoggerMessage.Define>( - LogLevel.Warning, + LogLevel.Debug, new EventId(2, "UnsupportedUICulture"), "{requestCultureProvider} returned the following unsupported UI Cultures '{uiCultures}'."); } diff --git a/src/Middleware/Localization/test/UnitTests/CookieRequestCultureProviderTest.cs b/src/Middleware/Localization/test/UnitTests/CookieRequestCultureProviderTest.cs index 0442cfccbc..2e11bb42cb 100644 --- a/src/Middleware/Localization/test/UnitTests/CookieRequestCultureProviderTest.cs +++ b/src/Middleware/Localization/test/UnitTests/CookieRequestCultureProviderTest.cs @@ -147,7 +147,7 @@ namespace Microsoft.Extensions.Localization } [Fact] - public async Task RequestLocalizationMiddleware_LogsWarningsForUnsupportedCultures() + public async Task RequestLocalizationMiddleware_LogsDebugForUnsupportedCultures() { var sink = new TestSink( TestSink.EnableWithTypeName, @@ -195,12 +195,12 @@ namespace Microsoft.Extensions.Localization var expectedMessage = $"{nameof(CookieRequestCultureProvider)} returned the following unsupported cultures '??'."; var write = Assert.Single(sink.Writes); - Assert.Equal(LogLevel.Warning, write.LogLevel); + Assert.Equal(LogLevel.Debug, write.LogLevel); Assert.Equal(expectedMessage, write.State.ToString()); } [Fact] - public async Task RequestLocalizationMiddleware_LogsWarningsForUnsupportedUICultures() + public async Task RequestLocalizationMiddleware_LogsDebugForUnsupportedUICultures() { var sink = new TestSink( TestSink.EnableWithTypeName, @@ -247,7 +247,7 @@ namespace Microsoft.Extensions.Localization var expectedMessage = $"{nameof(CookieRequestCultureProvider)} returned the following unsupported UI Cultures '??'."; var write = Assert.Single(sink.Writes); - Assert.Equal(LogLevel.Warning, write.LogLevel); + Assert.Equal(LogLevel.Debug, write.LogLevel); Assert.Equal(expectedMessage, write.State.ToString()); } }