huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use preparsed version, rather than reparsing (#2021) 

Current path is:

 Parser -> HttpVersion Enum -> Get Version String -> Set `HttpVersion` with string -> Convert back to Enum

Can just set the enum directly since its already parsed.

Also using the const rather than strings; where the strings are in code
This commit is contained in:
Ben Adams 2017-08-27 01:18:16 +01:00 committed by David Fowler
parent 088f7e32ae
commit 09be7c416a
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Kestrel.Core/Internal/Http/Frame.cs
View File

@ -158,11 +158,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
{ {
if (_httpVersion == Http.HttpVersion.Http11) if (_httpVersion == Http.HttpVersion.Http11)
{ {
return "HTTP/1.1"; return HttpUtilities.Http11Version;
} }
if (_httpVersion == Http.HttpVersion.Http10) if (_httpVersion == Http.HttpVersion.Http10)
{ {
return "HTTP/1.0"; return HttpUtilities.Http10Version;
} }
return string.Empty; return string.Empty;
@ -173,11 +173,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
{ {
// GetKnownVersion returns versions which ReferenceEquals interned string // GetKnownVersion returns versions which ReferenceEquals interned string
// As most common path, check for this only in fast-path and inline // As most common path, check for this only in fast-path and inline
if (ReferenceEquals(value, "HTTP/1.1")) if (ReferenceEquals(value, HttpUtilities.Http11Version))
{ {
_httpVersion = Http.HttpVersion.Http11; _httpVersion = Http.HttpVersion.Http11;
} }
else if (ReferenceEquals(value, "HTTP/1.0")) else if (ReferenceEquals(value, HttpUtilities.Http10Version))
{ {
_httpVersion = Http.HttpVersion.Http10; _httpVersion = Http.HttpVersion.Http10;
} }
@ -191,11 +191,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
[MethodImpl(MethodImplOptions.NoInlining)] [MethodImpl(MethodImplOptions.NoInlining)]
private void HttpVersionSetSlow(string value) private void HttpVersionSetSlow(string value)
{ {
if (value == "HTTP/1.1") if (value == HttpUtilities.Http11Version)
{ {
_httpVersion = Http.HttpVersion.Http11; _httpVersion = Http.HttpVersion.Http11;
} }
else if (value == "HTTP/1.0") else if (value == HttpUtilities.Http10Version)
{ {
_httpVersion = Http.HttpVersion.Http10; _httpVersion = Http.HttpVersion.Http10;
} }
@ -1224,7 +1224,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
Method = method != HttpMethod.Custom Method = method != HttpMethod.Custom
? HttpUtilities.MethodToString(method) ?? string.Empty ? HttpUtilities.MethodToString(method) ?? string.Empty
: customMethod.GetAsciiStringNonNullCharacters(); : customMethod.GetAsciiStringNonNullCharacters();
HttpVersion = HttpUtilities.VersionToString(version); _httpVersion = version;
Debug.Assert(RawTarget != null, "RawTarget was not set"); Debug.Assert(RawTarget != null, "RawTarget was not set");
Debug.Assert(Method != null, "Method was not set"); Debug.Assert(Method != null, "Method was not set");