From 09be7c416a032ed55a3cefa8b1554af92bb54abf Mon Sep 17 00:00:00 2001
From: Ben Adams <thundercat@illyriad.co.uk>
Date: Sun, 27 Aug 2017 01:18:16 +0100
Subject: [PATCH] Use preparsed version, rather than reparsing (#2021)

Current path is:

 Parser -> HttpVersion Enum -> Get Version String -> Set `HttpVersion` with string -> Convert back to Enum

Can just set the enum directly since its already parsed.

Also using the const rather than strings; where the strings are in code
---
 src/Kestrel.Core/Internal/Http/Frame.cs | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/Kestrel.Core/Internal/Http/Frame.cs b/src/Kestrel.Core/Internal/Http/Frame.cs
index 4c4121df62..3c56334f26 100644
--- a/src/Kestrel.Core/Internal/Http/Frame.cs
+++ b/src/Kestrel.Core/Internal/Http/Frame.cs
@@ -158,11 +158,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
             {
                 if (_httpVersion == Http.HttpVersion.Http11)
                 {
-                    return "HTTP/1.1";
+                    return HttpUtilities.Http11Version;
                 }
                 if (_httpVersion == Http.HttpVersion.Http10)
                 {
-                    return "HTTP/1.0";
+                    return HttpUtilities.Http10Version;
                 }
 
                 return string.Empty;
@@ -173,11 +173,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
             {
                 // GetKnownVersion returns versions which ReferenceEquals interned string
                 // As most common path, check for this only in fast-path and inline
-                if (ReferenceEquals(value, "HTTP/1.1"))
+                if (ReferenceEquals(value, HttpUtilities.Http11Version))
                 {
                     _httpVersion = Http.HttpVersion.Http11;
                 }
-                else if (ReferenceEquals(value, "HTTP/1.0"))
+                else if (ReferenceEquals(value, HttpUtilities.Http10Version))
                 {
                     _httpVersion = Http.HttpVersion.Http10;
                 }
@@ -191,11 +191,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
         [MethodImpl(MethodImplOptions.NoInlining)]
         private void HttpVersionSetSlow(string value)
         {
-            if (value == "HTTP/1.1")
+            if (value == HttpUtilities.Http11Version)
             {
                 _httpVersion = Http.HttpVersion.Http11;
             }
-            else if (value == "HTTP/1.0")
+            else if (value == HttpUtilities.Http10Version)
             {
                 _httpVersion = Http.HttpVersion.Http10;
             }
@@ -1224,7 +1224,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
             Method = method != HttpMethod.Custom
                 ? HttpUtilities.MethodToString(method) ?? string.Empty
                 : customMethod.GetAsciiStringNonNullCharacters();
-            HttpVersion = HttpUtilities.VersionToString(version);
+            _httpVersion = version;
 
             Debug.Assert(RawTarget != null, "RawTarget was not set");
             Debug.Assert(Method != null, "Method was not set");