Commit Graph

486 Commits

Author SHA1 Message Date
Hannes Wallnöfer 701d25ad41 8028210: Missing conversions on array index expression
Reviewed-by: attila, jlaskey, lagergren
2013-11-16 00:23:46 +01:00
Attila Szegedi 193c892437 8028020: Function parameter as last expression in comma in return value causes bad type calculation
Reviewed-by: jlaskey, lagergren, sundar
2013-11-11 14:25:01 +01:00
Athijegannathan Sundararajan 9c0bfd337b 8027828: ClassCastException when converting return value of a Java method to boolean
Reviewed-by: jlaskey, attila
2013-11-07 17:26:46 +05:30
Athijegannathan Sundararajan 1a4300e042 8027753: Support ScriptObject to JSObject, ScriptObjectMirror, Map, Bindings auto-conversion as well as explicit wrap, unwrap
Reviewed-by: jlaskey, hannesw, attila
2013-11-04 18:52:22 +05:30
Attila Szegedi 5b69c36f31 8027236: Ensure ScriptObject and ConsString aren't visible to Java
Reviewed-by: lagergren, sundar
2013-11-01 15:36:33 +01:00
Athijegannathan Sundararajan 5f0dae04d0 8027700: function redeclaration checks missing for declaration binding instantiation
Reviewed-by: jlaskey, lagergren
2013-11-01 19:54:48 +05:30
Athijegannathan Sundararajan 79197a579a 8027562: eval should load second and subsequent arguments for side effect
Reviewed-by: jlaskey, lagergren
2013-10-30 20:09:44 +05:30
Hannes Wallnöfer eb1ac57404 8027042: Evaluation order for binary operators can be improved
Reviewed-by: lagergren, jlaskey, attila
2013-10-25 10:20:49 +02:00
Athijegannathan Sundararajan 88d33f9397 8027128: jdk.nashorn.api.scripting.JSObject should be an interface
Reviewed-by: hannesw, attila, jlaskey
2013-10-23 17:30:13 +05:30
Athijegannathan Sundararajan 2e2ed4da7b 8027024: String.prototype.charAt and charCodeAt do not evaluate 'self' and 'pos' arguments in right order
Reviewed-by: jlaskey, attila, lagergren
2013-10-22 17:38:12 +05:30
Hannes Wallnöfer 66d4cfc344 8026955: for-in should convert primitive values to object
Reviewed-by: jlaskey, lagergren
2013-10-22 11:31:03 +02:00
Hannes Wallnöfer 02f1c63a96 8027015: AutoCloseable no longer implements @FunctionalInterface
Reviewed-by: lagergren, sundar
2013-10-22 11:12:36 +02:00
Athijegannathan Sundararajan 4e089bf89f 8027016: Array.prototype.indexOf should return -1 when array is of length zero
Reviewed-by: lagergren, attila
2013-10-22 14:27:52 +05:30
Hannes Wallnöfer ec44b39357 8026858: Array length does not handle defined properties correctly
Reviewed-by: jlaskey
2013-10-18 22:42:41 +02:00
Hannes Wallnöfer e230ab93cf 8026805: Array.prototype.length doesn't work as expected
Reviewed-by: sundar, lagergren
2013-10-18 12:50:21 +02:00
Hannes Wallnöfer 51efcaca19 8026701: Array.prototype.splice is slow on dense arrays
Reviewed-by: lagergren, sundar, jlaskey
2013-10-17 17:33:16 +02:00
Attila Szegedi 58290e75b1 8026161: Don't narrow floating-point literals in the lexer
Reviewed-by: hannesw, jlaskey
2013-10-17 12:38:50 +02:00
Hannes Wallnöfer 98e95a2a05 8026693: getType() called on DISCARD node
Reviewed-by: sundar, lagergren
2013-10-16 10:15:55 +02:00
Hannes Wallnöfer 4b1800b556 8026692: eval() throws NullPointerException with --compile-only
Reviewed-by: sundar, lagergren
2013-10-16 10:12:22 +02:00
James Laskey 5fc60da189 8026498: Revert: latest runsunspider.js tests contains several bugs
Reviewed-by: sundar, hannesw
2013-10-15 13:14:04 -03:00
Hannes Wallnöfer 6dea2bf070 8026367: Add a sync keyword to mozilla_compat
Reviewed-by: sundar, attila, lagergren
2013-10-15 17:37:47 +02:00
Hannes Wallnöfer f6a5c28343 8026016: too many relinks dominate avatar.js http benchmark
Reviewed-by: sundar, jlaskey, attila
2013-10-14 11:45:15 +02:00
James Laskey 77fa728cc4 8026309: latest runsunspider.js tests contains several bugs
Reviewed-by: sundar, lagergren
2013-10-11 14:54:16 +02:00
Athijegannathan Sundararajan 49c0702260 8026317: $ in the function name results in wrong function being invoked
Reviewed-by: lagergren, jlaskey
2013-10-11 14:11:14 +02:00
Athijegannathan Sundararajan 93568dc4b4 8026302: source representation of getter and setter methods is wrong
Reviewed-by: lagergren, hannesw, jlaskey
2013-10-11 11:15:59 +02:00
Hannes Wallnöfer 0efd1ec560 8026292: Megamorphic setter fails with boolean value
Reviewed-by: jlaskey, sundar
2013-10-11 10:56:08 +02:00
Athijegannathan Sundararajan 47391b81c0 8026263: [NASHORN] Test test/script/basic/JDK-8025488.js fails in nightly builds
Reviewed-by: jlaskey
2013-10-11 06:50:06 +02:00
Athijegannathan Sundararajan b9a835c52c 8026264: Getter, setter function name mangling issues
Reviewed-by: lagergren, jlaskey
2013-10-10 21:43:35 +02:00
Athijegannathan Sundararajan c137ccf192 8026162: "this" in SAM adapter functions is wrong
Reviewed-by: jlaskey, hannesw
2013-10-10 14:43:22 +02:00
Athijegannathan Sundararajan c2db4022bf 8026248: importClass has to be a varargs function
Reviewed-by: jlaskey, hannesw
2013-10-10 13:17:57 +02:00
Athijegannathan Sundararajan b7eebfe780 8026167: Class cache/reuse of 'eval' scripts results in ClassCastException in some cases
Reviewed-by: lagergren, jlaskey
2013-10-10 11:48:56 +02:00
Marcus Lagergren 35d5f5765d 8026137: Fix Issues with Binary Evaluation Order
Co-authored-by: Attila Szegedi <attila.szegedi@oracle.com>
Reviewed-by: hannesw, jlaskey
2013-10-09 17:53:22 +02:00
Hannes Wallnöfer 1e868581be 8026008: Constant folding removes var statement
Reviewed-by: sundar, jlaskey
2013-10-09 14:50:39 +02:00
Athijegannathan Sundararajan bfdab50e81 8026125: Array.prototype.slice.call(Java.type("java.util.HashMap")) throws ClassCastException: jdk.internal.dynalink.beans.StaticClass cannot be cast to jdk.nashorn.internal.runtime.ScriptObject
Reviewed-by: hannesw, jlaskey
2013-10-09 13:26:23 +02:00
Athijegannathan Sundararajan 0f45589a8f 8026112: Function("with(x ? 1e81 : (x2.constructor = 0.1)){}") throws AssertionError: double is not compatible with object
Reviewed-by: lagergren, hannesw
2013-10-09 10:47:47 +02:00
Athijegannathan Sundararajan 0d1247801d 8026048: Function constructor should convert arguments to String before performing any syntax checks
Reviewed-by: jlaskey, hannesw
2013-10-08 16:46:03 +02:00
Hannes Wallnöfer 8011d24b07 8026042: FoldConstants need to guard against ArrayLiteralNode
Reviewed-by: jlaskey, sundar
2013-10-08 15:53:22 +02:00
Athijegannathan Sundararajan ba4818b152 8026033: Switch should load expression even when there are no cases in it
Reviewed-by: jlaskey, hannesw
2013-10-08 13:02:39 +02:00
Hannes Wallnöfer c4f493f508 8025213: Assignment marks variable as defined too early
Reviewed-by: jlaskey, lagergren, sundar
2013-10-08 11:55:19 +02:00
Athijegannathan Sundararajan 4183b8a64e 8025771: Enhance Nashorn Contexts
Reviewed-by: jlaskey, hannesw
2013-10-04 16:21:29 +05:30
Athijegannathan Sundararajan 1056c46d27 8025488: Error.captureStackTrace should not format error stack
Reviewed-by: hannesw, attila
2013-10-01 14:38:56 +05:30
Hannes Wallnöfer 409c2ccd49 8025589: Array.prototype.shift should only copy defined elements in generic mode
Reviewed-by: sundar, attila
2013-09-30 15:54:05 +02:00
Hannes Wallnöfer eb99702aad 8025520: Array.prototype.slice should only copy defined elements
Reviewed-by: sundar, lagergren
2013-09-27 17:00:37 +02:00
Hannes Wallnöfer b9971d37df 8025515: Performance issues with Source.getLine()
Reviewed-by: sundar, lagergren
2013-09-27 16:59:01 +02:00
Hannes Wallnöfer bd14ea3137 8025486: RegExp constructor arguments are not evaluated in right order
Reviewed-by: sundar
2013-09-26 11:47:24 +02:00
Hannes Wallnöfer 7001bd4f94 8025197: String replace method fails with regexp /$/gi
Reviewed-by: sundar
2013-09-26 10:14:24 +02:00
Hannes Wallnöfer 564d8f4025 8025434: RegExp lastIndex can exceed int range
Reviewed-by: lagergren, sundar
2013-09-25 16:37:56 +02:00
Athijegannathan Sundararajan 817cdf16bc 8025325: parseFloat does not handle '.' in exponent part
Reviewed-by: hannesw
2013-09-25 08:17:37 +05:30
Athijegannathan Sundararajan 4a45497ed6 8025312: parseInt should convert 'radix' argument to ToInt32 even if empty string is parsed
Reviewed-by: jlaskey, hannesw
2013-09-24 20:43:42 +05:30
Hannes Wallnöfer 8a393eac8c 8025163: Date methods should not return -0
Reviewed-by: lagergren, jlaskey
2013-09-21 10:11:15 +02:00
Athijegannathan Sundararajan d179ec2b6b 8025149: JSON.stringify does not handle 'space' argument as per the spec
Reviewed-by: jlaskey, hannesw
2013-09-20 22:37:08 +05:30
Athijegannathan Sundararajan 42d4c2e741 8025147: Trailing comma is not allowed in JSONArray and JSONObject
Reviewed-by: hannesw, jlaskey
2013-09-20 20:55:43 +05:30
Athijegannathan Sundararajan b6b06381da 8025111: undefined or null 'with' expression in empty with block should throw TypeError
Reviewed-by: lagergren, hannesw
2013-09-20 12:56:07 +05:30
Athijegannathan Sundararajan 247f43df94 8025090: 'while' statement with 'test' using var before being declared in body results in VerifyError
Reviewed-by: jlaskey
2013-09-19 23:48:37 +05:30
Athijegannathan Sundararajan d68fab7409 8025080: Object literal getter, setter function with number format property name results in ClassFormatError
Reviewed-by: lagergren, hannesw
2013-09-19 21:20:47 +05:30
Athijegannathan Sundararajan 77da4f4a41 8025048: true as case label results in ClassCastException
Reviewed-by: lagergren
2013-09-19 13:34:01 +05:30
Athijegannathan Sundararajan 406cffea6e 8024972: for (LeftHandSideExpression in Expression) crashes the compiler
Reviewed-by: lagergren, hannesw
2013-09-18 13:06:17 +05:30
Attila Szegedi 35a72600c9 8024846: keep separate internal arguments variable
Reviewed-by: lagergren, sundar
2013-09-16 14:44:20 +02:00
Athijegannathan Sundararajan 952b8f0d36 8024847: Java.to should accept mirror and external JSObjects as array-like objects as well
Reviewed-by: hannesw, attila, lagergren
2013-09-16 15:08:36 +05:30
Athijegannathan Sundararajan 0045b8bd09 8024619: JDBC java.sql.DriverManager is not usable from JS script
Reviewed-by: jlaskey, lagergren, attila
2013-09-13 16:45:11 +05:30
Athijegannathan Sundararajan 60b4bc0b5a 8024693: Various minor issues with JSONWriter used by script parser API
Reviewed-by: jlaskey, hannesw
2013-09-12 22:16:40 +05:30
Hannes Wallnöfer 4a06176db4 8024512: Regex /[^\[]/ doesn't match
Reviewed-by: jlaskey, sundar
2013-09-12 17:13:59 +02:00
Athijegannathan Sundararajan 67694e12b2 8024180: Incorrect handling of expression and parent scope in 'with' statements
Reviewed-by: jlaskey, hannesw
2013-09-09 20:10:41 +05:30
Athijegannathan Sundararajan 3b41324b70 8024255: When a keyword is used as object property name, the property can not be deleted
Reviewed-by: jlaskey, lagergren
2013-09-05 21:17:06 +05:30
Athijegannathan Sundararajan 6fa75fd4ae 8024174: Setting __proto__ property in Object literal should be supported
Reviewed-by: jlaskey, lagergren
2013-09-04 19:58:16 +05:30
Athijegannathan Sundararajan 65f19c786e 8024120: Setting __proto__ to null removes the __proto__ property
Reviewed-by: lagergren, attila
2013-09-04 14:29:07 +05:30
Athijegannathan Sundararajan 34aafa961f 8023784: Object.prototype.toString should contain the class name for all instances
Reviewed-by: lagergren, jlaskey
2013-08-27 18:57:50 +05:30
Attila Szegedi 516ee6ca6a 8023780: Gracefully handle @CS methods while binding bean properties
Reviewed-by: jlaskey, lagergren, sundar
2013-08-27 13:17:00 +02:00
Hannes Wallnöfer c8d2baed47 8023650: Regexp m flag does not recognize CRNL or CR
Reviewed-by: jlaskey, lagergren
2013-08-26 15:59:41 +02:00
James Laskey feb12df2ac 8019987: String trimRight and trimLeft could be defined
Reviewed-by: sundar
2013-08-23 12:20:19 -03:00
Attila Szegedi 6f5afdecbf 8023630: Implement Java.super() as the preferred way to call super methods
Reviewed-by: jlaskey, lagergren, sundar
2013-08-23 13:10:45 +02:00
Hannes Wallnöfer 2dd48af1ba 8023531: new RegExp('').toString() should return '/(?:)/'
Reviewed-by: sundar, jlaskey
2013-08-22 17:23:50 +02:00
Athijegannathan Sundararajan f08402dd57 8023551: Mirror functions can not be invoked using invokeMethod, invokeFunction
Reviewed-by: attila, jlaskey, lagergren
2013-08-22 18:46:26 +05:30
Athijegannathan Sundararajan 3a59c354d9 8023368: Instance __proto__ property should exist and be writable
Reviewed-by: attila, hannesw
2013-08-21 17:28:53 +05:30
Attila Szegedi 303b0f1780 8022903: Enhance for-in and for-each for Lists and Maps
Reviewed-by: lagergren, sundar
2013-08-21 13:39:40 +02:00
Attila Szegedi b1bab51463 8023373: allow super invocation for adapters
Reviewed-by: lagergren, sundar
2013-08-21 13:39:09 +02:00
Hannes Wallnöfer a1552db3ae 8019985: Date.parse("2000-01-01T00:00:00.Z") should return NaN
Reviewed-by: sundar, jlaskey
2013-08-16 13:42:44 +02:00
Athijegannathan Sundararajan d7e1bdda70 8020355: bind on built-in constructors don't use bound argument values
Reviewed-by: lagergren, hannesw
2013-08-16 15:04:36 +05:30
Athijegannathan Sundararajan 75149148e3 8023026: Array.prototype iterator functions like forEach, reduce should work for Java arrays, lists
Reviewed-by: jlaskey, lagergren
2013-08-14 20:51:53 +05:30
Athijegannathan Sundararajan 1c83c2a6ca 8022598: Object.getPrototypeOf should return null for host objects rather than throwing TypeError
Reviewed-by: lagergren, jlaskey, attila, hannesw
2013-08-12 18:16:28 +05:30
Hannes Wallnöfer c2e627d7f2 8022731: NativeArguments has wrong implementation of isMapped()
Reviewed-by: lagergren, jlaskey
2013-08-12 13:31:43 +02:00
Athijegannathan Sundararajan a2215722a2 8022524: Memory leaks in nashorn sources and tests found by jhat analysis
Reviewed-by: attila, hannesw
2013-08-08 16:38:32 +05:30
Hannes Wallnöfer c9429aa5a1 8020132: Big object literal with numerical keys exceeds method size
Reviewed-by: lagergren, sundar
2013-08-01 12:23:38 +02:00
Michael Horowitz 5bce0606af 8021321: Two runsunspider tests fail after updating sunspider to 1.0
Reviewed-by: jlaskey, sundar
2013-07-26 09:17:54 -03:00
Hannes Wallnöfer a218959d0c 8020719: Run tests with reduced splitter threshold
Reviewed-by: lagergren, sundar, jlaskey
2013-07-26 13:50:52 +02:00
Athijegannathan Sundararajan 27b2f43920 8021122: Not all callables are handled for toString and other function valued properties
Reviewed-by: attila, hannesw, jlaskey
2013-07-23 18:17:25 +05:30
Attila Szegedi f107468fd6 8020820: Limit access to static members of reflective classes
Reviewed-by: jlaskey, sundar
2013-07-18 16:47:45 +02:00
Hannes Wallnöfer bf8ed4fe82 8020356: ClassCastException Undefined->Scope on spiltter class generated for a large switch statement
Reviewed-by: jlaskey, attila
2013-07-17 18:20:40 +02:00
Attila Szegedi 36cb049cd5 8015356: array concatenation should skip empty elements
Reviewed-by: jlaskey, sundar
2013-07-16 17:03:30 +02:00
Attila Szegedi a4f27565d7 8020357: throw RangeError for too large NativeArrayBuffer size
Reviewed-by: jlaskey, hannesw, sundar
2013-07-16 15:28:33 +02:00
Hannes Wallnöfer d7aa718a42 8020358: Array(0xfffffff) throws OutOfMemoryError
Reviewed-by: jlaskey, sundar
2013-07-15 18:32:23 +02:00
Attila Szegedi 687fe4060c 8020508: Enforce reflection access restrictions on Object.bindProperties
Reviewed-by: jlaskey, sundar
2013-07-15 16:31:49 +02:00
Hannes Wallnöfer 4b0269cad7 8020354: Object literal property initialization is not done in source order
Reviewed-by: sundar, jlaskey
2013-07-15 15:51:06 +02:00
Attila Szegedi 30383a110f 8020324: Implement Object.bindProperties(target, source) for beans
Reviewed-by: hannesw, sundar
2013-07-15 12:33:48 +02:00
Athijegannathan Sundararajan ef064349fa 8020463: Input argument array wrapping in loadWithNewGlobal is wrong
Reviewed-by: attila, jlaskey
2013-07-12 20:06:41 +05:30
Attila Szegedi c084cc34ff 8019822: Duplicate name and signature in finally block
Reviewed-by: jlaskey, sundar
2013-07-12 11:58:42 +02:00
Athijegannathan Sundararajan cf924d87c1 8020223: ClassCastException: String can not be casted to ScriptFunction
Reviewed-by: attila, lagergren
2013-07-12 15:27:16 +05:30
Athijegannathan Sundararajan b00d887a3f 8020437: Wrong handling of line numbers with multiline string literals
Reviewed-by: attila, lagergren
2013-07-12 15:01:33 +05:30
Athijegannathan Sundararajan fe298edbc2 8012191: noSuchProperty can't cope with vararg functions
Reviewed-by: jlaskey, attila
2013-07-11 22:58:37 +05:30
Athijegannathan Sundararajan 3f9a1af516 8020380: __noSuchProperty__ defined in mozilla_compat.js script should be non-enumerable
Reviewed-by: jlaskey, hannesw, attila
2013-07-11 18:23:13 +05:30
Athijegannathan Sundararajan 5a4f0090b4 8020325: static property does not work on accessible, public classes
Reviewed-by: attila, hannesw, lagergren
2013-07-11 16:34:55 +05:30
Hannes Wallnöfer 04f83326fe 8016681: regex capture behaves differently than on V8
Reviewed-by: lagergren, sundar
2013-07-10 10:54:19 +02:00
Marcus Lagergren 9768aeb2a2 8020124: In the case of an eval switch, we might need explicit conversions of the tag store, as it was not known in the surrounding environment
Reviewed-by: sundar, jlaskey
2013-07-09 15:56:59 +02:00
Athijegannathan Sundararajan 0f2b5afed6 8014785: Ability to extend global instance by binding properties of another object
Reviewed-by: attila, hannesw, jlaskey, lagergren
2013-07-09 17:37:46 +05:30
Hannes Wallnöfer 017ad9ea83 8019963: empty char range in regex
Reviewed-by: jlaskey, sundar
2013-07-08 19:34:55 +02:00
Marcus Lagergren dfaa2689bd 8019983: Void returns combined with return with expression picked the wrong return type
Reviewed-by: sundar, jlaskey
2013-07-05 19:35:39 +02:00
Attila Szegedi b92c68729b 8019819: scope symbol didn't get a slot in certain cases
Reviewed-by: hannesw, jlaskey, lagergren, sundar
2013-07-05 15:10:47 +02:00
Hannes Wallnöfer 4f243bda24 8017084: Use spill properties for large object literals
Reviewed-by: lagergren, sundar
2013-07-05 14:36:54 +02:00
Athijegannathan Sundararajan f6a65631c4 8019947: inherited property invalidation does not work with two globals in same context
Reviewed-by: jlaskey, lagergren, hannesw, attila
2013-07-05 14:38:04 +05:30
Marcus Lagergren 7049721e76 Merge 2013-07-04 17:28:04 +02:00
Marcus Lagergren 844f46caa2 8019821: allInteger switches were confused by boolean cases, as they are a narrower type than int
Reviewed-by: sundar, hannesw
2013-07-04 17:27:33 +02:00
Attila Szegedi 3d52870f3f 8019809: return after break incorrectly sets the block as terminal
Reviewed-by: jlaskey, lagergren
2013-07-04 14:10:18 +02:00
Attila Szegedi 3f7d4928e8 8017768: allow dot as inner class name separator for Java.type
Reviewed-by: jlaskey, sundar
2013-07-03 18:10:12 +02:00
Athijegannathan Sundararajan ff3ef9ecbe 8019814: Add regression test for passing cases
Reviewed-by: jlaskey, lagergren
2013-07-03 19:20:29 +05:30
Marcus Lagergren 848aedfe09 8019811: Static calls - self referential functions needed a return type conversion if they were specialized, as they can't use the same mechanism as indy calls
Reviewed-by: sundar, jlaskey
2013-07-03 15:46:03 +02:00
Athijegannathan Sundararajan 3ac129eecb 8019805: for each (init; test; modify) is invalid
Reviewed-by: lagergren, jlaskey
2013-07-03 17:26:31 +05:30
Marcus Lagergren 02834e4afb 8019585: Sometimes a var declaration using itself in its init wasn't declared as canBeUndefined, causing erroneous bytecode
Reviewed-by: sundar, attila
2013-07-03 13:03:36 +02:00
Attila Szegedi edd7847948 8010946: AccessControl.doPrivileged is broken when called from js script
Reviewed-by: jlaskey, sundar
2013-07-03 12:39:28 +02:00
Athijegannathan Sundararajan 5f627c3f73 8019791: ~ is a unary operator
Reviewed-by: hannesw
2013-07-03 14:08:00 +05:30
Athijegannathan Sundararajan d524343202 8019783: typeof does not work properly for java methods and foreign objects
Reviewed-by: hannesw
2013-07-03 13:13:17 +05:30
Athijegannathan Sundararajan fbd20eb5a5 8019629: void operator should always evaluate to undefined
Reviewed-by: jlaskey
2013-07-03 00:08:45 +05:30
Marcus Lagergren ee66717b91 Merge 2013-07-02 15:01:38 +02:00
Marcus Lagergren e888c99eea 8017082: Long array literals were slightly broken
Reviewed-by: sundar, attila
2013-07-02 14:50:39 +02:00
Athijegannathan Sundararajan 747485156a 8019553: NPE on illegal l-value for increment and decrement
Reviewed-by: jlaskey, attila, lagergren
2013-07-02 18:00:15 +05:30
Marcus Lagergren 422a1a6e4f 8016667: Wrong bytecode when testing/setting due to null check shortcut checking against primitive too
Reviewed-by: jlaskey, sundar
2013-07-02 13:50:19 +02:00
Athijegannathan Sundararajan 817ab71e77 8019508: Comma handling in object literal parsing is wrong
Reviewed-by: hannesw
2013-07-01 23:36:40 +05:30
Athijegannathan Sundararajan bcf7f18a37 8019488: switch on literals result in NoSuchMethodError or VerifyError
Reviewed-by: hannesw
2013-07-01 19:52:07 +05:30
Athijegannathan Sundararajan afc55770aa 8019482: Number("0x0.0p0") should evaluate to NaN
Reviewed-by: lagergren
2013-07-01 17:21:09 +05:30
Athijegannathan Sundararajan 09fbdd43ec 8019478: Object.prototype.toString.call(/a/.exec("a")) === "[object Array]" should be true
Reviewed-by: hannesw
2013-07-01 14:15:07 +05:30
Athijegannathan Sundararajan 4a0c5773e8 8019473: Parser issues related to functions and blocks
Reviewed-by: lagergren
2013-07-01 12:38:01 +05:30
Athijegannathan Sundararajan e8d954092f 8019365: Error stack format
Reviewed-by: hannesw
2013-06-28 19:36:26 +05:30
Athijegannathan Sundararajan a32e6fdb56 8019226: line number not generated for first statement if it is on the same function declaration line
Reviewed-by: jlaskey, hannesw
2013-06-27 13:24:50 +05:30
Athijegannathan Sundararajan 10ead7dab6 8014781: support Error.captureStackTrace
Reviewed-by: jlaskey, hannesw
2013-06-26 19:42:17 +05:30
Athijegannathan Sundararajan dcd23b305b 8017950: error.stack should be a string rather than an array
Reviewed-by: hannesw, jlaskey
2013-06-26 16:36:13 +05:30
Athijegannathan Sundararajan e9d5123d37 8015969: Needs to enforce and document that global "context" and "engine" can't be modified when running via jsr223
Reviewed-by: hannesw, jlaskey
2013-06-25 17:31:19 +05:30
Athijegannathan Sundararajan 81d5a4107a 8015959: Can't call foreign constructor
Reviewed-by: jlaskey, hannesw
2013-06-24 19:06:01 +05:30
James Laskey 9fbabf6b05 8017448: JDK-8010732.js.EXPECTED truncated
Reviewed-by: sundar
2013-06-22 10:12:19 -03:00
James Laskey b963805954 8010732: BigDecimal, BigInteger and Long handling in nashorn
Reviewed-by: sundar
2013-06-21 14:34:00 -03:00
Athijegannathan Sundararajan f5460159e5 8017046: Cannot assign undefined to a function argument if the function uses arguments object
Reviewed-by: hannesw
2013-06-20 13:45:38 +05:30
Athijegannathan Sundararajan e4025899fa 8015347: Parsing issue with decodeURIComponent
Reviewed-by: jlaskey, hannesw
2013-06-19 21:07:59 +05:30
James Laskey 353aa488ce 8010697: DeletedArrayFilter seems to leak memory
Reviewed-by: hannesw, sundar
2013-06-19 09:10:49 -03:00
Athijegannathan Sundararajan 47eba2d2e0 8016550: nashorn.option.no.syntax.extensions has the wrong default
Reviewed-by: hannesw, lagergren
2013-06-17 13:56:05 +05:30
Athijegannathan Sundararajan 060dfe2898 8016618: script mirror object access should be improved
Reviewed-by: jlaskey, lagergren
2013-06-14 21:16:14 +05:30
Marcus Lagergren 96fbb88df3 8016235: Use in catch block that may not have been executed in try block caused illegal byte code to be generated
Reviewed-by: jlaskey, hannesw
2013-06-14 13:53:40 +02:00
Hannes Wallnöfer 7face9458c 8016542: String.prototype.replace called with function argument should not replace $ patterns
Reviewed-by: lagergren, jlaskey
2013-06-13 20:50:24 +02:00
Hannes Wallnöfer 5b154a5b4f 8016528: Hex code from escape() should be padded
Reviewed-by: jlaskey, lagergren
2013-06-13 15:26:49 +02:00
Hannes Wallnöfer dda2826464 8016518: Parsing of octal string escapes is broken
Reviewed-by: sundar, lagergren
2013-06-13 12:52:09 +02:00
Athijegannathan Sundararajan 16d0a965fa 8015355: Array.prototype functions don't honour non-writable length and / or index properties
Reviewed-by: lagergren, hannesw
2013-06-13 16:08:35 +05:30
Hannes Wallnöfer 3d767bca1b 8011893: JS Object builtin prototype is not thread safe
Reviewed-by: sundar, jlaskey
2013-06-12 16:41:38 +02:00
Athijegannathan Sundararajan bdb8adea29 8015357: a = []; a[0x7fffffff]=1; a.sort()[0] should evaluate to 1 instead of undefined
Reviewed-by: hannesw, lagergren
2013-06-11 13:09:43 +05:30
Athijegannathan Sundararajan 053ba4e20d 8016239: loadWithNewGlobal should support user supplied arguments from the caller
Reviewed-by: lagergren, attila, jlaskey
2013-06-10 19:54:07 +05:30
Marcus Lagergren 1b1f02c19e 8016226: backing out test without third party license approval
Reviewed-by: attila, sundar
2013-06-10 13:27:07 +02:00
Marcus Lagergren 6a2a3f6704 8015892: canBeUndefined too conservative for some use before declaration cases
Reviewed-by: attila, hannesw
2013-06-10 13:21:29 +02:00
Hannes Wallnöfer ce78a8a932 8012291: NativeArray is inconsistent in using long for length and index in some places and int for the same in other places
Reviewed-by: lagergren, jlaskey
2013-06-07 17:44:25 +02:00
Athijegannathan Sundararajan c2900ab304 8015346: JSON parsing issues with escaped strings, octal, decimal numbers
Reviewed-by: hannesw, jlaskey
2013-06-06 21:41:20 +05:30
Hannes Wallnöfer 40901eeec2 8015350: Array.prototype.reduceRight issue with large length and index
Reviewed-by: attila, sundar, lagergren
2013-06-05 12:44:24 +02:00
Athijegannathan Sundararajan b741beb138 8015945: loadWithNewGlobal return value has to be properly wrapped
Reviewed-by: lagergren, hannesw
2013-06-05 12:08:49 +05:30
Athijegannathan Sundararajan 6886336fa6 8015830: Javascript mapping of ScriptEngine bindings does not expose keys
Reviewed-by: jlaskey, lagergren
2013-06-04 22:31:48 +05:30
Athijegannathan Sundararajan 6189769558 8015855: test/script/basic/JDK-8012164.js fails on Windows
Reviewed-by: hannesw, lagergren, jlaskey
2013-06-04 17:33:14 +05:30
James Laskey f788b6d3f6 8015741: Need a global.load function that starts with a new global scope
Reviewed-by: sundar, lagergren
2013-06-03 08:34:29 -03:00
Athijegannathan Sundararajan 40faec4d9d 8015345: Function("}),print('test'),({") should throw SyntaxError
Reviewed-by: lagergren, hannesw, jlaskey
2013-06-03 15:58:14 +05:30
Athijegannathan Sundararajan 0e6bee19f8 8012164: Error.stack needs trimming
Reviewed-by: lagergren, jlaskey
2013-05-31 17:39:12 +05:30
Athijegannathan Sundararajan 088d541d8b 8015353: Date.parse illegal string parsing issues
Reviewed-by: jlaskey, lagergren
2013-05-30 16:49:46 +05:30
James Laskey 48cfa4cb5a 8015636: Add more typed arrays code coverage tests
Reviewed-by: sundar
2013-05-29 16:23:50 -03:00
Athijegannathan Sundararajan c48e92a780 8015349: "abc".lastIndexOf("a",-1) should evaluate to 0 and not -1
Reviewed-by: lagergren, attila, jlaskey
2013-05-29 21:27:10 +05:30
Marcus Lagergren b0c280785d 8011023: Math round didn't conform to ECMAScript 5 spec
Reviewed-by: jlaskey, attila
2013-05-29 14:08:00 +02:00
Marcus Lagergren cbb053f7fb 8015447: Octane harness fixes for rhino and entire test runs: ant octane, ant octane-v8, ant octane-rhino
Reviewed-by: sundar, jlaskey
2013-05-27 17:57:07 +02:00
Athijegannathan Sundararajan d13ac3d3d5 8015352: "i".toUpperCase() => currently returns "İ", but should be "I" (with Turkish locale)
Reviewed-by: jlaskey, lagergren
2013-05-27 20:41:34 +05:30
Marcus Lagergren b493faa2d8 Merge 2013-05-27 13:12:11 +02:00
Marcus Lagergren 6a392f4027 8014219: Make the run-octane harness more deterministic by not measuring elapsed time every iteration. Also got rid of most of the run logic in base.js and call benchmarks directly for the same purpose
Reviewed-by: jlaskey, attila
2013-05-27 13:11:13 +02:00
Hannes Wallnöfer 11468d556f 8015348: RegExp("[") results in StackOverflowError
Reviewed-by: sundar, attila
2013-05-27 12:26:39 +02:00
Athijegannathan Sundararajan 332e51a6bb 8015354: JSON.parse should not use [[Put]] but use [[DefineOwnProperty]] instead
Reviewed-by: lagergren, hannesw
2013-05-24 18:39:25 +05:30
Marcus Lagergren f83e919989 8012083: Array literal constant folding issue
Reviewed-by: attila, jlaskey
2013-05-23 13:10:58 +02:00
Attila Szegedi 52a4d3c8b2 8015267: Allow conversion of JS arrays to Java List/Deque
Reviewed-by: lagergren, sundar
2013-05-23 12:01:35 +02:00
Hannes Wallnöfer c77f6c77d4 8010804: Review long and integer usage conventions
Reviewed-by: jlaskey, sundar
2013-05-22 16:43:48 +02:00
Athijegannathan Sundararajan adcd7d1aff 8014735: Typed Array, BYTES_PER_ELEMENT should be a class property
Reviewed-by: lagergren, jlaskey
2013-05-22 19:33:08 +05:30
Attila Szegedi 11ec013b8d 8014953: Have NativeJavaPackage throw a ClassNotFoundException when invoked
Reviewed-by: jlaskey, sundar
2013-05-21 13:40:12 +02:00
Attila Szegedi 5d5bca4ae5 8014797: rename Java.toJavaArray/toJavaScriptArray to Java.to/from, respectively
Reviewed-by: jlaskey, sundar
2013-05-20 21:25:14 +02:00
Marcus Lagergren ae8734143b 8006069: Range analysis first iteration, runtime specializations
Reviewed-by: jlaskey, sundar
2013-05-20 16:38:38 +02:00
Konstantin Shefov a4f54f441d 8014823: Reprise - Smoke test fail: Windows JDK-8008554.js - access denied ("java.io.FilePermission" "//C/aurora/sandbox/nashorn~source/test/script/basic/NASHORN-99.js" "read")
Reviewed-by: jlaskey
2013-05-17 16:44:22 -03:00
Marcus Lagergren fffb35cbc2 8013919: Original exception no longer thrown away when a finally rethrows
Reviewed-by: jlaskey, sundar
2013-05-16 13:44:25 +02:00
Attila Szegedi 9da19b1b6d 8014647: Allow class-based overrides to be initialized with a ScriptFunction
Reviewed-by: hannesw, jlaskey, sundar
2013-05-15 20:21:59 +02:00
James Laskey f06f2a3e52 8014648: Exclude testing and infrastructure packages from code coverage, round two
Reviewed-by: sundar
2013-05-15 12:09:38 -03:00
Athijegannathan Sundararajan 3685969224 8012305: Function.bind can't be called on prototype function inside constructor
Reviewed-by: lagergren, attila
2013-05-15 19:45:16 +05:30
Marcus Lagergren b32558e9a7 8014426: Original exception no longer thrown away when a finally rethrows
Reviewed-by: attila, jlaskey
2013-05-14 19:56:35 +02:00
Attila Szegedi 383e211c44 8011718: binding already bound function with extra arguments fails
Reviewed-by: jlaskey, sundar
2013-05-14 19:18:17 +02:00
Marcus Lagergren b160091ade 8013914: Removed explicit LineNumberNodes that were too brittle when code moves around, and also introduced unnecessary footprint. Introduced the Statement node and fixed dead code elimination issues that were discovered by the absense of labels for LineNumberNodes
Reviewed-by: jlaskey, attila
2013-05-07 14:43:17 +02:00
Hannes Wallnöfer c6db4d2a03 8013874: Function argument's prototype seem cached and wrongly reused
Reviewed-by: jlaskey
2013-05-03 22:50:51 +02:00
Hannes Wallnöfer 43cd5160dd 8013873: Regexp regression for escaped dash in character class
Reviewed-by: jlaskey
2013-05-03 22:48:53 +02:00
Hannes Wallnöfer 3d3dacd0ea 8013878: ClassCastException in Regex
Reviewed-by: jlaskey
2013-05-03 22:47:23 +02:00
Marcus Lagergren ce70e6a95d 8013477: Node.setSymbol needs to be copy on write - enable IR snapshots for recompilation based on callsite type specialization. [not enabled by default, hidden by a flag for now]
Reviewed-by: jlaskey, hannesw
2013-05-03 15:33:54 +02:00
Hannes Wallnöfer aad82c7b91 8013729: SwitchPoint invalidation not working over prototype chain
Reviewed-by: lagergren, sundar
2013-05-02 09:19:44 +02:00
Attila Szegedi 33cbb83b12 8008814: Configurable ignore/warning/error behavior for function declaration as statement
Reviewed-by: jlaskey, sundar
2013-04-29 23:22:20 +02:00
Athijegannathan Sundararajan fe2a152258 8013444: JSON.parse does not invoke "reviver" callback as per spec
Reviewed-by: jlaskey, hannesw
2013-04-29 18:40:40 +05:30
Athijegannathan Sundararajan 1700f6fb54 8013337: Issues with Date.prototype's get, set functions
Reviewed-by: jlaskey, hannesw, lagergren
2013-04-26 18:31:42 +05:30
Attila Szegedi 404c83da33 8013325: function named 'arguments' should set DEFINES_ARGUMENTS flag in its parent, not itself
Reviewed-by: hannesw, sundar
2013-04-26 09:20:37 +02:00
Attila Szegedi 64b4df9248 8013167: Vararg constructor not found
Reviewed-by: jlaskey, lagergren, sundar
2013-04-25 15:31:23 +02:00
Hannes Wallnöfer f495c8b9f3 8013131: Various compatibility issues in String.prototype.split()
Reviewed-by: lagergren, jlaskey
2013-04-25 14:20:23 +02:00
Hannes Wallnöfer 691cf54e57 8008238: Labeled break in finally causes stack overflow in Node copy
Reviewed-by: lagergren, attila
2013-04-24 13:36:31 +02:00
Hannes Wallnöfer 9e818775ef 8012931: NativeDate.safeToString() throws RangeError for invalid date
Reviewed-by: lagergren, attila
2013-04-24 13:34:22 +02:00
Hannes Wallnöfer 8bf1b1cb9c 8012334: ToUint32, ToInt32, and ToUint16 don't conform to spec
Reviewed-by: lagergren, attila
2013-04-24 13:28:25 +02:00
James Laskey 18ad0aa203 8011578: -Dnashorn.unstable.relink.threshold=1 causes tests to fail
Reviewed-by: sundar, lagergren
2013-04-20 08:54:13 -03:00
Marcus Lagergren ebad1dc34d 8010701: Immutable nodes - final iteration
Reviewed-by: sundar, hannesw, jlaskey
2013-04-19 16:11:16 +02:00
Hannes Wallnöfer d2fc3d537a 8012460: RegExp regression
Reviewed-by: jlaskey, sundar
2013-04-18 14:25:45 +02:00
Athijegannathan Sundararajan 65adccc0ce 8012462: Date.prototype.toJSON does not handle non-Date 'this' as per the spec
Reviewed-by: jlaskey, hannesw
2013-04-18 15:50:30 +05:30
Athijegannathan Sundararajan 54b929b349 8012457: Function.prototype.apply should accept any array-like argument for function arguments
Reviewed-by: lagergren, jlaskey
2013-04-17 16:52:06 +05:30
Athijegannathan Sundararajan 7cc7dc2d19 8012240: Array.prototype.map.call({length: -1, get 0(){throw 0}}, function(){}).length does not throw error
Reviewed-by: lagergren, jlaskey
2013-04-15 20:12:50 +05:30
Hannes Wallnöfer 0e49b64b83 8011980: Allow NUL character in character class
Reviewed-by: sundar, lagergren
2013-04-11 12:16:39 +02:00
Athijegannathan Sundararajan 9170d68b5a 8011974: Comparator function returning negative and positive Infinity does not work as expected with Array.prototype.sort
Reviewed-by: hannesw, lagergren
2013-04-11 15:04:55 +05:30
Athijegannathan Sundararajan 30fdece570 8011960: [2,1].sort(null) should throw TypeError
Reviewed-by: hannesw, lagergren
2013-04-11 13:20:03 +05:30
Hannes Wallnöfer ad7e2cd8de 8011756: Wrong characters supported in RegExp \c escape
Reviewed-by: lagergren, attila
2013-04-10 14:08:00 +02:00
Hannes Wallnöfer 3c60983c02 8011749: Bugs with empty character class handling
Reviewed-by: lagergren, attila
2013-04-10 14:05:11 +02:00
Hannes Wallnöfer ab923e74bf 8011714: Regexp decimal escape handling still not correct
Reviewed-by: lagergren, attila
2013-04-10 14:00:11 +02:00
Hannes Wallnöfer bc7905ab3a 8009230: Nashorn rejects extended RegExp syntax accepted by all major JS engines
Reviewed-by: jlaskey, lagergren
2013-04-05 19:50:10 +02:00
Attila Szegedi 35f9ab2054 8011555: Invalid class name in with block with JavaImporter causes MH type mismatch
Reviewed-by: jlaskey, lagergren
2013-04-04 18:32:00 +02:00
Athijegannathan Sundararajan 194f867e24 8011552: Arrays with missing elements are not properly sorted
Reviewed-by: jlaskey, lagergren
2013-04-04 20:46:31 +05:30
Attila Szegedi a6439d2b72 Merge 2013-04-04 15:55:42 +02:00
Attila Szegedi 5a45a7da03 8011544: Allow subclassing Java classes from script without creating instances
Reviewed-by: jlaskey, sundar
2013-04-04 15:53:26 +02:00
Athijegannathan Sundararajan 76f2aa79e6 8011543: "".split(undefined,{valueOf:function(){throw 2}}) does not throw exception
Reviewed-by: lagergren, jlaskey
2013-04-04 18:30:30 +05:30
Athijegannathan Sundararajan e20dc52ab2 8011421: When using Object.defineProperty on arrays, PropertyDescriptor's property accessors are invoked multiple times
Reviewed-by: lagergren, hannesw
2013-04-04 13:54:51 +05:30
Athijegannathan Sundararajan 2b494aafd9 8011394: RegExp.prototype.test() does not call valueOf on lastIndex property as per the spec
Reviewed-by: lagergren, jlaskey, hannesw
2013-04-04 10:24:46 +05:30
Athijegannathan Sundararajan 84f1ee1581 8011382: Data prototype methods and constructor do not call user defined toISOString, valueOf methods per spec
Reviewed-by: lagergren, jlaskey
2013-04-03 20:17:05 +05:30
Athijegannathan Sundararajan a85fab2730 8011365: Array.prototype.join and Array.prototype.toString do not throw TypeError on null, undefined
Reviewed-by: attila, hannesw, lagergren
2013-04-03 15:27:28 +05:30
Attila Szegedi 7891ed4115 8011362: Overloaded method resolution foiled by nulls
Reviewed-by: hannesw, sundar
2013-04-03 11:13:08 +02:00
Athijegannathan Sundararajan d35b6ae5f6 8011357: Array.prototype.slice and Array.prototype.splice should not call user defined valueOf of start, end arguments more than once
Reviewed-by: lagergren, hannesw
2013-04-03 11:41:42 +05:30
Athijegannathan Sundararajan e96d207c68 8011274: Object.getOwnPropertyDescriptor(function(){"use strict"},"caller").get.hasOwnProperty("prototype") should be false
Reviewed-by: lagergren, jlaskey
2013-04-02 23:01:10 +05:30
Athijegannathan Sundararajan fcc548f01d 8011237: Object.isExtensible(Object.getOwnPropertyDescriptor(function(){"use strict"},"caller").get) should be false
Reviewed-by: lagergren, jlaskey
2013-04-02 20:42:03 +05:30
Athijegannathan Sundararajan da76d3b5ec 8011209: Object.getOwnPropertyDescriptor(function(){"use strict"},"caller").get.length is not 0
Reviewed-by: lagergren, hannesw, jlaskey
2013-04-02 17:40:53 +05:30
Marcus Lagergren fec16029ea 8010995: The bug ID 8010710 accidentally got two digits transposed in the checkin and unit test name
Reviewed-by: hannesw, sundar
2013-03-29 08:55:05 +01:00
Athijegannathan Sundararajan bf6e4f1ec7 8010924: Dealing with undefined property gets you a fatal stack
Reviewed-by: lagergren, jlaskey
2013-03-28 20:48:25 +05:30
Athijegannathan Sundararajan 97d7f98a21 8010720: Linkage problem with java.lang.String.length()
Reviewed-by: hannesw, lagergren
2013-03-26 18:26:19 +05:30
Athijegannathan Sundararajan a9423b7ebf 8010709: org on the top level doesn't resolve
Reviewed-by: lagergren, hannesw
2013-03-25 18:20:16 +05:30
Marcus Lagergren 897aab045e 8017010: index evaluation to a temporary location for index operator much change temporaries to slots, but never scoped vars
Reviewed-by: hannesw, sundar
2013-03-25 12:01:06 +01:00
Attila Szegedi 7188961426 8010652: Eliminate non-child references in Block/FunctionNode, and make few node types immutable
Reviewed-by: jlaskey, lagergren
2013-03-23 00:58:39 +01:00
Athijegannathan Sundararajan c846064c8f 8010199: javax.script.Invocable implementation for nashorn does not return null when matching functions are missing
Reviewed-by: lagergren, jlaskey
2013-03-18 21:03:11 +05:30
Marcus Lagergren e05970ca52 8010147: Forgot to add EXPECTED files for lazy and eager sunspider test
Reviewed-by: sundar, jlaskey
2013-03-15 16:07:13 +01:00
Marcus Lagergren 2aeaf10fff 8009982: Lazy execution bugfix. Added lazy sunspider unit test. Added mandreel to compile-octane test. Fixed warnings
Reviewed-by: sundar, jlaskey
2013-03-14 14:49:55 +01:00
Athijegannathan Sundararajan d671cda73c 8009868: For loop with "true" as condition results in AssertionError in codegen
Reviewed-by: jlaskey, hannesw, lagergren
2013-03-12 21:17:47 +05:30
Athijegannathan Sundararajan bb6c34adc7 8009757: Package access clean up and refactoring
Reviewed-by: jlaskey, lagergren, attila
2013-03-12 18:12:42 +05:30
Athijegannathan Sundararajan 4f3800def1 8009553: Object.create(Array.prototype) doesn't respect reset length
Reviewed-by: jlaskey, lagergren
2013-03-06 22:38:18 +05:30
Hannes Wallnöfer 242e864599 8008370: coffee script compiler doesn't work with Nashorn
Reviewed-by: lagergren, attila
2013-03-04 11:44:54 +01:00
Attila Szegedi 0248a98842 8006984: Introducing local into a function inside with statement confuses its scope
Reviewed-by: jlaskey, lagergren, sundar
2013-02-25 16:51:04 +01:00
Marcus Lagergren 90b971a60d 8008554: load was broken for URLs
Reviewed-by: attila, sundar
2013-02-22 08:57:22 +01:00
Athijegannathan Sundararajan be8f1b2b35 8008448: Add coverage test for jdk.nashorn.internal.ir.debug.JSONWriter
Reviewed-by: jlaskey, attila
2013-02-19 20:33:07 +05:30
Athijegannathan Sundararajan 350c3e01c1 8008387: Improve code coverage tests for JSObjectLinker and NashornBottomLinker
Reviewed-by: lagergren, jlaskey, hannesw
2013-02-18 20:41:12 +05:30
Athijegannathan Sundararajan 1fb8213bb0 8008298: Add tests to cover specialized versions of Math functions
Reviewed-by: jlaskey, lagergren
2013-02-15 20:40:05 +05:30
Athijegannathan Sundararajan c09d1ba6d7 8008291: Add more tests for better coverage of objects, scripting and parser packages
Reviewed-by: lagergren, jlaskey
2013-02-15 18:30:19 +05:30
Hannes Wallnöfer 8edbed784d 8008215: break in catch clause causes java.lang.VerifyError: Inconsistent stackmap
Reviewed-by: jlaskey, lagergren
2013-02-15 09:18:05 +01:00
Hannes Wallnöfer 6aeeee6b63 8008198: java.lang.AssertionError: Invalid break target class jdk.nashorn.internal.ir.TryNode
Reviewed-by: attila, jlaskey
2013-02-14 14:07:53 +01:00
Attila Szegedi 85c55a2aa4 8007990: No access to interface methods on a restricted class
Reviewed-by: jlaskey, lagergren, sundar
2013-02-14 13:51:54 +01:00