Commit Graph

139 Commits

Author SHA1 Message Date
Thomas Schatzl 3a227e7886 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
When G1 is run with -XX:-G1DeferredRSUpdate, the VM crashes because of wrong initialization order of member variables. The change makes the initalization explicit, not relying on initialization order any more.

Reviewed-by: brutisso, mgerdin
2014-07-21 09:41:06 +02:00
Andrey Zakharov 2ebb3718c2 8026847: [TESTBUG] gc/g1/TestSummarizeRSetStats* tests launch 32bit jvm with UseCompressedOops
The test launched a 32 bit VM with UseCompressedOops enabled. This is not supported on 32 bit VMs, causing a test failure. Investigation showed that the use of this flag is not required at all, so simply remove it.

Reviewed-by: tschatzl, jwilhelm
2014-07-21 09:40:19 +02:00
Thomas Schatzl 297f319bf8 8019342: G1: High "Other" time most likely due to card redirtying
Parallelize card redirtying to decrease the time it takes.

Reviewed-by: brutisso
2014-07-21 09:40:19 +02:00
Bengt Rutisson 9de9d95e24 8049327: [TESTBUG] gc/logging/TestGCId.java assumes default PrintGCID value is true
Reviewed-by: ehelin, tschatzl
2014-07-07 14:44:33 +02:00
Bengt Rutisson 08cdf9431c 8043607: Add a GC id as a log decoration similar to PrintGCTimeStamps
Reviewed-by: jwilhelm, ehelin, tschatzl
2014-06-19 13:31:14 +02:00
Erik Helin 8e85dd4454 8042933: assert(capacity_until_gc >= committed_bytes) failed
Reviewed-by: stefank, jmasa
2014-06-13 08:44:11 +02:00
Per Lidén 9d63a03e7c 8042310: TestStringDeduplicationMemoryUsage test failing
Reviewed-by: ehelin, jwilhelm
2014-05-30 10:43:51 +02:00
Per Lidén bed7a5e664 8038461: Test gc/g1/TestStringDeduplicationMemoryUsage.java fails with unexpected memory usage
Reviewed-by: jmasa, sjohanss
2014-04-03 10:39:27 +02:00
Yasumasa Suenaga e00446818f 7090324: gclog rotation via external tool
GC log rotation can be set via java command line, but customer sometime need to sync with OS level rotation setting.

Reviewed-by: sla, minqi, ehelin
2014-03-31 13:09:35 -07:00
Per Lidén e9acbd7c38 8029075: String deduplication in G1
Implementation of JEP 192, http://openjdk.java.net/jeps/192

Reviewed-by: brutisso, tschatzl, coleenp
2014-03-18 19:07:22 +01:00
Thomas Schatzl 95b44732e5 Merge 2014-03-24 08:05:53 -07:00
Thomas Schatzl f5bf8669db 8035654: Add times for evacuation failure handling in "Other" time
Detailed breakdown of time spent in the evacuation failure handling phases to make the "Other" time roughly correspond to the sum of its parts.

Reviewed-by: jwilhelm, jmasa
2014-03-24 15:30:46 +01:00
Thomas Schatzl aabfd5d2b8 8035398: Add card redirty time in "Other" time in G1
Show the time taken by card redirtying during GC in a new "Redirty Cards" line.

Reviewed-by: jwilhelm, brutisso
2014-03-24 15:30:40 +01:00
Thomas Schatzl 84b78d9a81 8027295: Free CSet takes ~50% of young pause time
Improve fast card cache iteration and avoid taking locks when freeing the collection set.

Reviewed-by: brutisso
2014-03-24 15:30:36 +01:00
Thomas Schatzl 04075dff2c 8035406: Improve data structure for Code Cache remembered sets
Change the code cache remembered sets data structure from a GrowableArray to a chunked list of nmethods. This makes the data structure more amenable to parallelization, and decreases freeing time.

Reviewed-by: mgerdin, brutisso
2014-03-24 15:30:14 +01:00
Andrey Zakharov bbfffe4e31 8037510: CMM Testing: Min/MaxHeapFreeRatio flags should be manageable through the API
Added tests for Min/MaxHeapFreeRatio flags

Reviewed-by: jwilhelm, tschatzl
2014-03-20 16:31:47 +01:00
Thomas Schatzl 0d958d12f2 8032771: The flag VerifySilently misses a test case
Add test case for the VerifySilently flag.

Reviewed-by: brutisso
2014-01-31 09:55:59 +01:00
Thomas Schatzl 0ed35536e3 8027476: Improve performance of Stringtable unlink
8027455: Improve symbol table scan times during gc pauses

Parallelize string table and symbol table scan during remark and full GC. Some additional statistics output if the experimental flag G1TraceStringSymbolTableScrubbing is set.

Reviewed-by: mgerdin, coleenp, brutisso
2014-01-20 11:47:07 +01:00
Mikael Vidstedt e64b2eeaa0 8029233: Update copyright year to match last edit in jdk8 hotspot repository for 2013
Copyright year updated for files modified during 2013

Reviewed-by: twisti, iveresov
2013-12-24 11:48:39 -08:00
Thomas Schatzl 6f46da6198 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
Change checks for isHumongous() to continuesHumongous() as installing a code root for a humongous object is valid, but not for continuations of humongous objects. Cleaned up asserts.

Reviewed-by: jmasa, tamao
2013-11-07 15:17:10 +01:00
Jesper Wilhelmsson 0fa3a71c8a 8016309: assert(eden_size > 0 && survivor_size > 0) failed: just checking
7057939: jmap shows MaxNewSize=4GB when Java is using parallel collector

Major cleanup of the collectorpolicy classes

Reviewed-by: tschatzl, jcoomes
2013-11-01 17:09:38 +01:00
Bengt Rutisson f12f991935 8027132: Print deprecation warning message for the flags controlling the CMS foreground collector
Reviewed-by: stefank, ehelin, ysr, tschatzl
2013-10-28 13:27:57 +01:00
Stefan Karlsson ddd9098a27 8026781: Add missing test to exercise -XX:+UseLargePagesInMetaspace
Reviewed-by: mgerdin, brutisso
2013-10-21 09:34:10 +02:00
Stefan Karlsson 9f6e8976d0 Merge 2013-10-15 07:10:09 -07:00
Per Lidén c6e227a3e6 8024634: gc/startup_warnings tests can fail due to unrelated warnings
Reviewed-by: brutisso, jwilhelm, tamao
2013-10-15 11:44:47 +02:00
Per Lidén 908dd54639 8023158: hotspot/test/gc/7168848/HumongousAlloc.java fails 14 full gcs, expect 0 full gcs
Reviewed-by: brutisso, tschatzl
2013-10-15 11:38:47 +02:00
Stefan Johansson 3e9df3ecf1 8025661: Ill-formed -Xminf and -Xmaxf options values interpreted as 0
Using strtod() instead of atof() when parsing -Xminf and -Xmaxf.

Reviewed-by: brutisso, pliden
2013-10-14 14:21:34 +02:00
Erik Helin ac15ca0d6a Merge 2013-10-02 18:24:58 +02:00
Mikael Gerdin 9204842093 8012525: gc/metaspace/G1AddMetaspaceDependency.java Test fails a safepoint timeout assertion or hangs
Reviewed-by: brutisso, tschatzl
2013-10-02 14:33:32 +02:00
Thomas Schatzl f144f37f49 8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
The initialization for the remembered set summary data structures used the wrong thread count, i.e. number of worker threads instead of number of refinement threads.

Reviewed-by: brutisso
2013-09-30 12:43:59 +02:00
Erik Helin 2722c5d966 8025226: TestPerfCountersAndMemoryPools.java fails with -Xmixed or -Xcomp
Reviewed-by: brutisso, mgerdin
2013-09-30 11:39:07 +02:00
Thomas Schatzl bd9ffce267 8014078: G1: improve remembered set summary information by providing per region type information
Add memory consumption breakdown on a per region type in the G1 remembered set summary statistics. This simplifies remembered set memory consumption analysis.

Reviewed-by: brutisso
2013-09-26 12:49:45 +02:00
Niclas Adlertz afef481831 Merge 2013-09-19 18:01:39 +02:00
Thomas Schatzl 3111ab9115 Merge 2013-09-18 15:59:41 +02:00
Thomas Schatzl 3e4a59f797 8024662: gc/arguments/TestUseCompressedOopsErgo.java does not compile
Fix compilation error and use of an outdated VM option in the test

Reviewed-by: stefank, jwilhelm
2013-09-18 10:02:19 +02:00
Erik Helin 2cab7ea037 8024718: Metaspace performance counters and memory pools should report the same data
Reviewed-by: stefank, dholmes, coleenp
2013-09-17 20:59:07 +02:00
Christian Tornqvist 0051ace82a 8014905: [TESTBUG] Some hotspot tests should be updated to divide test jdk and compile jdk
Change JDKToolFinder to look in compile.jdk if the executable cannot be found in test.jdk

Reviewed-by: dholmes, hseigel
2013-09-17 16:55:53 +02:00
Thomas Schatzl 05929860a5 Merge 2013-09-16 13:32:44 +02:00
Thomas Schatzl 3184042cd1 8024396: VM crashing with assert(!UseLargePages || UseParallelOldGC || use_large_pages) failed: Wrong alignment to use large pages
Loosen wrong assert for UseParallelOldGC to UseParallelGC

Reviewed-by: stefank, brutisso
2013-09-16 10:20:45 +02:00
Thomas Schatzl b4e927d2a9 Merge 2013-09-16 09:41:03 +02:00
Stefan Karlsson 860b5dcec7 8024650: Don't adjust MaxMetaspaceSize up to MetaspaceSize
Reviewed-by: jwilhelm, brutisso, tschatzl
2013-09-13 22:22:14 +02:00
Thomas Schatzl 962008f22b 8010722: assert: failed: heap size is too big for compressed oops
Use conservative assumptions of required alignment for the various garbage collector components into account when determining the maximum heap size that supports compressed oops. Using this conservative value avoids several circular dependencies in the calculation.

Reviewed-by: stefank, dholmes
2013-09-11 16:25:02 +02:00
Thomas Schatzl 87a98b7267 8021823: G1: Concurrent marking crashes with -XX:ObjectAlignmentInBytes>=32 in 64bit VMs
Correctly calculate the initialization value for the shift between object start and bitmap bit in the G1 mark bitmaps.

Reviewed-by: tonyp
2013-09-11 10:19:16 +02:00
Igor Ignatyev c73d393947 8012447: Java CTW implementation
Reviewed-by: vlivanov, kvn, twisti
2013-09-05 16:38:04 +04:00
Erik Helin 30f059b5fc 8015107: NPG: Use consistent naming for metaspace concepts
Reviewed-by: coleenp, mgerdin, hseigel
2013-08-12 17:37:02 +02:00
Erik Helin 3ea9481c2f 8014659: NPG: performance counters for compressed klass space
Reviewed-by: mgerdin, coleenp, hseigel, jmasa, ctornqvi
2013-08-07 16:47:32 +02:00
Bengt Rutisson a1e1caf8ba 8021879: G1: G1HeapRegionSize flag value not updated correctly
Reviewed-by: tschatzl, jmasa
2013-08-01 09:35:04 +02:00
Bengt Rutisson 5a10114616 8021967: Deprecate -XX:DefaultMaxRAMFraction
Reviewed-by: tschatzl, jmasa, kvn, tamao
2013-08-01 07:03:07 +02:00
Thomas Schatzl 93e5db7033 8020123: Test gc/g1/TestPrintRegionRememberedSetInfo.java fails with "test result: Error. No action after @build"
Remove the @build tag and replace it by a @run tag so that the test gets executed

Reviewed-by: brutisso, mgerdin
2013-07-24 10:07:37 +02:00
Tao Mao 7109e85e43 8017611: Auto corrector for mistyped vm options
The auto corrector for mistyped vm options fuzzy-matches existing flags based on string similarity (Dice's coefficient).

Reviewed-by: kvn, dsamersoff, hseigel, johnc
2013-06-28 20:18:04 -07:00
Erik Helin 604a75ff30 8013590: NPG: Add a memory pool MXBean for Metaspace
Reviewed-by: jmasa, mgerdin
2013-06-26 16:58:37 +02:00
Jon Masamitsu ca3a1be3fe 8014851: UseAdaptiveGCBoundary is broken
Reviewed-by: tschatzl, brutisso
2013-06-25 15:17:11 -07:00
Thomas Schatzl 54964edefa 8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
Fixed the output of G1SummarizeRSetStats: too small datatype for the number of concurrently processed cards, added concurrent remembered set thread time retrieval for Linux and Windows (BSD uses os::elapsedTime() now), and other cleanup. The information presented during VM operation is now relative to the previous output, not always cumulative if G1SummarizeRSetStatsPeriod > 0. At VM exit, the code prints a cumulative summary.

Reviewed-by: johnc, jwilhelm
2013-05-28 09:32:06 +02:00
Thomas Schatzl b8276670c2 8014765: VM exits if MaxTenuringThreshold is set below the default InitialTenuringThreshold, and InitialTenuringThreshold is not set
The VM exits when the condition in the subject line applies. The fix sets InitialTenuringThreshold to MaxTenuringThreshold if it is larger than MaxTenuringThreshold and InitialTenuringThreshold has not been set (is default).

Reviewed-by: jwilhelm, jmasa, brutisso, johnc
2013-05-16 23:51:51 +02:00
John Cuthbertson 5838d847a1 8010738: G1: Output for full GCs with +PrintGCDetails should contain perm gen size/meta data change info
Include metaspace information (used, allocated, reserved) in the PrintGCDetails output for full GCs.

Reviewed-by: poonam, jmasa, brutisso
2013-05-16 09:24:26 -07:00
Thomas Schatzl 5ebe77bb6b 8014240: G1: Add remembered set size information to output of G1PrintRegionLivenessInfo
Improve the output of G1PrintRegionLivenessInfo by adding a per-region remembered set size information column

Reviewed-by: jwilhelm, johnc
2013-05-16 13:02:33 +02:00
Thomas Schatzl 9ce9586188 8014489: tests/gc/arguments/Test(Serial|CMS|Parallel|G1)HeapSizeFlags jtreg tests invoke wrong class
Some jtreg tests reference unknown classes in the @run and @build lines. This change fixes them.

Reviewed-by: stefank, ehelin
2013-05-14 17:08:31 +02:00
Thomas Schatzl 9cfde1acc3 8014058: Regression tests for 8006088
The patch for 8006088 misses regression tests after a merge error, this CR provides them.

Reviewed-by: jwilhelm, tamao, jmasa
2013-05-13 09:45:33 +02:00
Jon Masamitsu bbff951f67 8013184: CMS: Call reset_after_compaction() only if a compaction has been done
Reviewed-by: mgerdin, johnc, tschatzl
2013-05-08 17:12:52 -07:00
Jon Masamitsu 973d0400c4 8013032: CMS: assert(used() == used_after_gc && used_after_gc <= capacity()) failed: used: 0 used_after_gc: 292080 capacity: 1431699456
Reviewed-by: tschatzl, mgerdin, johnc
2013-05-08 16:28:03 -07:00
Bengt Rutisson a8ad116e49 8013872: G1: HeapRegionSeq::shrink_by() has invalid assert
Refactored shrink_by() to only use region counts and not byte sizes

Reviewed-by: johnc, tschatzl
2013-05-06 21:30:34 +02:00
Bengt Rutisson 36c195270d 8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment
Make sure max alignemnt is at least as large as min alignment

Reviewed-by: johnc, jmasa, tschatzl
2013-05-06 09:16:14 +02:00
John Cuthbertson fefd60fcfd 8011898: gc/TestVerifyBeforeGCDuringStartup.java: java.lang.RuntimeException: '[Verifying' missing from stdout/stderr: [Error: Could not find or load main class]
System.getProperty("test.java.opts") can return NULL, which gets converted to to the empty string, and the child java command then interprets that as the name of the main class.

Reviewed-by: jmasa, brutisso
2013-04-26 10:57:57 -07:00
Jon Masamitsu ddbf6ad621 8012111: Remove warning about CMS generation shrinking
Reviewed-by: johnc, brutisso, stefank
2013-04-22 22:00:03 -07:00
Kevin Walls 4e6c27cef0 7109087: gc/7072527/TestFullGCCount.java fails when GC is set in command-line
Reviewed-by: mgerdin
2013-04-18 17:02:20 +01:00
Mikael Gerdin 0edccc9e61 8010196: NPG: Internal Error: Metaspace allocation lock -- possible deadlock
Refactor the CLD dependency list into a separate class. Use an ObjectLocker to synchronize additions to the CLD dependency list.

Reviewed-by: stefank, coleenp
2013-04-10 13:27:35 +02:00
Leonid Mesnik 6f3fdce7b3 8009808: TEST-BUG : test case is using bash style tests. Default shell for jtreg is bourne. thus failure
Rewrite test to use Java only instead of shell script

Reviewed-by: mgerdin, brutisso
2013-04-09 15:32:45 +02:00
John Cuthbertson 90d010120f 8011343: Add new flag for verifying the heap during startup
Perform verification during VM startup under control of new flag and within a VMOperation.

Reviewed-by: stefank, jmasa, brutisso
2013-04-05 10:20:04 -07:00
Mikael Gerdin 0a963fd1b7 Merge 2013-04-03 09:19:02 +02:00
Gary Collins c2a873f014 8009152: A number of jtreg tests need review/improvement
Added a new test_env.txt file to capture common shell variable. Added concept of COMPILEJAVA for use when TESTJAVA is a JRE. If COMPILEJAVA not set then TESTJAVA will be the default with assumption it is a JDK.

Reviewed-by: kvn, brutisso, coleenp
2013-03-27 09:49:51 -07:00
Erik Helin d67e393dd6 8009408: gc/metaspace/ClassMetaspaceSizeInJmapHeap.java fails with "exit code 1"
Reviewed-by: brutisso, sla, ctornqvi
2013-03-23 09:16:37 +01:00
John Cuthbertson 9c89e6d28a 8010463: G1: Crashes with -UseTLAB and heap verification
Some parts of the G1 heap can only be walked during a safepoint. Skip verifying these parts of the heap when verifying during JVM startup.

Reviewed-by: brutisso, tschatzl
2013-03-29 13:49:37 -07:00
Erik Helin cf6d13410c 8010818: NPG: Remove metaspace memory pools
Reviewed-by: mgerdin, stefank
2013-03-27 10:55:37 +01:00
Erik Helin 902be4665b 8000754: NPG: Implement a MemoryPool MXBean for Metaspace
Reviewed-by: jmasa, stefank
2013-03-22 16:10:01 +01:00
Erik Helin 919ef8e0df 8004924: NPG: jmap -heap output should contain ClassMetaspaceSize value
Reviewed-by: stefank, mgerdin
2013-02-06 07:48:02 +01:00
John Cuthbertson 1d1641be2f 8008188: Add regression test for 8005875
Add regression test for crash seen in 8005875. Test is run with G1 and PGCT=0 and issues "jcmd <pid> Thread.print" against itself. Without the fix for 8005875 the test will crash.

Reviewed-by: brutisso
2013-02-20 12:52:13 -08:00
Filipp Zhinkin bfe250c236 8006628: NEED_TEST for JDK-8002870
Regression test for 8000311. Verifies that PLABStats works with zero parallel GC threads.

Reviewed-by: jmasa, johnc
2013-02-19 16:22:28 -08:00
Bengt Rutisson c2f4ba73be 8006398: Add regression tests for deprectated GCs
Reviewed-by: ehelin, jwilhelm, jmasa
2013-02-14 09:11:43 +01:00
Pavel Punegov 373b8ccd27 7191926: Remove MKS dependency in Hotspot regression tests
Add case for CYGWIN in .sh files.

Reviewed-by: coleenp, kvn
2012-08-29 14:49:05 -04:00
Coleen Phillimore d52b3a7eb7 7129723: MAC: Some regression tests need to recognize Mac OS X platform
Add Darwin like Linux to shell scripts

Reviewed-by: kvn, kamg, dholmes
2012-08-01 16:52:43 -04:00
John Coomes ec1fb16e34 Merge 2012-06-01 10:29:02 -07:00
Matherey Nunez 818597ae4f 7168848: Add test to check that humongous object allocation path also checks the heap occupancy
Added test that checks humongous object allocation path also check the heap occupancy and initiate a marking cycle when / if needed.

Reviewed-by: brutisso, jwilhelm
2012-05-21 14:59:59 +02:00
Kevin Walls 8b44324ec4 7157734: hotspot test scripts not testing 64-bit JVM under JPRT/JTREG
Reviewed-by: kvn
2012-05-11 17:24:32 +01:00
Krystal Mok 24e8905fdf 7072527: CMS: JMM GC counters overcount in some cases
Avoid overcounting when CMS has concurrent mode failure.

Reviewed-by: ysr
2011-08-02 14:37:35 +01:00
Yumin Qi 5d0ad03a55 6941923: RFE: Handling large log files produced by long running Java Applications
Supply optinal flags to realize gc log rotation

Reviewed-by: ysr, jwilhelm
2011-06-10 15:08:36 -07:00
Kevin Walls 2114fddad9 6980392: TEST_BUG: gc/6581734/Test6581734.java has typo
Simple correction in testcase

Reviewed-by: mchung
2010-08-27 16:57:04 +01:00
Kevin Walls 5fb46fd5a8 6581734: CMS Old Gen's collection usage is zero after GC which is incorrect
Management code enabled for use by a concurrent collector.

Reviewed-by: mchung, ysr
2010-07-30 22:43:50 +01:00
John Coomes e379759e1b 6887948: test/gc/6845368/bigobj.java fails due to timeout
Reviewed-by: iveresov
2009-10-05 05:51:22 -07:00
John Coomes e7c70c499b 6845368: large objects cause a crash or unexpected exception
Reviewed-by: jmasa, iveresov
2009-08-13 16:22:45 -07:00