huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
aspnetcore/test/Microsoft.AspNet.Mvc.Core.Test
History
Doug Bunting 48f09d0e8d Do not trounce existing property values that are not bound in `TryUpdateModel` scenarios 
- #2836

Part 1: Use existing property values when recursing in `MutableObjectModelBinder`
- remove `ComplexModelDTO` because that indirection made fixing this issue more difficult and doesn't add value
  - started with an old closed PR (#2241) which did some of this work
- correct `MutableObjectModelBinderTest` tests that exercised behaviour that can't occur
  - the old `dto.Results` dictionary was never incomplete; nor could it contain `null` values

Part 2: Change `MutableObjectModelBinder` to pass complex property values into binding system
- model binding no longer trounces nodes in the model tree that aren't bound
- create model instances less often in `TryUpdateModel` scenarios
  - refactor `EnsureModel()` to `GetModel()` and use appropriately
- reorder logic in `SetProperty()` and `AddToProperty()` to avoid copying to / from the same collection
  - also cleans up some code duplication

nits:
- clean up `MutableObjectModelBinderTest`
  - fix odd line wrappings and indentation
  - use `nameof()` more
  - use `string.Empty` more
  - simplify a couple of `Returns()` expressions
- make assertions in `TryUpdateModelIntegrationTest` more readable
  - no need to work through `ModelStateDictionary.Keys`
  - also use `Length` instead of `Count()`; test code but we don't need Linq at all in that test class
 		2015-08-18 09:57:41 -07:00
..
ApplicationModel
…
Authorization Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
DepenencyInjection Homogenize MVC startup code patterns 2015-08-16 18:48:24 -07:00
Internal
…
ModelBinding Do not trounce existing property values that are not bound in `TryUpdateModel` scenarios 2015-08-18 09:57:41 -07:00
Properties
…
Routing
…
TestFiles Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
ActionExecutorTests.cs
…
ActionFilterAttributeTests.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
BadRequestObjectResultTests.cs React to move of StatusCodes 2015-07-08 12:43:33 -07:00
BadRequestResultTests.cs React to move of StatusCodes 2015-07-08 12:43:33 -07:00
BindAttributeTest.cs
…
ChallengeResultTest.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
ConsumesAttributeTests.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
ContentResultTest.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
ControllerActionArgumentBinderTests.cs
…
ControllerActionDescriptorBuilderTest.cs Fix #2837 - Make it easier to get ParameterInfo/PropertyInfo 2015-08-03 10:53:33 -07:00
ControllerActionDescriptorProviderTests.cs
…
ControllerActionInvokerTest.cs Add more event notification data points 2015-08-16 16:42:58 -07:00
CreatedAtActionResultTests.cs Remove IScopedInstance - use AsyncLocal for ActionContext and 2015-08-13 15:58:29 -07:00
CreatedAtRouteResultTests.cs Remove IScopedInstance - use AsyncLocal for ActionContext and 2015-08-13 15:58:29 -07:00
CreatedResultTests.cs Remove IScopedInstance - use AsyncLocal for ActionContext and 2015-08-13 15:58:29 -07:00
DefaultActionSelectorTests.cs
…
DefaultAssemblyProviderTests.cs react to DNX renames 2015-07-31 13:48:22 -07:00
DefaultControllerActivatorTest.cs
…
DefaultControllerFactoryTest.cs Remove IScopedInstance - use AsyncLocal for ActionContext and 2015-08-13 15:58:29 -07:00
DefaultControllerTypeProviderTest.cs
…
DefaultFilterProviderTest.cs
…
EmptyResultTests.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
ExcludeTypeValidationFilterExtensionsTests.cs
…
FilePathResultTest.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
FileResultTest.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
FileStreamResultTest.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
FilterCollectionExtensionsTest.cs
…
FlushReportingStream.cs
…
FormatFilterTest.cs Remove IScopedInstance - use AsyncLocal for ActionContext and 2015-08-13 15:58:29 -07:00
FormatterMappingsTest.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
HttpMethodProviderAttributesTests.cs
…
HttpNotFoundObjectResultTest.cs Remove IScopedInstance - use AsyncLocal for ActionContext and 2015-08-13 15:58:29 -07:00
HttpNotFoundResultTests.cs React to move of StatusCodes 2015-07-08 12:43:33 -07:00
HttpOkObjectResultTest.cs Remove IScopedInstance - use AsyncLocal for ActionContext and 2015-08-13 15:58:29 -07:00
HttpOkResultTest.cs Add `HttpOkResult`, `HttpOkObjectResult`, and `Ok()` methods in `Controller` 2015-07-23 18:49:36 -07:00
HttpResponseStreamWriterTest.cs
…
HttpStatusCodeResultTests.cs React to move of StatusCodes 2015-07-08 12:43:33 -07:00
HttpUnauthorizedResultTests.cs React to move of StatusCodes 2015-07-08 12:43:33 -07:00
KnownRouteValueConstraintTests.cs
…
Microsoft.AspNet.Mvc.Core.Test.xproj
…
MockMvcOptionsAccessor.cs
…
ModelBindingHelperTest.cs Do not trounce existing property values that are not bound in `TryUpdateModel` scenarios 2015-08-18 09:57:41 -07:00
MvcCoreServiceCollectionExtensionsTest.cs React to namespace change in DI. 2015-08-11 14:10:30 -07:00
MvcOptionsTest.cs Add basic startup experience for MVC.Core 2015-07-08 17:16:07 -07:00
MvcRouteHandlerTests.cs Add more event notification data points 2015-08-16 16:42:58 -07:00
NoContentFormatterTests.cs React to move of StatusCodes 2015-07-08 12:43:33 -07:00
NonDisposableStreamTest.cs
…
ObjectResultTests.cs Remove IScopedInstance - use AsyncLocal for ActionContext and 2015-08-13 15:58:29 -07:00
OutputFormatterTests.cs Fix for #2739 2015-07-10 12:01:57 -07:00
ProducesAttributeTests.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
RedirectResultTest.cs Remove IScopedInstance - use AsyncLocal for ActionContext and 2015-08-13 15:58:29 -07:00
RedirectToActionResultTest.cs Make saving TempData operate via a filter 2015-08-07 16:53:11 -07:00
RedirectToRouteResultTest.cs Make saving TempData operate via a filter 2015-08-07 16:53:11 -07:00
RequireHttpsAttributeTests.cs React to move of StatusCodes 2015-07-08 12:43:33 -07:00
ResponseCacheAttributeTest.cs Add basic startup experience for MVC.Core 2015-07-08 17:16:07 -07:00
ResponseCacheFilterTest.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
ResultFilterAttributeTest.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
RouteDataActionConstraintTest.cs
…
RouteTemplateProviderAttributesTest.cs
…
SerializableErrorTests.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
ServiceBasedControllerActivatorTest.cs Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00
SimpleTypeExcludeFilterTest.cs
…
StreamOutputFormatterTest.cs
…
StringOutputFormatterTests.cs
…
TestController.cs
…
UrlHelperTest.cs Fix #2859 - Correct UrlHelper for special tokens 2015-08-13 17:04:21 -07:00
project.json Split up MVC.Extensions into smaller packages 2015-07-06 23:41:22 -07:00