The issue here is actually different than described in the bug. ResultFilter should only short circuit when .Cancel is set to true. This is consistent with legacy MVC. Added tests for all of this stuff. There's already good test coverage for the invoker, what was missing was coverage for the attributes and for the methods on Controller. ExceptionFilterAttribute and AuthorizationFilterAttribute don't have short circuiting logic inside of them, so they are already covered by tests for the invoker. |
||
|---|---|---|
| .. | ||
| ActionResults | ||
| AntiXsrf | ||
| Filters | ||
| Properties | ||
| Rendering | ||
| ActionAttributeTests.cs | ||
| ActionExecutorTests.cs | ||
| ActionSelectionConventionTests.cs | ||
| ControllerTests.cs | ||
| DefaultActionSelectorTest.cs | ||
| DefaultControllerAssemblyProviderTests.cs | ||
| DefaultControllerFactoryTest.cs | ||
| JsonResultTest.cs | ||
| KnownRouteValueConstraintTests.cs | ||
| Microsoft.AspNet.Mvc.Core.Test.kproj | ||
| MvcOptionsTests.cs | ||
| PropertyHelperTest.cs | ||
| ReflectedActionDescriptorProviderTests.cs | ||
| ReflectedActionInvokerTest.cs | ||
| TestController.cs | ||
| TypeHelperTest.cs | ||
| UrlHelperTest.cs | ||
| ViewComponentTests.cs | ||
| ViewResultTest.cs | ||
| project.json | ||