597 lines
21 KiB
C#
597 lines
21 KiB
C#
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
|
|
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.AspNet.Http;
|
|
using Microsoft.AspNet.Mvc.ModelBinding;
|
|
using Xunit;
|
|
|
|
namespace Microsoft.AspNet.Mvc.IntegrationTests
|
|
{
|
|
public class TryUpdateModelIntegrationTest
|
|
{
|
|
private class Address
|
|
{
|
|
public string Street { get; set; }
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_ExistingModel_EmptyPrefix_GetsOverWritten()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Address { Street = "DefaultStreet" };
|
|
var oldModel = model;
|
|
|
|
// Act
|
|
var result = await TryUpdateModel(model, string.Empty, operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.Same(oldModel, model);
|
|
Assert.Equal("SomeStreet", model.Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_ExistingModel_EmptyPrefix_GetsBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Address();
|
|
// Act
|
|
var result = await TryUpdateModel(model, string.Empty, operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.Equal("SomeStreet", model.Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
private class Person2
|
|
{
|
|
public List<Address> Address { get; set; }
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_SettableCollectionModel_EmptyPrefix_GetsBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person2();
|
|
// Act
|
|
var result = await TryUpdateModel(model, string.Empty, operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
Assert.Equal(1, model.Address.Count);
|
|
Assert.Equal("SomeStreet", model.Address[0].Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "Address[0].Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
private class Person3
|
|
{
|
|
public Person3()
|
|
{
|
|
Address = new List<Address>();
|
|
}
|
|
|
|
public List<Address> Address { get; }
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_NonSettableCollectionModel_EmptyPrefix_GetsBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person3();
|
|
// Act
|
|
var result = await TryUpdateModel(model, string.Empty, operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
Assert.Equal(1, model.Address.Count);
|
|
Assert.Equal("SomeStreet", model.Address[0].Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "Address[0].Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
private class Person6
|
|
{
|
|
public CustomReadOnlyCollection<Address> Address { get; set; }
|
|
}
|
|
|
|
[Fact(Skip = "Validation incorrect for collections when using TryUpdateModel, #2941")]
|
|
public async Task TryUpdateModel_ReadOnlyCollectionModel_EmptyPrefix_DoesNotGetBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person6();
|
|
|
|
// Act
|
|
var result = await TryUpdateModel(model, string.Empty, operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
|
|
// Read-only collection should not be updated.
|
|
Assert.Empty(model.Address);
|
|
|
|
// ModelState (data is valid but is not copied into Address).
|
|
Assert.True(modelState.IsValid);
|
|
var entry = Assert.Single(modelState);
|
|
Assert.Equal("Address[0].Street", entry.Key);
|
|
var state = entry.Value;
|
|
Assert.NotNull(state);
|
|
Assert.Equal(ModelValidationState.Valid, state.ValidationState);
|
|
Assert.Equal("SomeStreet", state.Value.RawValue);
|
|
}
|
|
|
|
private class Person4
|
|
{
|
|
public Address[] Address { get; set; }
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_SettableArrayModel_EmptyPrefix_GetsBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person4();
|
|
// Act
|
|
var result = await TryUpdateModel(model, string.Empty, operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
Assert.Equal(1, model.Address.Count());
|
|
Assert.Equal("SomeStreet", model.Address[0].Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "Address[0].Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
private class Person5
|
|
{
|
|
public Address[] Address { get; } = new Address[] { };
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_NonSettableArrayModel_EmptyPrefix_GetsBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person5();
|
|
// Act
|
|
var result = await TryUpdateModel(model, string.Empty, operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
|
|
// Arrays should not be updated.
|
|
Assert.Equal(0, model.Address.Count());
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
Assert.Empty(modelState.Keys);
|
|
}
|
|
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_ExistingModel_WithPrefix_GetsOverWritten()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("prefix.Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Address { Street = "DefaultStreet" };
|
|
var oldModel = model;
|
|
|
|
// Act
|
|
var result = await TryUpdateModel(model, "prefix", operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.Same(oldModel, model);
|
|
Assert.Equal("SomeStreet", model.Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "prefix.Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_ExistingModel_WithPrefix_GetsBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("prefix.Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Address();
|
|
// Act
|
|
var result = await TryUpdateModel(model, "prefix", operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.Equal("SomeStreet", model.Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "prefix.Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_SettableCollectionModel_WithPrefix_GetsBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("prefix.Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person2();
|
|
// Act
|
|
var result = await TryUpdateModel(model, "prefix", operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
Assert.Equal(1, model.Address.Count);
|
|
Assert.Equal("SomeStreet", model.Address[0].Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "prefix.Address[0].Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_NonSettableCollectionModel_WithPrefix_GetsBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("prefix.Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person3();
|
|
// Act
|
|
var result = await TryUpdateModel(model, "prefix", operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
Assert.Equal(1, model.Address.Count);
|
|
Assert.Equal("SomeStreet", model.Address[0].Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "prefix.Address[0].Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
[Fact(Skip = "Validation incorrect for collections when using TryUpdateModel, #2941")]
|
|
public async Task TryUpdateModel_ReadOnlyCollectionModel_WithPrefix_DoesNotGetBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("prefix.Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person6();
|
|
|
|
// Act
|
|
var result = await TryUpdateModel(model, "prefix", operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
|
|
// Read-only collection should not be updated.
|
|
Assert.Empty(model.Address);
|
|
|
|
// ModelState (data is valid but is not copied into Address).
|
|
Assert.True(modelState.IsValid);
|
|
var entry = Assert.Single(modelState);
|
|
Assert.Equal("prefix.Address[0].Street", entry.Key);
|
|
var state = entry.Value;
|
|
Assert.NotNull(state);
|
|
Assert.Equal(ModelValidationState.Valid, state.ValidationState);
|
|
Assert.Equal("SomeStreet", state.Value.RawValue);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_SettableArrayModel_WithPrefix_GetsBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("prefix.Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person4();
|
|
// Act
|
|
var result = await TryUpdateModel(model, "prefix", operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
Assert.Equal(1, model.Address.Count());
|
|
Assert.Equal("SomeStreet", model.Address[0].Street);
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
|
|
Assert.Equal(1, modelState.Keys.Count);
|
|
var key = Assert.Single(modelState.Keys, k => k == "prefix.Address[0].Street");
|
|
Assert.NotNull(modelState[key].Value);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.AttemptedValue);
|
|
Assert.Equal("SomeStreet", modelState[key].Value.RawValue);
|
|
Assert.Empty(modelState[key].Errors);
|
|
Assert.Equal(ModelValidationState.Valid, modelState[key].ValidationState);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TryUpdateModel_NonSettableArrayModel_WithPrefix_DoesNotGetBound()
|
|
{
|
|
// Arrange
|
|
var operationContext = ModelBindingTestHelper.GetOperationBindingContext(request =>
|
|
{
|
|
request.QueryString = QueryString.Create("prefix.Address[0].Street", "SomeStreet");
|
|
});
|
|
|
|
var modelState = new ModelStateDictionary();
|
|
var model = new Person5();
|
|
// Act
|
|
var result = await TryUpdateModel(model, "prefix", operationContext, modelState);
|
|
|
|
// Assert
|
|
Assert.True(result);
|
|
|
|
// Model
|
|
Assert.NotNull(model.Address);
|
|
|
|
// Arrays should not be updated.
|
|
Assert.Equal(0, model.Address.Count());
|
|
|
|
// ModelState
|
|
Assert.True(modelState.IsValid);
|
|
Assert.Empty(modelState.Keys);
|
|
}
|
|
|
|
private class CustomReadOnlyCollection<T> : ICollection<T>
|
|
{
|
|
private ICollection<T> _original;
|
|
|
|
public CustomReadOnlyCollection()
|
|
: this(new List<T>())
|
|
{
|
|
}
|
|
|
|
public CustomReadOnlyCollection(ICollection<T> original)
|
|
{
|
|
_original = original;
|
|
}
|
|
|
|
public int Count
|
|
{
|
|
get { return _original.Count; }
|
|
}
|
|
|
|
public bool IsReadOnly
|
|
{
|
|
get { return true; }
|
|
}
|
|
|
|
public void Add(T item)
|
|
{
|
|
throw new NotSupportedException();
|
|
}
|
|
|
|
public void Clear()
|
|
{
|
|
throw new NotSupportedException();
|
|
}
|
|
|
|
public bool Contains(T item)
|
|
{
|
|
return _original.Contains(item);
|
|
}
|
|
|
|
public void CopyTo(T[] array, int arrayIndex)
|
|
{
|
|
_original.CopyTo(array, arrayIndex);
|
|
}
|
|
|
|
public bool Remove(T item)
|
|
{
|
|
throw new NotSupportedException();
|
|
}
|
|
|
|
public IEnumerator<T> GetEnumerator()
|
|
{
|
|
foreach (T t in _original)
|
|
{
|
|
yield return t;
|
|
}
|
|
}
|
|
|
|
System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator()
|
|
{
|
|
return GetEnumerator();
|
|
}
|
|
}
|
|
|
|
private Task<bool> TryUpdateModel(
|
|
object model,
|
|
string prefix,
|
|
OperationBindingContext operationContext,
|
|
ModelStateDictionary modelState)
|
|
{
|
|
return ModelBindingHelper.TryUpdateModelAsync(
|
|
model,
|
|
model.GetType(),
|
|
prefix,
|
|
operationContext.HttpContext,
|
|
modelState,
|
|
operationContext.MetadataProvider,
|
|
operationContext.ModelBinder,
|
|
operationContext.ValueProvider,
|
|
operationContext.InputFormatters,
|
|
ModelBindingTestHelper.GetObjectValidator(),
|
|
operationContext.ValidatorProvider);
|
|
}
|
|
}
|
|
} |