d6f3a1bd22
- Allow identical `@using` directives in the primary document. This means that if a user types `@using System` twice in the primary document (i.e. `Index.cshtml`) then we'll generate that using statement twice; this enables proper C# IntelliSense to light up on both using statements and allows auto-completion to work because there's no more magical distinction logic for Razor code that is in the current document. - Prior to this change if you had two identical using statements in the same document one would be in no-mans land mapped to nothing (not C#, not HTML) and the other would be mapped to C#; the second a user differentiated the two statements (i.e. adding a `.`) we'd distinctify the using statements resulting in an invalid completion. - This PR has an end-user impact where they will now receive the normal C# warning about having duplicate using. I treated this prior behavior more as a bug because we threw away the first using directive instance which impacted editing and in general was a silly thing to correct for the user. - Added new integration test showing how using directives are not de-duplicated in the primary document. #1255 |
||
|---|---|---|
| .. | ||
| IntegrationTests | ||
| Properties | ||
| TestFiles/IntegrationTests | ||
| AssemblyAttributeInjectionPassTest.cs | ||
| InjectDirectiveTest.cs | ||
| InjectTargetExtensionTest.cs | ||
| InstrumentationPassTest.cs | ||
| Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj | ||
| ModelDirectiveTest.cs | ||
| ModelExpressionPassTest.cs | ||
| MvcImportProjectFeatureTest.cs | ||
| MvcRazorTemplateEngineTest.cs | ||
| MvcShim.cs | ||
| MvcViewDocumentClassifierPassTest.cs | ||
| NamespaceDirectiveTest.cs | ||
| PageDirectiveTest.cs | ||
| RazorPageDocumentClassifierPassTest.cs | ||
| SourceMappingsSerializer.cs | ||
| TagHelperDescriptorExtensionsTest.cs | ||
| ViewComponentTagHelperDescriptorFactoryTest.cs | ||
| ViewComponentTagHelperDescriptorProviderTest.cs | ||
| ViewComponentTagHelperPassTest.cs | ||
| ViewComponentTagHelperTargetExtensionTest.cs | ||
| ViewComponentTypeVisitorTest.cs | ||
| xunit.runner.json | ||