23375c911b
We had a startTask we would await in DisposeAsync and channel completion continuation. This task would be initially set to a completed task and then once StartAsync was invoked it would be replaced with the actual task representing StartAsyncInternal. However if a transport failed immediately after starting the channel completion continuation could have been called before the StartAsyncInternal method completed. In this case we would await the inital completed task and then very likely would fail trying to await _receiveLoop task because it wouldn't necessarily be set. The fix is to use TaskCompletionSource so we don't try to swap tasks. We need to do some additional state checks because: - the TaskCompletionSource task may never be completed (e.g. DisposeAsync is being called without starting the connection) - TaskCompletionSource allows setting the result only once and we should not return its task more than once (e.g. calling StartAsync after connection was successfully started and stopped) Fixes #304 |
||
|---|---|---|
| .. | ||
| Microsoft.AspNetCore.SignalR | ||
| Microsoft.AspNetCore.SignalR.Client | ||
| Microsoft.AspNetCore.SignalR.Common | ||
| Microsoft.AspNetCore.SignalR.Redis | ||
| Microsoft.AspNetCore.Sockets | ||
| Microsoft.AspNetCore.Sockets.Client | ||
| Microsoft.AspNetCore.Sockets.Common | ||
| Microsoft.AspNetCore.WebSockets.Internal | ||
| Microsoft.Extensions.WebSockets.Internal | ||