This change ensures that setting ExceptionContext.Result will always execute if set. The problem with 1.1.0 is that when we had a real short circuit the wrong set of conditions were checked. I suspect that when you set ExceptionFilter.Result and didn't short circuit that result filters were also running (which is a bug). Added a few tests that verify that the result doesn't trigger result filters. I did some general cleanup on this code path to make the state transitions more clear. No exception was thrown -> BeginResult Exception was handled -> ExceptionHandled Exception was not handled -> gets rethrown |
||
|---|---|---|
| .. | ||
| Microsoft.AspNetCore.Mvc.Abstractions.Test | ||
| Microsoft.AspNetCore.Mvc.ApiExplorer.Test | ||
| Microsoft.AspNetCore.Mvc.Core.Test | ||
| Microsoft.AspNetCore.Mvc.Cors.Test | ||
| Microsoft.AspNetCore.Mvc.DataAnnotations.Test | ||
| Microsoft.AspNetCore.Mvc.Formatters.Json.Test | ||
| Microsoft.AspNetCore.Mvc.Formatters.Xml.Test | ||
| Microsoft.AspNetCore.Mvc.FunctionalTests | ||
| Microsoft.AspNetCore.Mvc.IntegrationTests | ||
| Microsoft.AspNetCore.Mvc.Localization.Test | ||
| Microsoft.AspNetCore.Mvc.Razor.Host.Test | ||
| Microsoft.AspNetCore.Mvc.Razor.Test | ||
| Microsoft.AspNetCore.Mvc.TagHelpers.Test | ||
| Microsoft.AspNetCore.Mvc.Test | ||
| Microsoft.AspNetCore.Mvc.TestCommon | ||
| Microsoft.AspNetCore.Mvc.TestDiagnosticListener.Sources | ||
| Microsoft.AspNetCore.Mvc.ViewFeatures.Test | ||
| Microsoft.AspNetCore.Mvc.WebApiCompatShimTest | ||
| WebSites | ||