aspnetcore/eng
Doug Bunting 326507bb01
Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790)
* Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values
- Ensure `$(SharedFxVersion)` doesn't change in `$(NoSemVer20)` projects
- Ignore current project's `$(VersionSuffix)` in `$(TargetingPackVersion)`
    - Never assume `$(AspNetCoreBaselineVersion)` matches released targeting pack
- Stabilize both versions correctly
- Use these properties more widely
    - Remove other mechanisms to get the same values
    - Reduce use of the `_GetPackageVersionInfo` target
    - Reduce use of `$(SharedFxVersion)` for the targeting pack

nits:
- Correct comments about old RTMVersions.csproj project
- Fix or remove a few other comments

* Do not pass package filenames on Helix command Lines
- remove parsing of these command-line arguments from `RuntestOptions`
  - instead craft the names using passed `$(SharedFxVersion)`
- restore `$(DotNetRuntimeSourceFeedKey)` on Helix command line
  - lost somewhere along the line
- correct argument count in runtests.sh
  - treated 11th argument as both Helix timeout and feed credential
  - count was messed up somewhere alone the line

nits:
- update C# syntax in `RuntestOptions` e.g. remove unused `public` setters
- sort and group properties and their assignments
2020-09-11 19:17:28 -07:00
..
common [release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/runtime (#25777) 2020-09-10 22:48:26 +00:00
docker
helix Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790) 2020-09-11 19:17:28 -07:00
scripts
targets Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790) 2020-09-11 19:17:28 -07:00
tools
AfterSigning.targets
AfterSolutionBuild.targets
AllRulesDisabled.ruleset
Baseline.Designer.props
Baseline.xml
Build.props Point to the correct directory for SDK test assets (#25734) 2020-09-10 11:55:37 -07:00
CodeGen.proj
Common.props
Dependencies.props Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790) 2020-09-11 19:17:28 -07:00
GenAPI.exclusions.txt
LicenseHeader.txt
PoliCheckExclusions.xml
ProjectReferences.props Move ProtectedBrowserStorage to the shared fx (#25557) 2020-09-09 09:54:14 -07:00
PublishSymbols.proj
Publishing.props
QuarantinedTests.AfterArcade.props
QuarantinedTests.BeforeArcade.props
SharedFramework.External.props [release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/runtime dotnet/efcore (#25555) 2020-09-08 23:34:53 +00:00
SharedFramework.Local.props
SignCheckExclusionsFile.txt
Signing.props
Tools.props
Version.Details.xml Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790) 2020-09-11 19:17:28 -07:00
Versions.props Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790) 2020-09-11 19:17:28 -07:00
Workarounds.props
Workarounds.targets
WorkaroundsImported.targets
configure-toolset.ps1
configure-toolset.sh
empty.proj
sdl-tsa-vars.config