06475270ec
SendAsync was using InvokeCoreAsync code to send messages. In case of exception InvokeCoreAsync is blocking and returns a task to the user so they can await for the remote call to complete. Any exception thrown is caught and used to fail the task returned to the user. SendAsync does not return a special task to the user so re-using InvokeCore resulted in swallowing exceptions. While SendAsync is fire and forget it actually should throw if the message could not be send and it was not happening. While adding tests it turned out we did not test cases where Invoke/SendAsync/StreamAsync were invoked before starting the connection and this resulted in a NullReferenceException. I also fixed that. |
||
|---|---|---|
| .. | ||
| HttpConnectionTests.cs | ||
| HubConnectionBuilderExtensionsTests.cs | ||
| HubConnectionBuilderTests.cs | ||
| HubConnectionExtensionsTests.cs | ||
| HubConnectionProtocolTests.cs | ||
| HubConnectionTests.cs | ||
| LongPollingTransportTests.cs | ||
| Microsoft.AspNetCore.SignalR.Client.Tests.csproj | ||
| ResponseUtils.cs | ||
| ServerSentEventsParserTests.cs | ||
| ServerSentEventsTransportTests.cs | ||
| TaskQueueTests.cs | ||
| TestConnection.cs | ||
| TestTransportFactory.cs | ||