huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
aspnetcore/test/Microsoft.AspNet.Mvc.Functi...
History
Doug Bunting d03a851ab3 Use `MvcTextFixture` as much as possible 
- #3066
  - reduce `TestServer` -> `PhysicalFileProvider` -> `FileSystemWatcher` count enough to run with Core CLR on Linux
- remove use of `HttpClient.DefaultRequestHeaders`; any client change affects other tests
- remove use of `RequestBuilder` class; creates a per-test `HttpClient` and requires the `TestServer`
- updated a few expectations because `CommonTestEncoder` does JavaScript a bit differently
  - "JavaScriptEncode[[...]]" -> "JavaScriptStringEncode[[...]]"
- side benefit: xUnit reports functional tests execute for only ~12.4s; was >30s before this change

Infrastructure: Enhance `MvcTestFixture`
- handle `ConfigureServices()` methods that are not `void`
- handle `Configure(IApplicationBuilder, ILoggerFactory)`
- ensure server is initialized with consistent `CurrentCulture` and `CurrentUICulture`
- add `FilteredDefaultAssemblyProviderFixture<TStartup>` and `MvcEncodedTestFixture<TStartup>`
  - add `MvcTextFixture.AddAdditionalServices()` extension point supporting these

- do not expose the `TestServer`; an anti-pattern for tests to manipulate the server
- update class names to match containing files
- use existing `TestApplicationEnvironment`
  - apply some `MvcTestFixture` improvements to the shared `TestApplicationEnvironment` class
- remove unused methods from `TestHelper`

nits:
- touched-up some leftover `_app` &c declarations to be more explicit and minimize `using`s
- moved statements into correct sections of methods in `RoutingTests`
- removed `TestLoggerFactory` and related classes from `TagHelperSampleTest`
 		2015-09-15 10:18:27 -07:00
..
Logging
…
compiler/resources Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ActionResultTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ActivatorTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
AntiforgeryTestHelper.cs
…
AntiforgeryTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ApiExplorerTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ApplicationModelTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
BasicTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
BestEffortLinkGenerationTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
CompilationOptionsTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
CompositeViewEngineTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ConsumesAttributeTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ContentNegotiationTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ControllerDiscoveryConventionTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ControllerFromServicesTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
CorsMiddlewareTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
CorsTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
CustomRouteTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
CustomUrlHelperTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
DefaultOrderTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
DefaultValuesTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
DependencyResolverTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
DirectivesTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ErrorPageTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ExceptionInfo.cs
…
FileResultTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
FilteredDefaultAssemblyProviderFixtureOfT.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
FiltersTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
FlushPointTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
FormatFilterTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
HtmlGenerationTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
HtmlHelperOptionsTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
HttpResponseMessageExceptions.cs
…
InlineConstraintTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
InputFormatterTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
InputObjectValidationTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
JsonOutputFormatterTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
JsonPatchTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
JsonResultTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
LinkGenerationTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
LocalizationTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
Microsoft.AspNet.Mvc.FunctionalTests.xproj
…
ModelBindingBindingBehaviorTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ModelBindingDataMemberRequiredTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ModelBindingFromFormTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ModelBindingFromHeaderTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ModelBindingFromQueryTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ModelBindingFromRouteTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ModelBindingModelBinderAttributeTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ModelBindingTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ModelMetadataAttributeTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
MvcEncodedTestFixtureOfT.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
MvcSampleTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
MvcStartupTests.cs
…
MvcTestFixture.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
MvcTestFixtureOfT.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
OutputFormatterTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
PrecompilationTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RazorEmbeddedViewsTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RazorFileSystemCaseSensitivityTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RazorPageExecutionInstrumentationTest.cs
…
RazorViewLocationSpecificationTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RemoteAttributeValidationTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RequestServicesTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RespectBrowserAcceptHeaderTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ResponseCacheTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RoundTripTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RouteDataTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RoutingLowercaseUrlTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
RoutingTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
SerializableErrorTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
StreamOutputFormatterTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
TagHelperSampleTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
TagHelpersTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
TempDataTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
TestApplicationEnvironment.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
TestHelper.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
TryValidateModelTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
UrlResolutionTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ValueProviderTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
VersioningTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ViewComponentTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
ViewEngineTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
WebApiCompatShimActionResultTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
WebApiCompatShimActionSelectionTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
WebApiCompatShimBasicTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
WebApiCompatShimParameterBindingTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
XmlDataContractSerializerFormattersWrappingTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
XmlDataContractSerializerInputFormatterTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
XmlOutputFormatterTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
XmlSerializerFormattersWrappingTest.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
XmlSerializerInputFormatterTests.cs Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00
project.json Use `MvcTextFixture` as much as possible 2015-09-15 10:18:27 -07:00