Ryan Nowak
e396f1b451
Adding attribute routing
2014-07-03 18:53:38 -07:00
Ryan Nowak
c17d33154f
Fix for #617 - ViewResult can be constructed without a view engine
...
We want result types to be constructable without services.
2014-06-27 17:05:09 -07:00
dougbu
172a5a5500
Address review comments
...
- XML comments for changed `TemplateInfo` properties
- correct `DefaultDisplayTemplateTests` and `DefaultEditorTemplateTests` namespaces
- add a couple of low-level `TemplateInfo` tests
2014-06-27 15:56:51 -07:00
dougbu
bbf470bd34
Also test `string.Empty` model
2014-06-27 15:56:47 -07:00
dougbu
6eb1e38e33
Add `@Html.Display()` and `@Html.Editor()` tests with values in `ViewData`
2014-06-27 15:56:43 -07:00
dougbu
1a4d59ae14
Enable us to unit test `@Html...For()` methods
...
- add more `DefaultTemplatesUtilities.GetHtmlHelper()` overloads, all
returning a strongly-typed helper
- also correct that method to ensure template helpers each get a unique
`IHtmlHelper` instance
2014-06-27 15:56:35 -07:00
Pranav K
e7c2faff32
Unwrap nullable types in PropertyHelper prior to looking up properties
...
Fixes #721
2014-06-27 15:27:51 -07:00
Pranav K
0f0d44c6b3
Fixing ModelChunkVisitorTest to match resource name
...
Fixing stylecop issues
2014-06-27 11:55:24 -07:00
N. Taylor Mullen
2ad175b687
Add @model specific tests to validate output.
...
#568
2014-06-27 11:23:27 -07:00
N. Taylor Mullen
54d6b0b113
Modify tests to use new ModelCodeGenerator.
...
#568
2014-06-27 11:23:24 -07:00
Pranav K
2aacdeca4a
Modify AssociatedMetadataProvider to use PropertyHelper to create accessor
...
Additionally change it to use TypeExtensions.GetReadableProperties to get
property list. This causes it to ignore indexers which should not be
considered.
Fixes #595
2014-06-27 10:50:37 -07:00
Pranav K
3c092cb083
Moving model binders from DI to MvcOptions
2014-06-26 21:49:46 -07:00
Ryan Nowak
ba506b2976
fix build break - this wasnt referencing the right helios package
2014-06-26 14:18:41 -07:00
Ryan Nowak
f194723230
Adding tests for convention-based routing
2014-06-26 14:00:42 -07:00
Chris Ross
3aae5cb4fa
Fix one more test.
2014-06-26 11:06:26 -07:00
Chris Ross
1d3e6b0dd0
Fix breaks from GetFormAsync, IReadableStringCollection.Keys.
2014-06-26 10:56:56 -07:00
David Fowler
e6ec6e0aba
React to resource changes
2014-06-25 22:48:32 -07:00
Ryan Nowak
0d7f38e10e
Commonize code to limit functional tests to a single site each
2014-06-25 09:00:34 -07:00
dougbu
dd2216fa89
Remove K10 configuration from AutofacWebSite
2014-06-24 20:33:21 -07:00
dougbu
23146787dc
NET45-ify our Autofac functional test
...
- see loads of load failures after `kvm.ps1 upgrade -svrc50` otherwise
2014-06-24 19:33:50 -07:00
dougbu
5149c7cd19
Get ModelBinding test project working on K10 again
...
- restore `ClientRulesWithCompareAttribute_ErrorMessageUsesResourceOverride` since
DataAnnotations has fixed underlying problem
2014-06-24 19:33:47 -07:00
Pranav K
9bf6982168
Reacting to HttpAbstractions changes
2014-06-24 16:36:36 -07:00
Pranav K
24e1ac7ca1
Revive ModelMetadata.ShowForDisplay and ModelMetadata.ShowForEdit
...
Fixes #679
2014-06-23 16:50:09 -07:00
N. Taylor Mullen
6cc47cd5f1
Add Autofac functional test.
...
Added very simple Autofac functional test that validates that we can add custom classes to the DI system as well as just use the ones provided to us.
#669
2014-06-23 16:17:50 -07:00
dougbu
23740085f1
Catch MVC up with Helios rename
...
- one more file to change on dev branch
2014-06-23 15:46:57 -07:00
dougbu
2bfc3e32e9
Merge branch 'release' into dev
2014-06-23 15:45:03 -07:00
dougbu
0c6749a5e7
Catch MVC up with Helios rename
...
- allows builds to succeed after cleaning your repo (without NuGet.org source)
2014-06-23 14:05:47 -07:00
sornaks
15b06a4057
Fixing the TODOs dependent on SimpleDisplayText.
2014-06-23 11:55:16 -07:00
Pranav K
cca78bb055
Adding support for ActivateAttribute via IControllerActivator
...
This mechanism replaces code in Inject that activated properties
by looking them up by names.
2014-06-23 11:00:28 -07:00
Tian Pan
4c9f19aafc
Update controller methods to be all virtual
...
Fix #596
2014-06-20 15:40:02 -07:00
Ryan Nowak
e6ba1f23a2
refactor of action descriptor pipeline
...
(cherry picked from commit 634f756e7fd303fc3022563fcd8fb9b1cb47fba2)
2014-06-20 11:11:08 -07:00
Brice Lambson
172dcd179b
Bump version to 6.0.0-*
2014-06-19 11:21:43 -07:00
harshgMSFT
08b64a2a4a
InlineConstraint Functional Test, removing the dependency on a physical file.
2014-06-18 13:42:33 -07:00
Yishai Galatzer
9e1deb7982
Fixup unit tests to mock RequestServices instead of ApplicationServices
2014-06-18 13:40:58 -07:00
Tian Pan
e27742fd0b
IsValidActionMethod fails to check static methods.
...
Fix #638
2014-06-16 18:04:09 -07:00
Pranav K
85bd056780
CreateActionResult should work when action returns Task.
...
Fixes #647
2014-06-16 16:13:18 -07:00
Ryan Nowak
d79943d30f
Fixing issues build/project issues that someone else missed.
2014-06-16 13:26:49 -07:00
harshgMSFT
170283c724
Fixing StyleCop Issues for issues reported for commit# b58083f73a
2014-06-16 13:16:37 -07:00
Ryan Nowak
1bae3bcaa2
Issue #592 - ActionResult is not being executed by ResultFilterAttribute
...
The issue here is actually different than described in the bug.
ResultFilter should only short circuit when .Cancel is set to true. This
is consistent with legacy MVC.
Added tests for all of this stuff. There's already good test coverage for
the invoker, what was missing was coverage for the attributes and for the
methods on Controller. ExceptionFilterAttribute and
AuthorizationFilterAttribute don't have short circuiting logic inside of
them, so they are already covered by tests for the invoker.
2014-06-16 12:42:59 -07:00
harshgMSFT
10285d7d39
This additional constraint enables adding a route to the template (and potentially to the UseMvc method) without actually implementing the actual artifact.
...
For example without adding an area to a controller, a route can still be added to the template.
- Also added functional tests.
2014-06-16 11:24:22 -07:00
harshgMSFT
b58083f73a
Renaming AntiForgeryConfig-> AntiForgeryOptions.
...
Adding MvcOptions and updating AntiForgery system to use AntiForgeryConfiguration from MvcOptions
2014-06-12 16:55:49 -07:00
Ryan Nowak
7f34c94de7
Adding a context class for ValueProviderFactories
...
This allows model binding to once again be independent of routing. Sending
RouteContext into model binding was an odd choice from a layering
point-of-view.
2014-06-11 18:03:09 -07:00
Ryan Nowak
44ed23f65e
Fix a build break in k10
2014-06-11 12:49:15 -07:00
Tian Pan
31915f0b46
Remove ComponentResultHelper
...
Fix #598
2014-06-11 11:32:22 -07:00
Tian Pan
e95585dfbd
Remove ActionResultHelper
...
Fix #597
2014-06-11 11:17:45 -07:00
Tian Pan
60443101d5
Enable request to reach base controller class's action
...
Fix #378
2014-06-11 10:57:19 -07:00
sornaks
28516a0ae9
Changes to support DisplayColumn attribute. Updating the MvcSample as well to start using DisplayColumn attribute. Adding UnitTests for the same.
2014-06-10 16:45:55 -07:00
Pranav K
7396f58d99
Support ModelMetaData.IsRequired
...
* Update DataAnnotationsModelValidatorProvider to use ModelMetadata.IsRequired
* Adding tests and updating existing ones that didn't work with IsRequired
Fixes #533
2014-06-10 10:20:24 -07:00
Pranav K
0123b38840
Adding missing files to kproj
2014-06-09 14:55:50 -07:00
Pranav K
59e419ba0a
Adding support for @Inject to Mvc
2014-06-09 13:43:08 -07:00
Javier Calvarro Nelson
c98bc503e8
Check for result.Body.Length = 0 instead of checking that the body is the empty string
2014-06-09 13:35:42 -07:00
Javier Calvarro Nelson
2523d5d9ea
Addressed feedback from @rynowak
2014-06-09 13:35:39 -07:00
Javier Calvarro Nelson
5ba74f500c
Incorporated code review feedback
2014-06-09 13:35:35 -07:00
Javier Calvarro Nelson
16f19b5cc6
Added functional tests to cover rendering views without layout and
...
to return a result without content.
2014-06-09 13:35:31 -07:00
Pranav K
822d84a2b4
Use default values when binding action arguments
...
Fixes #545
2014-06-09 11:44:26 -07:00
harshgMSFT
dd3dafddb8
Mvc Changes corresponding to Routing DI changes. Refer pr#63
2014-06-06 17:22:06 -07:00
Yishai Galatzer
6d78f8adb3
Cache action descriptor providers and provide a race safe data structure to get the version.
...
The default implementation has a safe race, and does not allow for action description addition at runtime.
It can be replaced with an implementation that can reload.
Consumers of the new service that do extra caching are now responsible to look at the version and change the implementation.
2014-06-06 15:19:30 -07:00
Ryan Nowak
bd08a2ca62
fix a build break due to api change
2014-06-06 11:06:41 -07:00
Ryan Nowak
a3314a4805
changing to use list instead of stack
2014-06-06 10:49:58 -07:00
Ryan Nowak
69034b78b8
Issue #65 merge RoutingContext and RequestContext
...
See the relevant PR in aspnet/Routing#60 .
This incorporates the breaking changes.
2014-06-06 10:49:55 -07:00
sornaks
6b836e9e77
Introducing ChallengeResult to call Response.Challenge()
2014-06-06 10:31:18 -07:00
Ryan Nowak
cf0304b897
Fixing style issues in Mvc.Core
2014-06-04 20:40:23 -07:00
Pranav K
97e06138ed
Cleaning up StyleCop errors
2014-06-04 13:28:30 -07:00
harshgMSFT
b96da245cb
RouteCollection -> RouteBuilder changes for MVC.
2014-06-03 16:43:54 -07:00
sornaks
dffc58dedc
Issue #242 - Introducing ObjectContentResult
2014-06-03 16:00:36 -07:00
Pranav K
06362db5dc
Adding unit test for ViewResult
2014-06-03 13:53:51 -07:00
harshgMSFT
483e9038b4
Supporting Urls With ~/ while redirecting.
...
Fix for Issue#304
2014-06-03 11:29:27 -07:00
Tian Pan
6082cd9f36
View components - More built in return methods ( Fix #354 )
...
Modify Content/Json/View return type as strongly-typed.
2014-06-02 23:12:42 -07:00
Pranav K
19ab3a4fc6
* Moving Utf8EncodingWithoutBOM to a shared type
2014-06-02 11:09:55 -07:00
dougbu
065ee36fdd
Reflect recently-added file in .kproj
...
- from commit 6f3511379f
2014-05-30 19:01:33 -07:00
Pranav K
6f3511379f
Modify JsonResult to generate results in UTF8 without BOM by default
...
Fixes #577
2014-05-30 10:52:15 -07:00
David Fowler
1284ab63b6
Re-enabled the test
2014-05-29 22:42:50 -07:00
David Fowler
c6f8244f79
Unblock the build
2014-05-29 02:20:55 -07:00
Javier Calvarro Nelson
931a3cd809
Added functional tests for MVC.
...
Created a test project to hold functional tests, a basic
application for test purposes under test\WebSites and added
the first functional test to validate view rendering.
2014-05-28 12:46:41 -07:00
Pranav K
d8ba998dec
Change IValueProviderFactory.GetValueProvider to be synchronous.
2014-05-27 14:08:13 -07:00
David Fowler
7388dece9f
Fixed project.json casing
2014-05-26 02:50:43 -07:00
Pranav K
a834928f1a
Change IsValid method in ModelStateDictionary to GetValidationState
...
Fixes #400
2014-05-21 19:33:36 -07:00
Pranav K
0c66074033
Modify MvcRazorHost to use a fixed namespace for generated views.
...
Fixes #554
2014-05-20 17:00:02 -07:00
Pranav K
a53e378cf4
Updating kproj file to match tooling changes
2014-05-18 20:13:56 -07:00
Andrew Peters
f13865dedc
Updating copyright headers
2014-05-08 23:01:20 -07:00
Wei Wang
dc8b5010a0
Merge branch 'sort-dependencies' into dev
...
Conflicts:
src/Microsoft.AspNet.Mvc.Core/project.json
src/Microsoft.AspNet.Mvc.Razor.Host/project.json
src/Microsoft.AspNet.Mvc.Razor/project.json
2014-05-08 11:16:25 -07:00
David Fowler
3b31df3d29
React to renames
2014-05-08 03:24:18 -07:00
Wei Wang
7b2feab670
Sort dependencies and remove duplicates in dependencies
2014-05-07 18:24:04 -07:00
Pranav K
4566947e33
Change ModelState.IsValid back to bool
2014-05-07 17:41:47 -07:00
lajones
235707ec8a
Microsoft.ComponentModel.DataAnnotations is being renamed to Microsoft.DataAnnotations
2014-05-07 13:35:36 -07:00
harshgMSFT
bbafa0a29a
Tests for AntiForgery System.
2014-05-07 10:27:01 -07:00
Pranav K
904c91d2b9
CompositeModelBinder should only validate the object graph at the top
...
level.
DataAnnotationsModelValidator should prefer the container to Metadata.Model
Fixes #247
2014-05-06 17:39:50 -07:00
Wei Wang
e800fcd44f
Eliminate duplicated dependencies
2014-05-06 15:27:10 -07:00
Pranav K
076dedcca5
Reacting to package and namespace changes
2014-05-06 14:06:29 -07:00
Ryan Nowak
abbaa11212
Incorporate name changes: HttpAbstractions
2014-05-05 17:14:08 -07:00
Ryan Nowak
4ece9969bf
HttpAbstractions
2014-05-05 16:29:14 -07:00
Sebastien Ros
6f16dabf08
Renaming Microsoft.AspNet.Security namespace
2014-05-05 16:13:54 -07:00
Ryan Nowak
7a8dc36553
Adding controller-as-filter support
...
If the controller implements IFilter, it will be added to the filters
collection.
It's hardcoded to be 'first' as it was in MVC, but can be overridden by
implementing IOrderedFilter.
2014-05-05 14:03:01 -07:00
Louis DeJardin
bbcac43aaa
Updating DataAnnotations version reference
2014-05-02 20:53:12 -07:00
Hao Kung
9bf42374b0
Fix for moving extension methods to IServiceCollection
2014-05-02 12:37:05 -07:00
N. Taylor Mullen
4494f40d67
Addressed code review comments.
2014-05-02 12:16:28 -07:00
N. Taylor Mullen
c986c663e3
Add tests to ensure cshtml ending for full path view names.
...
#206
2014-05-02 12:16:26 -07:00
Ryan Nowak
f5b3ae4a3b
Renaming Exception Filter methods
...
These were accidentally the same names as the action filter methods.
Oopsies. Name taken from MVC and appended Async for the async version
because that's how we roll.
2014-05-01 23:14:47 -07:00
dougbu
392aa464b2
Oops wrong test
2014-05-01 19:22:16 -07:00
dougbu
a2ba36498a
TEMPORARILY disable ClientRulesWithCompareAttribute_ErrorMessageUsesOverride
...
- test failing under CoreCLR
- leave it running under .NET 4.5
2014-05-01 19:12:23 -07:00