Commit Graph

2896 Commits

Author SHA1 Message Date
Nathanael Marchand ac4d6366b7 Fix Api Explorer not returning type with ActionResult<T> and no type in ProducesResponseTypeAttribute 2018-06-29 11:47:13 -07:00
Pranav K 042c833145
Razor runtime compilation produces errors if running on a shared runtime that's rolled forward
Do not provide compilation references from runtime MVC assemblies. This avoids cases where the app is compiled
against an older MVC but running against a newer one (e.g. shared fx roll forward) resulting in compiling against multiple
versions of MVC assemblies

Fixes #7969
2018-06-29 11:40:23 -07:00
Kiran Challa 54c14b8782 Reacting to Routing repo's EndpointFinder changes 2018-06-28 12:40:04 -07:00
Doug Bunting 4dd4e5ef3e
Shorten names so MVC repo can be cloned on Windows benchmarks server 2018-06-27 14:33:31 -07:00
kishanAnem e1af5b8b6d Array or List in query string does not get parsed #7712 (#7967)
- exclude collections when detecting complex types in `ApiBehaviorApplicationModelProvider`
- add test cases
2018-06-26 11:43:46 -07:00
Pranav K 94a7c83998
Change DefaultApiConventions (#7939)
* Change DefaultApiConventions

* Introduce attributes for matching by name and type.

* Move discovery of ApiConventionAttribute to ApiBehaviorApplicationModelProvider. This is required
for us to detect during startup if the convention is incorrectly authored.
2018-06-25 08:24:30 -07:00
Pranav K 6911e192e4
Add IsRequired and DefaultValue to ApiParameterDescription 2018-06-22 06:51:58 -07:00
Pranav K 17d2545b55
Throw if the type parameter for ActionResult<T> is an action result (#7942)
Fixes #7931
2018-06-21 07:51:12 -07:00
N. Taylor Mullen 2599e0f5cc Fix up a few pieces for the fallback integrity check feature.
- Regenerated test baselines.
- Update code styling in TagHelpers.
- Modified some comments for clarity.
- Renamed fallback integrity attribute for both script and link tags.

#7845
2018-06-20 16:10:52 -07:00
jmhmaine 8a77ed23d3 Added support for ignoring integrity attribute on fallback for the Link TagHelper
- Do not include integrity attribute when asp-fallback-intergrity-check is false
 - Added Unit Tests, manual tests

Addresses #7845
2018-06-20 16:10:52 -07:00
Pranav K 4f7e849cc1
Setting up for ApiConventionAttribute analyzers (#7912)
* Setting up for ApiConventionAttribute analyzers
2018-06-20 15:22:53 -07:00
Pranav K e7ab81fe0b Ensure analyzer package is referenced by Microsoft.AspNetCore.Mvc
Fixes #7684
2018-06-19 16:11:47 -07:00
James Newton-King 3547341762
Add support for conventional routes with dispatching (#7928) 2018-06-20 09:02:52 +12:00
Kiran Challa a0a9c2c585 Integrate Dispatcher's link generator
Related to https://github.com/aspnet/Routing/issues/530
2018-06-19 04:14:05 -07:00
Pranav K a712ccc98a Fix up error message when compilation references are missing 2018-06-18 09:20:08 -07:00
Kiran Challa 6df28ef09a Reach to Dispatcher changes and fix build break 2018-06-15 09:30:07 -07:00
Ryan Brandenburg 7eac72ae46 Set 2.1 baselines 2018-06-14 11:09:28 -07:00
James Newton-King a7406d4497
Add MvcEndpointDataSource and functional tests (#7886) 2018-06-14 11:03:45 +12:00
Pranav K 287a3c5e69 Allow IgnoreAntiForgeryToken applied on Razor Page models to work
Fixes #7795
2018-06-13 11:59:47 -07:00
Pranav K 6c2ef122f8 Add support for conventions in DefaultApiDescriptionProvider 2018-06-11 16:07:09 -07:00
Brecht Carlier 203258d00e Update AnchorTagHelper.cs
Fixed incorrect documentation
2018-06-08 15:13:28 -07:00
Pranav K c29527f992
Add some assertions for controllers and controller actions 2018-06-08 15:00:19 -07:00
Pranav K f2eb6f8d37 Add some tests for CodeAnalysisExtensions 2018-06-08 14:58:29 -07:00
Ryan Brandenburg b7064c576d Use templates for VSTS builds 2018-06-07 12:37:01 -07:00
Nate McMaster 672c794335
Add certificate names for code signing 2018-06-05 22:34:04 -07:00
Pranav K 592ed3b4f5
Create an analyzer to warn users not to decorate filters on page handler methods
Fixes #7684
2018-06-05 17:23:30 -07:00
Pranav K f0c552ee49
Fixup DebuggerDisplay for PageActionDescriptor 2018-05-31 13:47:39 -07:00
Pranav K 8e31319215
Prevent null refs in some simple cases in CachedExpressionCompiler
Fixes #6928
2018-05-29 11:09:48 -07:00
Ryan Brandenburg edf4e8fd9e DataAnnotations of Enum values use DataAnnotationLocalizerProvider 2018-05-25 16:00:00 -07:00
Kiran Challa 418aac57f4 [Fixes #7609] ApiBehaviorApplicationModelProvider overwrites existing BindingInfo in entirety when inferring binding sources 2018-05-24 14:28:42 -07:00
Pranav K 49c653ed0b Infer BindingSource.FormFile for IEnumerable<IFormFile>
Fixes #7770
2018-05-22 11:05:09 -07:00
Nisha Kaushik 077b1d87a9 #7024 Request: ServiceBasedPageModelActivatorProvider [Review Changes] 2018-05-22 10:23:08 -07:00
Nisha Kaushik 0c795c4f33 #7024 Request: ServiceBasedPageModelActivatorProvider 2018-05-22 10:23:08 -07:00
Pranav K e1eaf6a6e0
Cleanup TestCommon 2018-05-18 10:45:57 -07:00
Pranav K 624a5ed522 Fix ActionMethodExecutor incorrectly setting DeclaredType on ObjectResult
Fixes #7782
2018-05-18 10:43:28 -07:00
Pavel Krymets a736441ca5
Enable analyzers (#7789) 2018-05-18 10:26:42 -07:00
Kiran Challa 4472c00c6f PR feedback fixes for logging requestpredicate shortcircuit logging 2018-05-17 11:17:29 -07:00
Kiran Challa d80471ad15 Added logging to model binding requestpredicate shortcircuit 2018-05-15 14:13:03 -07:00
Sébastien Ros 19d82928ba
Making Razor compilation cache replaceable (#7780) 2018-05-15 11:36:47 -07:00
Pranav K d9f035ad7c
CacheTagHelper should be able to vary by culture
Fixes #3398
2018-05-13 14:21:08 -07:00
Pranav K 1ca6ce3377 setupAction parameter in MvcLocalizationServices.AddLocalizationServices is never used
Fixes #7761
2018-05-09 18:12:15 -07:00
Pranav K 504da3c565
Cleanup CachedExpressionCompiler 2018-05-08 15:34:38 -07:00
Pranav K bda5ea9df0 Cleanup BindingInfo \ ModelMetadata coalescing in ModelBinderFactory
Fixes #7583
2018-05-08 10:24:18 -07:00
Pranav K 26454fb1da Add ViewComponentResult helper methods to Page \ PageModel
Fixes #7051
2018-05-07 16:35:29 -07:00
Pranav K dfd9b17f68
More keynotfound avoidance 2018-05-07 11:08:41 -07:00
Pranav K f35deb71f9 Prevent KeyNotFound when logging 2018-05-07 10:50:26 -07:00
Jass Bagga e0188c4936
Modify info level logging for pages (#7733)
Addresses #7602
2018-05-04 13:47:48 -07:00
Pranav K 777782ac6e Test cleanup 2018-05-03 16:03:42 -07:00
Kiran Challa 19c41c0494 Revert "[Fixes #6902] Added an overload for StatusCode that takes in System.Net.HttpStatusCode"
This reverts commit c567a690bc.

[Fixes #7709] Revert https://github.com/aspnet/Mvc/pull/6902
2018-05-01 13:27:57 -07:00
Ajay Bhargav Baaskaran 595e83d0eb Added nuspec file to Mvc.Analyzers assembly 2018-04-20 14:53:46 -07:00