4f1b7ccca6
Use ModelMetadata from actual types for validation
...
Fixes https://github.com/aspnet/Mvc/issues/7952
2018-07-12 12:46:49 -07:00
f179339a79
Combine BufferWriter and CountingBufferWriter
2018-07-12 11:58:49 -07:00
128eefdef3
Remove usage of the Microsoft.Extensions.Buffers.Sources package, copy the source into Kestrel
...
This moves source code that used to be in aspnet/Common. It was only used here, so this simplifies the process of working with these internal-only APIs.
cref https://github.com/aspnet/Common/pull/386
2018-07-11 22:31:23 -07:00
e5c501099a
Remove unused .Source packages
2018-07-11 21:33:51 -07:00
dbc930cc78
ResponseCache attribute on RazorPages Error handler method should be moved to model
...
Fixes #553
2018-07-11 14:50:40 -07:00
d2a8d3a61c
Fix cookie regression ( #1811 )
2018-07-11 13:14:51 -07:00
0ab8e15f05
[ Fixes #1866 ] Fix ActivePage declarations
...
* Fix missing activepage declarations
* Change activepage declarations to correct values
* Add missing ActivePage
2018-07-10 13:00:52 -07:00
1d9db7c25f
Merge 2.1.2 into release/2.1
2018-07-10 10:34:35 -07:00
3eae93082f
Merge 2.1.2 into release/2.1
2018-07-10 10:29:05 -07:00
bd995d4cb1
[ Fixes #7959 ] Conventional routing with custom templates not working when you have area attributes
2018-07-09 12:35:14 -07:00
bf03fee4be
Refactor LZMA generation to support Docker and Antares usage
...
List explicitly as .csproj files the scenarios for which the offline package cache is important
Produces new artifacts designed for various scenarios, such as:
* Docker (where xml doc files are not needed)
* Azure web apps (where 1.x SDKs must still be supported, but xml docs are not needed)
2018-07-06 13:15:23 -07:00
fa702ff6ef
Update AddSignalRCore to respect user registered services ( #2434 )
2018-07-05 12:52:33 -07:00
e7db3f840b
Handle pipe name with whitespace properly
2018-07-03 16:55:55 -07:00
727bd52b64
Add package version to Microsoft.AspNetCore.App in project templates
...
As discussed in aspnet/Home#3292 , we're reversing course on the implicit package version feature. This adds a package version for Microsoft.AspNetCore.App to the `dotnet new` and VS templates.
2018-07-03 16:53:46 -07:00
82f7f2aab8
Fix Api Explorer not returning type with ActionResult<T> and no type in ProducesResponseTypeAttribute
2018-06-29 12:00:16 -07:00
2d5a1737a2
Update Razor SDK packing logic to not include Pack at properties layer.
...
- Added test to verify that no-build scenarios work as expected.
#2378
2018-06-29 11:45:59 -07:00
c4d5ef94a9
Razor runtime compilation produces errors if running on a shared runtime that's rolled forward
...
Do not provide compilation references from runtime MVC assemblies. This avoids cases where the app is compiled
against an older MVC but running against a newer one (e.g. shared fx roll forward) resulting in compiling against multiple
versions of MVC assemblies
Fixes #7969
2018-06-29 11:17:25 -07:00
9273759dca
[2.1]: Remove unused project capability from Microsoft.AspNetCore.App ( #1237 )
...
Removing this from .App in 2.1.3 because this was unused, and the capability is not actually supported by VS. This will be re-added in the future versions of .App when we land the VS integration for in-process hosting.
cref https://github.com/aspnet/IISIntegration/pull/969
2018-06-29 11:02:39 -07:00
ac31e5ab30
[2.1.3] Consistently handle connection aborts ( #2619 )
...
* Decouple connection objects from the server (#2535 )
- Making progress towards being able to use the connection objects on the client side.
* Wait for input writer to complete before calling OnConnectionClosed (#2566 )
* Wait for the ConnectionClosed token to stop tracking connections (#2574 )
- The prior strategy of waiting for the pipe completed callbacks doesn't work
because blocks are returned to the memory pool after the callbacks are fired.
* Consistently handle connection resets (#2547 )
* Provide better connection abort exceptions and logs
* void IConnectionDispatcher.OnConnection
2018-06-28 10:51:22 -07:00
91a1d2de50
Add unit tests for the shared framework ( #1228 )
...
Changes:
* Add a test project with simple unit tests for the shared framework
* Add root-level Directory.Build.props/targets files
* Cleanup .csproj files to reduce duplication
2018-06-27 14:56:10 -07:00
d2dcd9c6b9
Set 2.1 baselines
2018-06-14 16:46:02 -07:00
606b3c590f
Set 2.1 baselines
2018-06-14 16:43:31 -07:00
aa24887d43
Set 2.1 baselines
2018-06-14 16:42:34 -07:00
4295027333
Set 2.1 baselines
2018-06-14 14:12:20 -07:00
4cb04470a5
Set 2.1 baselines
2018-06-14 14:10:10 -07:00
2328792540
Set 2.1 baselines
2018-06-14 11:40:22 -07:00
78fc556758
Set 2.1 baselines
2018-06-14 11:36:27 -07:00
a04813edc3
Set 2.1 baselines
2018-06-14 11:29:25 -07:00
61ced27c18
Set 2.1 baselines
2018-06-14 11:21:42 -07:00
887353707e
Set 2.1 baselines
2018-06-14 11:11:43 -07:00
78fc49ba0c
Set 2.1 baselines
2018-06-14 11:09:19 -07:00
bb49eeebe6
Set 2.1 baselines
2018-06-14 11:07:25 -07:00
4b93b75e78
Set 2.1 baselines
2018-06-14 11:06:20 -07:00
f43646e7a1
Set 2.1 baselines
2018-06-14 10:07:39 -07:00
d1235cdda0
Set 2.1 baselines
2018-06-14 10:06:58 -07:00
7922b27c65
Set 2.1 baselines
2018-06-14 10:06:06 -07:00
d1b1a8097b
Set 2.1 baselines
2018-06-14 10:02:28 -07:00
b7c722bb68
Set 2.1 baselines
2018-06-14 09:37:25 -07:00
c367db6226
Set 2.1 baselines
2018-06-14 09:36:28 -07:00
5bed1972fe
Set 2.1 baselines
2018-06-13 15:47:53 -07:00
01477ecf61
Set 2.1 baselines
2018-06-13 15:47:05 -07:00
9215a8a3ee
Set 2.1 baselines
2018-06-13 13:54:40 -07:00
ff3f0e905d
Merge branch 'release/2.1' into release/2.1.2
2018-06-12 14:16:29 -07:00
e4d290b601
Fix Json regression in Socket Transport ( #2578 )
2018-05-31 16:28:25 -07:00
d1416e679b
[2.1.1] Provide clearer exception message for breaking change ( #2623 )
...
- In 2.1, the default transport (Sockets) can no longer bind to certain
endpoint types (Unix domain sockets and open socket handles).
- The new message recommends manually selecting the libuv transport
to work around this issue.
2018-05-31 15:45:26 -07:00
af177c5adc
Add Memory<byte> overloads to HttpUpgradeStream ( #2622 )
2018-05-31 15:44:39 -07:00
9e15b2bca4
Fix PipeReader consumption pattern [2.1]
2018-05-31 11:27:38 -07:00
a5fb8a3d3c
[ Fixes #523 ] Fix the jquery.min.js file in RazorPages web application
2018-05-30 16:01:45 -07:00
74883b2cf0
[ Fixes #528 ] Windows authentication is not applied on launchSettings.json
2018-05-30 14:05:59 -07:00
c976d0aa6e
[2.1.1] Gracefully handle disposing while writing ( #2180 ) ( #2355 )
2018-05-30 10:33:31 -07:00
0452f460c6
Fix not reading to end of argument JSON on binding error ( #2319 ) ( #2360 )
2018-05-30 09:25:35 -07:00
2d63669695
[ Fixes #7609 ] ApiBehaviorApplicationModelProvider overwrites existing BindingInfo in entirety when inferring binding sources
2018-05-30 05:30:10 -07:00
52a9e7a54d
Remove obsolete reference in Angular template home. Fixes #470
2018-05-30 11:22:14 +01:00
5ec7bacdfe
Lower severity of AuthenticationException logs from SslStream handshake ( #2614 )
2018-05-29 16:27:16 -07:00
6e67c9345c
Remove reference to Microsoft.AspNetCore.Mvc.Razor.ViewCompilation from desktop templates
...
Fixes #530
2018-05-29 15:23:03 -07:00
9c3a331e4f
Allow publish to work when BuildProjectReferences=false
...
Fixes #2363
2018-05-29 15:17:01 -07:00
984cd46c4d
Fix ActionMethodExecutor incorrectly setting DeclaredType on ObjectResult
...
Fixes #7782
2018-05-29 14:35:42 -07:00
0f12047271
Fix dependency versions for Hosting and Mvc.RazorPages
2018-05-29 14:27:47 -07:00
3fa10f92ad
Fix losing UTC DateTimeKind on ISO8601 UTC values ( #2317 ) ( #2357 )
2018-05-29 11:27:29 -07:00
2629ceed08
CheckPassword only reset lockout when TFA disabled
2018-05-17 14:05:39 -07:00
ef9fa1868a
Fix SRI hash values for jquery ( #521 )
2018-05-16 11:49:40 -07:00
5403ec47ec
Fixed sha-integrity content of script tags in IdentityUI's cshtml files
...
Related to https://github.com/aspnet/templating/issues/520
2018-05-16 11:46:58 -07:00
e1a22b315d
Android HttpClientHandler.ClientCertificates fix ( #2270 )
2018-05-16 11:25:39 -07:00
95f543848c
Fix multiple connections for a single user in Redis and MemoryLeak ( #2273 )
2018-05-15 15:57:23 -07:00
b7eacbb1c3
Upgrade node-sass to 4.9.0
...
[Fixes #513 ] Angular template incompatible with NodeJs 10
2018-05-11 13:26:45 -07:00
da21fc89cf
Handle exception in SocketConnection.Shutdown() ( #2562 )
2018-05-10 23:39:06 -07:00
e6a88c1b9c
Relieve response backpressure immediately when closing socket ( #2557 )
...
* Relieve response backpressure immediately when closing socket
2018-05-10 17:13:57 -07:00
4b1fb58a8a
Throw error on unexpected close ( #2205 )
2018-05-10 16:38:21 -07:00
6f6382799b
Use params passed into HubConnectionBuilder ( #2223 )
2018-05-07 18:19:20 -07:00
05d68efbae
Merge branch 'release/2.1.0-rc1' into release/2.1
2018-05-07 14:35:41 -07:00
5c17bff55d
Don't throw on FIN from upgraded connections ( #2533 )
...
* Allow app to drain request buffer after FIN
2018-05-04 16:21:07 -07:00
e306b8680e
Fix namespace for AddDefaultIdentity ( #1781 )
2018-05-04 14:05:13 -07:00
b492dbe5d1
fix #2187 by passing min size through to buffer writer when encoding ( #2190 )
2018-05-03 19:10:15 -07:00
361caff1ad
Remove managed InProcess code ( #809 )
2018-05-03 17:18:33 -07:00
89956df7ea
[Review] Updated migrations and scripts ( #484 )
...
* Update migrations
* Add regex for schema name and product version
* Fix ModelSnapshot product version
* Change version to 2.1.0
2018-05-03 13:22:26 -07:00
99114c25a4
Adjust spacing in csproj files ( #492 )
...
Address #462 and fix build break
2018-05-03 11:40:39 -07:00
8c7f33a6d7
Port C# client perf fix to release ( #2189 )
2018-05-02 21:53:39 -07:00
41c0a69c5b
Allow build server to run on net46
2018-05-02 16:17:09 -07:00
622e133a8a
fix #2134 by disposing httpconnection if start fails ( #2137 ) ( #2188 )
2018-05-02 13:10:58 -07:00
d6f15759fd
Add property to allow the SDK to disable shared framework trimming ( #1130 )
...
The MicrosoftNETPlatformLibrary property instructs the .NET Core SDK to treat a particular package as the shared framework platform. This affects how the SDK will trim references and publish output, determines how the runtimeconfig files are generated, and may affect how optimizations are preformed by other tools. In some installations of .NET Core, the ASP.NET Core shared framework is not available. This change adds properties to let the SDK determine on which platforms ASP.NET Core is enabled.
2018-05-02 08:49:03 -07:00
41c8dcf449
Fix not setting HttpConnection.ConnectionId ( #2154 )
2018-05-01 21:48:57 -07:00
3e906fb64a
Minor API cleanup ( #2147 )
2018-05-01 17:51:08 -07:00
555c1fd720
Fix not detecting marker service ( #2149 )
2018-05-01 17:42:00 -07:00
e0e9eb0b36
Add pre-generated shims to dotnet tool packages
2018-05-01 16:57:36 -07:00
a94323499b
Change CopyToPublishDirectory on Content items instead of explicitly removing this from publish items
...
Fixes #2295
2018-05-01 16:50:49 -07:00
05c84f008a
Ensure Views dll are copied during P2P builds
...
FastUpToDateCheck in VS doesn't account for changes solely to .Views.dll. This causes referencing projects to be treated as
up to date even though a referenced project rebuilt. Touch the marker file to cause referenced projects to rebuild.
Fixes https://github.com/aspnet/Razor/issues/2306
to cause it to treat
2018-05-01 16:50:49 -07:00
8d99ba53ce
Make incremental build in VS copy output files
...
Fixes #2306
2018-05-01 16:50:49 -07:00
d711916ad6
fix #2140 by ensuring the access token flows to WebSocketTransport ( #2173 )
2018-05-01 16:14:24 -07:00
295801ac50
XML documentation ( #2106 )
2018-05-01 16:08:09 -07:00
2c1376c95f
Add a AddHostedService extension #1402
2018-05-01 14:07:24 -07:00
601f41026a
Updated icon for RazorClassLibrary
2018-05-01 13:34:51 -07:00
19c41c0494
Revert "[ Fixes #6902 ] Added an overload for StatusCode that takes in System.Net.HttpStatusCode"
...
This reverts commit c567a690bcFixes #7709 ] Revert https://github.com/aspnet/Mvc/pull/6902
2018-05-01 13:27:57 -07:00
a89dc30d43
AllowAnonymous for external login providers and confirm email ( #1769 )
...
Addresses #1762
2018-05-01 12:30:46 -07:00
1717b97444
Run self-host tests with no-build. #1399
2018-05-01 12:22:36 -07:00
b0e1fa5e30
Fix connection abort
2018-04-23 17:01:49 -07:00
0d047d64f3
Remove explicit reference to NETStandard.Library when using .NET Framework
2018-04-23 13:32:50 -07:00
0f131ac245
Disambiguate /p from -p on dotnet-run
2018-04-21 08:13:29 -07:00
ed7e6db79e
Attempt to fix more failing tests in prodcon builds
2018-04-21 08:01:30 -07:00
47eafca4d8
CancellationToken EVERYWHERE ( #2101 )
2018-04-20 16:21:51 -07:00
2a10e6fe1d
Added nuspec file for Mvc.Razor.ViewCompilation to include symbols
2018-04-20 15:26:34 -07:00
aa181128ac
Generate symbol nupkgs for tools
2018-04-20 15:10:03 -07:00
595e83d0eb
Added nuspec file to Mvc.Analyzers assembly
2018-04-20 14:53:46 -07:00
5d5222cdd8
Introduce BindPropertiesAttribute
...
* Allow controller and Razor Page models to be annotated with BindPropertiesAttribute
* Disallow BindPropertyAttribute from being declared on types.
* Do not allow arbitrary binding attributes to be applied to Razor Page models.
Fixes #7686
2018-04-20 14:32:14 -07:00
058830c9df
fix #2116 by requiring task return values from typed client ( #2117 )
2018-04-20 13:49:12 -07:00
9101ab636b
Always check for WebSockets close ( #2100 )
2018-04-20 08:21:04 -07:00
5516a969e3
Change Hub and friends to abstract ( #2108 )
2018-04-20 20:53:01 +12:00
ace9a0d414
fix #2097 by adding GetHttpContext to HubConnectionContext ( #2099 )
2018-04-19 19:14:39 -07:00
1957655653
Run hub invocations serially ( #2086 )
2018-04-19 16:59:06 -07:00
a8c3615df4
React to implicit Microsoft.AspNetCore.App reference
2018-04-19 16:49:13 -07:00
6b6d890c8f
fix #2078 by adding locking ( #2079 )
2018-04-19 15:32:04 -07:00
53c25198fd
Revert "Produce the Microsoft.AspNetCore.AzureAppServices.SiteExtension package on normal builds ( #188 )"
...
This reverts commit 0921e5b60f
2018-04-19 15:08:17 -07:00
44e282e8d4
Generate symbols.nupkg for Mvc.Razor
2018-04-19 12:32:36 -07:00
30928ba944
Disable implicit package version verification when --no-restore is used
...
Workaround an error when building in ProdCon where the RuntimeFrameworkVersion is overridden externally. Generally, the error is good, but when --no-restore is specified, we are okay ignoring this verification.
2018-04-19 12:24:10 -07:00
0921e5b60f
Produce the Microsoft.AspNetCore.AzureAppServices.SiteExtension package on normal builds ( #188 )
2018-04-19 11:00:10 -07:00
676bf179f3
Reduce redundant dependencies ( #2091 )
2018-04-19 00:18:52 -07:00
e9937ffb66
Split lock into WriteLock and StateLock to prevent deadlocks and unneeded lock contention ( #2081 )
2018-04-18 17:44:05 -07:00
d2fe76be21
Write process and pipe information to a pid file
2018-04-18 14:51:28 -07:00
903fe1e902
Added support for negotiate response to redirect the client to another SignalR endpoint ( #2070 )
...
- Add a SkipNegotiation flag to the .NET and ts client
to allow skipping the negotiation phase. Don't infer it based on the transport type.
- Updated the negotiate protocol to support returning a redirect url
- Added support to .NET client to handle redirect negotiations
- Handle poorly written endpoints that sends infinite redirects
- Added access token support and an infinite redirect guard
- Add delete handler for stopping the transport
2018-04-18 14:22:45 -07:00
60a9810268
Allow PartialTagHelper to specify a null model. Fixes #7667
2018-04-18 14:16:44 -07:00
faca3da42f
Ensure ViewData is set on PageResult after a handler method executes
...
[Fixes #7665 ] Initializing PageResult.Page as part of result execution breaks Identity UI
2018-04-18 11:44:04 -07:00
4f7d53f4e7
[ Fixes #7658 ] FileStreamResultExecutor fails to Dispose FileStream
2018-04-18 11:43:09 -07:00
6e4bd1eb46
Fixed PageFilter docs
2018-04-18 11:42:40 -07:00
1cede88f26
[ Fixes #7656 ] Deps file for netstandard2.0 targeting projects copied by Microsoft.AspNetCore.Mvc.Testing does not play well with Mvc
2018-04-18 11:03:52 -07:00
5c9b64244a
Expose the IHubProtocol on HubConnectionContext ( #2073 )
2018-04-18 10:35:55 -07:00
13e746c289
Update THIRD-PARTY-NOTICES link and remove Package Management panel from carousel ( #474 )
...
Addresses #330 and #469
2018-04-18 09:42:27 -07:00
b4046b5ed8
Fix #1989 by adding a 'binding failure' pseudo-message ( #2064 )
2018-04-17 20:08:07 -07:00
e781cd38cf
[ Fixes #7635 ] Provide a way to configure HTTP Client instances
2018-04-17 12:52:56 -07:00
e0b4c13895
[ Fixes #7587 ] Default to Development environment in tests
2018-04-17 12:52:51 -07:00
e0e96ce53b
Include parameter type's attributes in ModelMetadata
...
- #7595
- #7595 relates to #7350 but does not have the same root cause
- did _not_ revert the src changes in #7350 fix (d995b0418a
2018-04-17 12:40:38 -07:00
e06b1fd690
[ Fixes #1242 ] Moves IStartupConfigureServicesFilter and IStartupConfigureContainerFilter interfaces to the internal namespace
2018-04-17 12:31:09 -07:00
dc997821cc
Added nuspec and symbols.nuspec files to Razor.Design
2018-04-17 11:07:34 -07:00
8985fee4b5
Merge
2018-04-17 20:39:19 +12:00
05d6bbb782
Flush first long poll immediately ( #2032 )
...
There was a race condition between the first poll and any other http request that was sent.
In particular, if you called StartAsync then StopAsync it was possible for the delete to happen before the poll started leading to 400 errors. This change fixes that by making the very first poll
return immediately so that the client can use that to determine if there was an error connecting.
2018-04-17 00:49:26 -07:00
d35bcea0a5
Move HubException and add serialization ctor ( #2049 )
2018-04-17 14:10:42 +12:00
52c45f2204
Merge remote-tracking branch 'origin/release/2.1' into rybrande/MergeRelease21IntoDev
2018-04-16 15:15:38 -07:00
c8d842c160
Merge remote-tracking branch 'origin/release/2.1' into rybrande/MergeRelease21IntoDev
2018-04-16 15:05:29 -07:00
3c40b9efd2
Merge remote-tracking branch 'origin/release/2.1' into rybrande/MergeRelease21IntoDev
2018-04-16 14:24:13 -07:00
6fd09af374
Improve logging of request drain timeout ( #2480 )
2018-04-16 11:53:10 -07:00
c05c5a6b2a
React to aspnet/KestrelHttpServer#2496: make IConnectionInherentKeepAliveFeature a boolean feature ( #2041 )
2018-04-16 11:34:12 -07:00
3a45136cc4
make IConnectionInherentKeepAliveFeature a boolean feature ( #2496 )
2018-04-16 11:34:06 -07:00
a426334018
Expose IList instead of List
2018-04-16 10:44:22 -07:00
a5d9930802
API review changes ( #2043 )
...
- Make SerializedHubMessage and SerializedMessage
public
- Made HubConnectionStore public
- Move SendUtils and Utils to the internal folder
- Make Microsoft.AspNetCore.Http.Connections.Common/Internal public.
- Move InvocationRequest to internal folder
2018-04-16 10:31:10 -07:00
0a876cece7
Make https redirect no-op if no port is available #318
2018-04-16 09:49:43 -07:00
4d151a599e
Dynamically expand timeout when waiting for Angular CLI to be ready. Fixes #1611
2018-04-16 14:54:52 +01:00
78f7dccfab
Performance fix
...
- Usage of resolved loopback IP address instead of 'localhost'
Addresses #1588
2018-04-16 14:45:16 +01:00
927b08f893
Cache property access ( #2030 )
2018-04-15 23:23:00 -07:00
4f4dfe1d23
Move RedisLog to Internal namespace ( #2038 )
2018-04-16 18:08:26 +12:00
b5d5f11ef8
Rename excludedIds to excludedConnectionIds ( #2037 )
2018-04-16 18:03:16 +12:00
7745fd748a
Extension methods for IHubClients methods ( #2016 )
2018-04-15 22:43:26 -07:00
0da06fb5d2
Microsoft.AspNetCore.SignalR.Redis API review ( #2036 )
2018-04-16 15:56:49 +12:00
b3a9011698
API review changes for Microsoft.AspNetCore.SignalR ( #2033 )
2018-04-16 15:54:42 +12:00
6eac7049ba
Update text and binary formatter helpers to be shared ( #2035 )
2018-04-16 15:19:34 +12:00
d8fc2d4009
Fix test failures
...
* Disable deps file generation in class library project. This workarounds known issue - https://github.com/dotnet/core-setup/issues/3726
* Update RazorProjectRouteModelProvider to not specify a trailing slash. This produces paths with a single slash as opposed to two slashes messing with route creation.
* React to Microsoft.AspNetCore.Mvc.Razor.Extensions.Reference that shows up in the deps file.
2018-04-15 16:31:41 -07:00
a17320221e
Derp
2018-04-16 10:43:06 +12:00
62f14054eb
Capture and log prematurely closed connections
2018-04-16 10:41:35 +12:00
fbb13c4c1f
Improve response status logging
2018-04-16 09:38:47 +12:00
f8e641d007
Merge
2018-04-15 19:21:07 +12:00
725bb33949
Lazy initialize HttpConnectionContext.Items ( #2027 )
2018-04-15 19:06:13 +12:00
9d033aa9f9
Blah
2018-04-15 18:16:23 +12:00
c835288e84
Suppress web socket closing without handshake
2018-04-15 17:51:31 +12:00
ddc905c219
Add VerifyNoErrorsScope ( #1972 )
2018-04-15 11:12:21 +12:00
b9e7113c01
Move types out of .Core namespace and make method virtual ( #2024 )
2018-04-15 09:58:33 +12:00
377ed1b834
JsonHubProtocol and MessagePackHubProtocol version fields now private ( #2023 )
2018-04-15 09:58:05 +12:00
cc5ae02b7d
Fix binding & validating dictionaries of non-simple types in jQuery requests
...
- #7423
- retry failed inner bindings with alternate syntax in `ModelStateDictionary`
- use property syntax if first attempt tried index syntax and visa versa
- instantiate `ShortFormDictionaryValidationStrategy` with full `ModelState` keys
- can now provide exact `ModelState` keys that `ModelStateDictionary` used in inner bindings
- normalize model names without a leading period in `JQueryKeyValuePairNormalizer`
nits:
- take a few VS suggestions
2018-04-14 10:41:00 -07:00
5a77c8be25
API review Microsoft.AspNetCore.SignalR.Internal ( #2022 )
2018-04-15 00:23:26 +12:00
d6395a52bc
Send delete request after poll ends ( #2020 )
...
* Added test and fixed other test
2018-04-14 04:45:16 -07:00
0f8485cafc
Renamed class to match the file ( #2019 )
2018-04-14 04:08:26 -07:00
e4d0f2980e
Microsoft.AspNetCore.SignalR.Client refactor ( #2000 )
2018-04-14 21:09:41 +12:00
e30a02cee5
Less StringValue struct copies for header checks ( #2488 )
2018-04-13 18:21:50 -07:00
3f0a6ebc0d
API Review Dependency Injection ( #2015 )
2018-04-13 17:21:48 -07:00
1fbb940b82
Remove MSG from SignalR ( #2006 )
2018-04-13 17:08:02 -07:00
4984dd2cdd
Revert "[ Fixes #7587 ] No easy way to change ASPNETCORE_ENVIRONMENT"
...
This reverts commit 22510e1377
2018-04-13 16:51:25 -07:00
86a036cf76
Revert "[ Fixes #7635 ] Provide a way to configure clients in WebApplicationFactory"
...
This reverts commit 1e26571ba6
2018-04-13 16:50:38 -07:00
ae9aa9ebec
Add AllowAnonymous for resetting password navigation flow ( #1744 )
...
Addresses #1736 and aspnet/templating#448
2018-04-13 16:46:00 -07:00
c7f7f36210
API Review for Http.Connections ( #2010 )
2018-04-13 16:35:07 -07:00
95835d6c37
Continue generating RelatedAssemblyPart on assembly if GenerateAssemblyInfo=false
...
Fixes #2257
2018-04-13 16:14:37 -07:00
898b8cec84
Prepare for RazorAssemblyAttribute -> RazorTargetAssemblyAttribute rename
2018-04-13 16:13:44 -07:00
e5d9efbd48
Prepare for RazorAssemblyAttribute -> RazorTargetAssemblyAttribute rename
2018-04-13 16:12:19 -07:00
1e26571ba6
[ Fixes #7635 ] Provide a way to configure clients in WebApplicationFactory
2018-04-13 16:02:56 -07:00
22510e1377
[ Fixes #7587 ] No easy way to change ASPNETCORE_ENVIRONMENT
2018-04-13 16:02:56 -07:00
60b6ec047d
Don't fail the build when ExtensionDependencyChecker fails
2018-04-13 15:55:39 -07:00
f51af820a5
[ Fixes #1742 , #1722 , #1706 , #1725 , #1688 ] Fixes multiple issues
...
* Update test infrastructure to use the latest bits.
* Add tests for different types of users.
* Logout must redirect instead of just rendering
the page so that the identity in the request gets
properly updated
* Remove IUserFactory and IdentityUserFactory.
* Added tests to verify that the default UI endpoints are not accessible
when the default UI is not enabled.
* Update the user name at the same time when the email is updated.
2018-04-13 15:47:23 -07:00
d5e044f693
[ Fixes #7373 ] Assigning to the context's Result property, when implementing IPageFilter, causes an exception
2018-04-13 15:11:44 -07:00
faf2f3f065
Attempt to workaround issues with File.Move on NFS file shares ( aspnet/Home#2941 )
2018-04-13 15:08:28 -07:00
d0137a996c
Internalize Microsoft.AspNetCore.Http.Connections.Client.Internal ( #2014 )
2018-04-13 15:04:58 -07:00
021356bf27
Internalize classes in Http.Connections ( #2013 )
2018-04-13 14:57:37 -07:00
bfbd286ab6
Remove usages of obsolete APIs
2018-04-13 14:54:35 -07:00
2d51d23697
Add file logging to functional tests
2018-04-13 14:53:57 -07:00
8d1de6ec80
Make sure RazorSdk works when BuildingInVisualStudio \ BuildProjectReferences is disabled
...
Fixes #2247
2018-04-13 14:35:04 -07:00
a273e349ee
Fix error message ( #1752 )
...
Fixes https://github.com/aspnet/Identity/issues/1669
2018-04-13 14:31:35 -07:00
a9c7c322cb
Add "webapp" alias to RazorPages template.json ( #467 )
...
Addresses #325
2018-04-13 14:01:20 -07:00
d995b0418a
Allow BindPropertyAttribute to be specified on controller classes
...
Fixes #7350
2018-04-13 13:58:44 -07:00
f8dc5c4702
Obsoleted IRazorEngineBuilder APIs
2018-04-13 12:35:53 -07:00
499d39b364
rename MsgPack assembly only ( #2005 )
2018-04-13 12:01:45 -07:00
0919914e56
Internalize more classes ( #2004 )
2018-04-13 11:28:52 -07:00
5d52701cd2
Add Error razor page to Spa templates ( #464 )
...
Addresses #332
2018-04-13 11:11:01 -07:00
a8c0970cde
Check for non-null RequestServices ( #1378 )
2018-04-13 09:45:38 -07:00
2e761415e4
Implement IDisposable for derived types for WebApplicationFactory<T> ( #7637 )
...
* Implement IDisposable for derived types for WebApplicationFactory<T>
Add a protected Dispose method and a finalizer to WebApplicationFactory<T> for use in classes that derive from it and want to dispose of their own resources.
Resolves #7631 .
* Address review feedback
Only dispose of fields if disposing is true.
2018-04-13 09:30:33 -07:00
3e69fdc4ad
Delegate disposable to the IConnectionFactory ( #1999 )
...
- Added DisposeAsync to the IConnectionFactory. It's responsible for disposing the connection after the pipe has closed.
- Added dispose callback to WithConnectionFactory
- Don't wait for poll request to end before unwinding from the transport
- Make sure all http requests are done before returning from StopAsync in both SSE and longpolling
2018-04-13 09:16:23 -07:00
f824751bb9
Added Razor class library project template
...
[Fixes #323 ] Add a Razor class library project template
2018-04-13 04:21:49 -07:00
abe139ee16
Make the protocol and messages public ( #1994 )
...
* Move types to a .Protocol namespace
2018-04-13 01:53:41 -07:00
198013bfa3
Microsoft.AspNetCore.Http.Connections.Client refactors ( #1995 )
2018-04-13 20:13:58 +12:00
83dec1093a
Fixed flaky longpolling tests ( #1993 )
...
- Wait for disposal and removal of the connection
2018-04-13 00:42:31 -07:00
4a568e90d2
API review changes ( #1992 )
...
- Changed GetMessageBytes to return ReadOnlyMemory
- Make HandshakeProtocol.SuccessHandshakeData a readonly field
2018-04-13 00:25:02 -07:00
70c63fe9e8
Http.Connections.Client API Review changes ( #1987 )
2018-04-13 06:52:27 +00:00
0ee4a86564
Collapse AsSpan().Slice(..) into AsSpan(..) ( #1991 )
2018-04-12 23:15:47 -07:00
0053124ca4
Make Proxies Internal ( #1982 )
2018-04-13 00:38:16 +00:00
df4d901ae7
Fix 5 param On extension method ( #1984 )
2018-04-13 00:37:13 +00:00
10f3b6863e
Avoid nullref in KestrelEventSource ( #2483 )
...
* Avoid nullref in KestrelEventSource
* Improve HostNameIsReachableAttribute to speed up test discovery
2018-04-12 17:29:34 -07:00
4188d2fe68
sttimer changes to V2 ( #773 )
2018-04-12 17:11:38 -07:00
5fd1f9e0e5
Merge remote-tracking branch 'origin/release/2.1' into dev
2018-04-12 16:33:29 -07:00
5a2eb3becd
Include social logins and authenticator key as part of personal download ( #1745 )
2018-04-12 15:41:27 -07:00
9c83280770
Fixing couple issues ( #763 )
...
adding more logs and fix memory leak in case of configuration change and then shutdown
2018-04-12 14:10:25 -07:00
24328b8e88
fix #1281 by adding support for DELETE endpoint on server ( #1925 )
2018-04-12 12:39:08 -07:00
0992db9fd2
fix #1914 by switching RedisProtocol to MsgPack ( #1968 )
2018-04-12 12:10:51 -07:00
4e1ba2a6c7
Delay process exit in ConsoleLifetime #1329
2018-04-12 10:07:44 -07:00
ee12c4fcf2
Downgrade HTTPs handshake failures to debug #1853
2018-04-12 09:25:44 -07:00
c6fa9793eb
Make Protocols internal
2018-04-12 08:53:27 -07:00
4184b2406d
Updated to make routing always use UrlEncoder.Default and not depend on DI to get it.
...
[Fixes #513 ] RedirectToAction with Non-English Characters in Parameters and Authentication Causes Error
2018-04-12 05:15:45 -07:00
8b1a7e9199
API review feedback ( #1974 )
...
- Remove SetHttpContext
- Remove HttpContextFeature
- Add and implement IHttpTransportFeature on HttpConnectionContext
- Remove ConnectionMetadataNames
2018-04-12 03:50:14 -07:00
d4773e831c
Set default transport and application buffer sizes ( #1964 )
2018-04-12 18:23:00 +12:00
7563ccae20
Always use TaskCreationOptions.RunContinuationsAsynchronously ( #1966 )
2018-04-12 18:21:20 +12:00
3c8c8ea8e1
React to Kestrel changes ( #1969 )
2018-04-11 20:29:17 -07:00
ca44b4adfc
Moved kestrel specific features into transport abstractions ( #2482 )
2018-04-11 20:23:48 -07:00
e34b4e8335
Use DependencyContext.CompileLibraries to determine dependency graph ( #7626 )
...
* Use DependencyContext.CompileLibraries to determine dependency graph
Fixes https://github.com/aspnet/Mvc/issues/7617
2018-04-11 15:57:11 -07:00
f6b2880369
Flow the ConnectionContext to the SNI callback ( #2478 )
2018-04-11 15:56:25 -07:00
08f9990c39
Ensure there's a redis connection earlier
2018-04-11 15:25:38 -07:00
9cea47fa7d
Remove root directory customization options for Razor Pages areas
...
Fixes #7608
2018-04-11 15:25:31 -07:00
9365fcd053
Don't publish the refs directory when the app does not have any Razor files
...
Fixes https://github.com/aspnet/Razor/issues/2246
2018-04-11 15:20:16 -07:00
b8c3273cae
Dont always copy handlers ( #1945 )
2018-04-11 22:19:51 +00:00
c3ac7629d1
WebAPI launchUrl; MVC _LoginPartial; F# AllowedHosts ( #463 )
...
Addresses #455 , #392 , #445
2018-04-11 15:01:32 -07:00
e8bb88cb58
Fixing typo ( #2477 )
2018-04-11 14:27:53 -07:00
6d9df1ef33
Noop Razor Sdk for F# projects
2018-04-11 14:18:19 -07:00
0b5cb8a8b8
Reload HostFilteringOptions on change
2018-04-11 12:23:14 -07:00
768cad8a8a
Reload HostFilter options on change #317
2018-04-11 11:44:58 -07:00
8cc851ff9b
Clean up timer code with custom awaitable ( #1935 )
...
- Gets rid of locks by using an event loop
2018-04-11 10:39:29 -07:00
cb5bba36fc
Get off the event loop before dispatch ( #1952 )
2018-04-11 10:39:09 -07:00
b7b6bd9533
React to updates in dependencies and removal of System.Runtime.CompilerServices.Unsafe from netcoreapp ( #429 )
2018-04-11 09:59:22 -07:00
62272ad56a
Round off file result's LastModifiedDate to whole seconds for correct comparison with http header dates
...
[Fixes #7572 ] PhysicalFileResult does not respond 304 Not Modified
2018-04-11 06:43:50 -07:00
12b69a0fdb
Refactor HttpOptions in client ( #1942 )
...
- Rename HttpOptions to HttpConfigurationOptions
- Remove HttpConfigurationOptions from SignalR client project
- Updated client HttpConnection ctors
2018-04-11 20:20:04 +12:00
e2fbff2bd5
Feedback
2018-04-10 23:00:18 -07:00
b30c2fecbf
SSE formatting refactor ( #1916 )
2018-04-11 17:13:15 +12:00
c83baf2b76
Remove params from message ctors ( #1931 )
2018-04-11 12:11:13 +12:00
13f7981010
Rename Callback to Configure in UseConnections ( #1939 )
2018-04-11 00:08:22 +00:00
e2169ceda6
Connect to Redis asynchronously ( #1922 )
2018-04-10 23:48:11 +00:00
46efcd9332
Move srwWrapper to right location
2018-04-10 14:43:05 -07:00
5c91dbe062
Get tests working
2018-04-10 14:21:23 -07:00
da513bd8d8
Get build.cmd working and cleanup ignored files.
2018-04-10 14:21:00 -07:00
df9efa0770
Code changes to get ANCM current working on github
2018-04-10 14:19:53 -07:00
b594130020
Adds source code from VSTS
2018-04-10 14:19:53 -07:00
157e7f4fdd
Creates two separate projects for ANCM V1 and V2.
2018-04-10 14:19:32 -07:00
bec259f976
#364 - Expose HTTP_503_RESPONSE_VERBOSITY option ( #447 )
2018-04-10 12:08:33 -07:00
6629236a0e
Merge pull request #767 from aspnet/pakrym/perf
...
Improve performance
2018-04-10 12:07:26 -07:00
da32f45f58
Do not set sslPort if HTTPS not configured ( #458 )
...
Addresses #457
2018-04-10 12:02:10 -07:00
d63e8c5558
CPP
2018-04-10 11:04:34 -07:00
5504374125
Preserve directive node diagnostics in document node
2018-04-10 10:24:21 -07:00
ee2e46a614
What about now?
2018-04-10 09:08:13 -07:00
6b18dea711
Replace Constants.CompletedTask with Task.CompletedTask ( #235 )
2018-04-10 08:58:39 -07:00
61f7c82d49
Replace Helpers.CompletedTask and Helpers.CanceledTask ( #446 )
2018-04-10 08:57:25 -07:00
80e799d17c
PR comments
2018-04-10 08:30:37 -07:00
8a3516284e
Add GetMessageBytes to IHubProtocol ( #1915 )
2018-04-10 07:14:09 -07:00
31dfe91962
Support async access token factory ( #1911 )
2018-04-10 05:34:10 -07:00
6bc2ebb4c5
Use invariant culture and ordinal comparisons ( #1928 )
2018-04-10 16:52:19 +12:00
b030ab7e49
Update Connections.Abstractions.csproj ( #2473 )
2018-04-09 17:55:14 -07:00
6d050140e5
Swtich to MessagePack-CSharp ( #1879 )
2018-04-09 17:04:32 -07:00
e32b51d6e6
ENdpoint
2018-04-09 16:47:01 -07:00
f0eab4410a
Cleanup
2018-04-09 15:20:28 -07:00
7a14be006d
Fast reads
2018-04-09 15:16:47 -07:00
39053a5e22
Corrects spelling of some comments
2018-04-09 14:37:20 -07:00
5e5aa90575
Remove continue with
2018-04-09 14:26:28 -07:00
0feb83b637
Dont format some things
2018-04-09 12:10:32 -07:00
ec31ff0c28
Throw if multiple Body bound parameters are discovered
...
Fixes #6963
2018-04-09 11:20:34 -07:00
dca31cc6f6
Perf
2018-04-09 10:34:44 -07:00
01089da84d
Use in for ReadOnlySequence ( #1900 )
2018-04-09 09:29:27 -07:00
95e868b68c
Remove JsonSerializer ( #1913 )
2018-04-09 02:56:46 -07:00
406d8f9a81
readonly readonly structs ( #1908 )
2018-04-08 23:28:37 -07:00
8f1781f7eb
Cleanup LogEvent calls
2018-04-08 19:21:55 -07:00
bd78785f8d
Minor DefaultHubLifetimeManager improvements ( #1904 )
2018-04-09 12:31:14 +12:00
9fd713c73a
Make MemoryBufferWriter a Stream ( #1907 )
...
- Get rid of LimitArrayPoolWriteStream and use MemoryBufferWriter in its place in the MessagePackProtocol implementation.
- Added tests for MemoryPoolBufferWriter and fixed a bug in CopyToAsync
- Added CopyTo(`IBufferWriter<byte>`)
- Changed MemoryBufferWriter to fill the underlying arrays that back segments, the segment size is now a minimum.
2018-04-08 16:11:17 -07:00
27d18578d0
Use expression body properties and implicit arrays where possible ( #1906 )
2018-04-08 21:40:01 +12:00
0f663cadc4
readonly all the things ( #1901 )
2018-04-08 15:47:01 +12:00
4760cce6aa
Remove IConnection ( #2472 )
2018-04-07 18:55:59 -07:00
a3337eb6bd
Remove traces of ASP.NET Core Sockets ( #1899 )
2018-04-07 17:51:12 -07:00
c1049b722d
The grand unification of ConnectionContext ( #1895 )
...
This change rationalizes the 2 very similar abstractions that exist in Connections.Abstractions, IConnection and ConnectionContext. It also introduces an IConnectionFactory to SignalR that is used to create a new ConnectionContext for a HubConnection.
- HubConnection just completes both ends of the transport pipe instead of calling DisposeAsync.
- Implemented ConnectionContext on HttpConnection and added HttpConnectionFactory
- Updated tests
2018-04-07 16:19:01 -07:00
e3da7feab4
Clean up client ITransport interface ( #1893 )
...
- Transports own the pipe creation. The fact they are 2 sides is an implementation detail.
2018-04-07 15:11:42 -07:00
86083c0302
Removing native support for IObservable<T> ( #1890 )
...
- There are too many issues and questions with respect to back pressure and the buffering policy we should use when the client being streamed to can't support the data being pushed via OnNext.
As a result, we're dropping support for IObservable but keeping ChannelReader and we'll eventually support IAsyncEnumerable when that makes it into the BCL.
- Add sample showing Observable -> ChannelReader adaption
2018-04-07 15:10:39 -07:00
acc0b7ad0d
Serialize NegotiateResponse with IBufferWriter ( #1881 )
2018-04-07 15:50:13 +12:00
f632330d7f
Allocate pipe writer stream per connection ( #1885 )
...
- Don't create the PipeWriterStream per operation, make it per Connection
- Reduce the buffer size for CopyToAsync operations to 4K where possible instead of 81K (the default)
2018-04-06 14:36:35 -07:00
e51676fb47
Policheck errors
2018-04-06 13:01:20 -07:00
e3d90bdf6a
Fix graceful closing of pipes ( #1882 )
...
- Closing pipes gracefully in most cases. The only case where we forcefully close the pipes is during application shutdown
- Return 404 if sending to connection after disposal
- Added tests
2018-04-06 10:59:40 -07:00
5e019bd707
Add Microsoft.AspNetCore.All
...
Fixes https://github.com/aspnet/Mvc/issues/7605
2018-04-06 10:57:59 -07:00
84d43cb2d8
Remove extra class ( #1884 )
...
- Merged 2 DI classes in SignalR
2018-04-06 08:16:19 -07:00
a6bdb9b1ec
Fix typos in code documentation ( #1012 )
...
* Fix typos in code documentation
* Add missing detail to code documentation
2018-04-06 08:09:48 -07:00
4ddf8664c0
Don't throw from Observer's OnNext ( #1872 )
2018-04-06 00:35:04 -07:00
36edadabb4
Lock when sending data to connection ( #1876 )
2018-04-06 16:25:47 +12:00
cb5ece8a24
HttpTransportType refactor ( #1873 )
...
- Rename file to HttpTransportType.cs
- Add HttpTransportType.None
- Move All to static readonly field
- Make TransportType on client and service HttpConnectionOptions consistent
- Move setting defaults into ctor
2018-04-06 16:18:47 +12:00
921986d561
Fix AccessTokenFactory not being called with each request ( #1880 )
2018-04-06 15:46:36 +12:00
b0c4e9d0f7
0 byte read in WebSockets ( #1878 )
2018-04-05 18:50:30 -07:00
6270c1f47e
Merge branch 'rel/vs15.7' into dev
2018-04-05 16:28:17 -07:00
4cd24a2b08
Add experimental flag to un-special-case data-
...
This change allows blazor to opt into treating data- attributes the same
way as normal attributes in the parser.
2018-04-05 15:27:04 -07:00
Pranav K
Stephen Halter
Nate McMaster
Hao Kung
Anthony Stivers
Kiran Challa
Mikael Mengistu
Ajay Bhargav Baaskaran
Nate McMaster
Nathanael Marchand
N. Taylor Mullen
Ryan Brandenburg
Kiran Challa
Javier Calvarro Nelson
Andrew Stanton-Nurse
Steve Sanderson
James Newton-King
BrennanConroy
Pavel Krymets
Jass Bagga
Chris Ross (ASP.NET)
John Luo
David Fowler
Doug Bunting
Tadas Mazutis
Ben Adams
Martin Costello
Ahson Khan
Justin Kotalik
pan-wang
Sébastien Ros
FabianMeiswinkel
Kristian Hellang
Vegard Løkken
flash2048
Nate Barbettini
Ryan Nowak