Kiran Challa
7e26af908e
[ Fixes #6514 ] Add default ctor overload to AuthorizeFilter
2017-12-12 14:07:02 -08:00
Kiran Challa
821daa5ad0
[ Fixes #7085 ] ApplicationModelConventionExtensions should make a copy of collections when iterating them
2017-12-12 14:03:35 -08:00
Kiran Challa
db38da7edb
Fix Xml formatters to taking in MvcOptions to take affect of options mutation
...
Related to issue [Fixes #6858 ] Changes to MvcOption's settings (SuppressInputFormatterBuffering & AllowBindingUndefinedValueToEnumType) are not taking affect
2017-12-06 11:44:35 -08:00
Kiran Challa
629f87181a
[ Fixes #6858 ] Changes to MvcOption's settings (SuppressInputFormatterBuffering & AllowBindingUndefinedValueToEnumType) are not taking affect
2017-12-04 14:25:41 -08:00
Pranav K
b6144142fe
Update samples and tests to target netcoreapp2.1
2017-11-13 14:58:40 -08:00
Steve Sanderson
d9825d1547
Better JSON deserialization errors. Implements #4607 , #4862
2017-11-06 23:02:13 +00:00
Pranav K
ab4c519dd5
Infer multipart/form-data for FromFile parameters
2017-11-02 09:36:31 -07:00
Nate McMaster
2e4bc548f5
Pin tool and package versions to make builds more repeatable ( #7013 )
2017-10-31 19:18:14 -07:00
Ryan Nowak
861d78fb78
Refactor content negotiation code into a service ( #6998 )
...
* Refactor content negotiation code into a service
This is a refactor in anticipation of using this logic in some other
places
2017-10-31 16:32:37 -07:00
Pranav K
41efa409a4
Remove TestOptionsManager
2017-10-30 17:49:15 -07:00
Pranav K
de2aef61ba
Make controllers with ApiControllerAttribute visible in ApiExplorer
2017-10-27 12:04:12 -07:00
Pranav K
8946a68923
Infer binding sources for ApiController parameters
...
Fixes #6847
2017-10-16 15:20:43 -07:00
Ryan Nowak
7ba167fcd8
Add 'default response' to API Response Type
...
Also some cleanup and unit tests.
2017-10-09 19:48:52 -07:00
Nate McMaster
3f02482617
Minor test code changes to resolve xUnit2013 build error
2017-10-05 16:04:20 -07:00
Sébastien Ros
d0a8b5f78f
Port fix for URL helper redirect ( #6917 )
...
Fixes #6910
2017-10-05 11:24:18 -07:00
Pranav K
950db6587c
Require attribute routing with [ApiController]
...
Fixes #6870
2017-10-04 13:13:20 -07:00
Ryan Nowak
e3ce1f52d4
Added Conflict result helper to ControllerBase
...
- Added ConflictObjectResult and ConflictResult types.
- Conflict(), Conflict(object error), Conflict(ModelState modelState)
added to ControllerBase.cs.
Fixes #6172
2017-10-02 15:05:57 -07:00
Jass Bagga
2fcfc6be7c
Add EnableRangeProcessing ( #6895 )
...
Addresses #6780
2017-09-29 18:39:45 -07:00
Jass Bagga
eeac99985a
Only set Content-Length when serving body ( #6886 )
...
Addresses #6875
2017-09-25 15:07:12 -07:00
Kiran Challa
83c3ac62fb
Updated formatters to wrap exceptions in InputFormatException for invalid input
2017-09-22 14:33:17 -07:00
Ryan Nowak
38712609bb
Design extensibility for executors
...
We have all of these executors but they aren't really
documented/supported for extensibility today. This change introduces a
pattern for action result executors so we can make them extensible.
2017-09-22 10:32:55 -07:00
Kristian Hellang
97fab8711a
Add UnprocessableEntityResult, UnprocessableEntityObjectResult and ControllerBase.UnprocessableEntity methods ( #6851 )
...
* Added UnprocessableEntityResult
* Added UnprocessableEntityObjectResult
* Added UnprocessableEntity overloads to ControllerBase
Fixes https://github.com/aspnet/Mvc/issues/6795
2017-09-22 09:27:29 -07:00
Steve Sanderson
236ef5d1d1
Support validation and BindBehavior on top-level action parameters and bound properties. Fixes #6790
2017-09-22 10:13:48 +01:00
Pranav K
7f214492b8
Introduce a filter to send bad request results with details when ModelState is invalid ( #6849 )
...
* Introduce a filter to send bad request results with details when ModelState is invalid
Fixes #6789
2017-09-21 11:09:32 -07:00
Pranav K
f0a5af2ba7
Revisit the unwrapping code in ControllerActionInvoker
...
Fixes #6679
2017-09-19 09:49:37 -07:00
Kiran Challa
23b7d8f62a
Added RequestFormLimits filter.
...
[Fixes #5128 ] Overriding Request Form max upload limit
2017-09-18 13:48:15 -07:00
Ryan Nowak
c09575dbd0
Fix #4914 patternize filter overrides
...
Adding some convenience methods to the context class and updating our
code to use them.
2017-09-18 12:12:44 -07:00
Pranav K
776c2604f8
Introduce opinionated API defaults.
...
* Introduce ProblemDescriptionAttribute to enhance some 4xx messages and produce better API description.
* Introduce IErrorDescriptionProvider to modify the shape of error response.
Fixes #6785 , Fixes #6786
2017-09-14 17:07:34 -07:00
Kiran Challa
35601f95b3
Added a model binder for handling Enum types. [ Fixes #6329 ] Why don't we check for Enum.IsDefined on action parameters of enum type
2017-09-14 08:25:05 -07:00
Kiran Challa
06f6de6c11
Changed RequestSizeLimitAttribute to create an authorization filter rather than a resource filter.
...
[Fixes #6777 ] RequestSizeLimit is ignored
2017-09-12 17:03:24 -07:00
Pranav K
717f1e6f7d
Normalize paths in RazorViewEngine prior to invoking page factory
...
Fixes #6672
2017-09-07 11:36:31 -07:00
Pranav K
a7cc243942
Introduce ProblemDescription
2017-09-06 18:46:35 -07:00
Pranav K
151cf44607
Introduce ActionResult<T>
2017-09-06 18:46:06 -07:00
bchavez
16c267d95e
House Cleaning - Spelling and grammar 🚿
2017-08-30 14:58:44 -07:00
Nate McMaster
b811e69d00
Use PackageLineup to manage PackageReference versions
...
- Move the Mvc.Performance project from test/ to benchmarks/.
- Remove the Version attribute on PackageReference.
- Add a reference to two PackageLineup's.
- Add snippet to README explaining the additional requirement to run build.cmd /t:restore.
- Add a target to check that packages have been pinned.
2017-08-30 12:14:11 -07:00
Pranav K
900a5c7c4c
Add support for ResponseCache in Razor Pages
...
Fixes #6437
2017-08-18 16:25:40 -07:00
Nate McMaster
3a710c3d64
Upgrade to xunit 2.3.0-beta4
2017-08-17 10:45:03 -07:00
Nate McMaster
b43b244830
Use Directory.Build.props/targets
2017-08-16 12:30:13 -07:00
Javier Calvarro Nelson
f2a8c1cea7
Refactor CORS support out of MVC Core
2017-08-14 11:40:56 -07:00
Pranav K
a5b55edb93
Fix filter order ( #6577 )
...
* Fix filter order
2017-07-21 10:50:34 -07:00
Hao Kung
36e24b7a31
Fix AuthZ Regression ( #6574 )
2017-07-20 21:18:53 -07:00
Jass Bagga
b4fe715c71
Revert breaking change ( #6519 )
...
Addresses #6518
2017-07-07 17:09:36 -07:00
Pranav K
288da1a405
RedirectToPage(page, handler) does not work ( #6503 )
...
Fixes #6436
2017-07-06 14:12:57 -07:00
Doug Bunting
c351712419
Add `FloatingPointTypeModelBinderProvider` and related binders
...
- #5502
- support thousands separators for `decimal`, `double` and `float`
- add tests demonstrating `SimpleTypeModelBinder` does not support thousands separators for numeric types
- add tests demonstrating use of commas (not thousands separators) with `enum` values
2017-07-03 17:55:04 -07:00
Hao Kung
eeee3ef731
Add SignOut overload + Use new auth api ( #6476 )
2017-07-03 12:32:11 -07:00
Henk Mollema
948982ebff
Create custom collection for model binder providers
...
Fixes #6161
2017-06-30 15:44:07 -07:00
Doug Bunting
f76a390a4e
Fall back to linear search for prefix matches
...
- #6469
2017-06-30 10:59:07 -07:00
Jass Bagga
17f6b17a6d
Add RequestSizeLimitAttribute ( #6453 )
...
Addresses #6352
2017-06-29 13:04:27 -07:00
Doug Bunting
a90f4118ad
Do not include type names in `ModelState` error messages
...
- #6076
- add resources and accessors specifically for the element / parameter cases
- avoid `metadata.GetDisplayName()` where possible
- fill in the `ValidationContext` that `ValidatorObjectAdapter` uses
- e.g. `Validate_NestedComplexType_IValidatableObject_Invalid()` test fails without this
Possible future work:
- improve error message used for `ModelMetadata.IsRequired` elements and parameters
- use something besides the type for `ValidationContext.DisplayName` of elements and parameters
nits:
- trailing whitespace
- use more `out var`
2017-06-28 15:16:23 -07:00
Henk Mollema
7166dfecd7
Add generic overloads on FilterCollection
2017-06-28 09:03:48 -07:00
Ryan Nowak
0ad9c7d4eb
Making Pages Binding Consistent
...
This changeset reckonciles the binding work we did for pages with
controllers.
A quick summary:
- Moves [BindProperty] to the MVC namespace (#6401 )
- Makes [FromRoute] and friends behave consistently (#6402 )
- Makes [BindProperty] work with controllers (untracked)
2017-06-26 18:11:44 -07:00
Pranav K
b1b7252ddc
Merge pull request #6383 from aspnet/rel/2.0.0-preview2
...
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 15:11:23 -07:00
Pranav K
d92d8cddeb
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 14:40:29 -07:00
Pranav K
a5f3a6425e
Remove TaskCache and TaskCacheOfT
2017-06-08 08:19:20 -07:00
Pranav K
8f883e8e13
Use RazorViewAttribute \ RazorPageAttribute for view discovery
2017-06-07 13:49:24 -07:00
Jass Bagga
7ffd88757d
Respond to RangeHelper refactor ( #6348 )
...
Respond to https://github.com/aspnet/StaticFiles/pull/200
2017-06-06 11:22:35 -07:00
Jass Bagga
a0d9b08f58
Set Content-Length and increase BufferSize ( #6347 )
...
Addresses #6045
2017-06-01 11:27:49 -07:00
Ryan Nowak
688e518991
Add result filters to pages
2017-05-26 12:33:46 -07:00
Ryan Nowak
84e007a2a7
Move exception and result filters in base
2017-05-26 12:33:46 -07:00
Ryan Nowak
e7bd6cfc06
Refactor invoker tests for reuse
2017-05-26 12:33:46 -07:00
Hao Kung
4c2d727e38
React to Auth + switch to Policy Evaluator
2017-05-25 18:23:41 -07:00
Ryan Brandenburg
03404cd3df
Return to NetStandard
2017-05-25 10:34:16 -07:00
Ryan Nowak
083f55e337
Delete pranav's test logs :)
2017-05-22 17:38:27 -07:00
Pranav K
c5f771d96d
Use factory pattern for caching in ControllerActionInvoker
2017-05-22 13:05:55 -07:00
Jass Bagga
9aff0a67c1
Range support for FileResult( #6150 )
...
Addresses #3702
2017-05-19 10:51:46 -07:00
Nate McMaster
d70bfdd1ea
Upgrade test framework versions and fix test issues
2017-05-15 14:11:27 -07:00
Steve Sanderson
014a786b45
Replace IModelBindingMessageProvider with new highly-virtual base class ( #6241 )
...
Replace IModelBindingMessageProvider with new highly-virtual base class. Fixes #6069
2017-05-10 16:02:18 +01:00
Ryan Nowak
e2cb8e8ac8
A new and exciting implementation of action selection
...
This is an improved implementation of the ActionSelector for conventional
routing. This will do fewer dictionary lookups than the decision tree, and
will avoid OrdinalIgnoreCase hashing in the common case.
2017-05-05 17:54:09 -07:00
Pranav K
64ffcfaa89
Merge pull request #6236 from aspnet/rel/2.0.0-preview1
...
Change TFM to netcoreapp2.0 (#6234 )
2017-05-04 22:18:48 -07:00
Pranav K
1c5e417606
Change TFM to netcoreapp2.0 ( #6234 )
...
* Change TFM to netcoreapp2.0
2017-05-04 18:11:26 -07:00
Steve Sanderson
6f3a295041
React to new ObjectMethodExecutor in Common
2017-05-03 15:40:02 +01:00
Ryan Brandenburg
42b988ad88
./ paths relative on page.
2017-04-25 11:57:58 -07:00
Pranav K
649ee4d28d
Add support for page handler to URL generating APIs.
2017-04-24 22:56:58 -07:00
Ryan Nowak
04fd762943
Rename form-action -> handler
2017-04-24 14:15:35 -07:00
Doug Bunting
141b637d20
Bump `MemoryPoolHttpResponseStreamWriter` buffer size up to 16K `char`s
...
- #3516
- fix tests that relied on otherwise-unused `HttpResponseStreamWriter.DefaultBufferSize`
2017-04-23 16:15:58 -07:00
Pranav K
ca017eced2
Add page to AnchorTagHelper and FormTagHelper
...
Fixes #6088
2017-04-21 18:12:54 -07:00
Pranav K
f568d3c2bc
Support finding "sibling" pages when using RedirecToPage
...
Fixes #6083
2017-04-21 18:12:52 -07:00
Ajay Bhargav Baaskaran
8eac7c2d6c
[ Fixes #6117 ] Added RedirectToPage overloads to Controller
2017-04-21 12:19:35 -07:00
Christopher Dresel
025870e8b9
Fix #6159 - Fix deep copy for ControllerModel and ActionModel
2017-04-21 07:41:14 -07:00
Kiran Challa
f4d84f50cd
Upgrading Moq to 4.7.1
2017-04-20 17:07:50 -07:00
Ryan Nowak
4bf518b09b
Fix #6140 - Allow linking between controller and page
...
The issue here is that route values used for action selection are
'global'. That means that pages need to have a 'null' route value for
'action' and controllers need to have a 'null' route value for pages. This
is the same way that areas work.
The fix is to move the 'merge' of route values up to a level where pages
and controllers can work together. Since ADPs use the russian-doll
pattern, the fix is to run this 'merge' in the controller ADP, but after
all of the ADs have been created.
2017-04-19 16:48:38 -07:00
Hao Kung
3e8cd1e7c9
MVC => Auth 2.0
2017-04-19 11:57:04 -07:00
Mike Harder
e766a259ed
Revert "Skip test `AssemblyPartTest.GetReferencePaths_ReturnsReferencesFromDependencyContext_IfPreserveCompilationContextIsSet`"
...
This reverts commit c69e48f06b .
2017-04-14 18:41:31 -07:00
Pranav K
49628bca2e
Use case invariant lookups for DependencyModel to workaround CLI version differences
2017-04-14 17:03:20 -07:00
Pranav K
8fa95d66d4
Add support for suppressing inbound and outbound routing
2017-04-14 17:02:45 -07:00
Mike Harder
c69e48f06b
Skip test `AssemblyPartTest.GetReferencePaths_ReturnsReferencesFromDependencyContext_IfPreserveCompilationContextIsSet`
...
- Workaround for "Can not find compilation library location for package" (https://github.com/dotnet/cli/issues/6318 )
2017-04-14 15:37:54 -07:00
Pranav K
c8a1bb6914
React to deps file casing change
...
Fixes #6122
2017-04-13 13:09:00 -07:00
Pranav K
dfbf6d43ff
Temporarily skipping ReferenceAssemblies_ReturnsLoadableReferenceAssemblies
2017-04-12 14:31:21 -07:00
Jass Bagga
1a8ac88da7
Add PreserveMethod ( #6075 )
...
Addresses #5609
2017-04-10 17:31:59 -07:00
Steve Sanderson
90acd055fe
Make [FromBody] treat empty request bodies as invalid ( #4750 )
2017-04-10 16:55:14 +01:00
Steve Sanderson
4f351bd37c
Add support for media type suffixes ( #5273 , #6032 )
2017-03-31 10:20:43 +01:00
Doug Bunting
824d65ca3d
Remove `ValueProviderResultExtensions`
...
- #5063
- update tests that used one extension method to instead use `ModelBindingHelper` directly
nit: `mbc` -> `context`
2017-03-24 22:17:34 -07:00
Pranav K
e7101f248a
Support model binding to Razor Pages properties on page and PageModel classes
...
Fixes #5952
2017-03-24 07:45:19 -07:00
Pranav K
705c36921a
Use alternate workaround for #6005
2017-03-22 19:14:46 -07:00
Pranav K
18785dbed6
Add System.Reflection.TypeExtensions to fix net46 tests
2017-03-22 06:33:04 -07:00
Pranav K
badb6ce8e5
Remove net451 as a cross-compile target
2017-03-22 06:32:50 -07:00
Nate McMaster
6f7717a381
Unify dependency versions to one file
2017-03-15 16:54:32 -07:00
Pranav K
de25357c28
Do not throw if a library does not have a runtime component
...
Fixes #5690
2017-03-14 15:07:50 -07:00
Ajay Bhargav Baaskaran
2ffaa88830
Using NullLogger types from Logging.Abstractions
2017-03-14 12:24:18 -07:00
Doug Bunting
9b3b3e91bd
Re-enable functional tests on full .NET Framework
...
- #5873
- creating an EXE for the test project seems to work around #5873
- also avoids dotnet/sdk#926 when building in Visual Studio
nit: clean up duplicate test data
2017-03-01 23:08:46 -08:00