5 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
Steve Sanderson
|
e0c32f42f4
|
Key support. Implements #8232 (#9850)
* Store component/element keys on RenderTreeFrame Also refactored how RenderTreeFrame gets constructed. The previous arrangement of having ad-hoc ctor overloads for different scenarios became intractible (too many combinations to avoid clashes; risk of accidentally losing field values when cloning). There's now one constructor per RenderTreeFrameType, so you always know where to add any new field values, and implicitly guarantees you don't lose other field values because adding a new param forces updates at all the call sites. * Add StackObjectPool, which will be useful momentarily * Support keyed insertions/deletions * Refactor AppendDiffEntriesForRange to prepare for adding "move" logic * Apply permutations on the JS side * Handle keyed moves by writing a post-edit permutation list * Shrink KeyedItemInfo struct * Include sourcemaps when building client-side Blazor apps with ReferenceFromSource * Update struct length of edit frames now it's explicit layout It's longer now because all the reference-type fields, except the last, now have to be 8 bytes for compatibility with 64-bit runtimes. Previously on Mono WebAssembly the reference-type fields were all 4 bytes. * Tolerate clashing keys (i.e., produce a valid diff, even if suboptimal) * Tolerate keys being added/removed incorrectly * E2E test harness for 'key' * Some more unit test cases * Invert diffing logic to prefer matching by key over sequence Previously it preferred sequence over key, but that's wrong, and surfaces as bugs when you mix keyed and unkeyed items. We need to prefer key over sequence, because key is meant to guarantee preservation, whereas sequence is just best-effort preservation. * Make unit test cases more adversarial * First actual E2E test * In E2E test, verify correct preservation of components * E2E tests for simple insert/delete cases (with and without keys) * E2E test for reordering. Also extend other tests to verify simultaneous editing. * E2E test for many simultaneous changes * Update reference sources * CR: Avoid x = y = z * CR: Only use 'finally' for actual cleanup * CR: Clean up RenderTreeFrame assignment * CR: Include 'key' in RenderTreeFrame.ToString() * CR: Avoid "new T()" in StackObjectPool * CR: Make KeyedItemInfo readonly * CR: Handle change of frame type with matching keys (and sequence) * CR: Add E2E test showing form + key scenarios * Preserve focus across edits * Tweak E2E test case * In client-side Blazor, prevent recursive event handler invocations * Actual E2E tests for moving form elements |
|
Pranav K
|
9a35bbea03
|
Experience for Razor SDK (#8731)
* Experience for Razor SDK * Remove Components.Build * Update MVC projects and templates to use AddRazorSupportForMvc * Update components templates to use .razor extension Fixes https://github.com/aspnet/AspNetCore/issues/6392 * Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190321.3 - Microsoft.NET.Sdk.Razor - 3.0.0-preview4.19171.3 - Microsoft.CodeAnalysis.Razor - 3.0.0-preview4.19171.3 - Microsoft.AspNetCore.Razor.Language - 3.0.0-preview4.19171.3 - Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview4.19171.3 * Update dependencies from https://github.com/dotnet/core-setup build 20190322.01 - Microsoft.NETCore.App - 3.0.0-preview4-27522-01 Dependency coherency updates - Microsoft.Bcl.Json.Sources - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - Microsoft.CSharp - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - Microsoft.Win32.Registry - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.ComponentModel.Annotations - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Data.SqlClient - 4.7.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Diagnostics.EventLog - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.IO.Pipelines - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Net.Http.WinHttpHandler - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Net.WebSockets.WebSocketProtocol - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Reflection.Metadata - 1.7.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Runtime.CompilerServices.Unsafe - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Security.Cryptography.Cng - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Security.Cryptography.Pkcs - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Security.Cryptography.Xml - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Security.Permissions - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Security.Principal.Windows - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.ServiceProcess.ServiceController - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Text.Encodings.Web - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - System.Threading.Channels - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App) - Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27522-01 (parent: Microsoft.NETCore.App) - Microsoft.NETCore.Platforms - 3.0.0-preview4.19164.7 (parent: Microsoft.NETCore.App) * Update dependencies from https://github.com/aspnet/EntityFrameworkCore build 20190321.4 - Microsoft.EntityFrameworkCore.Tools - 3.0.0-preview4.19171.4 - Microsoft.EntityFrameworkCore.SqlServer - 3.0.0-preview4.19171.4 - dotnet-ef - 3.0.0-preview4.19171.4 - Microsoft.EntityFrameworkCore - 3.0.0-preview4.19171.4 - Microsoft.EntityFrameworkCore.InMemory - 3.0.0-preview4.19171.4 - Microsoft.EntityFrameworkCore.Relational - 3.0.0-preview4.19171.4 - Microsoft.EntityFrameworkCore.Sqlite - 3.0.0-preview4.19171.4 * Update dependencies from https://github.com/aspnet/Extensions build 20190321.4 - Mono.WebAssembly.Interop - 3.0.0-preview4.19171.4 - Microsoft.JSInterop - 3.0.0-preview4.19171.4 - Microsoft.Internal.Extensions.Refs - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Diagnostics.HealthChecks - 3.0.0-preview4.19171.4 - Microsoft.Extensions.DiagnosticAdapter - 3.0.0-preview4.19171.4 - Microsoft.Extensions.DependencyInjection.Abstractions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.DependencyInjection - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.Xml - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.UserSecrets - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.KeyPerFile - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.Json - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.Ini - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.FileExtensions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.0-preview4.19171.4 - Microsoft.Extensions.FileProviders.Abstractions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.CommandLine - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.AzureKeyVault - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.Abstractions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration - 3.0.0-preview4.19171.4 - Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Caching.StackExchangeRedis - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Caching.SqlServer - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Caching.Memory - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Caching.Abstractions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.ActivatorUtilities.Sources - 3.0.0-preview4.19171.4 - Microsoft.AspNetCore.Testing - 3.0.0-preview4.19171.4 - Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview4.19171.4 - Microsoft.AspNetCore.Analyzer.Testing - 3.0.0-preview4.19171.4 - Internal.AspNetCore.Analyzers - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Configuration.Binder - 3.0.0-preview4.19171.4 - Microsoft.Extensions.FileProviders.Composite - 3.0.0-preview4.19171.4 - Microsoft.Extensions.FileProviders.Embedded - 3.0.0-preview4.19171.4 - Microsoft.Extensions.FileProviders.Physical - 3.0.0-preview4.19171.4 - Microsoft.Extensions.WebEncoders - 3.0.0-preview4.19171.4 - Microsoft.Extensions.ValueStopwatch.Sources - 3.0.0-preview4.19171.4 - Microsoft.Extensions.TypeNameHelper.Sources - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Primitives - 3.0.0-preview4.19171.4 - Microsoft.Extensions.ParameterDefaultValue.Sources - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Options.DataAnnotations - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Options.ConfigurationExtensions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Options - 3.0.0-preview4.19171.4 - Microsoft.Extensions.ObjectPool - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Logging.TraceSource - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Logging.Testing - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Logging.EventSource - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Logging.Debug - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Logging.Console - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Logging.Configuration - 3.0.0-preview4.19171.4 - Microsoft.Extensions.FileSystemGlobbing - 3.0.0-preview4.19171.4 - Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview4.19171.4 - Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Hosting - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Hosting.Abstractions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Http - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Localization - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Localization.Abstractions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Logging - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Logging.Abstractions - 3.0.0-preview4.19171.4 - Microsoft.Extensions.Logging.AzureAppServices - 3.0.0-preview4.19171.4 * Grab latest from other aspnet repos - brings everything into coherence - aspnet/Extensions packages with version 3.0.0-preview4.19172.1 from build 20190322.1 - aspnet/AspNetCore-Tooling packages with version 3.0.0-preview4.19172.2 from build 20190322.2 - aspnet/EntityFrameworkCore packages with version 3.0.0-preview4.19172.3 from build 20190322.3 |
|
Nate McMaster
|
85ae18c723
|
Make Visual Studio 2019 a prerequisite to building this repo (#7005)
Changes:
* Make Visual Studio 2019 a prerequisite for building this repo
* Update .sln files
* Update Windows SDK to 17134
* Update developer docs
* Disable ANCM tests
* Update to .NET Core SDK 3.0 Preview 2
* Use Microsoft.NET.Sdk.Razor as a package consistently accross the repo
* React to changes in metadata from Microsoft.NETCore.App
* React to changes in .NET Core SDK
* Attempt to workaround CodeCheck.ps1 failure which doesn't repro locally or on different agents. Possibly due to differences in the version of the PowerShell task?
* Remove dead YML file
* Rename usages of win7-{x64,x86} to win-{x64,x86}
* Update KoreBuild to 3.0.0-build-20190219.1
|
|
|
Pranav K
|
c8319ece2a
|
Cleanup some infrastructure pieces in Components | |
|
Nate McMaster
|
5a70f5312f
|
Convert Components projects to use ProjectRef (#6698)
This addresses #4246 for src/Components/. A few other changes were necessary because components had been using stale dependencies. |