Commit Graph

37325 Commits

Author SHA1 Message Date
BrennanConroy 6861e89c8b
[Java] Fix incorrect visibility and some minor cleanup (#3112) 2018-10-10 16:31:14 -07:00
Ryan Brandenburg 7c817289ff
Merge branch 'master' into merge/release/2.2-to-master 2018-10-10 16:29:10 -07:00
Ryan Brandenburg 29cabb688e Merge branch 'merge/release/2.2-to-master' 2018-10-10 16:18:07 -07:00
Justin Kotalik 7cd5b2cbb0
Merge pull request #1486 from dotnet-maestro-bot/merge/release/2.2-to-master 2018-10-10 16:06:14 -07:00
ASP.NET CI cb7111b3c7 Updating submodule(s)
EntityFrameworkCore => 1832510f430b1729ee4d19ec7129029e24ef25c4
Microsoft.Data.Sqlite => ed4892b9d05c7bddd633bf967de17141dbf9fc2f

[auto-updated: submodules]
2018-10-10 15:44:49 -07:00
ASP.NET CI 10ee430043 Updating submodule(s)
Hosting => 5a3c664566
HttpAbstractions => b2d53bd328

[auto-updated: submodules]
2018-10-10 21:57:40 +00:00
ASP.NET CI ad8aeca6a7 Updating submodule(s)
IISIntegration => bfa583a9aa
SignalR => 2ee351786f

[auto-updated: submodules]
2018-10-10 14:57:02 -07:00
Doug Bunting 5cd86977ed
Rename client code generation components
- #8523
- main project / package --> `Microsoft.Extensions.ApiDescription.Design`
- tasks assembly and namespace --> `Microsoft.Extensions.ApiDescription.Tasks`
- tool namespace --> `Microsoft.Extensions.ApiDescription.Tool`
- targets --> verbs e.g. `GenerateTypeScriptNSwag` and `GenerateDocumentDefault`
- `@(ServiceProjectReference)` metadata -> align with common MSBuild project properties
  - exception: `$(MSBuildProjectExtensionsPath)`; it's readonly and `%(ProjectExtensionsPath)` is unambiguous
    - use `%(ProjectExtensionsPath)`
  - also add `%(Targets)` metadata and remove unused `%(ProjectRuntimeIdentifier)`
- `@(<ServiceProjectReferenceMetadata)` metadata -> align with MSBuild project properties
  - exceptions: `$(MSBuildProjectDirectory)`, `$(MSBuildProjectExtensionsPath)` and `$(MSBuildProjectName)`
    - readonly properties and names already unambiguous
2018-10-10 14:52:57 -07:00
Doug Bunting d3442f3590
Create a single Microsoft.Extensions.ApiDescription.Client package
- #8428
- add signing-related and PackageVerifier configuration for new package
- remove packaging configuration from dotnet-getdocument project
- adjust `dotnet-getdocument` invocation to its new location
- remove use of nonexistent (ignored) `dotnet-getdocument --no-build` option

Remove `--uri` feature from `dotnet-getdocument`
- reduce dependencies from Microsoft.AspNetCore.TestHost to Microsoft.AspNetCore.Hosting.Abstractions
  - assume web site depends on that
- merge `DownloadFileCore` into `DownloadFile`
- remove other unecessary code e.g. `WrappedException` was never `throw`n

Correct issues in `DownloadFile`
- e.g. dispose of `responseStream`, use `await` more, support FIPS-compliant machines

nits:
- clean up `Project` and the metadata it fetches
- remove unnecessary `.props` and `.targets` files
2018-10-10 14:52:56 -07:00
Doug Bunting 5a58f81d8d
Use Internal.AspNetCore.Sdk as an MSBuild SDK in new projects
- follow-up to 5bddd226a3
2018-10-10 14:52:56 -07:00
Doug Bunting ea80199e53
Fix a few issues with Microsoft.Extensions.ApiDescription.Client targets
- follow-ups to 1646345955 and 9d109f5956
- fix `%(Command)` updates in `DefaultDocumentGenerator` target
  - later references to metadata values set within an item are not up-to-date
- qualify values for `%(SourceProject)`, `%(SourceUri)` and `%(SourceDocument)` when setting that metadata
  - MSBuild can't distinguish unqualified metadata references unless using `<X Update="@(X)">`
- fix `@(CurrentServiceFileReference)` items
  - was a copy 'n paste error in `_ServiceFileReferenceGenerator_Core` target
- remove per-language default namespace values
- do not add TypeScript files to `@(Compile)`; generally enhance final item additions
  - use `$(DefaultLanguageSourceExtension)` to help here
  - exclude generated source files with `%(OutputPath)` that does not match `$(DefaultLanguageSourceExtension)`
  - really support `%(OutputPath)` directories
- stick with current `$(TargetFramework)` when building `...ReferenceGenerator_Inner` targets
  - `%(ProjectTargetFramework)` will not exist for all `@(ServiceFileReference)` items
  - building the current project, not a service project; `%(ProjectTargetFramework)` may not be supported

nits:
- shorten a few more long lines in Microsoft.Extensions.ApiDescription.Client.targets
- reduce logging from that file
- do not include `%(SerializedMetadata)` in `%(SerializedMetadata)`
  - caused extra-long serialization of items that were originally `@(ServiceProjectReference)`s
- add more info to various comments
- always use element syntax for metadata additions
2018-10-10 14:52:55 -07:00
Doug Bunting fb9393febf
Correct metadata additions and add errors about metadata
- related to #8419 and (more generally) #7947
- add errors for missing required metadata
- add errors for duplicate `%(DocumentPath)` and `%(OutputPath)` metadata
- remove `[Required]` for task inputs that may be `null` or empty
- correct `%(DocumentPath)`s generated in `GetProjectReferenceMetadata` task
  - use this task
2018-10-10 14:52:55 -07:00
Doug Bunting 87e304334d
Remove batching requirements placed on code and document generator providers
- #8419
- perform batching and `@(ServiceFileReference)` and `@(Compile)` additions in common code
  - take advantage of new simplicity in `DefaultDocumentGenerator` target
- add metadata serialization / deserialization in support of passing items into `<MSBuild />`
  - also ensure metadata values are escaped before calling `ITaskItem.SetMetadata(...)`
- correct typos in Microsoft.Extensions.ApiDescription.Client.* e.g. in comments and metadata names
- move last remaining `GenerationTasks` file

nits:
- combine `_ServiceProjectReferenceGenerator_Restore` and `_ServiceProjectReferenceGenerator_Build` targets
  - only build web sites projects once
- remove unused `buildMultiTargeting` targets
- remove qualification of metadata listed in an `<ItemDefinitionGroup />`; will always exist
- add / remove a few `Condition`s that were missing / redundant
- move properties users won't normally set to Microsoft.Extensions.ApiDescription.Client.targets
- shorten lines in MSBuild files
2018-10-10 14:52:55 -07:00
Doug Bunting 3f001750ad
Rationalize code sharing between the three code generation projects
- #8417
- just two files needed to be moved&hellip;
2018-10-10 14:52:54 -07:00
Doug Bunting a76ca293ef
Add missing license headers to src files
- #8415
- also correct a typo in Microsoft.AspNetCore.Mvc.Testing files' headers
2018-10-10 14:52:54 -07:00
Doug Bunting d0325ef264
Remove `CodeAnnotations`
- #8416
- turns out this required little on top of dougbu/remove.custom.tool
2018-10-10 14:52:54 -07:00
Doug Bunting 6ffcf3571e
Remove T4 custom tool
- use same generator as most other projects in aspnet repos
  - were not using named arguments to resource methods anyhow
- update resources to use regular (numbered) format parameters
- adjust to new `Resources` namespace; no need for separate `using`
- use `Format...(...)` methods as necessary
2018-10-10 14:52:54 -07:00
Doug Bunting e19c036f11
Fix up MSBuild files
- correct filenames
- remove NSwag-specific files
2018-10-10 14:52:53 -07:00
Doug Bunting 25d0916b49
Use one namespace for the three client code generation projects
- also cleared out most uses of `GetDocument` and `GenerationTasks` in MSBuild and strings
- temporarily fixed up T4 templates, adding Resources.tt (will remove custom generation soon)
2018-10-10 14:52:53 -07:00
Doug Bunting 95b4dc8ca0
Add first cut of Microsoft.Extensions.ApiDescription.Client package / project
- WIP in a number of ways
2018-10-10 14:52:36 -07:00
Hao Kung 5c174a3d7d Fix login.cshtml 2018-10-10 14:49:57 -07:00
Chris Ross (ASP.NET) b2d53bd328 Merge branch 'release/2.2' 2018-10-10 14:35:57 -07:00
Pavel Krymets bfa583a9aa
Guard OnAsyncCompletion from completing request before OnExecuteRequestHandler exits (#1489) 2018-10-10 14:34:55 -07:00
Chris Ross (ASP.NET) 5a3c664566 Merge branch 'release/2.2' 2018-10-10 14:33:17 -07:00
BrennanConroy 2ee351786f
[Java] Add pings and server timeout (#3027) 2018-10-10 13:49:22 -07:00
ASP.NET CI 1fa70901fe Updating submodule(s)
Common => d3cbcd0e83f2dfd406ef14c0629ff9d346af4e29
IISIntegration => ab124fc344

[auto-updated: submodules]
2018-10-10 20:40:22 +00:00
ASP.NET CI 6cc1091e14 Updating submodule(s)
Common => a366eefab59eec6912af4853cd708ad5e6754289

[auto-updated: submodules]
2018-10-10 20:34:28 +00:00
Pavel Krymets ab124fc344
Fix applicationInitialization tests and disconnect handler (#1484) 2018-10-10 12:41:11 -07:00
ASP.NET CI 194af32e5f Updating submodule(s)
SignalR => be4fe6c6f9
Templating => 7d09ec6ccc

[auto-updated: submodules]
2018-10-10 19:36:55 +00:00
ASP.NET CI 7869a5e0af Updating submodule(s)
Mvc => ce7d77aa09

[auto-updated: submodules]
2018-10-10 12:25:49 -07:00
Ryan Brandenburg 7d09ec6ccc
Low hanging fruit (#763)
Clean up low hanging fruit
2018-10-10 12:12:11 -07:00
James Newton-King ce7d77aa09
Merge pull request #8577 from dotnet-maestro-bot/merge/release/2.2-to-master 2018-10-11 08:10:56 +13:00
Mikael Mengistu be4fe6c6f9
Wait for handshake response in Java Client(#3068) 2018-10-10 12:03:26 -07:00
ASP.NET CI 75bdc78efe Updating submodule(s)
EntityFrameworkCore => beadb6ffabcc4d5d29b955fbb7765d4e4e192301

[auto-updated: submodules]
2018-10-10 11:43:49 -07:00
ASP.NET CI fd9789c779 Updating submodule(s)
EntityFrameworkCore => 172d5e68db74043d649c070300e3a78757e33da1
IISIntegration => ac7a6b56d4
SignalR => 692185f7d2

[auto-updated: submodules]
2018-10-10 18:25:17 +00:00
ASP.NET CI 2c593c4fc5 Updating submodule(s)
EntityFrameworkCore => 6242eb7121b10aaa27edb55eaf9533e97e2a6d14

[auto-updated: submodules]
2018-10-10 17:56:00 +00:00
BrennanConroy 4769c6019c
Merge pull request #1479 from aspnet/brecon/merge
Merge release/2.2 to master
2018-10-10 10:28:49 -07:00
Ryan Brandenburg 2c365b8fc5 Explicitly push to a branch 2018-10-10 10:16:53 -07:00
Pavel Krymets ac7a6b56d4
Reenable client disconnect tests (#1485) 2018-10-10 10:00:13 -07:00
Mikael Mengistu 692185f7d2
Upgrade Java client to RTM versioning (#3104) 2018-10-10 09:58:25 -07:00
ASP.NET CI 03f142a96f Updating submodule(s)
SignalR => cd33755bee

[auto-updated: submodules]
2018-10-10 16:45:16 +00:00
ASP.NET CI 11bbe0d0f8 Updating submodule(s)
SignalR => 073e2361d0

[auto-updated: submodules]
2018-10-10 09:40:03 -07:00
BrennanConroy 073e2361d0
Merge pull request #3107 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2018-10-10 09:24:31 -07:00
BrennanConroy 26eecf5d92 Merge release/2.2 to master 2018-10-10 08:57:30 -07:00
BrennanConroy cd33755bee
[Java] Make public API look like RxJava (#3103) 2018-10-10 08:50:41 -07:00
ASP.NET CI 79feb3677f Updating submodule(s)
HttpAbstractions => f6e20a38e2

[auto-updated: submodules]
2018-10-10 15:41:36 +00:00
James Newton-King f6e20a38e2 HostString throws ArgumentNullException for null host (#1045) 2018-10-10 08:27:33 -07:00
Steve Sanderson c05b98f9cb Update to latest JSInterop
... so we include https://github.com/dotnet/jsinterop/pull/3
2018-10-10 09:54:27 +01:00
ASP.NET CI fa2eccad2f Updating submodule(s)
Mvc => 9daf5ff7a4

[auto-updated: submodules]
2018-10-10 05:49:20 +00:00
James Newton-King 9daf5ff7a4
Fix PageRouteTransformerConvention with custom page routes (#8576) 2018-10-10 18:33:30 +13:00