400d243f42
Fix remaining feature gaps in DfaMatcher ( #621 )
...
* Fix remaining feature gaps in DfaMatcher
* addressed minor feedback
* missed one
2018-07-17 19:22:46 -07:00
1196349bf4
[ Fixes #583 ] Handle change events in RouteValueBaseEndpointFinder
2018-07-17 05:54:11 -07:00
aed2e24483
Allow to pass in HttpContext when generating links
2018-07-17 05:16:57 -07:00
02e1d78319
Minor fixes for MatchProcessorFactory
...
Fixing minor issues found doing DFA integration.
2018-07-16 21:06:35 -07:00
5f29e8b062
Hoist path out of loop in BarebonesMatcher
...
This is an oopsie from a previous change.
2018-07-16 20:43:31 -07:00
b2e4743c7d
Change benchmarks ( #612 )
...
Add benchmarks that include some HTTP method matching.
Clean up names and name like-kinded benchmarks alphabetically.
Matcher*Benchmark -> E2E including HTTP method selection
MatcherSelectCandidates*Benchmark -> Focused on just URL path processing
2018-07-14 17:21:05 -07:00
497a38035d
Add application startup check that dispatcher is added to request pipeline ( #614 )
2018-07-15 11:50:55 +12:00
73e4d55d7b
Check dispatcher services registered ( #610 )
2018-07-14 18:20:42 +12:00
9e114b547d
Introduce RoutePattern ( #585 )
...
* Introduce RoutePattern
Introduces RoutePattern - a new parser and representation for routing
templates, defaults, and constraints.
This is a new representation for all of the 'inputs' to routing that is
immutable and captures 'out of line' information for defaults and
constraints.
This will allow us to unify the handling of constraints and values from
attribute style routes and conventional style routes.
2018-07-13 18:01:46 -07:00
42708bec91
Added support for route constraints in Dispatcher world
2018-07-13 14:18:54 -07:00
1c7f53ae39
Fix TemplateBinder to consider null and empty string values the same
2018-07-13 10:21:55 -07:00
7209cab5e9
Productize JumpTable ( #594 )
...
* Productize JumpTable
2018-07-12 23:28:51 -07:00
0cf972cc43
Error message on no dispatcher middleware in endpoint middleware ( #600 )
2018-07-13 10:16:21 +12:00
3a022107dc
Revert "Added support for route constraints in Dispatcher world"
...
This reverts commit 85e92ab3cc
2018-07-12 06:24:37 -07:00
85e92ab3cc
Added support for route constraints in Dispatcher world
2018-07-12 05:06:22 -07:00
576c14a1b5
Remove InstructionMatcher
2018-07-11 23:47:57 -07:00
9c23ffb215
Added tests for verifying the effects of change made to empty string hashcode from netcoreapp2.0 to 2.1
2018-07-09 13:11:03 -07:00
1009705283
Added a RouteValuesBasedEndpointFinder
2018-06-28 10:53:10 -07:00
bc5f02444b
Benchmarks and improvements to route value dictionary ( #577 )
...
* Add benchmarks for RVD
There are the scenarios that are critical for URL matching performance.
* Reimplement RouteValueDictionary
Improves the scenarios with benchmarks by about 30%
* Fix benchmark
* PR feedback
* More feedback and tests
2018-06-26 13:41:49 -07:00
30fcfb65ea
Productionize Path tokenization
2018-06-21 17:13:03 -07:00
6efd679ce3
Fix TreeMatcher with route constraints ( #576 )
2018-06-22 10:33:44 +12:00
db95a8c624
Add more matcher tests
...
This is a code dump of existing tests for TemplateMatcher and TreeRouter
converted to the format of matcher conformance tests.
Note that most of the new tests aren't yet supported by our experimental
matchers, which don't support many of these advanced features.
2018-06-20 10:39:53 -07:00
5b8db03a57
Fixing up a few small issues
...
The instruction matcher was missing a few details, which made it faster
than it should have been. Right now I'm trying to keep the design of
these in sync. Once I fixed that it exposed a legitimate bug that was
blocking the github benchmark.
2018-06-15 18:04:43 -07:00
00e99dbbb2
Flesh out experimental matchers
...
This change improves this area a bit by consolidating the matcher
implementations between the benchmarks project and the conformance
tests.
Additionally I split the minimal matcher into a really trivial
implementation for the simple tests and a more complex one for the
larger tests. This allows us to keep the plaintext/techempower scenario
in sight while also having a good baseline for the more sophisticated
tests.
Also starting to add tests that verify that matchers behave as expected.
The matchers now successfully execute all of these benchmarks, which
means that they support literals and parameters.
Missing features:
- complex segments
- catchall
- default values
- optional parameters
- constraints
- complex segments with file extensions
This is a good place to iterate a bit more of perf and try to make a
decision about what we want to implement.
2018-06-15 15:43:50 -07:00
d3ddc1709a
Added initial support for link generation when using Dispatcher
2018-06-14 15:31:30 -07:00
9efa7665c9
Fix endpoint constraint cache ( #555 )
2018-06-13 16:40:06 +12:00
28d1bc4fa2
Fix TreeMatcher's use of EndpointSelector ( #551 )
2018-06-12 15:47:34 +12:00
84bc8351c9
Initial endpoint constraints functionality ( #548 )
2018-06-12 09:43:17 +12:00
08f12f2bfd
Add sample matcher tests
2018-06-09 13:29:06 -07:00
1b470f3d3b
Fix Endpoint order in TreeMatcher ( #542 )
2018-06-08 16:19:56 +12:00
21f8ce5e95
Initial DispatcherMiddleware tests ( #529 )
2018-06-07 21:47:06 +12:00
2fed6710a9
Added benchmark and test for dispatcher
2018-06-01 22:17:48 -07:00
8906d8e5f7
Added functional tests for Dispatcher sample
2018-06-01 21:33:30 -07:00
acea87a617
IUrlHelper and support for RouteOptions.LowercaseUrls
...
changes are made as suggestions.
@rynowak
#518
#Issue: aspnet/Mvc#7720
2018-05-31 20:07:01 -07:00
cb77c17cf4
TestCase added and IUrlHelper and support for RouteOptions.LowercaseUrls
...
checked appliesd to the query string.
@rynowak
#518
#Issue: aspnet/Mvc#7720
2018-05-31 20:07:01 -07:00
60f63cf9fb
Added a sample app for benchmarks
2018-05-31 14:39:38 -07:00
62c0d6a16a
Upgrade to netcoreapp22
2018-05-08 11:10:25 -07:00
39f7420c4d
Fixed routing test
2018-04-13 11:51:45 -07:00
7113e54267
Update usage of TestSink
2018-04-12 16:17:04 -07:00
4184b2406d
Updated to make routing always use UrlEncoder.Default and not depend on DI to get it.
...
[Fixes #513 ] RedirectToAction with Non-English Characters in Parameters and Authentication Causes Error
2018-04-12 05:15:45 -07:00
57697baedb
Tolerate leading "~/" or "/" ( #509 )
2018-01-11 13:00:01 -08:00
93d20ec78c
Revert Dispatcher changes ( #508 )
...
Addresses aspnet/Home#2741
2018-01-10 12:53:17 -08:00
c66d5240d1
Recreate cache of endpoints when data source updated ( #503 )
...
Addresses #454
2018-01-03 14:33:16 -08:00
a50780f8e3
Skip failing tests temporarily ( #506 )
2018-01-03 14:11:41 -08:00
54e96bd404
Tolerate leading "~/" or "/" ( #499 )
...
Addresses #441
2017-11-21 14:20:17 -08:00
b67c63927c
Update samples and tests to target netcoreapp2.1
2017-11-13 16:45:38 -08:00
fd83b300b8
Port TreeMatcher ( #488 )
...
Addresses #472
2017-11-07 10:51:50 -08:00
3fadca6a1b
Add IConstraintFactory ( #487 )
...
Addresses part of #472
2017-11-02 10:57:37 -07:00
f4fb178f55
Pin tool and package versions to make builds more repeatable
...
Part of aspnet/Universe#575
2017-11-01 16:32:09 -07:00
bb413c6ac3
Rename a bunch of old stuff
2017-10-26 12:35:58 -07:00
81ddda7b96
Add MetadataCollection
2017-10-26 12:35:58 -07:00
736b49294d
Add Template abstraction
...
This change adds the Template as a top level abstraction. URL templating
is now a two-stage process.
First you use a 'key' to look up a Template, then you use the Template
to create the URL.
This change also has some cleanup of the way RoutePatternBinder gets
instantiated. I added a factory service so that most of the complex
things can be made internal to Dispatcher. Now it's much easier to
constuct and use. These impacts some pubternal APIs that we already
broke, but makes them actually nice :)
Also cleaned up some tests and fixed one that was broken and not
running.
2017-10-25 22:15:24 -07:00
2d661396df
Port TemplateBinder to dispatcher
2017-10-25 14:28:20 -07:00
eebc7db2ca
Use RoutePatternMatcher logic in TemplateMatcher ( #484 )
2017-10-25 14:16:04 -07:00
485278bf0d
Add RoutePatternMatcher to Dispatcher ( #482 )
2017-10-23 11:20:23 -07:00
bd517f891f
Support conversions from RouteTemplate -> RoutePattern
2017-10-20 16:58:14 -07:00
fdc5f21428
Port PathTokenizer ( #478 )
2017-10-20 13:24:00 -07:00
08a64048da
Redesign public API for templates
...
-Renamed RouteTemplate -> RoutePattern
-Made immutable
-Added Builder
-Lots of fixes to parser to support new design
There are a few small issues logged for follow-up but this is mostly in
the place I want it design-wise.
2017-10-19 09:41:45 -07:00
3a5cd6dd25
Port TemplateParser to Dispatcher project ( #473 )
...
Addresses #466
2017-10-17 11:52:26 -07:00
bdbe922b22
Add logging ( #467 )
...
Addresses #439
2017-10-12 14:23:01 -07:00
56ae2e0177
Respond to feedback about handler factory
...
- Handler factories are now associated with the dispatcher entry
- Handler factory is now an interface
2017-10-06 10:11:05 -07:00
63d2cc4637
Changes due to davidfowl feedback
...
Changed dispatchers to IMatcher, added a context.
Removed a bunch of outdated cruft and updated the sample to use
attribute-routing like entries.
2017-10-05 18:31:23 -07:00
6b3d42f6bd
Minor changes to test code to resolve xUnit2013 build errors
2017-10-05 15:26:36 -07:00
2f8951e244
Productize HttpMethodEndpointSelector ( #463 )
...
Addresses #452
2017-10-05 15:14:17 -07:00
a146f0484b
fix test break
2017-09-29 16:26:29 -07:00
bd750ad76d
Making endpoints and addresses easier
...
This makes endpoints and addresses easier to work with by dropping the
'metadata first' approach for the the things that are really at the core
of the dispatcher.
2017-09-28 22:07:32 -07:00
44d08dcb2b
Add integration test
2017-09-27 16:12:45 -07:00
d652b86852
Split RVD in twain
2017-09-21 09:19:10 -07:00
ebd0baa458
Add dispatcher packages
2017-08-31 11:54:27 -07:00
e67d85d30c
Use PackageLineup to manage PackageReference versions
2017-08-29 11:31:54 -07:00
44f9a7083b
Use Directory.Build.props/targets
2017-08-29 11:30:03 -07:00
248f15dee1
Upgrade to xunit 2.3.0-beta4
...
Includes some changes as required by the new analyzers in this upgrade
2017-08-22 17:49:54 -07:00
cf229f479f
React to options
2017-06-26 13:55:36 -07:00
a18f59ab88
Changed expected exception message to the one defined in Resources.resx.
...
Removed the Debug.Assert as that caused the test runner to crash as in
this case the preceding part is not a literal.
Fixes the test runner crash.
2017-05-24 08:23:20 -07:00
f457c7b9d8
Changed expected parameter p2 to non-optional as it is non-optional in the template string.
...
Fixes test.
2017-05-24 08:23:20 -07:00
efb097ce60
Target .NET Standard 2.0 and add net461 testing
2017-05-23 14:38:36 -07:00
d075f1bcea
Upgrade test framework versions and fix test issues
2017-05-12 15:13:17 -07:00
ce021a888e
Change TFM to netcoreapp2.0
2017-05-05 09:49:42 -07:00
232b73a151
Fix aspnet/Mvc#6218
...
This fixes the case described in the comments in TemplateBinder.
This case is much more common for pages which is why we're only seeing it
now. We've had this issue for all of 1.0.0 in both conventional and
attribute routing.
2017-04-28 17:00:35 -07:00
8358de0bd2
Use Bundled NETStandard.Library \ NETCoreApp versions instead of explicitly specifying one
2017-04-25 12:52:39 -07:00
95aadb3f4f
removed dead code
2017-04-20 16:47:26 -07:00
2388cca5ac
Workaround for issue https://github.com/aspnet/Routing/issues/390
2017-04-20 16:47:26 -07:00
ca66e89899
Add a basic attribute routing test
2017-04-11 08:12:27 -07:00
6c79e84d1b
Add BenchmarkDotNet boilerplate
2017-04-11 08:12:26 -07:00
8c58086030
Make TreeRouter restore RouteData snapshots consistently. Fixes #394 .
2017-04-11 15:36:34 +01:00
77da34c7b3
Converted sample and test projects to netcoreapp2.0
2017-03-23 17:04:59 -07:00
1ef45e64b8
Update to net46
2017-03-22 18:26:48 -07:00
101764328b
Consolidate dependency versions to one file and remove workarounds
2017-03-15 17:01:10 -07:00
4569750d86
Using NullLogger types from Logging.Abstractions ( #389 )
2017-03-14 12:19:33 -07:00
ce76fc02f2
Bump test projects up to .NET 4.5.2
...
- aspnet/Testing#248
- xUnit no longer supports .NET 4.5.1
- build tests for desktop .NET only on Windows
2017-02-14 16:35:35 -08:00
0f4ce625ed
Update to VS 2017 RC3
2017-01-27 11:04:42 -08:00
755d436840
Fixed error message related to escaping curly braces.
2017-01-03 14:33:36 -08:00
071b616178
Merge branch 'rel/1.1.1' into dev
...
# Conflicts:
# NuGet.config
# samples/RoutingSample.Web/project.json
# src/Microsoft.AspNetCore.Routing.Abstractions/project.json
# src/Microsoft.AspNetCore.Routing.DecisionTree.Sources/project.json
# src/Microsoft.AspNetCore.Routing/project.json
# test/Microsoft.AspNetCore.Mvc.Routing.Abstractions.Tests/project.json
# test/Microsoft.AspNetCore.Routing.DecisionTree.Sources.Tests/project.json
# test/Microsoft.AspNetCore.Routing.FunctionalTests/project.json
# test/Microsoft.AspNetCore.Routing.Tests/project.json
2017-01-03 13:33:26 -08:00
4bfd663c45
[ Fixes #370 ] Raw route values should be restored after template binder failing binding values when generating a url
...
- Reverted changes made in commit: 1c9a54aeb8
2017-01-03 13:23:36 -08:00
ce525150ab
Updating to 4.4 CoreFx packages
2016-12-21 22:55:19 -08:00
20967cfa76
[ Fixes #367 ] Add extensions on WebHostBuilder for super simple HTTP service application building
2016-12-21 10:04:02 -08:00
45247e4d9c
Update Microsoft.AspNetCore.Routing.DecisionTree.Sources to use contentFiles
2016-12-15 17:54:10 -08:00
3db35194c9
Pinning versions for 1.1.0 release
2016-11-18 12:13:32 -08:00
d3c145cbe8
Updating versions to 1.2.0-*
2016-11-09 14:19:24 -08:00
d81ea871fb
Updating to netcoreapp1.1
2016-10-13 11:24:12 -07:00
Ryan Nowak
Kiran Challa
Kiran Challa
James Newton-King
Nate McMaster
Ryan Nowak
kishan.anem
Ryan Brandenburg
=
Jass Bagga
Pranav K
Hao Kung
Joonas Westlin
Steve Sanderson
Ajay Bhargav Baaskaran
Doug Bunting