defbadb26b
Various timer cleanup ( #3129 )
...
This change does 2 things:
- It disables the websocket keep alive since SignalR has its own bidirectional pings. This should remove a significant timer overhead per WebSocket connection that we end up with today. We have a single timer that sends to all connection on an interval.
- Don't pass the CancellationToken to ReadAsync in the handshake since the Pipe implementation holds onto the token for longer than it
needs to which keeps Timer objects alive (see dotnet/corefx#32806 )
I found this when reading the source code and looking at dumps of a couple of SignalR applications.
2018-10-13 11:43:20 -07:00
286e4bebf7
Add StackExchange.Redis 2.X.X package ( #3089 )
2018-10-10 16:40:27 -07:00
78a0a68cd1
Typos/spelling errors in XML doc comments and source. #Hacktoberfest ( #3039 )
2018-10-01 14:41:05 -07:00
1f91b523f7
Add error to negotiate ( #2998 )
2018-09-27 20:27:06 -07:00
4dfd93c1d7
[TS] Wait for handshake response ( #2983 )
2018-09-20 14:23:43 -07:00
f0a34a4ca4
Clone Windows Identity in LongPolling connections ( #2985 )
2018-09-20 13:39:25 -07:00
6ba5e87b45
Allow CancellationToken in streaming hub methods ( #2818 )
2018-09-19 15:21:07 -07:00
8be051ce34
Idempotentize AddSignalR ( #2972 )
2018-09-19 13:39:34 -07:00
48b3f18642
Improve the handshake request parsing errors ( #2953 )
...
- Print out the raw handshake payload as utf8 text if it fails to parse as JSON or if we're missing properties. This should help flesh out potentially buggy clients.
2018-09-13 22:11:17 -07:00
8dffc68cea
Cancel previous request on close ( #2923 ) ( #2942 )
2018-09-11 15:50:00 -07:00
adc5706bcb
Add more redis logs ( #2936 )
2018-09-10 11:51:27 -07:00
db99baac35
Don't capture AsyncLocals onto Timers ( #2904 )
2018-09-07 14:08:08 -07:00
f42f4c56e6
Initialize HttpConnectionManager before registering callbacks ( #2878 )
2018-08-30 14:42:16 -07:00
f8a46faf9d
Detect ASP.NET SignalR server connection attempt ( #2820 )
2018-08-22 11:17:04 -07:00
db3f3f2a53
Tweak some Redis log levels ( #2838 )
2018-08-22 10:35:43 -07:00
b82fcc0b21
log when WebSocketTransport has started ( #2752 )
2018-08-10 09:49:17 -07:00
a550ae6cc3
Provide a better error message when invoking a non-existant hub method ( #2768 )
2018-08-08 15:55:33 -07:00
2265acde78
Don't start stream if already canceled ( #2764 )
2018-08-08 14:04:05 -07:00
5e7f63b096
Make un-graceful shutdown a bit more graceful ( #2748 )
...
* Make un-graceful shutdown a bit more graceful
- Change how graceful shutdown is done to ensure there are no errors on shutdown.
- Avoid closing pipes from under other components that own those pipes.
- Close the application output so that the application's read loop ends gracefully. For websockets, we cancel the token, for other transports, we close the output directly.
2018-08-07 21:39:09 -07:00
e403de7fbf
Solve LongPolling races by moving Cts disposal to connection disposal ( #2731 )
2018-08-06 19:17:29 -07:00
e78e3db6f4
Honor InherentKeepAliveFeature for server timeout ( #2727 )
2018-08-06 10:37:12 -07:00
810c7cf9ad
Fix ODE race with cancellationtokensource ( #2721 )
2018-08-02 15:24:26 -07:00
90606338fb
Log when closing connection due to timeout ( #2722 )
2018-08-02 15:21:24 -07:00
c8eedb3540
Fix race when connection is canceled and new poll comes in ( #2697 )
2018-07-31 16:36:54 -07:00
651b39bc90
Revert "Merge branch 'master' into release/2.2"
...
This reverts commit 785200877a3d6e1e69fd
2018-07-31 15:24:33 -07:00
785200877a
Merge branch 'master' into release/2.2
2018-07-31 10:22:09 -07:00
3d6e1e69fd
Close LongPolling connection on poll exception ( #2701 )
2018-07-31 09:52:10 -07:00
34a7fc4d99
Merge branch 'merge/release/2.2-to-master'
2018-07-25 11:45:32 -07:00
433eeb6943
Abort connection on protocol error ( #2654 )
2018-07-19 14:50:14 -07:00
748e992865
Dygray/handshake versioning ( #2520 )
...
* set minor versions on the protocols
2018-07-05 16:42:42 -07:00
e7e2ca50e9
Ping Cleanup ( #2530 )
...
Tidied up some comments, to make the ResetPing client behavior easier to understand.
Will ping in debug mode for consistency. If this becomes a problem when debugging, developers can disable the pings manually. It's easier to fix something noisy, than try to diagnose inconsistently missing behavior.
2018-06-25 17:09:05 -07:00
a4a8b49908
Removed extra reference to Internal.AspNetCore.Sdk ( #2475 )
2018-06-12 16:12:52 -07:00
c7ebae47ea
Show detailed error message for HubExceptions ( #2461 )
2018-06-11 13:55:47 -07:00
0306038658
Return empty string for connectionId in some cases ( #2470 )
2018-06-11 12:50:34 -07:00
dd64e4d9a5
Clean up Spec Test dependencies ( #2451 )
2018-06-08 15:28:23 -07:00
e41764c161
Update AddSignalRCore to respect user registered services ( #2434 )
2018-06-07 16:32:37 -07:00
9d58e41521
Update Microsoft.AspNetCore.SignalR.Specification.Tests.csproj ( #2449 )
2018-06-07 12:26:09 -07:00
648705f648
Create a Public Test Suite for HubLifetimeManager implementations ( #2353 )
2018-06-06 16:59:55 -07:00
3d0f68b22c
server closes connections that have gone silent ( #2364 )
2018-06-05 15:21:55 -07:00
4f85ca2b1d
Add connection ID scope to HubConnection ( #2394 )
2018-06-01 11:12:51 +12:00
8d680db112
Remove scanning connections log messages ( #2397 )
2018-05-30 15:29:46 +12:00
f0f1df9b4a
PingInterval -> KeepAliveInterval ( #2384 )
2018-05-25 15:15:38 -07:00
02a9bde10d
Fix flaky ClientPingsMultipleTimes test ( #2368 )
2018-05-24 17:29:15 +12:00
5c633aa183
Log 404 responses from long polling transport DELETE as Debug instead of Error ( #2366 )
2018-05-24 14:21:48 +12:00
736b7f5042
Client pings server on interval ( #2309 )
2018-05-23 13:53:23 -07:00
e29296220d
Fix not reading to end of argument JSON on binding error ( #2319 )
2018-05-19 19:50:43 +12:00
879646aba3
Fix losing UTC DateTimeKind on ISO8601 UTC values ( #2317 )
2018-05-19 18:43:14 +12:00
96bbe70cd8
Handle incoming HTTP requests being canceled gracefully ( #2314 )
2018-05-19 13:32:05 +12:00
bff2060454
Fix JsonHubProtocol error message when too many arguments ( #2312 )
2018-05-18 19:55:53 +12:00
32cee74a0c
Generate baselines and enable Api check ( #2304 )
2018-05-17 15:21:13 -07:00
David Fowler
BrennanConroy
Brian Chavez
Ben Adams
Mikael Mengistu
Dylan Dmitri Gray
Nate McMaster
James Newton-King