Nate McMaster
3db604d9d2
Upgrade packages and projects to target netcoreapp3.0 (except the .NET signalr client) ( aspnet/SignalR#3315 )
2018-11-16 16:44:36 -08:00
BrennanConroy
71e2f45450
Wrap log in enabled check
2018-11-06 09:24:34 -08:00
MikaelMengistu
83b5abbfcd
Merge branch 'release/2.2'
2018-10-16 14:39:02 -07:00
David Fowler
defbadb26b
Various timer cleanup ( #3129 )
...
This change does 2 things:
- It disables the websocket keep alive since SignalR has its own bidirectional pings. This should remove a significant timer overhead per WebSocket connection that we end up with today. We have a single timer that sends to all connection on an interval.
- Don't pass the CancellationToken to ReadAsync in the handshake since the Pipe implementation holds onto the token for longer than it
needs to which keeps Timer objects alive (see dotnet/corefx#32806 )
I found this when reading the source code and looking at dumps of a couple of SignalR applications.
2018-10-13 11:43:20 -07:00
MikaelMengistu
c6a1c7463a
Merge branch 'release/2.2'
2018-10-01 16:19:06 -07:00
Brian Chavez
78a0a68cd1
Typos/spelling errors in XML doc comments and source. #Hacktoberfest ( #3039 )
2018-10-01 14:41:05 -07:00
BrennanConroy
e683b81dfe
Merge branch 'release/2.2'
2018-09-20 12:29:13 -07:00
BrennanConroy
6ba5e87b45
Allow CancellationToken in streaming hub methods ( #2818 )
2018-09-19 15:21:07 -07:00
BrennanConroy
8be051ce34
Idempotentize AddSignalR ( #2972 )
2018-09-19 13:39:34 -07:00
unknown
d32a5c14e1
Merge branch 'release/2.2'
2018-08-08 18:06:19 -07:00
BrennanConroy
a550ae6cc3
Provide a better error message when invoking a non-existant hub method ( #2768 )
2018-08-08 15:55:33 -07:00
Andrew Stanton-Nurse
d709fa62b9
Merge pull request #2719 from dotnet-maestro-bot/merge/release/2.2-to-master
...
[automated] Merge branch 'release/2.2' => 'master'
2018-08-03 10:59:01 -07:00
BrennanConroy
90606338fb
Log when closing connection due to timeout ( #2722 )
2018-08-02 15:21:24 -07:00
Dylan Dmitri Gray
76706144a5
Add support for streaming arguments to clients using Channel ( #2441 )
2018-08-01 09:31:43 -07:00
BrennanConroy
651b39bc90
Revert "Merge branch 'master' into release/2.2"
...
This reverts commit 785200877a , reversing
changes made to 3d6e1e69fd .
2018-07-31 15:24:33 -07:00
BrennanConroy
34a7fc4d99
Merge branch 'merge/release/2.2-to-master'
2018-07-25 11:45:32 -07:00
BrennanConroy
433eeb6943
Abort connection on protocol error ( #2654 )
2018-07-19 14:50:14 -07:00
Dylan Dmitri Gray
748e992865
Dygray/handshake versioning ( #2520 )
...
* set minor versions on the protocols
2018-07-05 16:42:42 -07:00
Dylan Dmitri Gray
e7e2ca50e9
Ping Cleanup ( #2530 )
...
Tidied up some comments, to make the ResetPing client behavior easier to understand.
Will ping in debug mode for consistency. If this becomes a problem when debugging, developers can disable the pings manually. It's easier to fix something noisy, than try to diagnose inconsistently missing behavior.
2018-06-25 17:09:05 -07:00
Mikael Mengistu
c7ebae47ea
Show detailed error message for HubExceptions ( #2461 )
2018-06-11 13:55:47 -07:00
Mikael Mengistu
e41764c161
Update AddSignalRCore to respect user registered services ( #2434 )
2018-06-07 16:32:37 -07:00
Mikael Mengistu
648705f648
Create a Public Test Suite for HubLifetimeManager implementations ( #2353 )
2018-06-06 16:59:55 -07:00
Dylan Dmitri Gray
3d0f68b22c
server closes connections that have gone silent ( #2364 )
2018-06-05 15:21:55 -07:00
BrennanConroy
32cee74a0c
Generate baselines and enable Api check ( #2304 )
2018-05-17 15:21:13 -07:00
Pavel Krymets
3719dc00fa
Enable analyzers ( #2300 )
2018-05-17 09:48:07 -07:00
BrennanConroy
7916f95235
Merge branch 'release/2.1' into dev
2018-05-10 16:54:26 -07:00
BrennanConroy
4b1fb58a8a
Throw error on unexpected close ( #2205 )
2018-05-10 16:38:21 -07:00
James Newton-King
277e2963ef
Merge branch 'release/2.1' into dev
2018-05-01 17:52:01 -07:00
James Newton-King
3e906fb64a
Minor API cleanup ( #2147 )
2018-05-01 17:51:08 -07:00
James Newton-King
49cdaad6d6
Merge pull request #2185 from aspnet/release/2.1
...
Fix not detecting marker service (#2149 )
2018-05-01 17:42:39 -07:00
James Newton-King
555c1fd720
Fix not detecting marker service ( #2149 )
2018-05-01 17:42:00 -07:00
Andrew Stanton-Nurse
1bba0fde87
Merge branch 'release/2.1' into dev
2018-05-01 16:15:57 -07:00
James Newton-King
295801ac50
XML documentation ( #2106 )
2018-05-01 16:08:09 -07:00
David Fowler
f3ba1babfc
Remove unnecessary state machines in DefautHubDispatcher ( #2167 )
...
* Remove unnecessary state machines in DefautHubDispatcher
- Remove state machines for async tail calls
- Added fast path for auth check when there are no policies
2018-04-30 22:41:32 -07:00
David Fowler
c53514fa19
Don't throw from AbortAsync ( #2166 )
...
- Log from inside of HubConnectionContext if the user callback failed.
- Use ThreadPool.QUWI instead of Task.Factory.StartNew.
- Remove try catch from HubConnectionHandler
2018-04-30 09:22:48 -07:00
David Fowler
ab451b53b7
Simplify error handling in HubConnectionHandler ( #2162 )
...
* Simplify error handling in HubConnectionHandler
- Since we execute hub methods inline, there's no need to abort the connection on unexpected exceptions.
- Don't pass the cancellation token to ReadAsync, instead just use CancelPendingRead.
- Don't treat OperationCancelledException errors as errors.
2018-04-29 22:51:16 -07:00
Andrew Stanton-Nurse
47eafca4d8
CancellationToken EVERYWHERE ( #2101 )
2018-04-20 16:21:51 -07:00
Andrew Stanton-Nurse
058830c9df
fix #2116 by requiring task return values from typed client ( #2117 )
2018-04-20 13:49:12 -07:00
James Newton-King
5516a969e3
Change Hub and friends to abstract ( #2108 )
2018-04-20 20:53:01 +12:00
BrennanConroy
1957655653
Run hub invocations serially ( #2086 )
2018-04-19 16:59:06 -07:00
Andrew Stanton-Nurse
6b6d890c8f
fix #2078 by adding locking ( #2079 )
2018-04-19 15:32:04 -07:00
David Fowler
5c9b64244a
Expose the IHubProtocol on HubConnectionContext ( #2073 )
2018-04-18 10:35:55 -07:00
Andrew Stanton-Nurse
b4046b5ed8
Fix #1989 by adding a 'binding failure' pseudo-message ( #2064 )
2018-04-17 20:08:07 -07:00
Andrew Stanton-Nurse
c05c5a6b2a
React to aspnet/KestrelHttpServer#2496: make IConnectionInherentKeepAliveFeature a boolean feature ( #2041 )
2018-04-16 11:34:12 -07:00
David Fowler
a5d9930802
API review changes ( #2043 )
...
- Make SerializedHubMessage and SerializedMessage
public
- Made HubConnectionStore public
- Move SendUtils and Utils to the internal folder
- Make Microsoft.AspNetCore.Http.Connections.Common/Internal public.
- Move InvocationRequest to internal folder
2018-04-16 10:31:10 -07:00
BrennanConroy
927b08f893
Cache property access ( #2030 )
2018-04-15 23:23:00 -07:00
James Newton-King
b5d5f11ef8
Rename excludedIds to excludedConnectionIds ( #2037 )
2018-04-16 18:03:16 +12:00
BrennanConroy
7745fd748a
Extension methods for IHubClients methods ( #2016 )
2018-04-15 22:43:26 -07:00
James Newton-King
b3a9011698
API review changes for Microsoft.AspNetCore.SignalR ( #2033 )
2018-04-16 15:54:42 +12:00
James Newton-King
b9e7113c01
Move types out of .Core namespace and make method virtual ( #2024 )
2018-04-15 09:58:33 +12:00