Commit Graph

18344 Commits

Author SHA1 Message Date
Justin Kotalik dcd1250f43
[3.1] Add latin1 support to IIS (#22798)
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
2020-06-12 11:10:00 -07:00
Sébastien Ros 0ec79c5196
Quarantining InputDateInteractsWithEditContext_NonNullableDateTime (#22857)
https://github.com/dotnet/aspnetcore-internal/issues/3616
2020-06-12 10:02:33 -07:00
Pranav K 75b27754d6
Ensure FileBufferingReadStream created by formatters are always disposed (#22746) 2020-06-11 13:14:15 -07:00
Javier Calvarro Nelson 5a9a98543f
[Blazor] Switches Error.razor to Error.cshtml (#22777)
* [Blazor] Switch to use a cshtml file for errors

* Update template tests
2020-06-11 13:13:05 -07:00
Javier Calvarro Nelson 9d7018544a
[Blazor] Fix manifest integrity computation (#22771)
* [Blazor] Fix manifest integrity computation

* Add a couple of tests to validate incrementalism
2020-06-11 13:12:53 -07:00
Javier Calvarro Nelson ce533485f0
[Blazor] Register HttpClient as a scoped instance (#22770)
This avoid the container holding on to transient HttpClient instances for the lifetime of the application.
2020-06-11 13:12:43 -07:00
Pranav K 8e813eea24
Workaround for DomException when invoking cache.put (#22756)
* Workaround for DomException when invoking cache.put

Invoking cache.put could sometimes result in exceptions being thrown. While this seems to have been fixed in Chromium - https://bugs.chromium.org/p/chromium/issues/detail?id=968444,
we've had several reports of this in our repo. The fix here is to write defensively when working with the cache apis since they appear to behave in unexpected ways..

Fixes https://github.com/dotnet/aspnetcore/issues/20256

* Fixup
2020-06-11 13:12:33 -07:00
Brennan 812f2f8145
Fixes NullRef exception in IIS in-proc (#22806) 2020-06-11 10:57:36 -07:00
Sébastien Ros 5f26302eaa
Quarantining CanDispatchAsyncWorkToSyncContext (#22803)
* Quarantining CanDispatchAsyncWorkToSyncContext

* Missing using

* Make method virtual
2020-06-11 09:30:26 -07:00
Safia Abdalla a529b4c70c
Add nan as dev dependency to React templates (#22089) (#22205) 2020-06-10 09:59:39 -07:00
Safia Abdalla 55822ca516
Upgrade jQuery in samples to version 3.5.1 (#21577) (#21792)
Fixes #21572

Co-authored-by: Christian Wenz <info@christianwenz.de>
2020-06-10 09:59:29 -07:00
Pranav K b3ad812c14
Mark Wasm benchmark app as a test asset 2020-06-09 19:24:03 -07:00
Pranav K ae8f67f201
Use randomized ports in dotnet-serve 2020-06-09 19:20:12 -07:00
Pranav K dd62a699f7
Merge remote-tracking branch 'origin/release/3.1' into prkrishn/merge-blazor-wasm 2020-06-09 16:54:36 -07:00
William Godbe 99e90f5782
Produce non-stable version of targeting pack (#22372)
* Produce non-stable version of targeting pack

* Fix tag

* Fix indentation

* Fixup proj file

* Move Internal proj to separate folder

* Remove redundant proj

* Start moving files

* finish moving files

* Set IsReferenceAssemblyProject=true in targeting pack proj
2020-06-09 16:40:00 -07:00
Justin Kotalik b19d9d9540
Enable control flow guard for IIS dlls (#22609) 2020-06-09 16:26:18 -07:00
Pranav K 11ac23c65d
Changes per PR 2020-06-08 22:19:34 -07:00
Safia Abdalla 0394a4520e
Fix logging config and output redirection in DebugProxy (#22157)
* Fix logging config and output redirection in DebugProxy
* Log all messages from DebugProxy
2020-05-27 10:32:15 -07:00
Pranav K 53edc767a7
Listen to the internet 2020-05-27 08:58:44 -07:00
Pranav K 81007200b5
Quality of life improvements 2020-05-26 18:26:07 -07:00
Pranav K ae2017f31e
Changes to allow building in 3.1 branch
* Undo overzealous merge choices
* Undo temporary changes applied when part of the repo was building in the blazor-wasm branch
* Skip SPA template tests in 3.1
2020-05-22 09:20:54 -07:00
DotNet Bot 844a82e37c Merged PR 8040: [internal/release/3.1] Update dependencies from dnceng/internal/dotnet-efcore
This pull request updates the following dependencies

[marker]: <> (Begin:e908e90a-0c22-4c54-b254-08d79557a113)
## From https://github.com/dotnet/efcore
- **Subscription**: e908e90a-0c22-4c54-b254-08d79557a113
- **Build**: 20200520.1
- **Date Produced**: 5/20/2020 5:36 PM
- **Commit**: 85b57af827aa71b77d673e813e046d081c8027ed
- **Branch**: refs/heads/internal/release/3.1
- **Updates**:
  - **Microsoft.EntityFrameworkCore.Tools**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore.InMemory**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore.Relational**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore.Sqlite**: from 3.1.4 to 3.1.5
  - **dotnet-ef**: from 3.1.4 to 3.1.5
  - **Microsoft.EntityFrameworkCore.SqlServer**: from 3.1.4 to 3.1.5

[marker]: <> (End:e908e90a-0c22-4c54-b254-08d79557a113)
2020-05-21 19:47:40 +00:00
Javier Calvarro Nelson a9449cd20c
[Templates] Update SPA dependencies to keep npm audit happy (#21330)
* Update react dependencies

* Update angular dependencies

* Update react-redux dependencies
2020-05-18 14:59:29 -07:00
Brennan 66ddf3523a Fix cleaning send queue on restart (#18511) 2020-05-18 14:58:38 -07:00
Pranav K 9949ab46c3
Fixup JS (#21922)
* Fixup JS

* Avoid monkey patching
2020-05-18 13:21:31 -07:00
Pranav K 8efeefb3d1
Merge branch 'blazor-wasm' into prkrishn/merge-blazor-wasm 2020-05-16 21:10:28 -07:00
Pranav K 8966415b6b
Merge commit 'bbafecc0535e1de3264845e51ea8b3d18eb3ca61' into prkrishn/merge-blazor-wasm 2020-05-15 10:12:32 -07:00
William Godbe 817127dfd0
[release/3.1] Give .msi's non-stable branding (#21801)
* Give .msi's non-stable branding

* Add BuildNumber to version

* Make GUIDInputs unique per-build
2020-05-14 16:34:09 -07:00
Doug Bunting de38479e5f
Improve build reliability (#20760)
* Improve build reliability
  - ensure `ResolveCustomReferences` target executes before packages are used
  - `ResolveAssemblyReferences` and `ResolveAssemblyReferencesDesignTime` targets run too late
    - e.g. failed builds of Microsoft.AspNetCore.WebUtilities or Microsoft.AspNetCore.Hosting when building from root
  - add `GetReferenceProjectTargetPathMetadata` for ease of use as well as reliability
    - avoids extra work to get existing metadata (ref/ projects execute no tasks in this target)

  nit: rename `@(ReferenceProjectMetadata)` -> `@(ReferenceProjectTargetPathMetadata)`

* Ensure `GetTargetPathMetadata` target runs with `$(TargetFramework)` set
  - ref/ projects all multi-target and otherwise no-op this target

* Revert "Fix various "Type or namespace not found" errors (#20736)"
  - change is no longer needed with other fixes in this PR

  This reverts commit 8218d6e0e7.
2020-05-13 11:31:09 -07:00
Ryan Nowak b194b6c90a
Fix use of precedence in endpoint routing DFA (#20801) (#21200)
* Fix use of precedence in endpoint routing DFA

Fixes: #18677
Fixes: #16579

This is a change to how sorting is use when building endpoint routing's graph of
nodes that is eventually transformed into the route table. There were
bugs in how this was done that made it incompatible in some niche
scenarios both with previous implementations and how we describe the
features in the abstract.

There are a wide array of cases that might have been impacted by this
bug because routing is a pattern language. Generally the bugs will involve a
catch-all, and some something that changes ordering of templates.

Issue #18677 has the simplest repro for this, the following templates
would not behave as expected:

```
a/{*b}
{a}/{b}
```

One would expect any URL Path starting with `/a` to match the first
route, but that's not what happens.

---

The change supports an opt-in via the following AppContext switch:

```
Microsoft.AspNetCore.Routing.UseCorrectCatchAllBehavior
```

Set to true to enable the correct behavior.

---

The root cause of this bug was an issue in how the algorithm used to be
build the DFA was designed. Specifically that it uses a BFS to build the
graph, and it uses an up-front one-time sort of endpoints in order to
drive that BFS.

The building of the graph has the expectation that at each level, we
will process **all** literal segments (`/a`) and then **all** parameter
segments (`/{a}`) and then **all** catch-all segments (`/{*a}`). Routing
defines a concept called *precedence* that defines the *conceptual*
order in while segments types are ordered.

So there are two problems:

- We sort based on criteria other than precedence (#16579)
- We can't rely on a one-time sort, it needs to be done at each level
(#18677)

---

The fix is to repeat the sort operation at each level and use precedence
as the only key for sorting (as dictated by the graph building algo).

We do a sort of the matches of each node *after* building the
precedence-based part of the DFA, based on the full sorting criteria, to
maintain compatibility.

* Add test
2020-05-13 11:12:14 -07:00
Brennan 8ff1cb906d
Set certificate in some Kestrel tests to avoid global machine state (#21516) (#21542) 2020-05-13 11:11:02 -07:00
William Godbe 9e2a480925
[release/3.1] Add .version file to shared framework zip (#21548)
* Add .version file to shared framework zip

* Fix test
2020-05-13 10:59:55 -07:00
Will Godbe a14119a308 Merge remote-tracking branch 'internal/internal/release/3.1' into wtgodbe/315 2020-05-12 16:02:32 -07:00
Pranav K 158126c27a
Add a scenario with timers (#19626)
* Add a scenario for measuring navigating between components

* Apply suggestions from code review

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-05-11 10:46:26 -07:00
Pranav K 22522a0d78
Update to mono sources http://github.com/mono/mono/commit/57dcba253 (#21700) 2020-05-11 10:40:12 -07:00
Pranav K 2ca2a2d405
Update debugger to 1a6e64a938 (#21524) 2020-05-06 00:17:48 +00:00
Pranav K 4f5bf164df
Show debugger attach message (#21483)
Also spruce up branding
2020-05-05 09:06:55 -07:00
Pranav K 9e412f4c7f
Do not attempt to load satellite assemblies until after MainAsync has executed (#21476)
WASM runtime does not like it when you attempt to load satellite assemblies
for two sets of non-neutral cultures - the first is always loaded. This change
defers loading satellite assemblies until after Program.Main has executed
and the developer has configured the culture for the application.

Fixes https://github.com/dotnet/aspnetcore/issues/21433
2020-05-05 09:06:42 -07:00
Pranav K cc2b64ec5e
Re-use the Blazor app for stress runs (#21078)
* Re-use the Blazor app for stress runs

Our current stress runs re-used the perf tests which recreated the blazor app on each run. Perf runs are meant to run
and be done, however, we want stress apps to be long lasting to capture things like memory leaks.

This change creates a fork in the tests to support stress runs that re-use the app between runs.
2020-05-04 09:02:05 -07:00
Safia Abdalla 2a97de0344
Fix intermediate path for service worker assets (#21128) 2020-04-30 15:03:16 -07:00
Pranav K 147f5758c6
Ensure satellite resources are published when building in VS (#21347)
* Ensure satellite resources are published when building in VS

Fixes https://github.com/dotnet/aspnetcore/issues/21355
2020-04-30 14:57:04 -07:00
Steve Sanderson 4438f33304 Update ws-proxy to match runtime in use (from Mono commit cc6d4bf6cfce33ae3b41f74ac14ac2cb770603d5) 2020-04-30 16:56:25 +01:00
John Luo 2ec9b2e5d1 Use the correct crossgen 2020-04-28 17:23:53 -07:00
Pranav K b837ebf206
Produce RTM branded blazor packages (#21257) 2020-04-27 13:37:33 -07:00
John Luo 05f58bbbfa Build aspnetcore for win-arm64 (#19317)
* Build for win-arm64

* Missed file

* Disable Selenium tests on arm64

* Include installers in the uploaded artifacts
2020-04-27 00:34:47 -07:00
Safia Abdalla 40f0cdfa3c
Fix up template generation for config (#21147) 2020-04-23 12:17:12 -07:00
Pranav K 5da314644a Add an option to allow trimming collation data 2020-04-23 12:08:21 +01:00
Larry Ewing 5dc5f6c230
Silence the runtime output from the debugger (#20975)
* Silence the runtime output from the debugger

* Update src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-04-22 11:15:49 -07:00
Pranav K 25f89e22f3
Update dbgproxy to 70ff920a89 (#21075) 2020-04-21 16:09:45 -07:00
dotnet-maestro[bot] b8f7dde377
[blazor-wasm] Update dependencies from dotnet/arcade dotnet/blazor (#20972)
* Update dependencies from https://github.com/dotnet/blazor build 20200417.2

- Microsoft.AspNetCore.Components.WebAssembly.Runtime: 3.2.0-rc1.20217.1 -> 3.2.0-rc1.20217.2

* Update dependencies from https://github.com/dotnet/blazor build 20200418.1

- Microsoft.AspNetCore.Components.WebAssembly.Runtime: 3.2.0-rc1.20217.1 -> 3.2.0-rc1.20218.1

* Update dependencies from https://github.com/dotnet/arcade build 20200418.1

- Microsoft.DotNet.Arcade.Sdk: 1.0.0-beta.20208.8 -> 1.0.0-beta.20218.1
- Microsoft.DotNet.GenAPI: 1.0.0-beta.20208.8 -> 1.0.0-beta.20218.1
- Microsoft.DotNet.Helix.Sdk: 2.0.0-beta.20208.8 -> 2.0.0-beta.20218.1

* Update dependencies from https://github.com/dotnet/blazor build 20200420.1

- Microsoft.AspNetCore.Components.WebAssembly.Runtime: 3.2.0-rc1.20217.1 -> 3.2.0-rc1.20220.1

* Update to BROWSER RID

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-04-21 20:19:04 +00:00