N. Taylor Mullen
da255ff9db
Make `TestProject.GetProjectDirectory` more thorough when finding project directory.
...
- Used our test path utilities to properly navigate to the project directory.
- Added some logic to make future debugging/test failures more diagnosable.
#2184
2018-03-26 12:36:46 -07:00
Pranav K
954a62c075
Remove EnableDefaultCompiledViewAssemblyLoadBehavior and add a switch to disable generating application part factory attribute
2018-03-22 17:09:53 -07:00
Pranav K
ac3065a9e1
Temporary workaround to make Razor Windows build on dotnet-ci
2018-03-22 12:17:06 -07:00
Ajay Bhargav Baaskaran
a7178a66bd
Show error if page directive is not at the top of file
2018-03-21 11:22:01 -07:00
Pranav K
8631f287d9
Add a few more Razor Sdk fixes
...
* UseSharedCompilation to determine the default value of UseRazorBuildServer
* Generate AssemblyDescriptionAttribute
2018-03-21 08:44:55 -07:00
Kiran Challa
431a8e195a
[ Fixes #2144 ] Incorrect target element of nested tag helper
2018-03-20 15:25:07 -07:00
Pranav K
5f3908cb54
Stop expressly testing on netcoreapp2.0
2018-03-20 09:37:26 -07:00
Pranav K
2bc3466e3d
Do not write generated files to disk if the input has parser errors
...
Fixes #2169
2018-03-19 21:30:47 -07:00
Ajay Bhargav Baaskaran
c934bd08ac
Merge branch 'rel/vs15.7' into release/2.1
2018-03-19 19:14:51 -07:00
Ajay Bhargav Baaskaran
9dc7c65205
Fix: Missing Html intellisense after directives
2018-03-19 17:16:11 -07:00
Ajay Bhargav Baaskaran
fab70c81ec
Merge branch 'rel/vs15.7' into release/2.1
2018-03-19 15:57:46 -07:00
Ajay Bhargav Baaskaran
79e744f691
Handle unreadable import items in design time
2018-03-19 15:39:25 -07:00
Ryan Nowak
6e4a968e12
Fix #2149 give generated files distinct extension
...
Gives our generated a files an extension that isn't used for any other
purpose (that we know of). This is handy for tooling to be able to
quickly know if a file is 'ours'. This comes up in places like
IVsSymbolicNavigationNotify (go to definition).
2018-03-19 12:59:16 -07:00
Pranav K
7ff56dadf4
CodeGen RouteTemplate as a RazorCompiledItemAttribute
2018-03-19 12:37:04 -07:00
Ajay Bhargav Baaskaran
767e5a12c3
Display errors from build server as part of MsBuild output
2018-03-19 10:49:00 -07:00
Artak
b58986414e
Make Razor HTML Comments aware ( #2178 )
...
* Merging changes (from dev branch; doing manually to squash them really)of HTML Parser to be aware of HTML Comments so TagHelpers don't complain about comments as content.
2018-03-19 10:18:29 -07:00
Pranav K
b74582e101
Ensure PreserveCompilationContext is set if we're targeting precompilation tool
...
PreserveCompilationContext must be set for precompilation tool to work, even when
the app has no views.
Fixes #2168
2018-03-15 12:49:56 -07:00
Pranav K
5f69a01cc5
RazorSdk - Attribute code generation fixes
...
* Allow the type name for ProvideApplicationPartFactoryAttribute to be specified.
* Generate ReleatedAssemblyAttribute in class library projects
2018-03-14 23:09:28 -07:00
N. Taylor Mullen
a6d03bd407
Workaround MonoDevelop.Core.FilePath tests failing to run due to strong name issues.
2018-03-13 16:56:23 -07:00
N. Taylor Mullen
1d602d1205
Add host project system for VS4Mac.
...
- Tied into VS4Macs ProjectExtensions in order to bootstrap our Razor world.
- We currently watch all DotNet projects with the expectation that they're the only ones that can potentially turn into Razor compatible projects.
- Added a fallback Razor project host which is used for pre-Razor SDK Razor versions (< 2.1).
- Added a default Razor project host which consumes all MSBuild data from the users packages and sets up the Razor world accordingly.
- Had to modify some existing contracts to work better with new expectations. one of these was the VS4Mac specific Workspace accessor; essentially we needed to be able to lookup a workspace from a solution.
- Some of our previous expectations about addins were wrong (not being able to directly reference your libraries). To avoid using reflection to bootstrap our types I tried out directly referencing our libraries and all worked fine.
- Refactored the DefaultRazorProjectHost in windows (since we had to in Mac) for testing purposes.
#2081
2018-03-13 15:31:45 -07:00
N. Taylor Mullen
492e958114
Change HostProjectBuildComplete to persist workspace projects.
...
- This was missed in the VS15.7 movement to dev.
2018-03-13 15:11:21 -07:00
Pranav K
425724ce28
Avoid generating RelatedAssemblyAttribute when RazorSdk isn't in play
2018-03-13 13:54:02 -07:00
Ajay Bhargav Baaskaran
fcd4484542
Fix TagHelperDescriptor.Kind serialization
2018-03-12 15:44:38 -07:00
Artak
a9004e503e
Merge pull request #2061 from aspnet/artakm/RestrictChildrenComments
...
Ignoring HTML comments in tag helper's body. Updated the markup parser to be aware of HTML Comments.
2018-03-12 11:17:57 -07:00
Artak Mkrtchyan
ae94c3c452
- Updated naming for methods to be more intuitive.
...
- Added extra tests for clarity
- Added extra comments to clarify complex areas
2018-03-09 18:18:16 -08:00
Artak Mkrtchyan
3e22c16930
Added extra tests for non-covered scenarios:
...
- For older version of Razor the HTML comments will be complained about by TahHelperRewriter
- RazorParserFeatureFlags tests now ensure that AllowHtmlCommentsInTagHelpers is true in 2.1 version and false in older versions
- Added extra test for IsHtmlCommentAhead to make sure Razor code transition is allowed in comment tag
- Moved the unallowed html comment ending to a static array.
2018-03-09 17:18:57 -08:00
Pranav K
483fba5972
Generate application part attributes
...
* Add support for generating attributes on Razor assembly
* Generate ProvideApplicationPartFactoryAttribute on Razor assembly
* Generate RelatedAssemblyAttribute on application assembly
2018-03-09 14:36:55 -08:00
Artak Mkrtchyan
e8eb3b7b1c
Added extra test to cover extra dash in closing comment
2018-03-09 11:52:23 -08:00
Artak Mkrtchyan
6c8c6a777c
- Clarified the code where the comment content ending is checked to be allowed or not.
...
- Added more unit tests
2018-03-09 09:16:17 -08:00
Artak Mkrtchyan
faccd90aa5
Added unit-tests to validate new methods
2018-03-08 16:36:56 -08:00
Ryan Nowak
2f79b90af5
Merge branch 'rel/vs15.7' into dev
2018-03-08 15:49:01 -08:00
Ryan Nowak
989a6c699f
Don't add the tag helper provider by default
...
Since the default tag helper provider is used by MVC then MVC should
include it. Now that Blazor is in the mix we shouldn't include it for
all configurations.
2018-03-08 15:41:34 -08:00
N. Taylor Mullen
07e672159e
Merge remote-tracking branch 'origin/dev' into nimullen/vs15.7merge
2018-03-08 14:44:14 -08:00
Artak Mkrtchyan
32e2c533c7
Naming improvements and test code cleanup
2018-03-08 13:37:05 -08:00
Artak Mkrtchyan
632c9dead7
Added tests for the LookaheadUntil method
2018-03-08 13:37:05 -08:00
Artak Mkrtchyan
33814fb634
Updated the Comments detection to comply with HTML 5 specification
2018-03-08 13:37:04 -08:00
Artak Mkrtchyan
6885fb15d0
Updated the test TagHelperBlockRewriteTest class
2018-03-08 13:37:04 -08:00
Artak Mkrtchyan
6f515bb763
Fixed all the tests to reflect HtmlComment block type support
2018-03-08 13:37:03 -08:00
Artak Mkrtchyan
e1fbea24f1
HtmlMarkupParser is now aware of HtmlComment blocks. Majority (if not all, will confirm soon) tests have been updated to account for HtmlComment blocks.
2018-03-08 13:37:03 -08:00
Artak Mkrtchyan
ad8485addd
Added new BlockType - HtmlComment
...
Updated the HtmlMarkupParser to understand the HtmlCOmments, and treat those as blocks.
2018-03-08 13:37:03 -08:00
Artak Mkrtchyan
679acdc5d4
Ignoring razor comments during validation
2018-03-08 13:37:02 -08:00
Artak Mkrtchyan
41b7d90ea8
Ignoring markup comments during validation
2018-03-08 13:37:01 -08:00
Artak Mkrtchyan
e6f68eb244
Added a unit test to repro the issue
2018-03-08 13:37:01 -08:00
Ajay Bhargav Baaskaran
e085441ad3
Don't limit parallel threads for xunit tests
2018-03-07 10:43:25 -08:00
Ajay Bhargav Baaskaran
c96d8e4bab
Skip test correctly
2018-03-06 17:47:43 -08:00
Pranav K
c4ba279fb5
Skipping flaky test and additional additional diagnositcs to Shutdown command
2018-03-06 09:15:53 -08:00
Pranav K
0d321771ad
Make UseRazorBuildServer=true by default
2018-03-06 09:15:52 -08:00
N. Taylor Mullen
5c456fbd04
Merge branch 'rel/vs15.7' into dev
...
# Conflicts:
# build/dependencies.props
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshot.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotManager.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotWorker.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotWorkerFactory.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshot.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshotUpdateContext.cs
# src/Microsoft.VisualStudio.Editor.Razor/DefaultVisualStudioDocumentTracker.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/Legacy/LegacyTagHelperResolver.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/Microsoft.VisualStudio.LanguageServices.Razor.csproj
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorConfiguration.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorExtension.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorGeneral.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorProjectProperties.cs
# test/Microsoft.CodeAnalysis.Razor.Workspaces.Test/ProjectSystem/DefaultProjectSnapshotTest.cs
# test/Microsoft.VisualStudio.Editor.Razor.Test/Microsoft.VisualStudio.Editor.Razor.Test.csproj
2018-03-05 22:58:07 -08:00
Ajay Bhargav Baaskaran
27e6c699e5
Don't print normal output as error
2018-03-05 15:22:37 -08:00
Ajay Bhargav Baaskaran
7e18efbf1f
Fixed flaky shutdown tests
2018-03-05 11:55:56 -08:00