N. Taylor Mullen
dbed73da32
Remove ProjectService requirements for Razor text buffer initialization.
...
- Now that we have our own content type the editor does the work of determining if a Razor file opened in a core project should flow to our code.
2018-05-03 11:13:36 -07:00
Ryan Nowak
e0612d7e07
Fixes for the document window state
2018-05-03 10:28:13 -07:00
Ajay Bhargav Baaskaran
8422029310
Merge branch 'release/2.1' into dev
2018-05-02 16:14:42 -07:00
Ajay Bhargav Baaskaran
b2c59700d5
Skip flaky test
2018-05-02 15:43:04 -07:00
Pranav K
1a2ca58eba
Merge pull request #2324 from aspnet/release/2.1
...
Merge release/2.1
2018-05-01 19:31:26 -07:00
Pranav K
a94323499b
Change CopyToPublishDirectory on Content items instead of explicitly removing this from publish items
...
Fixes #2295
2018-05-01 16:50:49 -07:00
Pranav K
05c84f008a
Ensure Views dll are copied during P2P builds
...
FastUpToDateCheck in VS doesn't account for changes solely to .Views.dll. This causes referencing projects to be treated as
up to date even though a referenced project rebuilt. Touch the marker file to cause referenced projects to rebuild.
Fixes https://github.com/aspnet/Razor/issues/2306
to cause it to treat
2018-05-01 16:50:49 -07:00
Pranav K
8d99ba53ce
Make incremental build in VS copy output files
...
Fixes #2306
2018-05-01 16:50:49 -07:00
Pranav K
2081663635
Re-enable desktop msbuild tests
...
Fixes #2208
2018-05-01 15:00:03 -07:00
Ajay Bhargav Baaskaran
7cba5ed593
Fix flaky test failure in ServerCommandTest
2018-04-30 16:32:18 -07:00
N. Taylor Mullen
c59dcb9b4c
Add IVT for Razor.LiveShare.Test.
2018-04-30 16:13:40 -07:00
N. Taylor Mullen
2885b4b138
Make document tracker resilient to multiple subscribes.
...
- Added tests to verify new functionality.
#2314
2018-04-30 12:03:13 -07:00
Pranav K
92a7e73b75
Skip flaky test
2018-04-26 17:42:01 -07:00
Pranav K
813e50087c
Specify RuntimeFrameworkVersion \ NSLibraryVersion when running tests
2018-04-26 17:42:01 -07:00
Ryan Nowak
e2edc280c5
Add documents, engine, tag helpers to snapshot
...
The project snapshot now maintains a RazorProjectEngine as well as set
of Tag Helpers that are known for that snapshot.
Pivoted some more services to be snapshot-centric.
Also added the ability to track .cshtml documents to the project system.
For now most components just ignore document changes.
2018-04-25 19:05:54 -04:00
Ajay Bhargav Baaskaran
bd871ef9e9
Handle Travis failure on ubuntu
2018-04-25 13:24:53 -07:00
Pranav K
1e2a1405e5
Update tests to target netcoreapp2.1
2018-04-25 10:27:07 -07:00
Pranav K
a6a5e4ea10
Simplify building Microsoft.AspNetCore.Razor.Design
2018-04-25 10:27:07 -07:00
Pranav K
a9f818bf82
Disable node-reuse to allow rebuilding
...
Recent builds of msbuild have node reuse enabled by default. This locks up the
task dlls after the test's completed preventing rebuilds untill you kill the process.
2018-04-23 12:50:38 -07:00
Ajay Bhargav Baaskaran
3adb7c9661
Handle Travis failure on ubuntu
2018-04-18 15:46:06 -07:00
Ajay Bhargav Baaskaran
d2fe76be21
Write process and pipe information to a pid file
2018-04-18 14:51:28 -07:00
Pranav K
95835d6c37
Continue generating RelatedAssemblyPart on assembly if GenerateAssemblyInfo=false
...
Fixes #2257
2018-04-13 16:14:37 -07:00
Pranav K
8d1de6ec80
Make sure RazorSdk works when BuildingInVisualStudio \ BuildProjectReferences is disabled
...
Fixes #2247
2018-04-13 14:35:04 -07:00
Ajay Bhargav Baaskaran
f8dc5c4702
Obsoleted IRazorEngineBuilder APIs
2018-04-13 12:35:53 -07:00
Pranav K
6130eb0ec5
Is 1888 fixed
2018-04-13 11:19:07 -07:00
Pranav K
9365fcd053
Don't publish the refs directory when the app does not have any Razor files
...
Fixes https://github.com/aspnet/Razor/issues/2246
2018-04-11 15:20:16 -07:00
Ajay Bhargav Baaskaran
6d9df1ef33
Noop Razor Sdk for F# projects
2018-04-11 14:18:19 -07:00
Ajay Bhargav Baaskaran
5504374125
Preserve directive node diagnostics in document node
2018-04-10 10:24:21 -07:00
Ajay Bhargav Baaskaran
6270c1f47e
Merge branch 'rel/vs15.7' into dev
2018-04-05 16:28:17 -07:00
Ryan Nowak
4cd24a2b08
Add experimental flag to un-special-case data-
...
This change allows blazor to opt into treating data- attributes the same
way as normal attributes in the parser.
2018-04-05 15:27:04 -07:00
Ryan Nowak
d1c0ab587c
Add support for type parameters to class nodes
...
This change will allow someone extending Razor to use generic type
parameters in generated classes.
There's no user-level extensibility provided here yet, as in there is no
language support for adding type parameters.
2018-04-05 15:26:42 -07:00
Ajay Bhargav Baaskaran
ae42d7599d
Show error if page directive is not at the top of file
2018-04-04 17:27:10 -07:00
Ajay Bhargav Baaskaran
b1007744b0
Added PipeOptions.CurrentUserOnly option to the named pipe streams
...
Don't run on server if CurrentUserOnly is not available
2018-04-04 09:53:36 -07:00
Ajay Bhargav Baaskaran
a2a920dde5
Normalize the tool assembly path before using it as the base for pipe name
2018-03-29 12:50:51 -07:00
Ajay Bhargav Baaskaran
03938dfd95
Handle Mutex creation exceptions
2018-03-28 18:23:30 -07:00
Ajay Bhargav Baaskaran
d1215d8fa1
Skip checking thumbprint of file in osx
2018-03-27 10:46:49 -07:00
Pranav K
1e11b5fa95
Make PreserveCompilationContext=true
2018-03-26 14:23:29 -07:00
N. Taylor Mullen
da255ff9db
Make `TestProject.GetProjectDirectory` more thorough when finding project directory.
...
- Used our test path utilities to properly navigate to the project directory.
- Added some logic to make future debugging/test failures more diagnosable.
#2184
2018-03-26 12:36:46 -07:00
Pranav K
954a62c075
Remove EnableDefaultCompiledViewAssemblyLoadBehavior and add a switch to disable generating application part factory attribute
2018-03-22 17:09:53 -07:00
Pranav K
ac3065a9e1
Temporary workaround to make Razor Windows build on dotnet-ci
2018-03-22 12:17:06 -07:00
Ajay Bhargav Baaskaran
a7178a66bd
Show error if page directive is not at the top of file
2018-03-21 11:22:01 -07:00
Pranav K
8631f287d9
Add a few more Razor Sdk fixes
...
* UseSharedCompilation to determine the default value of UseRazorBuildServer
* Generate AssemblyDescriptionAttribute
2018-03-21 08:44:55 -07:00
Kiran Challa
431a8e195a
[ Fixes #2144 ] Incorrect target element of nested tag helper
2018-03-20 15:25:07 -07:00
N. Taylor Mullen
c874f84c3d
Revert "Revert "Make Razor HTML Comments aware ( #2178 )""
...
This reverts commit 1f3f4b79da .
2018-03-20 15:23:53 -07:00
N. Taylor Mullen
1f3f4b79da
Revert "Make Razor HTML Comments aware ( #2178 )"
...
This reverts commit b58986414e .
2018-03-20 11:54:09 -07:00
Pranav K
5f3908cb54
Stop expressly testing on netcoreapp2.0
2018-03-20 09:37:26 -07:00
Pranav K
2bc3466e3d
Do not write generated files to disk if the input has parser errors
...
Fixes #2169
2018-03-19 21:30:47 -07:00
Ajay Bhargav Baaskaran
c934bd08ac
Merge branch 'rel/vs15.7' into release/2.1
2018-03-19 19:14:51 -07:00
Ajay Bhargav Baaskaran
9dc7c65205
Fix: Missing Html intellisense after directives
2018-03-19 17:16:11 -07:00
Ajay Bhargav Baaskaran
fab70c81ec
Merge branch 'rel/vs15.7' into release/2.1
2018-03-19 15:57:46 -07:00
Ajay Bhargav Baaskaran
79e744f691
Handle unreadable import items in design time
2018-03-19 15:39:25 -07:00
Ryan Nowak
6e4a968e12
Fix #2149 give generated files distinct extension
...
Gives our generated a files an extension that isn't used for any other
purpose (that we know of). This is handy for tooling to be able to
quickly know if a file is 'ours'. This comes up in places like
IVsSymbolicNavigationNotify (go to definition).
2018-03-19 12:59:16 -07:00
Pranav K
7ff56dadf4
CodeGen RouteTemplate as a RazorCompiledItemAttribute
2018-03-19 12:37:04 -07:00
Ajay Bhargav Baaskaran
767e5a12c3
Display errors from build server as part of MsBuild output
2018-03-19 10:49:00 -07:00
Artak
b58986414e
Make Razor HTML Comments aware ( #2178 )
...
* Merging changes (from dev branch; doing manually to squash them really)of HTML Parser to be aware of HTML Comments so TagHelpers don't complain about comments as content.
2018-03-19 10:18:29 -07:00
Pranav K
b74582e101
Ensure PreserveCompilationContext is set if we're targeting precompilation tool
...
PreserveCompilationContext must be set for precompilation tool to work, even when
the app has no views.
Fixes #2168
2018-03-15 12:49:56 -07:00
Pranav K
5f69a01cc5
RazorSdk - Attribute code generation fixes
...
* Allow the type name for ProvideApplicationPartFactoryAttribute to be specified.
* Generate ReleatedAssemblyAttribute in class library projects
2018-03-14 23:09:28 -07:00
N. Taylor Mullen
a6d03bd407
Workaround MonoDevelop.Core.FilePath tests failing to run due to strong name issues.
2018-03-13 16:56:23 -07:00
N. Taylor Mullen
1d602d1205
Add host project system for VS4Mac.
...
- Tied into VS4Macs ProjectExtensions in order to bootstrap our Razor world.
- We currently watch all DotNet projects with the expectation that they're the only ones that can potentially turn into Razor compatible projects.
- Added a fallback Razor project host which is used for pre-Razor SDK Razor versions (< 2.1).
- Added a default Razor project host which consumes all MSBuild data from the users packages and sets up the Razor world accordingly.
- Had to modify some existing contracts to work better with new expectations. one of these was the VS4Mac specific Workspace accessor; essentially we needed to be able to lookup a workspace from a solution.
- Some of our previous expectations about addins were wrong (not being able to directly reference your libraries). To avoid using reflection to bootstrap our types I tried out directly referencing our libraries and all worked fine.
- Refactored the DefaultRazorProjectHost in windows (since we had to in Mac) for testing purposes.
#2081
2018-03-13 15:31:45 -07:00
N. Taylor Mullen
492e958114
Change HostProjectBuildComplete to persist workspace projects.
...
- This was missed in the VS15.7 movement to dev.
2018-03-13 15:11:21 -07:00
Pranav K
425724ce28
Avoid generating RelatedAssemblyAttribute when RazorSdk isn't in play
2018-03-13 13:54:02 -07:00
Ajay Bhargav Baaskaran
fcd4484542
Fix TagHelperDescriptor.Kind serialization
2018-03-12 15:44:38 -07:00
Artak
a9004e503e
Merge pull request #2061 from aspnet/artakm/RestrictChildrenComments
...
Ignoring HTML comments in tag helper's body. Updated the markup parser to be aware of HTML Comments.
2018-03-12 11:17:57 -07:00
Artak Mkrtchyan
ae94c3c452
- Updated naming for methods to be more intuitive.
...
- Added extra tests for clarity
- Added extra comments to clarify complex areas
2018-03-09 18:18:16 -08:00
Artak Mkrtchyan
3e22c16930
Added extra tests for non-covered scenarios:
...
- For older version of Razor the HTML comments will be complained about by TahHelperRewriter
- RazorParserFeatureFlags tests now ensure that AllowHtmlCommentsInTagHelpers is true in 2.1 version and false in older versions
- Added extra test for IsHtmlCommentAhead to make sure Razor code transition is allowed in comment tag
- Moved the unallowed html comment ending to a static array.
2018-03-09 17:18:57 -08:00
Pranav K
483fba5972
Generate application part attributes
...
* Add support for generating attributes on Razor assembly
* Generate ProvideApplicationPartFactoryAttribute on Razor assembly
* Generate RelatedAssemblyAttribute on application assembly
2018-03-09 14:36:55 -08:00
Artak Mkrtchyan
e8eb3b7b1c
Added extra test to cover extra dash in closing comment
2018-03-09 11:52:23 -08:00
Artak Mkrtchyan
6c8c6a777c
- Clarified the code where the comment content ending is checked to be allowed or not.
...
- Added more unit tests
2018-03-09 09:16:17 -08:00
Artak Mkrtchyan
faccd90aa5
Added unit-tests to validate new methods
2018-03-08 16:36:56 -08:00
Ryan Nowak
2f79b90af5
Merge branch 'rel/vs15.7' into dev
2018-03-08 15:49:01 -08:00
Ryan Nowak
989a6c699f
Don't add the tag helper provider by default
...
Since the default tag helper provider is used by MVC then MVC should
include it. Now that Blazor is in the mix we shouldn't include it for
all configurations.
2018-03-08 15:41:34 -08:00
N. Taylor Mullen
07e672159e
Merge remote-tracking branch 'origin/dev' into nimullen/vs15.7merge
2018-03-08 14:44:14 -08:00
Artak Mkrtchyan
32e2c533c7
Naming improvements and test code cleanup
2018-03-08 13:37:05 -08:00
Artak Mkrtchyan
632c9dead7
Added tests for the LookaheadUntil method
2018-03-08 13:37:05 -08:00
Artak Mkrtchyan
33814fb634
Updated the Comments detection to comply with HTML 5 specification
2018-03-08 13:37:04 -08:00
Artak Mkrtchyan
6885fb15d0
Updated the test TagHelperBlockRewriteTest class
2018-03-08 13:37:04 -08:00
Artak Mkrtchyan
6f515bb763
Fixed all the tests to reflect HtmlComment block type support
2018-03-08 13:37:03 -08:00
Artak Mkrtchyan
e1fbea24f1
HtmlMarkupParser is now aware of HtmlComment blocks. Majority (if not all, will confirm soon) tests have been updated to account for HtmlComment blocks.
2018-03-08 13:37:03 -08:00
Artak Mkrtchyan
ad8485addd
Added new BlockType - HtmlComment
...
Updated the HtmlMarkupParser to understand the HtmlCOmments, and treat those as blocks.
2018-03-08 13:37:03 -08:00
Artak Mkrtchyan
679acdc5d4
Ignoring razor comments during validation
2018-03-08 13:37:02 -08:00
Artak Mkrtchyan
41b7d90ea8
Ignoring markup comments during validation
2018-03-08 13:37:01 -08:00
Artak Mkrtchyan
e6f68eb244
Added a unit test to repro the issue
2018-03-08 13:37:01 -08:00
Ajay Bhargav Baaskaran
e085441ad3
Don't limit parallel threads for xunit tests
2018-03-07 10:43:25 -08:00
Ajay Bhargav Baaskaran
c96d8e4bab
Skip test correctly
2018-03-06 17:47:43 -08:00
Pranav K
c4ba279fb5
Skipping flaky test and additional additional diagnositcs to Shutdown command
2018-03-06 09:15:53 -08:00
Pranav K
0d321771ad
Make UseRazorBuildServer=true by default
2018-03-06 09:15:52 -08:00
N. Taylor Mullen
5c456fbd04
Merge branch 'rel/vs15.7' into dev
...
# Conflicts:
# build/dependencies.props
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshot.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotManager.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotWorker.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotWorkerFactory.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshot.cs
# src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshotUpdateContext.cs
# src/Microsoft.VisualStudio.Editor.Razor/DefaultVisualStudioDocumentTracker.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/Legacy/LegacyTagHelperResolver.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/Microsoft.VisualStudio.LanguageServices.Razor.csproj
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorConfiguration.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorExtension.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorGeneral.cs
# src/Microsoft.VisualStudio.LanguageServices.Razor/ProjectSystem/Rules/RazorProjectProperties.cs
# test/Microsoft.CodeAnalysis.Razor.Workspaces.Test/ProjectSystem/DefaultProjectSnapshotTest.cs
# test/Microsoft.VisualStudio.Editor.Razor.Test/Microsoft.VisualStudio.Editor.Razor.Test.csproj
2018-03-05 22:58:07 -08:00
Ajay Bhargav Baaskaran
27e6c699e5
Don't print normal output as error
2018-03-05 15:22:37 -08:00
Ajay Bhargav Baaskaran
7e18efbf1f
Fixed flaky shutdown tests
2018-03-05 11:55:56 -08:00
Pranav K
41c923926e
Make RazorCompileOnBuild=true
...
Fixes #1986
2018-03-05 11:29:44 -08:00
Pranav K
29bd5f49dd
Fix build break
2018-03-02 10:05:44 -08:00
Pranav K
5bd650bdd1
Pack should pack symbol nupkg
...
* Update path calculation for BuiltProjectOutputGroupOutput to include full path. This matches
the behavior of Microsoft.Common.targets.
* Add Razor symbols to DebugSymbolsProjectOutputGroupOutput
Fixes #2116
2018-03-02 07:45:24 -08:00
Ajay Bhargav Baaskaran
0f1bc0e0bd
Fix flaky dispatcher test
2018-03-01 14:29:25 -08:00
Ajay Bhargav Baaskaran
a9dca60a10
Added support for AssemblyMetadata caching during build server TagHelper discovery
2018-03-01 13:08:56 -08:00
Ryan Nowak
d6784b5f16
Report faults on Razor project system exceptions
...
Using the async-tasks service will automatically handle and report
exceptions from the project system
2018-02-28 13:04:42 -08:00
Pranav K
62df770c39
PreserveCompilationContext needs to be set only if a project has any Razor files
...
Fixes #2077
2018-02-28 11:45:20 -08:00
Pranav K
f51ddf68a6
Add RazorGenerate items to UpToDateCheckInput
...
Fixes #2048
2018-02-27 15:01:27 -08:00
Pranav K
2958a145e3
Revert "Revert "Update to the latest Sdk and cleanup projects""
...
This reverts commit fed0970b33 .
2018-02-27 09:44:03 -08:00
Pranav K
aa21a6be6e
Use File.Open overload that overwrites file entirely in DiscoverCommand ( #2110 )
...
* Use File.Open overload that overwrites file entirely in DiscoverCommand
Re-enable TagHelper discovery incrementalism test
Fixes #2104
2018-02-26 10:22:29 -08:00
N. Taylor Mullen
b538ceba93
Change final code documents to not contain non-existent imports.
...
- Existent imports are imports that have content that contribute to the processing of a Razor document. Prior to this we had a legacy expectation that code documents had empty markers in them for all of their import locations. This proved troublesome when cross-referencing files that had file paths and were supposed to be existent but weren't in metadata. Now that we have a project engine with a de-coupled import feature we can rely on the import feature for finding all locations of important files and then strip out any non-existent items.
2018-02-23 16:30:22 -08:00