927e7c8bfc
Support route data tokens with Endpoint Routing ( #8360 )
2018-08-30 15:14:34 +12:00
ffdbea9dc1
Add analyzer support for status code methods and constructors
2018-08-29 18:23:52 -07:00
82a01a414d
Set trace id in ProblemDetalsClientErrorFactory
2018-08-29 16:03:08 -07:00
b649133eec
Refactor KnownRouteValueConstraint to not require HttpContext ( #8352 )
2018-08-30 08:57:53 +12:00
d09c3c9e28
Polish ProblemDetails
...
* Add ability to set extended members on ProblemDetails
* Skip empty valued properties when serializing ProblemDetails
Fixes #8296
Fixes #8317
2018-08-28 16:21:39 -07:00
667ad4daff
Use ClientErrorData to configure ClientErrorResultFilter
...
Fixes #8289
2018-08-28 13:35:32 -07:00
96b77c8663
Fix aspnet/Routing#721
2018-08-28 12:26:13 -07:00
0fcf2448c3
Fix aspnet/Routing#722
...
Exposes a separate change token that will be triggered after action
descriptors have been updated.
2018-08-27 17:24:21 -07:00
8ed9d0aac2
Use Endpoint instead of RouteEndpoint where possible ( #8331 )
2018-08-28 11:00:11 +12:00
cb0627b28a
Addressing a skipped test
...
I think something that was meant to be revisited in a PR got left
behing. I found this while fixing aspnet/Routing#772 and it seems worth
addressing.
This change removes the hardcoding of action/controller/area in the
data source, and corrects the behavior of required route values when
they aren't in that set.
2018-08-27 15:34:37 -07:00
a7301120b1
Unwrap filter factories in TypeFilterAttribute & ServiceFilterAttribute
...
Fixes #7855
2018-08-24 14:15:40 -07:00
8eea0ad44c
Update tests to latest compat switch
2018-08-23 08:09:02 -07:00
e2de54a92d
Update MvcEndpointDataSource to use RoutePattern ( #8249 )
2018-08-23 21:42:42 +12:00
03da30f3bf
Replace remaining references to global routing ( #8312 )
2018-08-23 10:23:29 +12:00
cbe1526763
React to routing changes ( #8303 )
2018-08-22 17:15:09 +12:00
5bd818bd64
Introduce ProblemDetailsFilter
...
Fixes https://github.com/aspnet/Mvc/issues/6786
2018-08-21 17:29:12 -07:00
522006d2c8
[Design] Add a MaxValidationDepth option to ValidationVisitor
...
Fixes #7357
2018-08-16 15:01:18 -07:00
200a70bb86
Update doc comments
2018-08-15 11:42:50 -07:00
2421ae8c83
Add IStatusCodeActionResult ( #8265 )
...
* Add IStatusCodeActionResult
* Add unit test for explicitly implemented property on StatusCodeResult
2018-08-13 15:39:20 -07:00
9da8e2c908
Ensure UnsupportedContentTypeFilter runs before ModelStateInvalidFilter
...
Both UnsupportedContentTypeFilter and ModelStateInvalidFilter use ModelState to
determine the response. UnsupportedContentTypeFilter returns a more specific
response and should execute earlier than the latter filter.
Fixes #8236
2018-08-10 10:39:13 -07:00
9585084258
Using Routing feature branch versions
2018-08-07 13:38:36 -07:00
47f2f451e3
EnableEndpointRouting documentation ( #8220 )
2018-08-07 09:22:33 +12:00
c16f86f0ef
React to Routing repo's api changes
2018-08-03 16:25:41 -07:00
d4472f08ed
Remove legacy EnableGlobalRouting option ( #8214 )
2018-08-04 09:58:00 +12:00
ac410b76d9
Change MvcEndpointInfo to internal ( #8210 )
2018-08-03 16:30:57 +12:00
ce8fc29728
ConsumesAttribute accepts requests without content type
...
Fixes #8174
2018-08-02 16:27:23 -07:00
0989231ed5
Make structs readonly
2018-08-02 15:44:09 -07:00
2b289d2f2c
Use MatcherPolicy for Consumes
2018-08-01 19:05:04 -07:00
44f5b54f5f
React to routing API review ( #8194 )
2018-08-02 13:37:43 +12:00
046af405b6
Rename global routing to endpoint routing ( #8179 )
2018-08-01 15:05:49 +12:00
367717760b
Handle subtype with suffix being a subtype without a suffix ( #8170 )
2018-07-30 12:05:41 -07:00
0102d4efab
Introduce ApiConventionMethodAttribute
...
Fixes #8147
2018-07-30 11:13:25 -07:00
fbae57cde1
React to the removal of EndpointConstraint
2018-07-28 19:03:16 -07:00
c01c7075be
Add EndpointMetadata to ActionDescriptor and hookup CORS ( #8158 )
2018-07-28 16:12:54 +12:00
556880872d
Ensure later validations of `null` models do not overwrite `Invalid` state
...
- #8078
2018-07-26 13:49:22 -07:00
f31ab716ee
Change MvcEndpointDataSource to use GetChangeToken ( #8137 )
2018-07-26 09:20:26 +12:00
10ce77b9ca
Updated MvcEndpointDataSource to create endpoints with SuppressLinkGenerationMetadata
2018-07-25 06:41:57 -07:00
c08504b08a
MVC startup experience ( #8131 )
2018-07-25 14:30:51 +12:00
3df34dbbfe
React to Routing repo's LinkGenerator api changes
2018-07-24 05:20:53 -07:00
196e3f109f
React to Routing branding
...
This is a reaction PR for the branding changes in progress in Routing.
This can be merged after the changes to in to Routing.
2018-07-22 19:47:15 -07:00
5c488bf09c
make feature branch build
2018-07-20 12:57:43 -07:00
3ba6f35495
React to RoutePattern changes in Routing
2018-07-20 12:57:43 -07:00
53930af0e3
Set ProblemDetails status field during ObjectResult formatting
2018-07-19 17:57:55 -07:00
ec8976ffaf
Update MvcEndpointDataSource on raised change token ( #8108 )
2018-07-19 16:43:24 +12:00
badbcb9437
Add MvcEndpointDataSource benchmarks ( #8104 )
2018-07-18 15:48:18 +12:00
0caacb8217
React to LinkGenerator api changes
2018-07-17 05:24:27 -07:00
42218d5fb5
Versioning with endpoint constraint ( #8098 )
2018-07-17 16:37:45 +12:00
9d951325b2
Re-organize shared src packages so we can do true IVT between src assemblies
2018-07-16 11:15:58 -07:00
35fad0881b
Mark unused `ParameterBinder.BindModelAsync(...)` overloads as `[Obsolete]`
...
- #7660
- also addresses part of #7317 , only in `ComplexTypeModelBinderIntegrationTest`
2018-07-13 13:26:56 -07:00
f2608c2ff4
Do not suppress `ModelValidationState.Invalid` entries
...
- #7992 , #7963
2018-07-13 13:21:43 -07:00
f12f9b46ed
Add startup filter to set MiddlewareFilterBuilder.ApplicationBuilder
2018-07-13 12:23:30 +12:00
a5083d525b
Fix regression with Authorize + IPolicyProvider ( #8068 )
2018-07-12 15:36:03 -07:00
46189abda7
Refactoring for ApiConvention analyzers
2018-07-12 14:26:27 -07:00
a67d9363e2
Consumes endpoint constraint ( #8057 )
2018-07-12 16:35:33 +12:00
183ecd85d6
Fix MVC integration with UseEndpoint ( #8047 )
2018-07-11 11:47:33 +12:00
1e7be641ae
Add some common aliases for conventions
...
Fixes #8015
2018-07-09 18:25:29 -07:00
0812279464
Merge branch 'release/2.1' into kichalla/21.to.22.mergecommit
...
# Conflicts:
# build/dependencies.props
# korebuild-lock.txt
# src/Microsoft.AspNetCore.Mvc.ApiExplorer/DefaultApiDescriptionProvider.cs
# test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ApiBehaviorApplicationModelProviderTest.cs
# version.props
2018-07-09 13:00:10 -07:00
bd995d4cb1
[ Fixes #7959 ] Conventional routing with custom templates not working when you have area attributes
2018-07-09 12:35:14 -07:00
d2bb674b0a
Add support for default response ( #8028 )
...
* Add support for default response
Fixes #6828
2018-07-06 16:44:07 -07:00
335500ab0e
Use ModelMetadata from actual types for validation
...
Fixes https://github.com/aspnet/Mvc/issues/7952
2018-07-02 11:23:16 -07:00
f6befb9ed3
Added ObjectResult implementation for Unauthorized response
2018-06-29 14:27:34 -07:00
54c14b8782
Reacting to Routing repo's EndpointFinder changes
2018-06-28 12:40:04 -07:00
e1af5b8b6d
Array or List in query string does not get parsed #7712 ( #7967 )
...
- exclude collections when detecting complex types in `ApiBehaviorApplicationModelProvider`
- add test cases
2018-06-26 11:43:46 -07:00
94a7c83998
Change DefaultApiConventions ( #7939 )
...
* Change DefaultApiConventions
* Introduce attributes for matching by name and type.
* Move discovery of ApiConventionAttribute to ApiBehaviorApplicationModelProvider. This is required
for us to detect during startup if the convention is incorrectly authored.
2018-06-25 08:24:30 -07:00
6911e192e4
Add IsRequired and DefaultValue to ApiParameterDescription
2018-06-22 06:51:58 -07:00
17d2545b55
Throw if the type parameter for ActionResult<T> is an action result ( #7942 )
...
Fixes #7931
2018-06-21 07:51:12 -07:00
4f7e849cc1
Setting up for ApiConventionAttribute analyzers ( #7912 )
...
* Setting up for ApiConventionAttribute analyzers
2018-06-20 15:22:53 -07:00
3547341762
Add support for conventional routes with dispatching ( #7928 )
2018-06-20 09:02:52 +12:00
a0a9c2c585
Integrate Dispatcher's link generator
...
Related to https://github.com/aspnet/Routing/issues/530
2018-06-19 04:14:05 -07:00
6df28ef09a
Reach to Dispatcher changes and fix build break
2018-06-15 09:30:07 -07:00
7eac72ae46
Set 2.1 baselines
2018-06-14 11:09:28 -07:00
78fc49ba0c
Set 2.1 baselines
2018-06-14 11:09:19 -07:00
a7406d4497
Add MvcEndpointDataSource and functional tests ( #7886 )
2018-06-14 11:03:45 +12:00
287a3c5e69
Allow IgnoreAntiForgeryToken applied on Razor Page models to work
...
Fixes #7795
2018-06-13 11:59:47 -07:00
6c2ef122f8
Add support for conventions in DefaultApiDescriptionProvider
2018-06-11 16:07:09 -07:00
2d63669695
[ Fixes #7609 ] ApiBehaviorApplicationModelProvider overwrites existing BindingInfo in entirety when inferring binding sources
2018-05-30 05:30:10 -07:00
984cd46c4d
Fix ActionMethodExecutor incorrectly setting DeclaredType on ObjectResult
...
Fixes #7782
2018-05-29 14:35:42 -07:00
edf4e8fd9e
DataAnnotations of Enum values use DataAnnotationLocalizerProvider
2018-05-25 16:00:00 -07:00
418aac57f4
[ Fixes #7609 ] ApiBehaviorApplicationModelProvider overwrites existing BindingInfo in entirety when inferring binding sources
2018-05-24 14:28:42 -07:00
49c653ed0b
Infer BindingSource.FormFile for IEnumerable<IFormFile>
...
Fixes #7770
2018-05-22 11:05:09 -07:00
e1eaf6a6e0
Cleanup TestCommon
2018-05-18 10:45:57 -07:00
624a5ed522
Fix ActionMethodExecutor incorrectly setting DeclaredType on ObjectResult
...
Fixes #7782
2018-05-18 10:43:28 -07:00
a736441ca5
Enable analyzers ( #7789 )
2018-05-18 10:26:42 -07:00
4472c00c6f
PR feedback fixes for logging requestpredicate shortcircuit logging
2018-05-17 11:17:29 -07:00
d80471ad15
Added logging to model binding requestpredicate shortcircuit
2018-05-15 14:13:03 -07:00
bda5ea9df0
Cleanup BindingInfo \ ModelMetadata coalescing in ModelBinderFactory
...
Fixes #7583
2018-05-08 10:24:18 -07:00
dfd9b17f68
More keynotfound avoidance
2018-05-07 11:08:41 -07:00
f35deb71f9
Prevent KeyNotFound when logging
2018-05-07 10:50:26 -07:00
e0188c4936
Modify info level logging for pages ( #7733 )
...
Addresses #7602
2018-05-04 13:47:48 -07:00
777782ac6e
Test cleanup
2018-05-03 16:03:42 -07:00
19c41c0494
Revert "[ Fixes #6902 ] Added an overload for StatusCode that takes in System.Net.HttpStatusCode"
...
This reverts commit c567a690bcFixes #7709 ] Revert https://github.com/aspnet/Mvc/pull/6902
2018-05-01 13:27:57 -07:00
5d5222cdd8
Introduce BindPropertiesAttribute
...
* Allow controller and Razor Page models to be annotated with BindPropertiesAttribute
* Disallow BindPropertyAttribute from being declared on types.
* Do not allow arbitrary binding attributes to be applied to Razor Page models.
Fixes #7686
2018-04-20 14:32:14 -07:00
4f7d53f4e7
[ Fixes #7658 ] FileStreamResultExecutor fails to Dispose FileStream
2018-04-18 11:43:09 -07:00
e0e96ce53b
Include parameter type's attributes in ModelMetadata
...
- #7595
- #7595 relates to #7350 but does not have the same root cause
- did _not_ revert the src changes in #7350 fix (d995b0418a
2018-04-17 12:40:38 -07:00
cc5ae02b7d
Fix binding & validating dictionaries of non-simple types in jQuery requests
...
- #7423
- retry failed inner bindings with alternate syntax in `ModelStateDictionary`
- use property syntax if first attempt tried index syntax and visa versa
- instantiate `ShortFormDictionaryValidationStrategy` with full `ModelState` keys
- can now provide exact `ModelState` keys that `ModelStateDictionary` used in inner bindings
- normalize model names without a leading period in `JQueryKeyValuePairNormalizer`
nits:
- take a few VS suggestions
2018-04-14 10:41:00 -07:00
d5e044f693
[ Fixes #7373 ] Assigning to the context's Result property, when implementing IPageFilter, causes an exception
2018-04-13 15:11:44 -07:00
d995b0418a
Allow BindPropertyAttribute to be specified on controller classes
...
Fixes #7350
2018-04-13 13:58:44 -07:00
e34b4e8335
Use DependencyContext.CompileLibraries to determine dependency graph ( #7626 )
...
* Use DependencyContext.CompileLibraries to determine dependency graph
Fixes https://github.com/aspnet/Mvc/issues/7617
2018-04-11 15:57:11 -07:00
62272ad56a
Round off file result's LastModifiedDate to whole seconds for correct comparison with http header dates
...
[Fixes #7572 ] PhysicalFileResult does not respond 304 Not Modified
2018-04-11 06:43:50 -07:00
39053a5e22
Corrects spelling of some comments
2018-04-09 14:37:20 -07:00
James Newton-King
Kristian Hellang
Pranav K
Ryan Nowak
Ryan Brandenburg
Kiran Challa
Ryan Nowak
Justin Kotalik
Doug Bunting
Kiran Challa
Hao Kung
Zbginiew Dobras
kishanAnem
Pavel Krymets
Jass Bagga
flash2048