Commit Graph

16 Commits

Author SHA1 Message Date
Ryan Nowak b23ea5b668 Improvements to MVC EventData typess
Improvments to names
- Using EventData suffix
- More clarity for events assocated with filters

Fixes: #12263

We have to report the BeforeActionMethod using its old signature because
it's used by Intellitrace. I added a new pair of events with a better
name to use with strong types since there's no practical way to update
the old ones.
2019-07-19 12:53:40 -07:00
John Luo f7ba8f1002
Use Arcade for resx generation (#12179) 2019-07-17 18:31:50 -07:00
Ben Adams 09722d1ce5 MVC use concrete types for DiagnosticListener (#11730)
* MVC use concrete types for DiagnosticListener

* Use DiagnosticListener not DiagnosticSource

* Implement interface explicitly

* Code check

* Feedback

* Feedback

* IReadOnlyDictionary

* Remove InstrumentationContext

* DiagnosticSource in RazorPageActivator

* Code check

* Feedback
2019-07-15 12:38:46 -07:00
N. Taylor Mullen 4623ce7f94 Make ~/ resolution show up at design time.
- This change results in proper errors for tags that utilize `~/`inside of local functions at design time.
- Updated TagHelper in code blocks analyzer error to mention `~/` since it will typically be a cause of confusion.

#10734
2019-07-02 14:55:18 -07:00
Pranav K 2a31739302
Update doc comment for RazorInjectAttribute (#11554)
* Update doc comment for RazorInjectAttribute
2019-06-25 13:32:21 -07:00
Ben Adams 19c9010c2f Read interface IList.Count once rather than per iteration (#9962) 2019-05-04 17:54:12 -07:00
Nate McMaster ae8e96f154
Remove API check baselines and related project settings (#9846) 2019-04-30 14:58:13 -07:00
Pranav K 2570126b27
Fixup XUnit warnings when running MVC tests (#9823) 2019-04-29 09:32:48 -07:00
Pranav K 2be80522b2
Prevent synchronous writes when using Razor (#9395)
* Do not perform synchronous writes to the Response TextWriter after a Razor FlushAsync
* Use ViewBuffer to perform async writes to the response when using ViewComponentResult

Related to #6397 

Fixes https://github.com/aspnet/AspNetCore/issues/4885
2019-04-16 16:12:37 -07:00
Ryan Nowak 284e968101 Add AddControllers and AddRazorPages
These are *new style* for configuring MVC in services. We're adding these to make
things feel a bit more tailored to those particular scenarios.

----

The main reason for this is that we've had repeated community asks for an
*API-optimized* way of configuring MVC. I don't think that using AddMvcCore
is a suitable building block, because it has too many options that you want.

I've think I've identified the reasonable set of features that should be part
of the default experience for APIs. All of these things are already pay-for-play
and are activated by the presence of attributes. The only additional cost is
loading of assemblies and a few additional inspections of the attributes
(cached).

----

Additionally the AddControllers experience is composible. You can add views
to it, or add pages and get the whole thing.

AddRazorPages is basically an alias for what AddMvc does today. We don't
currently have a way to add pages without controllers (the opposite is true).
Based on feedback we could specialize this more.

----

Branding and perception are important, and we've users ask for more flexibility
in what gets added. The plan is to update the templates to use this experience
in preview4, and see what kind of feedback we get.
2019-03-29 18:51:10 -07:00
sprelog bc009fc0f1 fixing possible NRE, when viewContext is null 2019-03-08 15:02:02 -08:00
Pavel Krymets 9355c7c1a5
Add reference assemblies support (#7764) 2019-02-21 14:33:35 -08:00
Chris Ross 4e44025a52
Replace IHostingEnvironment with IWebHostEnvironment (#7725) 2019-02-19 21:11:52 -08:00
Ajay Bhargav Baaskaran 7a26d27e8b Merge branch 'release/2.2' 2019-02-14 16:08:51 -08:00
Ajay Bhargav Baaskaran 0c2ee920a1 Merge branch 'release/2.1' into release/2.2 2019-02-13 14:52:38 -08:00
Ajay Bhargav Baaskaran 4cceccd568
Make Mvc repo folder layout consistent (#7518) 2019-02-13 10:53:39 -08:00