597a0c9a11
Add support for friendly routes in pages
...
FIxes #6325
2017-05-26 14:29:00 -07:00
688e518991
Add result filters to pages
2017-05-26 12:33:46 -07:00
84e007a2a7
Move exception and result filters in base
2017-05-26 12:33:46 -07:00
e7bd6cfc06
Refactor invoker tests for reuse
2017-05-26 12:33:46 -07:00
b7db6dbc8e
Remove pass-through activator for pages
...
This change removes a 'pass through' IRazorPageActivator that we were
using to avoid the default one initializing the Page twice.
The fix is to add an adapter so that the IRazorPage that the RazorView has
isn't the *real* page, it's the adapter. The adapter doesn't have anything
interesting to activate :).
2017-05-26 12:29:10 -07:00
c3f7613725
Make RazorReferenceManage public
...
Fix for #4938 . This change makes the reference manager public and
documented so that it can be replaced.
2017-05-26 10:58:45 -07:00
9f4ff22c4a
React to breaking change latest API Check detects
...
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
- relates to 014a786b45
2017-05-26 09:53:46 -07:00
4c2d727e38
React to Auth + switch to Policy Evaluator
2017-05-25 18:23:41 -07:00
bb5eb96625
Load the precompilation type from the loaded assembly
2017-05-25 15:00:12 -07:00
9ea37a1bbb
Fix TFM build breaks
2017-05-25 13:12:39 -07:00
03404cd3df
Return to NetStandard
2017-05-25 10:34:16 -07:00
452578e4a8
Revisit the architecture of CompilerCache
...
Fixes #5912
2017-05-25 08:54:15 -07:00
2992f8e38a
Separate PageContext and ViewContext
...
This change decouples PageContext and ViewContext completely.
2017-05-24 16:01:52 -07:00
6094c6ff52
Remove use of AssemblyLoadContext
...
This will be needed for the switch back to net46.
2017-05-24 11:05:58 -07:00
a6d97d35e3
Add back support for AddTagHelpersAsServices
...
This doesn't go through the Razor tag helper discovery pipeline because
this can really only ever work for ITagHelper based taghelpers. So
there's really no point in reusing that logic, which would be hard
anyway.
2017-05-23 14:04:42 -07:00
53c56f558b
React to StringSegment changes
2017-05-23 14:01:44 -07:00
e681c23d5c
Add ITagHelperComponentManager ( #6302 )
...
Addresses #6282
2017-05-23 13:22:15 -07:00
39f1f5c933
Move Pages filter creation to application model provider
...
Fixes #6198
2017-05-23 11:03:19 -07:00
c5f771d96d
Use factory pattern for caching in ControllerActionInvoker
2017-05-22 13:05:55 -07:00
9d38e2523c
Add methods to TagBuilder ( #6287 )
...
Addresses #5689
2017-05-19 12:23:16 -07:00
9aff0a67c1
Range support for FileResult( #6150 )
...
Addresses #3702
2017-05-19 10:51:46 -07:00
ece5e748ad
Minor documentation fix for SerializableError
...
ModelStateEntry -> ModelStateDictionary
2017-05-18 11:02:23 -07:00
97bbdafde3
React to Razor changes
2017-05-16 14:58:37 -07:00
51c142ae91
Modify GetProperties overload ( #6276 )
...
Addresses https://github.com/aspnet/Common/issues/219
2017-05-16 13:34:14 -07:00
4d905a4110
Make our executor methods virtual
...
Fixes #5874 - we are marking these methods virtual just in case someone
wants to customize the executors. These are in the 'public internal'
namespace but can't really be replaced because they aren't sufficiently
virtual.
2017-05-16 08:43:45 -07:00
af7303cd8d
Corrected xml-comment for the User-property
...
Removed comment about setting the User. `User` property only supports `get`.
2017-05-16 08:01:38 -07:00
5662717983
Add null check in WriteLiteral
2017-05-15 15:08:50 -07:00
cd6befdef1
Assign unique event Ids in the logger ( #6270 )
...
Addresses #6062
2017-05-15 11:52:52 -07:00
b2d95ffb21
Remove usage of NotFoundProjectItem
...
We're making this type internal in Razor, using a mock here is fine.
Also renamed some types with a generic name. The actual 'default'
RazorProject class lives in Razor and is internal.
2017-05-12 15:55:36 -07:00
b758a86a38
Modify ViewComponent_CannotFindComponent error message ( #6263 )
2017-05-12 14:15:29 -07:00
5eabae55cb
Added PushWriter and PopWriter to RazorPageBase
...
- Removed WriteXYZTo methods
2017-05-11 15:21:42 -07:00
42a4e9a143
Make uses of ObjectMethodExecutor internal
2017-05-10 21:17:51 -07:00
cf64b335f6
Remove unnecessary package references ( #6252 )
2017-05-10 12:06:10 -07:00
7d28714d9a
Pin build of ObjectMethodExecutor to allow breaking change to go thru first
2017-05-10 10:15:14 -07:00
014a786b45
Replace IModelBindingMessageProvider with new highly-virtual base class ( #6241 )
...
Replace IModelBindingMessageProvider with new highly-virtual base class. Fixes #6069
2017-05-10 16:02:18 +01:00
d13c9055f0
Merge branch 'rel/2.0.0-preview1' into dev
2017-05-05 19:29:20 -07:00
a1977cac50
Migration
2017-05-05 19:28:24 -07:00
e2cb8e8ac8
A new and exciting implementation of action selection
...
This is an improved implementation of the ActionSelector for conventional
routing. This will do fewer dictionary lookups than the decision tree, and
will avoid OrdinalIgnoreCase hashing in the common case.
2017-05-05 17:54:09 -07:00
87bb1d0ff5
Refactor GenerateCheckBox ( #6229 )
...
Addresses #5981 and #5983
2017-05-05 11:53:53 -07:00
64ffcfaa89
Merge pull request #6236 from aspnet/rel/2.0.0-preview1
...
Change TFM to netcoreapp2.0 (#6234 )
2017-05-04 22:18:48 -07:00
1c5e417606
Change TFM to netcoreapp2.0 ( #6234 )
...
* Change TFM to netcoreapp2.0
2017-05-04 18:11:26 -07:00
6f3a295041
React to new ObjectMethodExecutor in Common
2017-05-03 15:40:02 +01:00
720a47765d
Re-enable baseline check for ViewFeatures\r\nFixes #6186
2017-05-02 11:51:01 -07:00
8bece90c83
Fix asp-page-handler to generate form tags correctly.
...
- Prior to this change using asp-page-handler on its own did not create correct `<form>` elements. There were multiple issues, one as that the `FormTagHelper` would purposefully drop into a no-op code path. Second is the `DefaultHtmlGenerator` didn't call through to the `UrlHelper` correctly.
- Added functional test cases to validate asp-page-handler can live on its own on a form tag. This also included adding a variant where method="post".
- Added a `FormTagHelper` unit test to validate the `PageHandler` property is consumed properly.
#6208
2017-04-27 10:32:04 -07:00
b1b3a816cc
Rename View() to Page()
...
This requires us to introduce another base class between RazorPageBase and
Page - you need this because you aren't allow to have Page.Page().
2017-04-27 09:27:14 -07:00
490f94d425
Add placeholder `DefineSection` method.
...
- This enables 2.0.0 code generation to not error.
aspnet/Razor#1254
2017-04-26 15:12:16 -07:00
f165914b40
Update how `FormTagHelper` handles `get` method attributes.
...
- Added functional test to verify `asp-*` attributes on form taghelpers work as expected.
- Added a unit test to validate `FormTagHelper` behaves as expected.
- Moved `Method == "get"` checks into appropriate code paths. These include the one where a user specifies an empty or non-existent `action` attribute and where a user doesn't utilize any `asp-*` attributes. In the later, we default `Method` to `"get"` if it's not provided.
#6006
2017-04-25 15:17:15 -07:00
42b988ad88
./ paths relative on page.
2017-04-25 11:57:58 -07:00
bd39d36d75
Update API Check related files
...
React to aspnet/BuildTools#238
2017-04-25 08:19:00 -07:00
649ee4d28d
Add support for page handler to URL generating APIs.
2017-04-24 22:56:58 -07:00
ef0333ac6a
Add Antiforgery to the FormTagHelper pre-check for processing.
...
- Added a test case to the HtmlGeneration functional test (the one verifying complex FormTagHelpers).
- Added unit test verifying antiforgery behavior when it's the only provided parameter.
#6006
2017-04-24 21:46:54 -07:00
5c8a161ace
Change `FormTagHelper` to apply to all form tags.
...
- Added functional test to validate that non-attributed form tags have an antiforgery input generated. Re-generated baseline to reflect changes.
- Added a unit test to validate that parameterless `FormTagHelper`s behave as expected.
#6006
2017-04-24 18:39:01 -07:00
ccdaa5a729
Make /Pages the default root for pages.
...
Fixes #6184
2017-04-24 15:46:32 -07:00
04fd762943
Rename form-action -> handler
2017-04-24 14:15:35 -07:00
141b637d20
Bump `MemoryPoolHttpResponseStreamWriter` buffer size up to 16K `char`s
...
- #3516
- fix tests that relied on otherwise-unused `HttpResponseStreamWriter.DefaultBufferSize`
2017-04-23 16:15:58 -07:00
da5c304f5d
Temporarily deativate API Check
2017-04-21 19:42:04 -07:00
ca017eced2
Add page to AnchorTagHelper and FormTagHelper
...
Fixes #6088
2017-04-21 18:12:54 -07:00
f568d3c2bc
Support finding "sibling" pages when using RedirecToPage
...
Fixes #6083
2017-04-21 18:12:52 -07:00
297196baa0
Design updates to handler methods and binding
...
Implements #6091 , #6072 , #6090 , #5927
2017-04-21 17:29:25 -07:00
908b4c8d62
FormAction from QueryString
2017-04-21 15:04:37 -07:00
8eac7c2d6c
[ Fixes #6117 ] Added RedirectToPage overloads to Controller
2017-04-21 12:19:35 -07:00
83faaebdb6
Upgrade Roslyn dependency to 2.0.0.
...
- Added C# 7 unit and functional test to validate features work end-to-end.
#6149
2017-04-21 11:41:31 -07:00
025870e8b9
Fix #6159 - Fix deep copy for ControllerModel and ActionModel
2017-04-21 07:41:14 -07:00
5a184df808
Remove Binder from Page and PageModel
2017-04-20 17:54:50 -07:00
ea3becb3ca
Reenable APICheck
2017-04-20 13:48:26 -07:00
9fe480f735
Add LazyReferenceMetadataFeature
2017-04-20 13:05:50 -07:00
681b798a2e
RedirectToPage doesn't trim /Index from URL
...
Fixes #6080
2017-04-20 11:15:45 -07:00
a975d7fa01
react to removal of PlatformAbstractions ( #6164 )
2017-04-20 11:09:18 -07:00
4bf518b09b
Fix #6140 - Allow linking between controller and page
...
The issue here is that route values used for action selection are
'global'. That means that pages need to have a 'null' route value for
'action' and controllers need to have a 'null' route value for pages. This
is the same way that areas work.
The fix is to move the 'merge' of route values up to a level where pages
and controllers can work together. Since ADPs use the russian-doll
pattern, the fix is to run this 'merge' in the controller ADP, but after
all of the ADs have been created.
2017-04-19 16:48:38 -07:00
6cd487e15f
Disable api check temporarily to unblock build
2017-04-19 16:07:23 -07:00
025efe1d6e
Fix usings to use Auth 2.0
2017-04-19 15:12:50 -07:00
c9bfd2296d
Parity between Controller and Page/PageModel
2017-04-19 15:02:06 -07:00
3e8cd1e7c9
MVC => Auth 2.0
2017-04-19 11:57:04 -07:00
a8eb5bee70
Implement view search for pages
...
The View Engine now needs to know about pages :(. This isn't ideal but the
view engine needs to know what set of search paths to use. This was
already hardcoded for controllers vs controllers + areas. It felt right to
further hardcode instead of introduce a wierd abstraction that we only
use.
Additionally pages use a view location expander to implement an ascending
directory search.
2017-04-18 16:11:24 -07:00
c56b64fc41
Add factory methods
2017-04-17 16:11:34 -07:00
8ed55107e7
Add support for page precompilation
2017-04-17 10:43:50 -07:00
8fa95d66d4
Add support for suppressing inbound and outbound routing
2017-04-14 17:02:45 -07:00
d8a95c731b
Move RazorViewEngineOptionsSetup to internal namespace ( #6125 )
...
Addresses #6116
2017-04-13 13:35:35 -07:00
c8a1bb6914
React to deps file casing change
...
Fixes #6122
2017-04-13 13:09:00 -07:00
3474bdf776
RedirectToPage from a form-action handler includes the formaction
...
Fixes #6104
2017-04-12 09:27:08 -07:00
59a3aade9b
Fix [TempData] for PageModel's
2017-04-11 16:45:44 -07:00
1a8ac88da7
Add PreserveMethod ( #6075 )
...
Addresses #5609
2017-04-10 17:31:59 -07:00
36e272fdc2
React to Microsoft.AspNetCore.Razor.Evolution => Microsoft.AspNetCore.Razor.Language.
...
aspnet/Razor#1169
2017-04-10 10:20:19 -07:00
90acd055fe
Make [FromBody] treat empty request bodies as invalid ( #4750 )
2017-04-10 16:55:14 +01:00
1e7972bd8f
Add convenience methods for redirecting from a Razor Page back to itself
...
Fuxes #5953
2017-04-07 10:03:42 -07:00
4032de064e
Removing _PageStart.cshtml
...
Pages now also use _ViewStart.cshtml
Also contains some naming/text cleanup that was missed in the previous
commit.
2017-04-06 08:14:37 -07:00
c6e4609096
Getting rid of _PageImports
...
Pages will just use _ViewImports.
2017-04-06 08:14:37 -07:00
9e8d4db7d8
Move TempDataPropertyProvider into filter
2017-04-05 12:04:02 -07:00
925ad75cdf
Add convenience methods for redirecting to another Razor Page
...
Fixes #5956
2017-04-04 14:36:22 -07:00
2d19a82678
Update more resource designer files
2017-04-04 13:54:20 -07:00
b18e96717a
React to https://github.com/aspnet/Razor/issues/1098
2017-04-03 16:41:55 -07:00
d37b1548f8
Update to new resx format
2017-04-03 16:37:22 -07:00
10d2d7c9f6
Remove System.Reflection.TypeExtensions added to workaround test failures
...
Fixes #6005
2017-04-03 14:47:14 -07:00
fe3d45fad1
Adding AllowAnonymousToPage & AllowAnonymousToFolder
...
Fixes #5884
2017-03-31 20:17:31 -07:00
d19150ed22
Fix comment typos in preceding commit
2017-03-31 10:36:53 +01:00
4f351bd37c
Add support for media type suffixes ( #5273 , #6032 )
2017-03-31 10:20:43 +01:00
c47825944d
Remove Microsoft.AspNetCore.Mvc.Razor.Host
2017-03-29 16:50:39 -07:00
959324b337
Add EditorBrowsable attribute
2017-03-29 16:24:44 -07:00
eda5028cf4
Add TagHelperComponentTagHelper
...
Addresses #5728
2017-03-29 11:29:24 -07:00
c18f0780c1
[ Fixes #5413 ] JsonOutputFormatter adds all closing brackets when exceptions are thrown
2017-03-28 23:09:18 -07:00
b22326323a
Add properties to Page and PageModel
...
Fixes #6008
2017-03-28 13:26:38 -07:00
9c5b33dd8a
Upgraded Json.Net version to 10.0.1
2017-03-28 11:28:43 -07:00
d21af1f26d
React to MemoryCache trigger removal
2017-03-27 12:45:54 -07:00
58317b18ce
Fixing NRE when CacheTagHelper throws and exception ( #5989 )
...
Fixes #5988
2017-03-27 12:45:22 -07:00
575fe68b2b
Order enum values by DisplayAttribute.Order
...
Fixes #4297
2017-03-27 12:22:35 -07:00
6436538068
Rename `IHtmlHelper.TextBox()` parameter (for consistency)
...
- #5394
2017-03-27 10:24:30 -07:00
824d65ca3d
Remove `ValueProviderResultExtensions`
...
- #5063
- update tests that used one extension method to instead use `ModelBindingHelper` directly
nit: `mbc` -> `context`
2017-03-24 22:17:34 -07:00
cc6f0f6a26
ITagHelperComponent build fix
...
Fix build
In reaction to aspnet/Razor#1096
2017-03-24 15:23:03 -07:00
e7101f248a
Support model binding to Razor Pages properties on page and PageModel classes
...
Fixes #5952
2017-03-24 07:45:19 -07:00
d2430f0f4e
Merge pull request #6004 from CoskunSunali/dev
...
Avoid entry point assembly being loaded twice during assembly parts discovery
2017-03-22 22:07:28 -07:00
705c36921a
Use alternate workaround for #6005
2017-03-22 19:14:46 -07:00
e80abc1950
React to Razor changes
2017-03-22 18:06:18 -07:00
1152c468be
Disable API Check in projects with untracked breaking changes
2017-03-22 08:34:48 -07:00
badb6ce8e5
Remove net451 as a cross-compile target
2017-03-22 06:32:50 -07:00
11d265bddd
Avoid entry point assembly being loaded twice during assembly parts discovery.
...
Addresses https://github.com/aspnet/Mvc/issues/6003
2017-03-22 04:37:06 +03:00
5c79d4e8ee
Remove Usage of RazorIrNodeVisitorOfT ( #5991 )
2017-03-20 14:52:30 -07:00
270f66198f
Remove Razor from projects
2017-03-17 15:00:39 -07:00
1fdc5132cb
React to TagHelper descriptors api cleanup
2017-03-17 10:51:02 -07:00
1197657e5b
TempData property attribute
...
Addresses #5600
2017-03-16 16:34:35 -07:00
8f4ca32f48
Fix #5807 - Race condition in Invoker
...
This change addressed a race condition in the ObjectMethodExecutor where
the default argument values array can become visible before it is
initialized. If a second observer accesses the array while it is being
initialized, it can observe a null value for a reference type parameter,
leading to a nullref.
The fix here is to make everything immutable and initialize it all up
front. There's no reason to create an OME without eventually running it,
so there's no downside to doing the initialization up front.
2017-03-15 17:19:29 -07:00
6f7717a381
Unify dependency versions to one file
2017-03-15 16:54:32 -07:00
bee1a55cff
Use RazorPagesOptions.RootDirectory when looking for page hierarchies.
...
Fixes #5915
2017-03-14 18:56:50 -07:00
de25357c28
Do not throw if a library does not have a runtime component
...
Fixes #5690
2017-03-14 15:07:50 -07:00
82d87df166
Fix warning as error
2017-03-14 12:44:57 -07:00
365ae19c8b
Add InvalidTagHelperIndexerAssignment to RazorPageBase
2017-03-14 10:04:15 -07:00
e44d875df4
Adding AuthorizePage & AuthorizeFolder without requiring a policy
...
Refactoring
2017-03-13 16:39:52 -07:00
f7fd5114b3
Introduce MvcRazorTemplateEngine
2017-03-13 16:33:13 -07:00
4faef7afaf
Cache more things in HandlerMethodDescriptor
...
Add tests for DefaultPageHandlerMethodSelector
2017-03-13 13:15:26 -07:00
7b53ba1f6b
Reacting to https://github.com/aspnet/Razor/issues/1063
2017-03-13 09:46:36 -07:00
1c74e31715
Add tests for PageActionInvokerProvider ( #5882 )
2017-03-09 16:19:20 -08:00
7f3f6957be
Set path in DefaultPageFactory ( #5911 )
2017-03-09 16:15:43 -08:00
3cd8c8c14d
[ Fixes #5932 ] Add constructor taking the BinderType to ModelBinderAttribute
2017-03-09 08:16:00 -08:00
015dafc25f
[Feature] String should be an acceptable value for a checkbox if it can be parsed as a boolean ( #5845 )
...
- `string` should be an acceptable value for a checkbox if it can be parsed as a `bool`
- `throw` with different resources when `ModelType` isn't `bool` or `string` and when `string` value is not acceptable
2017-03-08 14:22:28 -08:00
d9d280d1ef
Make CookieTempDataProvider the default ITempDataProvider ( #5892 )
2017-03-07 16:04:47 -08:00
7bca31d079
Add convenience extension methods for IPageApplicationModelConvention
2017-03-06 15:28:44 -08:00
b6a6b50776
Fixing up an error in the XML Comments ( #5888 )
2017-03-06 11:07:16 -08:00
de1d0919e5
Add Http Response Codes to doc comments ( #5867 )
2017-03-06 10:00:07 -08:00
00c38fca59
Add ModelState to Page
2017-03-03 17:27:39 -08:00
145d27f9b3
Add a PagesOption type that allows configuring the root for Page file discovery
...
Fixes #5785
2017-03-03 17:20:07 -08:00
85e28ae478
Trim quotes from template ( #5838 )
2017-03-03 09:52:36 -08:00
7cadb58e12
Add convenience extension methods for IPageApplicationModelConvention
2017-03-02 17:38:04 -08:00
f6d25f7117
Fix build warning
2017-03-02 17:20:20 -08:00
f7c2e5bffc
[ Fixes #5844 ] Using ExtensionIRNode for Inject directive
2017-03-01 09:45:47 -08:00
acfad83aa6
Migrate to MSBuild
...
- thanx to @NTaylorMullen for initial conversion
- e.g. AssemblyInfo.cs files were already minimized or removed :)
- allow `>=` RC3 CLI's to build and run MVC
- work around several dotnet migration issues; see #5482
- disable full .NET Framework runs of functional tests; see #5873
- remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies
- remove project.json (!!), *.xproj, .notest, and web.config files
Redo earlier changes:
- apply test migration to .NET 4.5.2 in *.csproj world
- see 63507c80097e40#5768
- work around Microsoft/vstest#392
- rename tests to avoid duplicates
- work around Microsoft/vstest#419
- set up created `AppDomain`s with current `ApplicationBase`
2017-02-28 21:20:39 -08:00
0e914e55fa
Remove double null check ( #5862 )
...
Address #5834
2017-02-28 12:00:23 -08:00
ae61c7005c
React to Microsoft.CodeAnalysis.Razor version change
2017-02-27 17:12:37 -08:00
de30c5822a
* Cache ExecutorFactory as part of CompiledActionDescriptor
...
* Add tests for ExecutorFactory
2017-02-24 11:56:13 -08:00
498c1c570d
Update error message
...
Update error message based on PR feedback to less C# specific.
2017-02-23 14:21:58 -08:00
9950325269
Update view compilation error message
...
Update view compilation error message for csproj instead of
project.json.
2017-02-23 14:21:58 -08:00
f3b1f2ca29
Fixing doc comments
2017-02-23 11:13:34 -08:00
Pranav K
Ryan Nowak
Doug Bunting
Hao Kung
Ryan Brandenburg
Chris R
Jass Bagga
Mardoxx
Henrik W. Moe
Ajay Bhargav Baaskaran
Pavel Krymets
Steve Sanderson
John Luo
N. Taylor Mullen
Smit Patel
Christopher Dresel
Andrew Stanton-Nurse
Hisham Bin Ateya
Kiran Challa
twirpx
Derek Gray
David Fowler
Coskun Sunali
Stefan Nikolei
Nate McMaster
jacalvar
Nick Chapsas
Steve Gordon
martincostello
Steve Smith