Commit Graph

299 Commits

Author SHA1 Message Date
David Fowler c53514fa19
Don't throw from AbortAsync (#2166)
- Log from inside of HubConnectionContext if the user callback failed.
- Use ThreadPool.QUWI instead of Task.Factory.StartNew.
- Remove try catch from HubConnectionHandler
2018-04-30 09:22:48 -07:00
BrennanConroy 1c9607a1ed
Verify Verifiable spelling (#2114) 2018-04-22 21:33:57 -07:00
Andrew Stanton-Nurse d5f62f7b5a
Merge pull request #2122 from aspnet/release/2.1
CancellationToken EVERYWHERE (#2101)
2018-04-20 16:22:16 -07:00
Andrew Stanton-Nurse 47eafca4d8
CancellationToken EVERYWHERE (#2101) 2018-04-20 16:21:51 -07:00
Andrew Stanton-Nurse 36f05d42f5
Merge pull request #2118 from aspnet/release/2.1
Release/2.1
2018-04-20 13:49:53 -07:00
Andrew Stanton-Nurse 058830c9df
fix #2116 by requiring task return values from typed client (#2117) 2018-04-20 13:49:12 -07:00
BrennanConroy 1e65802109 Merge branch 'release/2.1' into dev 2018-04-20 08:53:15 -07:00
James Newton-King 5516a969e3
Change Hub and friends to abstract (#2108) 2018-04-20 20:53:01 +12:00
Andrew Stanton-Nurse ace9a0d414
fix #2097 by adding GetHttpContext to HubConnectionContext (#2099) 2018-04-19 19:14:39 -07:00
BrennanConroy 8571769f2f Merge branch 'release/2.1' into dev 2018-04-19 17:00:59 -07:00
BrennanConroy 1957655653
Run hub invocations serially (#2086) 2018-04-19 16:59:06 -07:00
Andrew Stanton-Nurse bea09f5f94
Merge pull request #2104 from aspnet/release/2.1
fix #2078 by adding locking (#2079)
2018-04-19 15:32:27 -07:00
Andrew Stanton-Nurse 6b6d890c8f
fix #2078 by adding locking (#2079) 2018-04-19 15:32:04 -07:00
David Fowler 9a0c190f48
Merge pull request #2082 from aspnet/release/2.1
Added support for negotiate response to redirect the client to anothe…
2018-04-18 14:51:55 -07:00
David Fowler 903fe1e902
Added support for negotiate response to redirect the client to another SignalR endpoint (#2070)
- Add a SkipNegotiation flag to the .NET and ts client
to allow skipping the negotiation phase. Don't infer it based on the transport type.
-  Updated the negotiate protocol to support returning a redirect url
- Added support to .NET client to handle redirect negotiations
- Handle poorly written endpoints that sends infinite redirects
- Added access token support and an infinite redirect guard
- Add delete handler for stopping the transport
2018-04-18 14:22:45 -07:00
Andrew Stanton-Nurse ba75e5fdf7 Merge branch 'release/2.1' into dev 2018-04-18 09:08:52 -07:00
Andrew Stanton-Nurse b4046b5ed8
Fix #1989 by adding a 'binding failure' pseudo-message (#2064) 2018-04-17 20:08:07 -07:00
Mike Harder e19079bd50
Remove unused dependency on Microsoft.AspNetCore.Server.IntegrationTesting (#2062) 2018-04-17 12:18:34 -07:00
James Newton-King 8985fee4b5
Merge 2018-04-17 20:39:19 +12:00
David Fowler 05d6bbb782
Flush first long poll immediately (#2032)
There was a race condition between the first poll and any other http request that was sent. 
In particular, if you called StartAsync then StopAsync it was possible for the delete to happen before the poll started leading to 400 errors. This change fixes that by making the very first poll
return immediately so that the client can use that to determine if there was an error connecting.
2018-04-17 00:49:26 -07:00
James Newton-King 818497de64
Improvements 2018-04-17 16:57:55 +12:00
David Fowler 680b51ed6c
Skip failing test (#2042) 2018-04-16 10:24:14 -07:00
James Newton-King b5d5f11ef8
Rename excludedIds to excludedConnectionIds (#2037) 2018-04-16 18:03:16 +12:00
James Newton-King b3a9011698
API review changes for Microsoft.AspNetCore.SignalR (#2033) 2018-04-16 15:54:42 +12:00
James Newton-King 64f52d1098
y u no log? 2018-04-16 08:33:19 +12:00
James Newton-King 1d900fe139
More logging! 2018-04-15 19:19:24 +12:00
James Newton-King 81b593fdbe
More logging! 2018-04-15 19:18:36 +12:00
James Newton-King 725bb33949
Lazy initialize HttpConnectionContext.Items (#2027) 2018-04-15 19:06:13 +12:00
James Newton-King 585bcc3ee0
How about this? 2018-04-15 19:02:56 +12:00
James Newton-King 89922a399f
Capture server logs in tests 2018-04-15 14:43:56 +12:00
James Newton-King ddc905c219
Add VerifyNoErrorsScope (#1972) 2018-04-15 11:12:21 +12:00
James Newton-King 377ed1b834
JsonHubProtocol and MessagePackHubProtocol version fields now private (#2023) 2018-04-15 09:58:05 +12:00
James Newton-King e4d0f2980e
Microsoft.AspNetCore.SignalR.Client refactor (#2000) 2018-04-14 21:09:41 +12:00
Andrew Stanton-Nurse 43e6ab750a
Fix #1927 by using Synchronous Callbacks everywhere. (#2003) 2018-04-13 11:38:03 -07:00
David Fowler 3e69fdc4ad
Delegate disposable to the IConnectionFactory (#1999)
- Added DisposeAsync to the IConnectionFactory. It's responsible for disposing the connection after the pipe has closed.
- Added dispose callback to WithConnectionFactory
- Don't wait for poll request to end before unwinding from the transport
- Make sure all http requests are done before returning from StopAsync in both SSE and longpolling
2018-04-13 09:16:23 -07:00
David Fowler abe139ee16
Make the protocol and messages public (#1994)
* Move types to a .Protocol namespace
2018-04-13 01:53:41 -07:00
James Newton-King 198013bfa3
Microsoft.AspNetCore.Http.Connections.Client refactors (#1995) 2018-04-13 20:13:58 +12:00
Ahson Khan 0ee4a86564 Collapse AsSpan().Slice(..) into AsSpan(..) (#1991) 2018-04-12 23:15:47 -07:00
Mikael Mengistu 0053124ca4
Make Proxies Internal (#1982) 2018-04-13 00:38:16 +00:00
David Fowler 8b1a7e9199
API review feedback (#1974)
- Remove SetHttpContext
- Remove HttpContextFeature
- Add and implement IHttpTransportFeature on HttpConnectionContext
- Remove ConnectionMetadataNames
2018-04-12 03:50:14 -07:00
James Newton-King 12b69a0fdb
Refactor HttpOptions in client (#1942)
- Rename HttpOptions to HttpConfigurationOptions
- Remove HttpConfigurationOptions from SignalR client project
- Updated client HttpConnection ctors
2018-04-11 20:20:04 +12:00
Mikael Mengistu 83821a028d
Rename HubEndPointTestUtils folder (#1943) 2018-04-11 04:05:28 +00:00
James Newton-King c83baf2b76
Remove params from message ctors (#1931) 2018-04-11 12:11:13 +12:00
BrennanConroy 6d050140e5
Swtich to MessagePack-CSharp (#1879) 2018-04-09 17:04:32 -07:00
James Newton-King bd78785f8d
Minor DefaultHubLifetimeManager improvements (#1904) 2018-04-09 12:31:14 +12:00
James Newton-King 27d18578d0
Use expression body properties and implicit arrays where possible (#1906) 2018-04-08 21:40:01 +12:00
James Newton-King 0f663cadc4
readonly all the things (#1901) 2018-04-08 15:47:01 +12:00
David Fowler e3da7feab4
Clean up client ITransport interface (#1893)
- Transports own the pipe creation. The fact they are 2 sides is an implementation detail.
2018-04-07 15:11:42 -07:00
David Fowler 86083c0302
Removing native support for IObservable<T> (#1890)
- There are too many issues and questions with respect to back pressure and the buffering policy we should use when the client being streamed to can't support the data being pushed via OnNext.
As a result, we're dropping support for IObservable but keeping ChannelReader and we'll eventually support IAsyncEnumerable when that makes it into the BCL.
- Add sample showing Observable -> ChannelReader adaption
2018-04-07 15:10:39 -07:00
Mikael Mengistu 4ddf8664c0
Don't throw from Observer's OnNext (#1872) 2018-04-06 00:35:04 -07:00